iobroker.device-watcher 0.3.0 → 1.0.0

package/main.js

@@ -19,12 +19,6 @@ class DeviceWatcher extends utils.Adapter {
 			useFormatDate: true,
 		});
 
-		this.on('ready', this.onReady.bind(this));
-		//this.on('stateChange', this.onStateChange.bind(this));
-		// this.on('objectChange', this.onObjectChange.bind(this));
-		// this.on('message', this.onMessage.bind(this));
-		this.on('unload', this.onUnload.bind(this));
-
 		// arrays
 		this.offlineDevices = [];
 		this.linkQualityDevices = [];
@@ -44,6 +38,9 @@ class DeviceWatcher extends utils.Adapter {
 
 		this.deviceReachable = '';
 
+		// Interval timer
+		this.refreshDataTimeout = null;
+
 		// arrays of supported adapters
 		this.arrApart = {
 			alexa2: {
@@ -89,6 +86,13 @@ class DeviceWatcher extends utils.Adapter {
 				'reach': '.present',
 				'isLowBat': '.batterylow'
 			},
+			harmony: {
+				'Selektor': 'harmony.*.hubConnected',
+				'adapter': 'harmony',
+				'battery': 'none',
+				'reach': '.hubConnected',
+				'isLowBat': 'none'
+			},
 			homematic: {
 				'Selektor': 'hm-rpc.*.UNREACH',
 				'adapter': 'homematic',
@@ -112,6 +116,13 @@ class DeviceWatcher extends utils.Adapter {
 				'reach': '.reachable',
 				'isLowBat': 'none'
 			},
+			jeelink: {
+				'Selektor': 'jeelink.*.lowBatt',
+				'adapter': 'jeelink',
+				'battery': 'none',
+				'reach': 'none',
+				'isLowBat': '.lowBatt'
+			},
 			mihome: {
 				'Selektor': 'mihome.*.percent',
 				'adapter': 'miHome',
@@ -127,18 +138,20 @@ class DeviceWatcher extends utils.Adapter {
 				'isLowBat': 'none'
 			},
 			mihomeVacuum: {
-				'Selektor': 'mihome-vacuum.*.wifi_signal',
+				'Selektor': 'mihome-vacuum.*.connection',
 				'adapter': 'mihomeVacuum',
-				'rssiState': '.wifi_signal',
+				'rssiState': '.deviceInfo.wifi_signal',
 				'battery': '.info.battery',
 				'battery2': '.control.battary_life',
-				'reach': '.connection',
-				'isLowBat': 'none'
+				'reach': '.info.connection',
+				'isLowBat': 'none',
+				'id': '.deviceInfo.model'
 			},
 			nukiExt: {
-				'Selektor': 'nuki-extended.*.batteryCritical',
+				'Selektor': 'nuki-extended.*.lastDataUpdate',
 				'adapter': 'nuki-extended',
-				'battery': '.batteryCharge',
+				'rssiState': 'none',
+				'battery': '.batteryChargeState',
 				'reach': 'none',
 				'isLowBat': '.batteryCritical'
 			},
@@ -192,27 +205,28 @@ class DeviceWatcher extends utils.Adapter {
 				'battery': '.Battery.level',
 				'reach': '.ready',
 				'isLowBat': '.Battery.isLow'
+			},
+			test: { // Only for Dev
+				'Selektor': '0_userdata.*.UNREACH',
+				'adapter': 'homematic',
+				'rssiState': '.RSSI_DEVICE',
+				'battery': '.OPERATING_VOLTAGE',
+				'reach': '.UNREACH',
+				'isLowBat': '.LOW_BAT',
+				'isLowBat2': '.LOWBAT'
 			}
 		};
-	}
 
-	async onReady() {
-		this.log.debug(`Adapter ${adapterName} was started`);
+		this.on('ready', this.onReady.bind(this));
+		this.on('stateChange', this.onStateChange.bind(this));
+		// this.on('objectChange', this.onObjectChange.bind(this));
+		// this.on('message', this.onMessage.bind(this));
+		this.on('unload', this.onUnload.bind(this));
 
-		try {
-			await this.main();
-			await this.writeDatapoints();
-			this.log.debug('all done, exiting');
-			this.terminate ? this.terminate('Everything done. Going to terminate till next schedule', 11) : process.exit(0);
-		} catch (error) {
-			this.errorReporting('[onReady]', error);
-			this.terminate ? this.terminate(15) : process.exit(15);
-		}
 	}
 
-
-	async main() {
-		this.log.debug(`Function started: ${this.main.name}`);
+	async onReady() {
+		this.log.debug(`Adapter ${adapterName} was started`);
 
 		try {
 			this.supAdapter = {
@@ -222,9 +236,11 @@ class DeviceWatcher extends utils.Adapter {
 				enocean: this.config.enoceanDevices,
 				esphome: this.config.esphomeDevices,
 				fritzdect: this.config.fritzdectDevices,
+				harmony: this.config.harmonyDevices,
 				homematic: this.config.homematicDevices,
 				hue: this.config.hueDevices,
 				hueExt: this.config.hueExtDevices,
+				jeelink: this.config.jeelinkDevices,
 				mihome: this.config.mihomeDevices,
 				mihomeGW: this.config.mihomeDevices,
 				mihomeVacuum: this.config.mihomeVacuumDevices,
@@ -236,28 +252,90 @@ class DeviceWatcher extends utils.Adapter {
 				switchbotBle: this.config.switchbotBleDevices,
 				zigbee: this.config.zigbeeDevices,
 				zwave: this.config.zwaveDevices,
+				test: false // Only for Dev
 			};
 
 			for (const [id] of Object.entries(this.arrApart)) {
 				if (this.supAdapter[id]) {
 					this.arrDev.push(this.arrApart[id]);
 					this.adapterSelected.push(await this.capitalize(id));
-					this.log.debug(JSON.stringify(this.arrDev));
 				}
 			}
 
 			//Check if an Adapter is selected.
 			if (this.adapterSelected.length >= 1) {
+				// show list in debug log
+				this.log.debug(JSON.stringify(this.arrDev));
+
 				this.log.info(`Number of selected adapters: ${this.adapterSelected.length}. Loading data from: ${(this.adapterSelected).join(', ')} ...`);
 			} else {
 				this.log.warn(`No adapter selected. Please check the instance configuration!`);
 				return; // cancel run if no adapter is selected
 			}
 
+			//create Blacklist
+			try {
+				await this.createBlacklist();
+			} catch (error) {
+				this.errorReporting('[onReady - create blacklist]', error);
+			}
+
+			// update data now
+			await this.main();
+
+			// update data in interval
+			await this.refreshData();
+
+		} catch (error) {
+			this.errorReporting('[onReady]', error);
+			this.terminate ? this.terminate(15) : process.exit(15);
+		}
+	}
+
+	/**
+     * Is called if a subscribed state changes
+     * @param {string} id
+     * @param {ioBroker.State | null | undefined} state
+     */
+	async onStateChange(id, state) {
+		if (state) {
+			// The state was changed
+			this.log.debug(`state ${id} changed: ${state.val} (ack = ${state.ack})`);
+			await this.main();
+		} else {
+			// The state was deleted
+			this.log.debug(`state ${id} deleted`);
+		}
+	}
+
+	async refreshData() {
+		const nextTimeout = this.config.updateinterval * 1000;
+
+		await this.main();
+
+		// Clear existing timeout
+		if (this.refreshDataTimeout) {
+			this.log.debug('clearing old refresh timeout');
+			this.clearTimeout(this.refreshDataTimeout);
+		}
+
+		this.refreshDataTimeout = this.setTimeout(() => {
+			this.log.debug('Updating Data');
+
+			this.refreshDataTimeout = null;
+			this.refreshData();
+		}, nextTimeout);
+	}
+
+	async main() {
+		this.log.debug(`Function started: ${this.main.name}`);
+
+		try {
+
 			//create and fill datapoints for each adapter if selected
 			try {
 				for (const [id] of Object.entries(this.arrApart)) {
-					if (this.supAdapter[id]) {
+					if ((this.supAdapter !== undefined) && (this.supAdapter[id])) {
 
 						if (this.config.createOwnFolder) {
 							await this.createDPsForEachAdapter(id);
@@ -290,7 +368,7 @@ class DeviceWatcher extends utils.Adapter {
 
 
 	/**
-	 * @param {string} [sentence] - Word which should be capitalize
+	 * @param {string} sentence - Word which should be capitalize
 	 **/
 	async capitalize(sentence) {
 		//make the first letter uppercase
@@ -298,7 +376,7 @@ class DeviceWatcher extends utils.Adapter {
 	}
 
 	/**
-	 * @param {object} [obj] - State of datapoint
+	 * @param {object} obj - State of datapoint
 	 **/
 	async getInitValue(obj) {
 		//state can be null or undefinded
@@ -307,7 +385,7 @@ class DeviceWatcher extends utils.Adapter {
 	}
 
 	/**
-	 * @param {object} [obj] - State of own datapoint
+	 * @param {object} obj - State of own datapoint
 	 **/
 	async getOwnInitValue(obj) {
 		//state can be null or undefinded for own states
@@ -317,7 +395,7 @@ class DeviceWatcher extends utils.Adapter {
 
 	//create datapoints for each adapter
 	/**
-	 * @param {object} [adptName] - Adaptername of devices
+	 * @param {object} adptName - Adaptername of devices
 	 **/
 	async createDPsForEachAdapter(adptName) {
 
@@ -643,19 +721,24 @@ class DeviceWatcher extends utils.Adapter {
 		});
 	}
 
-	/**
-	 * @param {object} [i] - Device Object
-	 **/
-	async createData(i) {
-		const devices = await this.getForeignStatesAsync(this.arrDev[i].Selektor);
-		const deviceAdapterName = await this.capitalize(this.arrDev[i].adapter);
+	async createBlacklist() {
+		this.log.debug(`Function started: ${this.createBlacklist.name}`);
+
 		const myBlacklist = this.config.tableBlacklist;
 
-		/*----------  Loop for blacklist ----------*/
 		for (const i in myBlacklist) {
 			this.blacklistArr.push(myBlacklist[i].device);
-			this.log.debug(`Found items on the blacklist: ${this.blacklistArr}`);
 		}
+		this.log.info(`Found items on the blacklist: ${this.blacklistArr}`);
+		this.log.debug(`Function finished: ${this.createBlacklist.name}`);
+	}
+
+	/**
+	 * @param {object} i - Device Object
+	 **/
+	async createData(i) {
+		const devices = await this.getForeignStatesAsync(this.arrDev[i].Selektor);
+		const deviceAdapterName = await this.capitalize(this.arrDev[i].adapter);
 
 		/*----------  Start of second main loop  ----------*/
 		for (const [id] of Object.entries(devices)) {
@@ -664,25 +747,29 @@ class DeviceWatcher extends utils.Adapter {
 				const currDeviceString = id.slice(0, (id.lastIndexOf('.') + 1) - 1);
 				const shortCurrDeviceString = currDeviceString.slice(0, (currDeviceString.lastIndexOf('.') + 1) - 1);
 
-				//Get device name
+				// Get device name
 				const deviceObject = await this.getForeignObjectAsync(currDeviceString);
 				const shortDeviceObject = await this.getForeignObjectAsync(shortCurrDeviceString);
 				let deviceName;
 
 				switch (this.arrDev[i].adapter) {
-					case 'switchbotBle':	//Get ID for Switchbot and ESPHome Devices
+					case 'switchbotBle':	// Get ID for Switchbot and ESPHome Devices
 					case 'esphome':
 						deviceName = await this.getInitValue(currDeviceString + this.arrDev[i].id);
 						break;
 
 					case 'hue-extended':
-					case 'mihomeVacuum':
 					case 'homematic':
+					case 'nuki-extended':
 						if (shortDeviceObject && typeof shortDeviceObject === 'object') {
 							deviceName = shortDeviceObject.common.name;
 						}
 						break;
 
+					case 'mihomeVacuum':
+						deviceName = await this.getInitValue(shortCurrDeviceString + this.arrDev[i].id);
+						break;
+
 					default:
 						if (deviceObject && typeof deviceObject === 'object') {
 							deviceName = deviceObject.common.name;
@@ -692,23 +779,28 @@ class DeviceWatcher extends utils.Adapter {
 
 				const deviceMainSelector = await this.getForeignStateAsync(id);
 
-				// 3. Get battery states
+				// Get battery states
 				const deviceBatteryState = await this.getInitValue(currDeviceString + this.arrDev[i].battery);
 				const shortDeviceBatteryState = await this.getInitValue(shortCurrDeviceString + this.arrDev[i].battery);
 				const shortDeviceBatteryState2 = await this.getInitValue(shortCurrDeviceString + this.arrDev[i].battery2);
 
-				// 1. Get link quality
+				// Get link quality
 				let deviceQualityState;
 				let linkQuality;
 
 				switch (this.arrDev[i].adapter) {
 					case 'sonoff':
-					case 'mihomeVacuum':
 					case 'homematic':
 						deviceQualityState = await this.getForeignStateAsync(currDeviceString + this.arrDev[i].rssiState);
 						break;
+
+					case 'mihomeVacuum':
+						deviceQualityState = await this.getForeignStateAsync(shortCurrDeviceString + this.arrDev[i].rssiState);
+						break;
+
 					default:
 						deviceQualityState = await this.getForeignStateAsync(id);
+						break;
 				}
 
 				if ((deviceQualityState) && (typeof deviceQualityState.val === 'number')) {
@@ -741,14 +833,13 @@ class DeviceWatcher extends utils.Adapter {
 						);
 					}
 				} else {
-					// no linkQuality available for powered devices
-					linkQuality = ' - ';
+					linkQuality = ' - '; // no linkQuality available for powered devices
 				}
 
-				// 1b. Count how many devices with link Quality
+				// Count how many devices with link Quality
 				this.linkQualityCount = this.linkQualityDevices.length;
 
-				// 2. When was the last contact to the device?
+				// When was the last contact to the device?
 				let lastContactString;
 
 				let deviceState = 'Online';
@@ -758,6 +849,7 @@ class DeviceWatcher extends utils.Adapter {
 						const lastContact = Math.round((time.getTime() - deviceMainSelector.ts) / 1000 / 60);
 						const lastStateChange = Math.round((time.getTime() - deviceMainSelector.lc) / 1000 / 60);
 						const deviceUnreachState = await this.getInitValue(currDeviceString + this.arrDev[i].reach);
+						const shortDeviceUnreachState = await this.getInitValue(shortCurrDeviceString + this.arrDev[i].reach);
 
 						const getLastContact = async () => {
 							lastContactString = this.formatDate(new Date((deviceMainSelector.ts)), 'hh:mm') + ' Uhr';
@@ -781,21 +873,29 @@ class DeviceWatcher extends utils.Adapter {
 							return lastContactString;
 						};
 
-						// 2b. wenn seit X Minuten kein Kontakt mehr besteht, nimm Gerät in Liste auf
-						//Rechne auf Tage um, wenn mehr als 48 Stunden seit letztem Kontakt vergangen sind
-						switch (this.arrDev[i].adapter) {
-							case 'ping':
-								//State changed
-								if (!deviceUnreachState) {
-									await getLastStateChange();
-								} else {
-									await getLastContact();
-								}
+						//  If there is no contact since user sets minutes add device in offline list
+						// calculate to days after 48 hours
+						switch (this.arrDev[i].reach) {
+							case 'none':
+								await getLastContact();
 								break;
 
 							default:
-								await getLastContact();
-								break;
+								//State changed
+								if  (this.arrDev[i].adapter == 'homematic') {
+									if (deviceUnreachState) {
+										await getLastStateChange();
+									} else {
+										await getLastContact();
+									}
+								} else {
+									if ((!deviceUnreachState)) {
+										await getLastStateChange();
+									} else {
+										await getLastContact();
+									}
+									break;
+								}
 						}
 
 						const pushOfflineDevice = async () => {
@@ -820,6 +920,8 @@ class DeviceWatcher extends utils.Adapter {
 							}
 						};
 
+						// await this.subscribeForeignStatesAsync(currDeviceString + this.arrDev[i].reach);
+
 						switch (this.arrDev[i].adapter) {
 							case 'alexa2':
 								if (this.config.alexa2MaxMinutes === -1) {
@@ -827,7 +929,7 @@ class DeviceWatcher extends utils.Adapter {
 										deviceState = 'Offline'; //set online state to offline
 										await pushOfflineDevice();
 									}
-								} else if (lastContact > this.config.alexa2MaxMinutes) {
+								} else if ((lastStateChange > this.config.alexa2MaxMinutes) && (!deviceUnreachState)) {
 									deviceState = 'Offline'; //set online state to offline
 									await pushOfflineDevice();
 								}
@@ -849,7 +951,7 @@ class DeviceWatcher extends utils.Adapter {
 										deviceState = 'Offline'; //set online state to offline
 										await pushOfflineDevice();
 									}
-								} else if (lastContact > this.config.deconzMaxMinutes) {
+								} else if ((lastStateChange > this.config.deconzMaxMinutes) && (!deviceUnreachState)) {
 									deviceState = 'Offline'; //set online state to offline
 									await pushOfflineDevice();
 								}
@@ -871,7 +973,7 @@ class DeviceWatcher extends utils.Adapter {
 										deviceState = 'Offline'; //set online state to offline
 										await pushOfflineDevice();
 									}
-								} else if (lastContact > this.config.esphomeMaxMinutes) {
+								} else if ((lastStateChange > this.config.esphomeMaxMinutes) && (!deviceUnreachState)) {
 									deviceState = 'Offline'; //set online state to offline
 									await pushOfflineDevice();
 								}
@@ -882,7 +984,18 @@ class DeviceWatcher extends utils.Adapter {
 										deviceState = 'Offline'; //set online state to offline
 										await pushOfflineDevice();
 									}
-								} else if (lastContact > this.config.fritzdectMaxMinutes) {
+								} else if ((lastStateChange > this.config.fritzdectMaxMinutes) && (!deviceUnreachState)) {
+									deviceState = 'Offline'; //set online state to offline
+									await pushOfflineDevice();
+								}
+								break;
+							case 'harmony':
+								if (this.config.harmonyMaxMinutes === -1) {
+									if (!deviceUnreachState) {
+										deviceState = 'Offline'; //set online state to offline
+										await pushOfflineDevice();
+									}
+								} else if ((lastStateChange > this.config.harmonyMaxMinutes) && (!deviceUnreachState)) {
 									deviceState = 'Offline'; //set online state to offline
 									await pushOfflineDevice();
 								}
@@ -893,7 +1006,7 @@ class DeviceWatcher extends utils.Adapter {
 										deviceState = 'Offline'; //set online state to offline
 										await pushOfflineDevice();
 									}
-								} else if (lastContact > this.config.homematicMaxMinutes) {
+								} else if ((lastStateChange > this.config.homematicMaxMinutes) && (deviceUnreachState)) {
 									deviceState = 'Offline'; //set online state to offline
 									await pushOfflineDevice();
 								}
@@ -904,7 +1017,7 @@ class DeviceWatcher extends utils.Adapter {
 										deviceState = 'Offline'; //set online state to offline
 										await pushOfflineDevice();
 									}
-								} else if (lastContact > this.config.hueMaxMinutes) {
+								} else if ((lastStateChange > this.config.hueMaxMinutes) && (!deviceUnreachState)) {
 									deviceState = 'Offline'; //set online state to offline
 									await pushOfflineDevice();
 								}
@@ -915,7 +1028,18 @@ class DeviceWatcher extends utils.Adapter {
 										deviceState = 'Offline'; //set online state to offline
 										await pushOfflineDevice();
 									}
-								} else if (lastContact > this.config.hueextMaxMinutes) {
+								} else if ((lastStateChange > this.config.hueextMaxMinutes) && (!deviceUnreachState)) {
+									deviceState = 'Offline'; //set online state to offline
+									await pushOfflineDevice();
+								}
+								break;
+							case 'jeelink':
+								if (this.config.jeelinkMaxMinutes === -1) {
+									if (!deviceUnreachState) {
+										deviceState = 'Offline'; //set online state to offline
+										await pushOfflineDevice();
+									}
+								} else if (lastContact > this.config.jeelinkMaxMinutes) {
 									deviceState = 'Offline'; //set online state to offline
 									await pushOfflineDevice();
 								}
@@ -926,18 +1050,18 @@ class DeviceWatcher extends utils.Adapter {
 										deviceState = 'Offline'; //set online state to offline
 										await pushOfflineDevice();
 									}
-								} else if (lastContact > this.config.mihomeMaxMinutes) {
+								} else if ((lastStateChange > this.config.mihomeMaxMinutes) && (!deviceUnreachState)) {
 									deviceState = 'Offline'; //set online state to offline
 									await pushOfflineDevice();
 								}
 								break;
 							case 'mihomeVacuum':
 								if (this.config.mihomeVacuumMaxMinutes === -1) {
-									if (!deviceUnreachState) {
+									if (!shortDeviceUnreachState) {
 										deviceState = 'Offline'; //set online state to offline
 										await pushOfflineDevice();
 									}
-								} else if (lastContact > this.config.mihomeVacuumMaxMinutes) {
+								} else if ((lastStateChange > this.config.mihomeVacuumMaxMinutes) && (!shortDeviceUnreachState)) {
 									deviceState = 'Offline'; //set online state to offline
 									await pushOfflineDevice();
 								}
@@ -970,7 +1094,7 @@ class DeviceWatcher extends utils.Adapter {
 										deviceState = 'Offline'; //set online state to offline
 										await pushOfflineDevice();
 									}
-								} else if (lastContact > this.config.shellyMaxMinutes) {
+								} else if ((lastStateChange > this.config.shellyMaxMinutes) && (!deviceUnreachState)) {
 									deviceState = 'Offline'; //set online state to offline
 									await pushOfflineDevice();
 								}
@@ -981,7 +1105,7 @@ class DeviceWatcher extends utils.Adapter {
 										deviceState = 'Offline'; //set online state to offline
 										await pushOfflineDevice();
 									}
-								} else if (lastContact > this.config.sonoffMaxMinutes) {
+								} else if ((lastStateChange > this.config.sonoffMaxMinutes) && (!deviceUnreachState)) {
 									deviceState = 'Offline'; //set online state to offline
 									await pushOfflineDevice();
 								}
@@ -992,7 +1116,7 @@ class DeviceWatcher extends utils.Adapter {
 										deviceState = 'Offline'; //set online state to offline
 										await pushOfflineDevice();
 									}
-								} else if (lastContact > this.config.sonosMaxMinutes) {
+								} else if ((lastStateChange > this.config.sonosMaxMinutes) && (!deviceUnreachState)) {
 									deviceState = 'Offline'; //set online state to offline
 									await pushOfflineDevice();
 								}
@@ -1014,7 +1138,7 @@ class DeviceWatcher extends utils.Adapter {
 										deviceState = 'Offline'; //set online state to offline
 										await pushOfflineDevice();
 									}
-								} else if (lastContact > this.config.zigbeeMaxMinutes) {
+								} else if ((lastStateChange > this.config.zigbeeMaxMinutes) && (!deviceUnreachState)) {
 									deviceState = 'Offline'; //set online state to offline
 									await pushOfflineDevice();
 								}
@@ -1025,7 +1149,7 @@ class DeviceWatcher extends utils.Adapter {
 										deviceState = 'Offline'; //set online state to offline
 										await pushOfflineDevice();
 									}
-								} else if (lastContact > this.config.zwaveMaxMinutes) {
+								} else if ((lastStateChange > this.config.zwaveMaxMinutes) && (!deviceUnreachState)) {
 									deviceState = 'Offline'; //set online state to offline
 									await pushOfflineDevice();
 								}
@@ -1038,16 +1162,51 @@ class DeviceWatcher extends utils.Adapter {
 
 
 
-				// 2c. Count how many devcies are offline
+				// Count how many devcies are offline
 				this.offlineDevicesCount = this.offlineDevices.length;
 
-				// 3. Get battery states
+				// Get battery states
 				let batteryHealth;
+				const deviceLowBatState = await this.getInitValue(currDeviceString + this.arrDev[i].isLowBat);
+				const deviceLowBatStateHM = await this.getInitValue(currDeviceString + this.arrDev[i].isLowBat2);
 
-				if ((!deviceBatteryState) && (!shortDeviceBatteryState)) {
-					batteryHealth = ' - ';
+				if ((!deviceBatteryState) && (!shortDeviceBatteryState) && (!shortDeviceBatteryState2)) {
+					if ((deviceLowBatState !== undefined) || (deviceLowBatState !== undefined) || (deviceLowBatStateHM !== undefined)) {
+						switch (this.arrDev[i].isLowBat) {
+							case 'none':
+								batteryHealth = ' - ';
+								break;
+							default:
+								if (!deviceLowBatState) {
+									batteryHealth = 'ok';
+								} else {
+									batteryHealth = 'low';
+								}
+								break;
+						}
+						switch (this.arrDev[i].isLowBat2) {
+							case 'none':
+								batteryHealth = ' - ';
+								break;
+							default:
+								if (!deviceLowBatState) {
+									batteryHealth = 'ok';
+								} else {
+									batteryHealth = 'low';
+								}
+								break;
+						}
+						this.batteryPowered.push(
+							{
+								'Device': deviceName,
+								'Adapter': deviceAdapterName,
+								'Battery': batteryHealth
+							}
+						);
+					} else {
+						batteryHealth = ' - ';
+					}
 				} else {
-
 					switch (this.arrDev[i].adapter) {
 						case 'homematic':
 							if (deviceBatteryState === 0) {
@@ -1109,16 +1268,15 @@ class DeviceWatcher extends utils.Adapter {
 					}
 				}
 
-				// 3b. Count how many devices are with battery
+				// Count how many devices are with battery
 				this.batteryPoweredCount = this.batteryPowered.length;
 
-				// 3c. Count how many devices are with low battery
+				// Count how many devices are with low battery
 				const batteryWarningMin = this.config.minWarnBatterie;
-				const deviceLowBatState = await this.getInitValue(currDeviceString + this.arrDev[i].isLowBat);
-				const deviceLowBatStateHM = await this.getInitValue(currDeviceString + this.arrDev[i].isLowBat2);
 
+				// fill list with low battery devices
 				switch (this.arrDev[i].adapter) {
-					case 'homematic':
+					case 'homematic': // there are differnt low bat states between hm and hmIp devices
 						if (deviceLowBatState || deviceLowBatStateHM) {
 							this.batteryLowPowered.push(
 								{
@@ -1130,7 +1288,7 @@ class DeviceWatcher extends utils.Adapter {
 						}
 						break;
 
-					default:
+					default: // for all other devices with low bat states
 						if (deviceLowBatState) {
 							this.batteryLowPowered.push(
 								{
@@ -1139,7 +1297,7 @@ class DeviceWatcher extends utils.Adapter {
 									'Battery': batteryHealth
 								}
 							);
-						} else if (deviceBatteryState && (deviceBatteryState < batteryWarningMin)) {
+						} else if (deviceBatteryState && (deviceBatteryState < batteryWarningMin)) { // if the battery state is under the set limit
 							this.batteryLowPowered.push(
 								{
 									'Device': deviceName,
@@ -1188,7 +1346,7 @@ class DeviceWatcher extends utils.Adapter {
 
 
 	/**
-	 * @param {string} [adptName] - Adapter name
+	 * @param {string} adptName - Adapter name
 	 */
 	async createDataForEachAdapter(adptName) {
 		// create Data for each Adapter in own lists
@@ -1225,6 +1383,7 @@ class DeviceWatcher extends utils.Adapter {
 			}
 
 			if (this.config.checkSendOfflineMsg) await this.sendOfflineNotifications(); // send message if new devices are offline
+			if (this.config.checkSendOfflineMsgDaily) await this.sendDailyOfflineNotifications(); // send daily overview of offline devices
 			if (this.config.checkSendBatteryMsg) await this.sendBatteryNotifications(); // send message for low battery devices
 			await this.writeDatapoints(); // fill the datapoints
 		} catch (error) {
@@ -1237,7 +1396,7 @@ class DeviceWatcher extends utils.Adapter {
 
 	/**
 	 * Notification service
-	 * @param {string} [text] - Text which should be send
+	 * @param {string} text - Text which should be send
 	 **/
 	async sendNotification(text) {
 
@@ -1366,8 +1525,10 @@ class DeviceWatcher extends utils.Adapter {
 			let msg = '';
 			const offlineDevicesCountOld = await this.getOwnInitValue('offlineCount');
 
-			if ((this.offlineDevicesCount != offlineDevicesCountOld)) {
-				if (this.offlineDevicesCount == 1) {	// make singular if it is only one device
+			if ((this.offlineDevicesCount !== offlineDevicesCountOld)) {
+				if (this.offlineDevicesCount == 0) {
+					msg = 'Alle Geräte sind Online.';
+				} else if (this.offlineDevicesCount == 1) {	// make singular if it is only one device
 					msg = 'Folgendes Gerät ist seit einiger Zeit nicht erreichbar: \n';
 				} else if (this.offlineDevicesCount >= 2) {		//make plural if it is more than one device
 					msg = `Folgende ${this.offlineDevicesCount} Geräte sind seit einiger Zeit nicht erreichbar: \n`;
@@ -1376,6 +1537,7 @@ class DeviceWatcher extends utils.Adapter {
 				for (const id of this.offlineDevices) {
 					msg = `${msg} \n ${id['Device']} (${id['Last contact']})`;
 				}
+
 				this.log.info(msg);
 				await this.setStateAsync('lastNotification', msg, true);
 				await this.sendNotification(msg);
@@ -1383,9 +1545,76 @@ class DeviceWatcher extends utils.Adapter {
 		} catch (error) {
 			this.errorReporting('[sendOfflineMessage]', error);
 		}
+
+		try {
+			// send daily an overview with offline devices
+			if (this.config.checkSendOfflineMsgDaily) {
+				// Check if the daily message for offline devices was already sent today
+				const lastOfflineNotifyIndicator = await this.getOwnInitValue('info.lastOfflineNotification');
+				const now = new Date(); // get date
+
+				// set indicator for send message first to 'false', after sending to 'true'
+				if (now.getHours() < 11) await this.setStateAsync('info.lastOfflineNotification', false, true);
+
+				// if time is > 11 (12:00 pm create message for offline devices devices)
+				if ((now.getHours() > 11) && (!lastOfflineNotifyIndicator)) {
+					let msg = '';
+
+					for (const id of this.offlineDevices) {
+						msg = `${msg} \n ${id['Device']} (${id['Last contact']})`;
+					}
+
+					if (this.offlineDevicesCount > 0) {
+						this.log.info(`Geräte Offline: ${msg}`);
+						await this.setStateAsync('lastNotification', `Geräte Offline: ${msg}`, true);
+
+						await this.sendNotification(`Geräte Offline: ${msg}`);
+
+						await this.setStateAsync('info.lastOfflineNotification', true, true);
+					}
+				}
+			}
+		} catch (error) {
+			this.errorReporting('[sendOfflineMessage - daily message]', error);
+		}
 		this.log.debug(`Finished the function: ${this.sendOfflineNotifications.name}`);
 	}//<--End of offline notification
 
+	async sendDailyOfflineNotifications() {
+		// send daily an overview with offline devices
+
+		this.log.debug(`Start the function: ${this.sendDailyOfflineNotifications.name}`);
+
+		try {
+			// Check if the daily message for offline devices was already sent today
+			const lastOfflineNotifyIndicator = await this.getOwnInitValue('info.lastOfflineNotification');
+			const now = new Date(); // get date
+
+			// set indicator for send message first to 'false', after sending to 'true'
+			if (now.getHours() < 11) await this.setStateAsync('info.lastOfflineNotification', false, true);
+
+			// if time is > 11 (12:00 pm create message for offline devices devices)
+			if ((now.getHours() > 11) && (!lastOfflineNotifyIndicator)) {
+				let msg = '';
+
+				for (const id of this.offlineDevices) {
+					msg = `${msg} \n ${id['Device']} (${id['Last contact']})`;
+				}
+
+				if (this.offlineDevicesCount > 0) {
+					this.log.info(`Geräte Offline: ${msg}`);
+					await this.setStateAsync('lastNotification', `Geräte Offline: ${msg}`, true);
+
+					await this.sendNotification(`Geräte Offline: ${msg}`);
+
+					await this.setStateAsync('info.lastOfflineNotification', true, true);
+				}
+			}
+		} catch (error) {
+			this.errorReporting('[sendDailyOfflineNotifications]', error);
+		}
+		this.log.debug(`Finished the function: ${this.sendDailyOfflineNotifications.name}`);
+	}//<--End of daily offline notification
 
 	async sendBatteryNotifications() {
 		// send message for low battery devices
@@ -1426,7 +1655,7 @@ class DeviceWatcher extends utils.Adapter {
 			const lastBatteryNotifyIndicator = await this.getOwnInitValue('info.lastBatteryNotification');
 
 			// set indicator for send message first to 'false', after sending to 'true'
-			if (now.getHours() < 11) { await this.setStateAsync('info.lastBatteryNotification', false, true); }
+			if (now.getHours() < 11) await this.setStateAsync('info.lastBatteryNotification', false, true);
 
 			// if time is > 11 (12:00 pm create message for low battery devices)
 			if ((now.getHours() > 11) && (!lastBatteryNotifyIndicator) && (checkToday != undefined)) {
@@ -1458,7 +1687,7 @@ class DeviceWatcher extends utils.Adapter {
 		this.log.debug(`Function started: ${this.resetVars.name}`);
 
 		// arrays
-		this.offlineDevices = [],
+		this.offlineDevices = [];
 		this.linkQualityDevices = [];
 		this.batteryPowered = [];
 		this.batteryLowPowered = [];
@@ -1553,8 +1782,8 @@ class DeviceWatcher extends utils.Adapter {
 	}//<--End  of writing Datapoints
 
 	/**
-	 * @param {object} [devices] - Device
-	 * @param {number} [deviceCount] - Counted devices
+	 * @param {object} devices - Device
+	 * @param {number} deviceCount - Counted devices
 	 */
 	async creatLinkQualityListHTML(devices, deviceCount) {
 		devices = devices.sort((a, b) => { return a.Device.localeCompare(b.Device); });
@@ -1585,8 +1814,8 @@ class DeviceWatcher extends utils.Adapter {
 	}
 
 	/**
-	 * @param {object} [devices] - Device
-	 * @param {number} [deviceCount] - Counted devices
+	 * @param {object} devices - Device
+	 * @param {number} deviceCount - Counted devices
 	 */
 	async createOfflineListHTML(devices, deviceCount) {
 		devices = devices.sort((a, b) => { return a.Device.localeCompare(b.Device); });
@@ -1643,9 +1872,9 @@ class DeviceWatcher extends utils.Adapter {
 			<td align=center><font>${device.Adapter}</font></td>`;
 
 			if (isLowBatteryList) {
-				html += `<td align=center><font color=orange>${device.Battery == ' - ' ? 'schwach' : device.Battery}</font></td>`;
+				html += `<td align=center><font color=orange>${device.Battery}</font></td>`;
 			} else {
-				html += `<td align=right><font color=#3bcf0e>${device.Battery == ' - ' ? 'ok' : device.Battery}</font></td>`;
+				html += `<td align=right><font color=#3bcf0e>${device.Battery}</font></td>`;
 			}
 
 			html += `</tr>`;
@@ -1656,8 +1885,8 @@ class DeviceWatcher extends utils.Adapter {
 	}
 
 	/**
-	 * @param {string} [codePart] - Message Prefix
-	 * @param {object} [error] - Sentry message
+	 * @param {string} codePart - Message Prefix
+	 * @param {object} error - Sentry message
 	 */
 	errorReporting(codePart, error) {
 		const msg = `[${codePart}] error: ${error.message}`;
@@ -1675,9 +1904,18 @@ class DeviceWatcher extends utils.Adapter {
 	} // <-- end of errorReporting
 
 
+	/**
+     * @param {() => void} callback
+     */
 	onUnload(callback) {
 		try {
 			this.log.info('cleaned everything up...');
+
+			if (this.refreshDataTimeout) {
+				this.log.debug('clearing refresh timeout');
+				this.clearTimeout(this.refreshDataTimeout);
+			}
+
 			callback();
 		} catch (e) {
 			callback();
@@ -1685,6 +1923,7 @@ class DeviceWatcher extends utils.Adapter {
 	}
 }
 
+// @ts-ignore parent is a valid property on module
 if (require.main !== module) {
 	// Export the constructor in compact mode
 	/**