iobroker.clage-dsx 0.0.7 → 0.0.8

package/README.md

@@ -81,6 +81,13 @@ For updates, write the same structure including a numeric `id` to `timers.update
 
 ## Changelog
 
+### 0.0.8
+
+- Fixed all findings from the ioBroker latest-repository review.
+- Updated energy and timestamp state roles and clarified the legacy temperature state.
+- Restricted setup writes to registered API fields and added safe polling upper limits.
+- Corrected all adapter description translations.
+
 ### 0.0.7
 
 - Corrected state roles for timestamps, version information and the numeric bus ID

package/admin/jsonConfig.json

@@ -51,6 +51,7 @@
       "type": "number",
       "label": "Active-device interval (ms)",
       "min": 1000,
+      "max": 3600000,
       "xs": 12,
       "sm": 6,
       "md": 3,
@@ -61,6 +62,7 @@
       "type": "number",
       "label": "Idle-device interval (ms)",
       "min": 5000,
+      "max": 3600000,
       "xs": 12,
       "sm": 6,
       "md": 3,
@@ -71,6 +73,7 @@
       "type": "number",
       "label": "History/setup interval (ms)",
       "min": 60000,
+      "max": 3600000,
       "xs": 12,
       "sm": 6,
       "md": 3,

package/io-package.json

@@ -1,8 +1,21 @@
 {
   "common": {
     "name": "clage-dsx",
-    "version": "0.0.7",
+    "version": "0.0.8",
     "news": {
+      "0.0.8": {
+        "en": "Fixed latest-repository review findings for roles, setup fields, polling limits and translations.",
+        "de": "Review-Hinweise zu Rollen, Setup-Feldern, Abfragegrenzen und Übersetzungen behoben.",
+        "ru": "Исправлены замечания проверки по ролям, полям настройки, ограничениям опроса и переводам.",
+        "pt": "Corrigidos os pontos da revisão relativos a funções, campos de configuração, limites de consulta e traduções.",
+        "nl": "Reviewpunten voor rollen, instelvelden, pollinglimieten en vertalingen opgelost.",
+        "fr": "Correction des remarques concernant les rôles, les champs de configuration, les limites d’interrogation et les traductions.",
+        "it": "Corretti i rilievi relativi a ruoli, campi di configurazione, limiti di polling e traduzioni.",
+        "es": "Corregidos los hallazgos sobre funciones, campos de configuración, límites de sondeo y traducciones.",
+        "pl": "Naprawiono uwagi dotyczące ról, pól konfiguracji, limitów odpytywania i tłumaczeń.",
+        "uk": "Виправлено зауваження щодо ролей, полів налаштування, обмежень опитування та перекладів.",
+        "zh-cn": "修复了角色、设置字段、轮询限制和翻译方面的审核问题。"
+      },
       "0.0.7": {
         "en": "Corrected state roles for timestamps, version information and the numeric bus ID.",
         "de": "Datenpunktrollen für Zeitstempel, Versionsinformationen und die numerische Bus-ID korrigiert.",
@@ -72,15 +85,15 @@
     "desc": {
       "en": "Control and monitor CLAGE water heaters through the Home Server API",
       "de": "CLAGE-Durchlauferhitzer über die Home-Server-API steuern und überwachen",
-      "ru": "подключение к clage dsx wather Heater",
-      "pt": "conexão com o aquecedor de wather dsx clage",
-      "nl": "verbinding met klei dsxwaze Heater",
-      "fr": "connexion à clage dsx wather Heater",
-      "it": "connessione al clage dsx wather Heater",
-      "es": "conexión a clage dsx wather Heater",
-      "pl": "w związku z tym księgowy",
-      "uk": "підключення до клітки dsx ватер нагрівач",
-      "zh-cn": "2. 冲突"
+      "ru": "Управление и мониторинг водонагревателей CLAGE через API Home Server",
+      "pt": "Controle e monitorização de aquecedores de água CLAGE através da API do Home Server",
+      "nl": "CLAGE-waterverwarmers bedienen en bewaken via de Home Server-API",
+      "fr": "Contrôler et surveiller les chauffe-eau CLAGE via l’API Home Server",
+      "it": "Controllo e monitoraggio degli scaldacqua CLAGE tramite l’API Home Server",
+      "es": "Control y supervisión de calentadores de agua CLAGE mediante la API de Home Server",
+      "pl": "Sterowanie i monitorowanie podgrzewaczy wody CLAGE przez interfejs API Home Server",
+      "uk": "Керування та моніторинг водонагрівачів CLAGE через API Home Server",
+      "zh-cn": "通过 Home Server API 控制和监控 CLAGE 热水器"
     },
     "authors": ["TheBam <elektrobam@gmx.de>"],
     "keywords": ["water heater", "clage"],

package/main.js

@@ -115,9 +115,9 @@ class ClageDsx extends utils.Adapter {
       return;
     }
 
-    this.activePollMs = Math.max(asNumber(this.config.activePollMs, 2000), 1000);
-    this.idlePollMs = Math.max(asNumber(this.config.idlePollMs, 30000), 5000);
-    this.detailsPollMs = Math.max(asNumber(this.config.detailsPollMs, 300000), 60000);
+    this.activePollMs = Math.min(Math.max(asNumber(this.config.activePollMs, 2000), 1000), 3600000);
+    this.idlePollMs = Math.min(Math.max(asNumber(this.config.idlePollMs, 30000), 5000), 3600000);
+    this.detailsPollMs = Math.min(Math.max(asNumber(this.config.detailsPollMs, 300000), 60000), 3600000);
     this.historyDays = Math.max(asNumber(this.config.historyDays, 30), 1);
     this.longPolling = this.config.longPolling !== false;
     this.client = axios.create({
@@ -160,7 +160,7 @@ class ClageDsx extends utils.Adapter {
     await this.ensureChannel("timers", "Timer management");
     await this.ensureState("info.connection", "Connected", "boolean", "indicator.connected", true, false);
     await this.ensureState("info.lastError", "Last error", "string", "text", true, false);
-    await this.ensureState("info.lastUpdate", "Last successful update", "string", "text", true, false);
+    await this.ensureState("info.lastUpdate", "Last successful update", "string", "date", true, false);
     await this.ensureState("info.apiVersion", "API version", "string", "text", true, false);
     await this.ensureState("info.servicesJson", "Available services", "string", "json", true, false);
     for (const [id, name, type, role] of [
@@ -257,9 +257,9 @@ class ClageDsx extends utils.Adapter {
       ["rssi", "Signal strength", "number", "value", true, false, "dBm"],
       ["lqi", "Link quality indicator", "number", "value", true, false],
       ["access", "API access mask", "number", "value", true, false],
-      ["activity", "Last radio activity", "string", "text", true, false],
+      ["activity", "Last radio activity", "string", "date", true, false],
       ["Setpoint", "Setpoint raw", "number", "level.temperature", true, true, "0.1 °C"],
-      ["Themperatur", "Setpoint temperature", "number", "level.temperature", true, true, "°C"],
+      ["Themperatur", "Setpoint temperature (legacy)", "number", "level.temperature", true, true, "°C"],
       ["tLimit", "Temperature limit raw", "number", "value.temperature", true, false, "0.1 °C"],
       ["flow", "Water flow raw", "number", "value", true, false, "0.1 l/min"],
       ["flowMax", "Maximum flow raw", "number", "level", true, true, "0.1 l/min"],
@@ -311,7 +311,7 @@ class ClageDsx extends utils.Adapter {
       ["timerPowerOn", "Heating duration", "number", "value.interval", false, "s"],
       ["timerLifetime", "Total operating time", "number", "value.interval", false, "s"],
       ["timerStandby", "Standby duration", "number", "value.interval", false, "s"],
-      ["totalPowerConsumption", "Total energy consumption", "number", "value.power.consumption", false, "kWh"],
+      ["totalPowerConsumption", "Total energy consumption", "number", "value.energy.consumed", false, "kWh"],
       ["totalWaterConsumption", "Total water consumption", "number", "value", false, "l"],
     ];
     for (const [name, label, type, role, write, unit] of setup) {
@@ -328,12 +328,12 @@ class ClageDsx extends utils.Adapter {
 
     for (const [name, label, type, role, unit] of [
       ["lastId", "Last draw-off ID", "number", "value", ""],
-      ["lastTime", "Last draw-off time", "string", "text", ""],
+      ["lastTime", "Last draw-off time", "string", "date", ""],
       ["lastDuration", "Last draw-off duration", "number", "value.interval", "s"],
-      ["lastEnergy", "Last draw-off energy", "number", "value.power.consumption", "Wh"],
+      ["lastEnergy", "Last draw-off energy", "number", "value.energy.consumed", "Wh"],
       ["lastWater", "Last draw-off water", "number", "value", "l"],
       ["totalDuration", "Total draw-off duration", "number", "value.interval", "s"],
-      ["totalEnergy", "Total draw-off energy", "number", "value.power.consumption", "Wh"],
+      ["totalEnergy", "Total draw-off energy", "number", "value.energy.consumed", "Wh"],
       ["totalWater", "Total draw-off water", "number", "value", "l"],
       ["historyJson", "Draw-off history", "string", "json", ""],
     ]) {
@@ -445,11 +445,22 @@ class ClageDsx extends utils.Adapter {
     const raw = response.data && response.data.devices && response.data.devices[0];
     const setup = (raw && raw.setup) || {};
     const transformed = {
-      ...setup,
+      swVersion: setup.swVersion,
+      serialDevice: setup.serialDevice,
+      serialPowerUnit: setup.serialPowerUnit,
       flowMax: setup.flowMax,
+      loadShedding: setup.loadShedding,
       scaldProtection: toCelsius(setup.scaldProtection),
       sound: setup.sound === undefined ? undefined : Boolean(setup.sound),
+      fcpAddr: setup.fcpAddr,
+      powerCosts: setup.powerCosts,
       powerMax: setup.powerMax === undefined ? undefined : asNumber(setup.powerMax) * 0.15,
+      calValue: setup.calValue,
+      timerPowerOn: setup.timerPowerOn,
+      timerLifetime: setup.timerLifetime,
+      timerStandby: setup.timerStandby,
+      totalPowerConsumption: setup.totalPowerConsumption,
+      totalWaterConsumption: setup.totalWaterConsumption,
     };
     for (const [name, value] of Object.entries(transformed)) {
       if (value !== undefined && value !== null) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "iobroker.clage-dsx",
-  "version": "0.0.7",
+  "version": "0.0.8",
   "description": "Control and monitor CLAGE water heaters through the Home Server API",
   "author": {
     "name": "TheBam",