iobroker.bmw 4.3.3 → 4.3.5

package/README.md

@@ -40,7 +40,7 @@ A detailed datapoint description you can find here [telematic.json](telematic.js
 
 ### 1. BMW ConnectedDrive Portal Setup
 
-1. Visit the BMW ConnectedDrive portal: **https://www.bmw.de/de-de/mybmw/vehicle-overview**
+1. Visit the BMW ConnectedDrive portal: **https://www.bmw.de/de-de/mybmw/vehicle-overview** or https://www.mini.de/de-de/mymini/vehicle-overview
 2. Navigate to the **BMW CarData** section (you'll see various service categories)
 
 ![BMW Portal Overview](img/bmw-portal-overview.png)
@@ -54,7 +54,7 @@ A detailed datapoint description you can find here [telematic.json](telematic.js
 
 ![CarData Client Setup](img/cardata-client-setup.png)
 
-# **CRITICAL**: Click one service and wait 30 seconds if you see an error message, then click again. Don't press on "Gerät Authentifizieren/Devict authentication" Enter the client_id in iobroker settings.
+# **CRITICAL**: Click one service and wait 30 seconds if you see an error message, then click again. Don't press on "Gerät Authentifizieren/Devict authentication" Enter the client_id in iobroker settings. If it is not working try all letters as lowercase.
 
 ### 2. CarData Streaming Configuration
 
@@ -214,6 +214,19 @@ This adapter is available at: [https://github.com/TA2k/ioBroker.bmw](https://git
   Placeholder for the next version (at the beginning of the line):
   ### **WORK IN PROGRESS**
 -->
+### 4.3.5 (2026-04-11)
+
+- (hombach) fix repo checker warnings
+- (hombach) fix vulnerability
+- (hombach) update dependencies
+- (hombach) remove old admin files
+
+### 4.3.4 (2026-02-28)
+
+- enhance docu and logging
+- (hombach) fix vulnerability
+- (hombach) update dependencies
+
 ### 4.3.3 (2026-01-02)
 
 - (hombach) year 2026 changes

package/admin/jsonConfig.json

@@ -97,8 +97,8 @@
         "zh-cn": "BMW CarData客户端ID"
       },
       "help": {
-        "en": "Client ID from BMW ConnectedDrive portal CarData section. Required for OAuth2 authentication.",
-        "de": "Client ID aus dem BMW ConnectedDrive Portal CarData Bereich. Erforderlich für OAuth2-Authentifizierung.",
+        "en": "Client ID from BMW ConnectedDrive portal CarData section. If it doesn't work, try making all letters lowercase.",
+        "de": "Client ID aus dem BMW ConnectedDrive Portal CarData Bereich. Falls es nicht funktioniert, dann alle Buchstaben kleinschreiben.",
         "ru": "Client ID из раздела CarData портала BMW ConnectedDrive. Требуется для OAuth2 аутентификации.",
         "pt": "Client ID da seção CarData do portal BMW ConnectedDrive. Necessário para autenticação OAuth2.",
         "nl": "Client ID uit BMW ConnectedDrive portal CarData sectie. Vereist voor OAuth2 authenticatie.",
@@ -255,6 +255,40 @@
       "lg": 6,
       "xl": 6
     },
+    "reverseGeocode": {
+      "type": "checkbox",
+      "label": {
+        "en": "Enable Reverse Geocoding",
+        "de": "Reverse Geocoding aktivieren",
+        "ru": "Включить обратное геокодирование",
+        "pt": "Ativar geocodificação reversa",
+        "nl": "Reverse geocoding inschakelen",
+        "fr": "Activer le géocodage inversé",
+        "it": "Abilita geocodifica inversa",
+        "es": "Habilitar geocodificación inversa",
+        "pl": "Włącz odwrotne geokodowanie",
+        "zh-cn": "启用反向地理编码"
+      },
+      "help": {
+        "en": "Convert GPS coordinates (latitude/longitude) to street address using OpenStreetMap Nominatim. Updates after position has not changed for 30 seconds.",
+        "de": "GPS-Koordinaten (Breitengrad/Längengrad) in Straßenadresse umwandeln mit OpenStreetMap Nominatim. Aktualisierung wenn Position sich 30 Sekunden nicht geändert hat.",
+        "ru": "Преобразование GPS координат (широта/долгота) в адрес улицы с помощью OpenStreetMap Nominatim. Обновление после того, как позиция не менялась 30 секунд.",
+        "pt": "Converter coordenadas GPS (latitude/longitude) em endereço usando OpenStreetMap Nominatim. Atualiza após a posição não mudar por 30 segundos.",
+        "nl": "GPS-coördinaten (breedtegraad/lengtegraad) omzetten naar adres met OpenStreetMap Nominatim. Update nadat positie 30 seconden niet is veranderd.",
+        "fr": "Convertir les coordonnées GPS (latitude/longitude) en adresse avec OpenStreetMap Nominatim. Mise à jour après que la position n'a pas changé pendant 30 secondes.",
+        "it": "Converti le coordinate GPS (latitudine/longitudine) in indirizzo usando OpenStreetMap Nominatim. Aggiornamento dopo che la posizione non è cambiata per 30 secondi.",
+        "es": "Convertir coordenadas GPS (latitud/longitud) a dirección usando OpenStreetMap Nominatim. Se actualiza después de que la posición no cambie durante 30 segundos.",
+        "pl": "Konwertuj współrzędne GPS (szerokość/długość geograficzną) na adres za pomocą OpenStreetMap Nominatim. Aktualizacja po 30 sekundach bez zmiany pozycji.",
+        "zh-cn": "使用OpenStreetMap Nominatim将GPS坐标（纬度/经度）转换为街道地址。位置30秒未变化后更新。"
+      },
+      "default": false,
+      "newLine": true,
+      "xs": 12,
+      "sm": 12,
+      "md": 6,
+      "lg": 6,
+      "xl": 6
+    },
     "_api_endpoints": {
       "type": "header",
       "text": {

package/io-package.json

@@ -1,8 +1,34 @@
 {
   "common": {
     "name": "bmw",
-    "version": "4.3.3",
+    "version": "4.3.5",
     "news": {
+      "4.3.5": {
+        "en": "fix repo checker warnings\nfix vulnerability\nupdate dependencies\nremove old admin files",
+        "de": "repo checker warnungen beheben\nfehlerbehebung\naktualisierung der abhängigkeiten\nalte admin-dateien entfernen",
+        "ru": "объявления repo checker\nисправить уязвимость\nобновление зависимостей\nудалить старые файлы admin",
+        "pt": "corrigir avisos de repo checker\ncorrigir vulnerabilidade\natualizar dependências\nremover arquivos de administração antigos",
+        "nl": "repareren repo-checker waarschuwingen\nkwetsbaarheid herstellen\nafhankelijkheden bijwerken\noude beheerbestanden verwijderen",
+        "fr": "corriger les avertissements de repo checker\nfixer la vulnérabilité\nmettre à jour les dépendances\nsupprimer les anciens fichiers d'administration",
+        "it": "correggere gli avvisi di errore repo\ncorrezione della vulnerabilità\naggiornamento dipendenze\nrimuovere vecchi file di amministrazione",
+        "es": "arregla las advertencias del chequeador de reposo\ncorrección de vulnerabilidad\ndependencias de actualización\neliminar archivos de administración antiguos",
+        "pl": "naprawić ostrzeżenia kontrolera repo\nnaprawić podatność\naktualizacji zależności\nusuwanie starych plików admin",
+        "uk": "виправити попередження репо-реєстраторів\nвиправити вразливість\nоновлення залежності\nвидалити старі файли адміністратора",
+        "zh-cn": "修复 repo 检查器警告\n消除脆弱性\n更新依赖关系\n删除旧管理文件"
+      },
+      "4.3.4": {
+        "en": "enhance docu and logging\nfix vulnerability\nupdate dependencies",
+        "de": "docu und protokollierung verbessern\nfehlerbehebung\naktualisierung der abhängigkeiten",
+        "ru": "усиление доку и лесозаготовок\nисправить уязвимость\nобновление зависимостей",
+        "pt": "melhorar o docu e o registo\ncorrigir vulnerabilidade\natualizar dependências",
+        "nl": "document en houtkap verbeteren\nkwetsbaarheid herstellen\nafhankelijkheden bijwerken",
+        "fr": "améliorer docu et l'exploitation forestière\nfixer la vulnérabilité\nmettre à jour les dépendances",
+        "it": "migliorare docu e logging\ncorrezione della vulnerabilità\naggiornamento dipendenze",
+        "es": "mejorar docu y logging\ncorrección de vulnerabilidad\ndependencias de actualización",
+        "pl": "zwiększyć doku i logowanie\nnaprawić podatność\naktualizacji zależności",
+        "uk": "посилити docu і журналювання\nвиправити вразливість\nоновлення залежності",
+        "zh-cn": "加强docu和记录\n消除脆弱性\n更新依赖关系"
+      },
       "4.3.3": {
         "en": "year 2026 changes\nupdate dependencies",
         "de": "jahr 2026 änderungen\naktualisierung der abhängigkeiten",
@@ -67,32 +93,6 @@
         "pl": "poprawić odświeżanie symboli\nnaprawić pobieranie obrazu",
         "uk": "поліпшення освіження токени\nфіксація зображення fetching",
         "zh-cn": "改进符号刷新\n固定图像获取"
-      },
-      "4.1.1": {
-        "en": "Add API fetching via Container and move other apis to manually fetching",
-        "de": "Fügen Sie API-Fetching über Container hinzu und verschieben Sie andere Apis, um manuelles Abholen",
-        "ru": "Добавьте извлечение API через контейнер и переместите другие apis для ручного извлечения",
-        "pt": "Adicionar a obtenção da API via Container e mover outros apis para obter manualmente",
-        "nl": "API-ophalen toevoegen via Container en andere apis verplaatsen naar handmatig ophalen",
-        "fr": "Ajouter l'API récupérer via Container et déplacer d'autres apis pour récupérer manuellement",
-        "it": "Aggiungere API fetching tramite Container e spostare altri apis per recuperare manualmente",
-        "es": "Añadir API buscar a través de Container y mover otros apis para buscar manualmente",
-        "pl": "Dodaj API pobieranie przez kontener i przenieś inne apis do ręcznego pobierania",
-        "uk": "Додати API fetching через контейнер і перемістити інші apis для вручну fetching",
-        "zh-cn": "通过容器添加 API 获取并移动其他 API 手动获取"
-      },
-      "4.0.5": {
-        "en": "BREAKING: Complete migration to BMW CarData API\nBREAKING: OAuth2 device flow authentication (no more username/password)\nBREAKING: Remote controls removed (CarData API is read-only)\nNEW: Real-time MQTT streaming for instant updates\nNEW: 50 API calls per 24h quota management\nNEW: Comprehensive data collection from all CarData endpoints",
-        "de": "BREAKING: Vollständige Migration zur BMW CarData API\nBREAKING: OAuth2 Device Flow Authentifizierung (keine Benutzername/Passwort mehr)\nBREAKING: Fernbedienungen entfernt (CarData API ist nur lesend)\nNEU: Echtzeit MQTT Streaming für sofortige Updates\nNEU: 50 API Aufrufe pro 24h Quota Management\nNEU: Umfassende Datensammlung von allen CarData Endpunkten",
-        "ru": "BREAKING: Полная миграция на BMW CarData API\nBREAKING: Аутентификация через OAuth2 device flow (без имени пользователя/пароля)\nBREAKING: Удалено дистанционное управление (CarData API только для чтения)\nNEW: Потоковая передача MQTT в реальном времени для мгновенных обновлений\nNEW: Управление квотой 50 API вызовов за 24 часа\nNEW: Полный сбор данных со всех конечных точек CarData",
-        "pt": "BREAKING: Migração completa para a BMW CarData API\nBREAKING: Autenticação OAuth2 device flow (sem mais utilizador/senha)\nBREAKING: Controles remotos removidos (CarData API é apenas leitura)\nNEW: Streaming MQTT em tempo real para atualizações instantâneas\nNEW: Gestão de quota de 50 chamadas API por 24h\nNEW: Coleta abrangente de dados de todos os endpoints CarData",
-        "nl": "BREAKING: Volledige migratie naar de BMW CarData API\nBREAKING: OAuth2 device flow authenticatie (geen gebruikersnaam/wachtwoord meer)\nBREAKING: Afstandsbedieningen verwijderd (CarData API is alleen-lezen)\nNEW: Real-time MQTT streaming voor directe updates\nNEW: Quota van 50 API-aanroepen per 24u\nNEW: Uitgebreide gegevensverzameling van alle CarData endpoints",
-        "fr": "BREAKING : Migration complète vers l’API BMW CarData\nBREAKING : Authentification par OAuth2 device flow (plus de nom d’utilisateur/mot de passe)\nBREAKING : Commandes à distance supprimées (CarData API est en lecture seule)\nNEW : Streaming MQTT en temps réel pour des mises à jour instantanées\nNEW : Gestion du quota de 50 appels API par 24h\nNEW : Collecte complète des données de tous les endpoints CarData",
-        "it": "BREAKING: Migrazione completa alla BMW CarData API\nBREAKING: Autenticazione OAuth2 device flow (niente più nome utente/password)\nBREAKING: Controlli remoti rimossi (CarData API è solo in lettura)\nNEW: Streaming MQTT in tempo reale per aggiornamenti istantanei\nNEW: Gestione quota di 50 chiamate API per 24h\nNEW: Raccolta completa dei dati da tutti gli endpoint CarData",
-        "es": "BREAKING: Migración completa a la BMW CarData API\nBREAKING: Autenticación OAuth2 device flow (sin más usuario/contraseña)\nBREAKING: Controles remotos eliminados (CarData API es solo lectura)\nNEW: Streaming MQTT en tiempo real para actualizaciones instantáneas\nNEW: Gestión de cuota de 50 llamadas API por 24h\nNEW: Recolección completa de datos de todos los endpoints CarData",
-        "pl": "BREAKING: Pełna migracja do BMW CarData API\nBREAKING: Uwierzytelnianie OAuth2 device flow (bez nazwy użytkownika/hasła)\nBREAKING: Usunięto zdalne sterowanie (CarData API tylko do odczytu)\nNEW: Strumieniowanie MQTT w czasie rzeczywistym dla natychmiastowych aktualizacji\nNEW: Zarządzanie limitem 50 wywołań API na 24h\nNEW: Kompleksowe zbieranie danych ze wszystkich endpointów CarData",
-        "uk": "BREAKING: Повна міграція на BMW CarData API\nBREAKING: Автентифікація через OAuth2 device flow (без імені користувача/пароля)\nBREAKING: Видалено дистанційне керування (CarData API лише для читання)\nNEW: Потокове MQTT у реальному часі для миттєвих оновлень\nNEW: Керування квотою 50 викликів API на 24 години\nNEW: Повний збір даних з усіх кінцевих точок CarData",
-        "zh-cn": "BREAKING：完全迁移到 BMW CarData API\nBREAKING：OAuth2 device flow 身份验证（不再需要用户名/密码）\nBREAKING：远程控制已移除（CarData API 仅支持读取）\nNEW：实时 MQTT 流式传输，立即更新\nNEW：24 小时内 50 次 API 调用配额管理\nNEW：从所有 CarData 端点全面收集数据"
       }
     },
     "titleLang": {
@@ -158,7 +158,7 @@
     ],
     "globalDependencies": [
       {
-        "admin": ">=7.6.17"
+        "admin": ">=7.6.20"
       }
     ]
   },
@@ -169,7 +169,8 @@
     "cardataStreamingUsername": "",
     "interval": 60,
     "brand": "bmw",
-    "ignorelist": ""
+    "ignorelist": "",
+    "reverseGeocode": false
   },
   "objects": [],
   "instanceObjects": [

package/main.js

@@ -4,12 +4,12 @@
 const utils = require('@iobroker/adapter-core');
 const axios = require('axios');
 
-const crypto = require('crypto');
+const crypto = require('node:crypto');
 const qs = require('qs');
 const Json2iob = require('json2iob');
 const axiosRetry = require('axios-retry').default;
-const fs = require('fs');
-const path = require('path');
+const fs = require('node:fs');
+const path = require('node:path');
 
 // BMW CarData API quota limit (calls per 24 hours)
 const API_QUOTA_LIMIT = 50;
@@ -50,6 +50,10 @@ class Bmw extends utils.Adapter {
     // Flag to track initial login (not adapter restart)
     this.initialLogin = false;
 
+    // Position tracking for reverse geocoding debounce
+    this.lastPosition = {}; // { vin: { lat, lon, timestamp } }
+    this.reverseGeocodeTimers = {}; // { vin: timer }
+
     // Initialize descriptions and states from telematic.json
     this.description = {};
     this.states = {};
@@ -199,8 +203,8 @@ class Bmw extends utils.Adapter {
         this.log.info('Periodic telematic data updates disabled (interval = 0)');
       }
 
-      this.log.info('BMW CarData adapter startup complete');
-      this.log.info('MQTT streaming: enabled');
+      this.log.info(`BMW CarData adapter startup complete`);
+      this.log.info(`MQTT streaming: enabled`);
       this.log.info(
         `API quota: ${
           API_QUOTA_LIMIT - this.apiCalls.length
@@ -213,7 +217,7 @@ class Bmw extends utils.Adapter {
 
   async login() {
     if (!this.config.clientId) {
-      this.log.error('BMW CarData Client ID not configured! Please set up in adapter settings.');
+      this.log.error(`BMW CarData Client ID not configured! Please set up in adapter settings.`);
       return false;
     }
 
@@ -222,7 +226,7 @@ class Bmw extends utils.Adapter {
 
     try {
       // Step 1: Get device code
-      this.log.debug('Starting BMW CarData device authorization flow');
+      this.log.debug(`Starting BMW CarData device authorization flow`);
       this.log.debug(`Auth API Base: ${this.authApiBase}`);
       this.log.debug(`Client ID: ${this.config.clientId}`);
       this.log.debug(`Code Challenge: ${codeChallenge}`);
@@ -259,9 +263,9 @@ class Bmw extends utils.Adapter {
 
             // Special handling for 400 Bad Request - likely client configuration issue
             if (error.response.status === 400) {
-              this.log.error('='.repeat(80));
+              this.log.error(`===================================================`);
               this.log.error(`BMW CLIENT ID CONFIGURATION ERROR (400 Bad Request)`);
-              this.log.error('='.repeat(80));
+              this.log.error(`===================================================`);
               this.log.error(`This error usually means:`);
               this.log.error(`1. CarData API access is not activated for your Client ID`);
               this.log.error(`2. CarData Streaming is not enabled for your Client ID`);
@@ -271,12 +275,12 @@ class Bmw extends utils.Adapter {
               this.log.error(`1. Visit BMW ConnectedDrive portal: https://www.bmw.de/de-de/mybmw/vehicle-overview`);
               this.log.error(`2. Go to CarData section`);
               this.log.error(
-                `3. Check if CarData API and CarData Streaming are both activated. Sometimes it needs 30s to save the selection`,
+                `3. Check if CarData API and CarData Streaming are both activated. Sometimes it needs 30s to save the selection!`,
               );
               this.log.error(`4. If not activated, enable both services`);
               this.log.error(`5. If already activated, delete and recreate your Client ID`);
               this.log.error(`6. Update the adapter configuration with the new Client ID`);
-              this.log.error('='.repeat(80));
+              this.log.error(`===================================================`);
             }
           }
           if (error.request) {
@@ -895,9 +899,14 @@ class Bmw extends utils.Adapter {
     });
 
     this.mqtt.on('error', async error => {
-      this.log.error(`MQTT error: ${error}`);
       this.setState('info.mqttConnected', false, true);
 
+      // Check if it's a connection timeout (server not reachable)
+      if (error.message && error.message.includes('connack timeout')) {
+        this.log.warn(`BMW MQTT server not reachable (Connack timeout) - will retry automatically`);
+        return;
+      }
+
       // Check if it's an authentication error indicating expired token
       if (
         error.message &&
@@ -914,6 +923,7 @@ class Bmw extends utils.Adapter {
           this.log.warn(`MQTT will retry connection with current token via built-in reconnection`);
         }
       } else {
+        this.log.error(`MQTT error: ${error}`);
         this.log.debug(`Non-authentication MQTT error - letting built-in client handle reconnection`);
       }
     });
@@ -963,6 +973,9 @@ class Bmw extends utils.Adapter {
           });
 
           await this.setState(`${vin}.lastStreamUpdate`, new Date().toISOString(), true);
+
+          // Check for position updates and trigger reverse geocoding
+          this.checkPositionFromData(vin, data.data);
         }
       }
     } catch (error) {
@@ -970,6 +983,33 @@ class Bmw extends utils.Adapter {
     }
   }
 
+  /**
+   * Check for position data and trigger reverse geocoding if available
+   *
+   * @param {string} vin - The vehicle VIN
+   * @param {object} data - The data object containing telematic data
+   */
+  checkPositionFromData(vin, data) {
+    if (!this.config.reverseGeocode) {
+      return;
+    }
+
+    const latKey = 'vehicle.cabin.infotainment.navigation.currentLocation.latitude';
+    const lonKey = 'vehicle.cabin.infotainment.navigation.currentLocation.longitude';
+
+    const latData = data[latKey];
+    const lonData = data[lonKey];
+
+    if (latData?.value != null && lonData?.value != null) {
+      const latitude = parseFloat(latData.value);
+      const longitude = parseFloat(lonData.value);
+
+      if (!isNaN(latitude) && !isNaN(longitude)) {
+        this.checkAndTriggerReverseGeocode(vin, latitude, longitude);
+      }
+    }
+  }
+
   /**
    * Clean up existing containers that start with "ioBroker"
    */
@@ -1095,8 +1135,8 @@ class Bmw extends utils.Adapter {
       };
 
       // Read telematic.json file
-      const fs = require('fs');
-      const path = require('path');
+      const fs = require('node:fs');
+      const path = require('node:path');
       const telematicPath = path.join(__dirname, 'telematic.json');
 
       if (!fs.existsSync(telematicPath)) {
@@ -1113,7 +1153,7 @@ class Bmw extends utils.Adapter {
 
       const containerData = {
         name: `ioBroker BMW Telematic Data - ${new Date().toISOString()}`,
-        purpose: 'Container for BMW telematic data endpoints used by ioBroker adapter',
+        purpose: `Container for BMW telematic data endpoints used by ioBroker adapter`,
         technicalDescriptors: technicalDescriptors,
       };
 
@@ -1344,6 +1384,107 @@ class Bmw extends utils.Adapter {
     return createSuccess;
   }
 
+  /**
+   * Reverse geocode position using OpenStreetMap Nominatim
+   *
+   * @param {number} latitude - The latitude value
+   * @param {number} longitude - The longitude value
+   * @param {string} vin - The vehicle VIN
+   */
+  async reversePosition(latitude, longitude, vin) {
+    this.log.debug(`Reverse geocoding for ${vin}: ${latitude}, ${longitude}`);
+
+    try {
+      const response = await axios.get('https://nominatim.openstreetmap.org/reverse', {
+        params: { lat: latitude, lon: longitude, format: 'json', zoom: 18 },
+        headers: { 'User-Agent': 'ioBroker/bmw-adapter' },
+        timeout: 10000,
+      });
+
+      const body = response.data;
+      if (!body?.display_name) {
+        this.log.debug(`No address found for ${latitude}, ${longitude}`);
+        return;
+      }
+
+      const address = body.address || {};
+      const road = address.road || address.street || '';
+      const number = address.house_number || '';
+      const postcode = address.postcode || '';
+      const city = address.city || address.town || address.village || address.municipality || '';
+      const country = address.country || '';
+
+      let fullAddress = road;
+      if (number) {
+        fullAddress += ` ${number}`;
+      }
+      if (city) {
+        fullAddress += `, ${postcode ? `${postcode} ` : ''}${city}`;
+      }
+      if (country) {
+        fullAddress += `, ${country}`;
+      }
+
+      // Store address data using json2iob
+      await this.json2iob.parse(
+        `${vin}.position.address`,
+        {
+          displayName: fullAddress,
+          road: road,
+          house_number: number,
+          postcode: postcode,
+          city: city,
+          country: country,
+          latitude: latitude,
+          longitude: longitude,
+        },
+        { channelName: 'Reverse Geocoded Address' },
+      );
+
+      this.log.info(`Address updated for ${vin}: ${fullAddress}`);
+    } catch (error) {
+      this.log.error(`Reverse geocoding failed: ${error.message}`);
+    }
+  }
+
+  /**
+   * Check and trigger reverse geocoding with debounce
+   * Only triggers if position hasn't changed for 30 seconds
+   *
+   * @param {string} vin - The vehicle VIN
+   * @param {number} latitude - Current latitude
+   * @param {number} longitude - Current longitude
+   */
+  checkAndTriggerReverseGeocode(vin, latitude, longitude) {
+    if (!this.config.reverseGeocode) {
+      return;
+    }
+
+    const DEBOUNCE_MS = 30000; // 30 seconds
+    const lastPos = this.lastPosition[vin];
+
+    // Check if position has changed
+    const positionChanged = !lastPos || lastPos.lat !== latitude || lastPos.lon !== longitude;
+
+    if (positionChanged) {
+      // Position changed - update tracking and reset timer
+      this.lastPosition[vin] = { lat: latitude, lon: longitude };
+
+      // Clear existing timer
+      if (this.reverseGeocodeTimers[vin]) {
+        clearTimeout(this.reverseGeocodeTimers[vin]);
+      }
+
+      // Set new debounce timer
+      this.reverseGeocodeTimers[vin] = setTimeout(() => {
+        this.log.debug(`Position stable for 30s, triggering reverse geocode for ${vin}`);
+        this.reversePosition(latitude, longitude, vin);
+      }, DEBOUNCE_MS);
+
+      this.log.debug(`Position changed for ${vin}, debounce timer reset`);
+    }
+  }
+
   /**
    * Is called when adapter shuts down - callback has to be called under any circumstances!
    *
@@ -1355,6 +1496,11 @@ class Bmw extends utils.Adapter {
       clearInterval(this.updateInterval);
       clearInterval(this.refreshTokenInterval);
 
+      // Clear reverse geocode timers
+      for (const vin of Object.keys(this.reverseGeocodeTimers)) {
+        clearTimeout(this.reverseGeocodeTimers[vin]);
+      }
+
       // Close MQTT connection
       if (this.mqtt) {
         this.mqtt.end();
@@ -1516,7 +1662,7 @@ class Bmw extends utils.Adapter {
 
           this.log.info(`Successfully fetched charging history for ${vin}: ${chargingData.totalSessions} sessions`);
         } else {
-          throw new Error('Failed to fetch charging history');
+          throw new Error(`Failed to fetch charging history`);
         }
         break;
       }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "iobroker.bmw",
-  "version": "4.3.3",
+  "version": "4.3.5",
   "description": "Adapter for BMW",
   "author": {
     "name": "TA2k",
@@ -22,21 +22,21 @@
   },
   "dependencies": {
     "@iobroker/adapter-core": "^3.3.2",
-    "axios": "^1.13.2",
+    "axios": "^1.15.0",
     "axios-retry": "^4.5.0",
-    "json2iob": "^2.6.21",
-    "mqtt": "^5.14.1",
-    "qs": "^6.14.0"
+    "json2iob": "^2.6.22",
+    "mqtt": "^5.15.0",
+    "qs": "^6.14.1"
   },
   "devDependencies": {
-    "@alcalzone/release-script": "^5.0.0",
-    "@alcalzone/release-script-plugin-iobroker": "^4.0.0",
-    "@alcalzone/release-script-plugin-license": "^4.0.0",
-    "@alcalzone/release-script-plugin-manual-review": "^4.0.0",
+    "@alcalzone/release-script": "^5.1.1",
+    "@alcalzone/release-script-plugin-iobroker": "^5.1.2",
+    "@alcalzone/release-script-plugin-license": "^5.1.1",
+    "@alcalzone/release-script-plugin-manual-review": "^5.1.1",
     "@iobroker/eslint-config": "^2.2.0",
     "@iobroker/testing": "^5.2.2",
-    "@tsconfig/node20": "^20.1.8",
-    "@types/node": "^25.0.3",
+    "@tsconfig/node20": "^20.1.9",
+    "@types/node": "^25.2.1",
     "@types/qs": "^6.14.0",
     "globals": "^16.5.0",
     "typescript": "~5.9.3"

package/admin/admin.d.ts

@@ -1,93 +0,0 @@
-declare let systemDictionary: Record<string, Record<string, string>>;
-
-declare let load: (settings: Record<string, unknown>, onChange: (hasChanges: boolean) => void) => void;
-declare let save: (callback: (settings: Record<string, unknown>) => void) => void;
-
-// make load and save exist on the window object
-interface Window {
-    load: typeof load;
-    save: typeof save;
-}
-
-declare const instance: number;
-declare const adapter: string;
-/** Translates text */
-declare function _(text: string, arg1?: string, arg2?: string, arg3?: string): string;
-declare const socket: ioBrokerSocket;
-declare function sendTo(
-    instance: any | null,
-    command: string,
-    message: any,
-    callback: (result: SendToResult) => void | Promise<void>,
-): void;
-
-interface SendToResult {
-    error?: string | Error;
-    result?: any;
-}
-
-// tslint:disable-next-line:class-name
-interface ioBrokerSocket {
-    emit(
-        command: "subscribeObjects",
-        pattern: string,
-        callback?: (err?: string) => void | Promise<void>,
-    ): void;
-    emit(
-        command: "subscribeStates",
-        pattern: string,
-        callback?: (err?: string) => void | Promise<void>,
-    ): void;
-    emit(
-        command: "unsubscribeObjects",
-        pattern: string,
-        callback?: (err?: string) => void | Promise<void>,
-    ): void;
-    emit(
-        command: "unsubscribeStates",
-        pattern: string,
-        callback?: (err?: string) => void | Promise<void>,
-    ): void;
-
-    emit(
-        event: "getObjectView",
-        view: "system",
-        type: "device",
-        options: ioBroker.GetObjectViewParams,
-        callback: (
-            err: string | undefined,
-            result?: any,
-        ) => void | Promise<void>,
-    ): void;
-    emit(
-        event: "getStates",
-        callback: (
-            err: string | undefined,
-            result?: Record<string, any>,
-        ) => void,
-    ): void;
-    emit(
-        event: "getState",
-        id: string,
-        callback: (err: string | undefined, result?: ioBroker.State) => void,
-    ): void;
-    emit(
-        event: "setState",
-        id: string,
-        state: unknown,
-        callback: (err: string | undefined, result?: any) => void,
-    ): void;
-
-    on(event: "objectChange", handler: ioBroker.ObjectChangeHandler): void;
-    on(event: "stateChange", handler: ioBroker.StateChangeHandler): void;
-    removeEventHandler(
-        event: "objectChange",
-        handler: ioBroker.ObjectChangeHandler,
-    ): void;
-    removeEventHandler(
-        event: "stateChange",
-        handler: ioBroker.StateChangeHandler,
-    ): void;
-
-    // TODO: other events
-}

package/admin/style.css

@@ -1,43 +0,0 @@
-/* You can delete those if you want. I just found them very helpful */
-* {
-    box-sizing: border-box
-}
-
-body {
-    overflow: hidden;
-}
-
-.adapter-body {
-    overflow: auto;
-}
-
-.m {
-    /* Don't cut off dropdowns! */
-    overflow: initial;
-}
-
-.m.adapter-container,
-.m.adapter-container>div.App {
-    /* Fix layout/scrolling issues with tabs */
-    height: 100%;
-    width: 100%;
-    position: relative;
-}
-
-.m .select-wrapper+label {
-    /* The positioning for dropdown labels is messed up */
-    transform: none !important;
-}
-
-label>i[title] {
-    /* Display the help cursor for the tooltip icons and fix their positioning */
-    cursor: help;
-    margin-left: 0.25em;
-}
-
-.dropdown-content {
-    /* Don't wrap text in dropdowns */
-    white-space: nowrap;
-}
-
-/* Add your styles here */

package/admin/tsconfig.json

@@ -1,9 +0,0 @@
-{
-    "extends": "../tsconfig.json",
-    "include": [
-        "./admin.d.ts",
-        "./**/*.js",
-        // include the adapter-config definition if it exists
-        "../src/lib/adapter-config.d.ts",
-    ]
-}

package/admin/words.js

@@ -1,66 +0,0 @@
-// eslint-disable-next-line no-unused-vars
-/*global systemDictionary:true */
-'use strict';
-
-systemDictionary = {
-  'bmw adapter settings': {
-    en: 'Adapter settings for bmw',
-    de: 'Adaptereinstellungen für bmw',
-    ru: 'Настройки адаптера для bmw',
-    pt: 'Configurações do adaptador para bmw',
-    nl: 'Adapterinstellingen voor bmw',
-    fr: "Paramètres d'adaptateur pour bmw",
-    it: "Impostazioni dell'adattatore per bmw",
-    es: 'Ajustes del adaptador para bmw',
-    pl: 'Ustawienia adaptera dla bmw',
-    'zh-cn': 'bmw2的适配器设置',
-  },
-  'App Email': {
-    en: 'App Email',
-    de: 'App-E-Mail',
-    ru: 'Электронная почта приложения',
-    pt: 'Email do aplicativo',
-    nl: 'App-e-mail',
-    fr: "Courriel de l'application",
-    it: "E-mail dell'app",
-    es: 'Correo electrónico de la aplicación',
-    pl: 'E-mail aplikacji',
-    'zh-cn': '应用电子邮件',
-  },
-  'App Password': {
-    en: 'App Password',
-    de: 'App-Passwort',
-    ru: 'Пароль приложения',
-    pt: 'Senha de app',
-    nl: 'App-wachtwoord',
-    fr: "Mot de passe de l'application",
-    it: "Password dell'app",
-    es: 'Contraseña de la aplicación',
-    pl: 'Hasło do aplikacji',
-    'zh-cn': '应用密码',
-  },
-  'Update interval (in minutes)': {
-    en: 'Update interval (in minutes)',
-    de: 'Aktualisierungsintervall (in Minuten)',
-    ru: 'Интервал обновления (в минутах)',
-    pt: 'Intervalo de atualização (em minutos)',
-    nl: 'Update-interval (in minuten)',
-    fr: 'Intervalle de mise à jour (en minutes)',
-    it: 'Intervallo di aggiornamento (in minuti)',
-    es: 'Intervalo de actualización (en minutos)',
-    pl: 'Interwał aktualizacji (w minutach)',
-    'zh-cn': '更新间隔（分钟）',
-  },
-  Brand: {
-    en: 'Brand',
-    de: 'Marke',
-    ru: 'Марка',
-    pt: 'Marca',
-    nl: 'Brand',
-    fr: 'Marque',
-    it: 'Marca',
-    es: 'Marca',
-    pl: 'Brandy',
-    'zh-cn': '陪审团',
-  },
-};