iobroker.assistant 1.4.2 → 1.4.3

package/README.md

@@ -235,6 +235,9 @@ train it twice.
     Placeholder for the next version (at the beginning of the line):
     ### **WORK IN PROGRESS**
 -->
+### 1.4.3 (2026-11-03)
+* (@GermanBluefox) An empty question sent with `sendTo('ask')` is rejected (`{error: 'empty question'}`) instead of going to the model with nothing but the time context, and the log names the sender once a minute. A script that asked on every answer looped about once a second and used pi-agent tokens. The log line of every `ask` now names the sender
+
 ### 1.4.2 (2026-11-03)
 * (@GermanBluefox) ESPHome satellites: after 2.5 seconds of speech a pause may be half as long again before the request ends, so a pause for thought no longer cuts off a longer request. Short commands close as fast as before
 * (@GermanBluefox) ESPHome satellites: speech recognition gets the recording without the device's chirp or beep and without the silence around the speech, and quiet speech is amplified (up to ×10). Whisper made "Продолжение следует..." of the beep and the silence

package/build/main.js

@@ -132,6 +132,8 @@ const VOICE_FORM_FIELDS = [
 ];
 /** Of those, the protected ones: the browser never gets them, so an empty value there means "keep the saved one" */
 const VOICE_FORM_SECRETS = ['voiceApiKey', 'openrouterSpeechKey', 'azureSpeechKey', 'awsSecretAccessKey'];
+/** An empty `ask` from the same caller is reported at most this often. */
+const EMPTY_ASK_REPORT_MS = 60_000;
 /** How long to wait for a device to confirm a write, and how often to look. */
 const ACK_TIMEOUT_MS = 2000;
 const ACK_POLL_MS = 150;
@@ -817,6 +819,25 @@ class Assistant extends adapter_core_1.Adapter {
             voice: (voices[provider] || '').trim() || undefined,
         });
     }
+    /** Per caller of `ask`: when an empty question was last reported, and how many came since. */
+    emptyAsks = new Map();
+    /**
+     * An empty `ask` is rejected, and reported once a minute per caller. Field report (2026-11-03): a caller asked
+     * with empty text every time an answer arrived — about once a second, each one a pi-agent request about "only
+     * the time" (the time context was the whole question) and paid tokens. A script that asks on every change of
+     * `text.response` loops exactly like that.
+     */
+    reportEmptyAsk(from) {
+        const now = Date.now();
+        const entry = this.emptyAsks.get(from) ?? { reportedAt: 0, count: 0 };
+        entry.count++;
+        if (now - entry.reportedAt >= EMPTY_ASK_REPORT_MS) {
+            this.log.warn(`Ignoring an empty question from ${from} (sendTo "ask")${entry.count > 1 ? ` — ${entry.count} since the last report` : ''}. A script that asks whenever text.response changes keeps doing this in a loop.`);
+            entry.reportedAt = now;
+            entry.count = 0;
+        }
+        this.emptyAsks.set(from, entry);
+    }
     /** Record the origin of the current text.request/response ('' = state write, 'chat' = message, else satellite). */
     setQuerySource(source) {
         this.setStateAsync('text.querySource', { val: source, ack: true }).catch(() => { });
@@ -2696,14 +2717,23 @@ class Assistant extends adapter_core_1.Adapter {
         const text = typeof message === 'string' ? message : message?.text;
         // Origin for text.querySource: caller-provided (e.g. 'telegram:Max') or 'chat' for the admin chat.
         const source = (typeof message === 'string' ? '' : message?.source?.trim()) || 'chat';
+        // Who sent it (javascript.0, telegram.0, admin.0 for the chat tab) — the way to find a script gone wrong.
+        const caller = String(obj.from || '').replace(/^system\.adapter\./, '') || 'unknown';
+        const question = String(text ?? '').trim();
+        if (!question) {
+            this.reportEmptyAsk(caller);
+            if (obj.callback) {
+                this.sendTo(obj.from, obj.command, { error: 'empty question' }, obj.callback);
+            }
+            return;
+        }
         if (!this.ready) {
             if (obj.callback) {
                 this.sendTo(obj.from, obj.command, { error: 'agent not ready' }, obj.callback);
             }
             return;
         }
-        const question = String(text ?? '');
-        this.log.info(`Q (${obj.command}): ${question}`);
+        this.log.info(`Q (${obj.command} from ${caller}): ${question}`);
         this.setStateAsync('text.request', { val: question, ack: true }).catch(() => { });
         this.setQuerySource(source);
         try {
@@ -2732,6 +2762,10 @@ class Assistant extends adapter_core_1.Adapter {
      * later turns have the full thread.
      */
     answer(question, source = '', origin = {}) {
+        if (!question.trim()) {
+            // Nothing to answer — and a model asked with nothing but the time context still costs a request.
+            return Promise.resolve('');
+        }
         const voice = VOICE_TRANSPORTS.has(origin.transport || '');
         return this.requestOrigin.run({ source, room: origin.room || '', voice }, () => this.journal
             ? this.journal.run(question, source, origin, () => {