iobroker.anthbot 0.0.2 → 0.0.4

package/LICENSE

@@ -1,5 +1,6 @@
 MIT License
 
+Copyright (c) 2026 iobroker-community-adapters <iobroker-community-adapters@gmx.de>  
 Copyright (c) 2026 Robin Rainton <robin@rainton.com>
 
 Permission is hereby granted, free of charge, to any person obtaining a copy

package/README.md

@@ -8,7 +8,7 @@
 
 [![NPM](https://nodei.co/npm/iobroker.anthbot.png?downloads=true)](https://nodei.co/npm/iobroker.anthbot/)
 
-**Tests:** ![Test and Release](https://github.com/raintonr/ioBroker.anthbot/workflows/Test%20and%20Release/badge.svg)
+**Tests:** ![Test and Release](https://github.com/iobroker-community-adapters/ioBroker.anthbot/workflows/Test%20and%20Release/badge.svg)
 
 ## anthbot adapter for ioBroker
 
@@ -19,12 +19,22 @@ Connect with Anthbot devices such as their robot mowers.
     Placeholder for the next version (at the beginning of the line):
     ### **WORK IN PROGRESS**
 -->
+### 0.0.4 (2026-05-18)
+- (copilot) Adapter requires node.js >= 22 now
+- (copilot) Adapter requires admin >= 7.7.22 now
+- (raintonr) Handle temporary IoT access tokens (#9)
+
+### 0.0.3 (2026-04-25)
+* (raintonr) adapter checker issues
+
 ### 0.0.2 (2026-04-25)
 * (raintonr) initial release
 
 ## License
 MIT License
 
+
+Copyright (c) 2026 iobroker-community-adapters <iobroker-community-adapters@gmx.de>  
 Copyright (c) 2026 Robin Rainton <robin@rainton.com>
 
 Permission is hereby granted, free of charge, to any person obtaining a copy

package/io-package.json

@@ -1,8 +1,34 @@
 {
   "common": {
     "name": "anthbot",
-    "version": "0.0.2",
+    "version": "0.0.4",
     "news": {
+      "0.0.4": {
+        "en": "Adapter requires node.js >= 22 now\nAdapter requires admin >= 7.7.22 now\nHandle temporary IoT access tokens (#9)",
+        "de": "Adapter benötigt node.js >= 22 jetzt\nAdapter benötigt admin >= 7.7.22 jetzt\nHandle temporäre IoT-Zugriffstoken (#9)",
+        "ru": "Адаптер требует node.js >= 22 сейчас\nАдаптер требует администратора >= 7.7.22\nОбработка временных токенов доступа к IoT (#9)",
+        "pt": "Adaptador requer nod.js >= 22 agora\nAdaptador requer admin >= 7.7.22 agora\nLidar com tokens de acesso temporário de IoT (# 9)",
+        "nl": "Voor de adapter zijn node.js < 22 nu nodig\nAdapter vereist admin < 7.7.22 nu\nTijdelijke IoT toegang tokens hanteren (#9)",
+        "fr": "Adaptateur nécessite node.js >= 22 maintenant\nAdaptateur nécessite admin >= 7.7.22 maintenant\nPoignez des jetons d'accès IoT temporaires (#9)",
+        "it": "Adattatore richiede node.js >= 22 ora\nAdattatore richiede admin >= 7.7.22 ora\nMantenere i gettoni di accesso IoT temporanei (#9)",
+        "es": "Adaptador requiere node.js ю= 22 ahora\nEl adaptador requiere administrador= 7.7.22 ahora\nHandle temporary IoT access tokens (#9)",
+        "pl": "Adapter wymaga node.js > = 22\nAdapter wymaga admin > = 7.7.22\nObsługa tymczasowych żetonów dostępu IoT (# 9)",
+        "uk": "Адаптер вимагає node.js >= 22 тепер\nАдаптер вимагає адмін >= 7.7.22 тепер\nЗручності для доступу до Інтернету речей (#9)",
+        "zh-cn": "适配器需要节点.js 现在22\n适任者需要管理员 \\ 7.7.22 现在\n处理临时 IOT 访问符 (# 9)"
+      },
+      "0.0.3": {
+        "en": "adapter checker issues",
+        "de": "adapter checker probleme",
+        "ru": "проблемы проверки адаптера",
+        "pt": "problemas com o verificador de adaptadores",
+        "nl": "problemen met de adaptercontrole",
+        "fr": "problèmes de vérification de l'adaptateur",
+        "it": "adattatore checker",
+        "es": "problemas de control de adaptador",
+        "pl": "problemy z sprawdzaniem adaptera",
+        "uk": "питання перевірки адаптера",
+        "zh-cn": "适配器检查器问题"
+      },
       "0.0.2": {
         "en": "initial release",
         "de": "Erstveröffentlichung",
@@ -44,7 +70,8 @@
       "zh-cn": "与 Anthbot 设备连接，例如机器人割草机"
     },
     "authors": [
-      "Robin Rainton <robin@rainton.com>"
+      "Robin Rainton <robin@rainton.com>",
+      "iobroker-community-adapters <iobroker-community-adapters@gmx.de>"
     ],
     "keywords": [
       "robot",
@@ -60,8 +87,8 @@
     "platform": "Javascript/Node.js",
     "icon": "anthbot.png",
     "enabled": true,
-    "extIcon": "https://raw.githubusercontent.com/raintonr/ioBroker.anthbot/main/admin/anthbot.png",
-    "readme": "https://github.com/raintonr/ioBroker.anthbot/blob/main/README.md",
+    "extIcon": "https://raw.githubusercontent.com/iobroker-community-adapters/ioBroker.anthbot/master/admin/anthbot.png",
+    "readme": "https://github.com/iobroker-community-adapters/ioBroker.anthbot/blob/master/README.md",
     "loglevel": "info",
     "tier": 3,
     "mode": "daemon",
@@ -79,15 +106,22 @@
     ],
     "globalDependencies": [
       {
-        "admin": ">=7.0.23"
+        "admin": ">=7.7.22"
       }
     ]
   },
   "native": {
     "username": "",
     "password": "",
-    "regionCode": null
+    "regionCode": 61
   },
+  "encryptedNative": [
+    "password"
+  ],
+  "protectedNative": [
+    "username",
+    "password"
+  ],
   "objects": [],
   "instanceObjects": [
     {

package/lib/anthbotApi.js

@@ -34,7 +34,7 @@ const REQUEST_TIMEOUT = 15000; // 15 seconds
 // Shared methods
 class AnthotCloudApi {
     /**
-     * @param {{ verboseLogger?: ((message: string) => void) | null}} options
+     * @param {{ verboseLogger?: ((message: string) => void) | null }} options - Configuration options
      */
     constructor({ verboseLogger = null }) {
         this.verboseLogger = verboseLogger;
@@ -117,7 +117,7 @@ class AnthotCloudApi {
  * Client for Anthbot cloud account endpoints
  */
 class AnthbotCloudApiClient {
-    /** @param {{ verboseLogger?: ((message: string) => void) | null }} options */
+    /** @param {{ verboseLogger?: ((message: string) => void) | null }} options - Configuration options */
     constructor({ verboseLogger = null }) {
         this.endpointHost = DEFAULT_API_HOST;
         this.authHeaders = {
@@ -134,8 +134,13 @@ class AnthbotCloudApiClient {
 
     /**
      * Login and return bearer token
+     *
+     * @param {string} username - Username
+     * @param {string} password - Password
+     * @param {number} areaCode - Country/region code
+     * @returns {Promise<string>} Bearer token
      */
-    async asyncLogin({ username, password, areaCode }) {
+    async asyncLogin(username, password, areaCode) {
         const url = `https://${this.endpointHost}/api/v1/login`;
         const headers = {
             Accept: 'application/json, text/plain, */*',
@@ -158,15 +163,14 @@ class AnthbotCloudApiClient {
 
         let data;
         try {
-            data = /** @type {{ code: number; data: { access_token: string } }} */ (await response.json());
+            data = /** @type {{code: number, data?: any}} */ (await response.json());
         } catch {
             throw new Error('Invalid JSON response from login');
         }
 
         if (typeof data !== 'object' || data === null) {
             throw new Error('Invalid login payload type');
-        }
-        if (data.code !== 0) {
+        } else if (data.code !== 0) {
             throw new Error(`Login rejected: code=${JSON.stringify(data.code)}`);
         }
 
@@ -186,6 +190,9 @@ class AnthbotCloudApiClient {
         return bearerToken;
     }
 
+    /**
+     * Make sure we have valid bearerToken
+     */
     checkToken() {
         if (!this.bearerToken) {
             throw new Error('Bearer token not configured');
@@ -194,6 +201,8 @@ class AnthbotCloudApiClient {
 
     /**
      * Fetch account-bound Anthbot devices
+     *
+     * @returns {Promise<{alias: string, sn: string}[]>} - List of devices
      */
     async asyncGetBoundDevices() {
         this.checkToken();
@@ -208,12 +217,17 @@ class AnthbotCloudApiClient {
             throw new Error(`Request to ${url} failed, response ${response.status}`);
         }
 
-        return /** @type {{ data:  {alias: string, sn: string}[] }} */ (await response.json()).data;
+        return /** @type {{data?: any}} */ (await response.json()).data;
     }
 
     /**
      * Fetch latest messages
      * Returns only last message by default
+     *
+     * @param {string} serialNumber - Device serial number
+     * @param {number} pageNum - Page number
+     * @param {number} pageSize - Page size
+     * @returns {Promise<unknown>} Latest messages
      */
     async asyncGetCodeList(serialNumber, pageNum = 1, pageSize = 1) {
         this.checkToken();
@@ -230,9 +244,15 @@ class AnthbotCloudApiClient {
             throw new Error(`Request to ${url} failed, response ${response.status}`);
         }
 
-        return /** @type {{ data: { data: unknown } }} */ (await response.json())?.data?.data;
+        return /** @type {{data?: any}} */ (await response.json())?.data?.data;
     }
 
+    /**
+     * Get verification token for presigned URL retrieval
+     *
+     * @param {string} serialNumber - Device serial number
+     * @returns {string} - Verification token
+     */
     buildVerificationToken(serialNumber) {
         const unixTimestamp = Math.floor(Date.now() / 1000);
         const tokenSuffix = unixTimestamp.toString();
@@ -243,21 +263,21 @@ class AnthbotCloudApiClient {
     /**
      * Fetch account-bound Anthbot devices
      *
-     * @param {string} sn
-     * @param {string} filename
-     * @param {string} category
-     * @param {string} sub_category
-     * @returns {Promise<string>} URL for the requested file
+     * @param {string} serialNumber - Device serial number
+     * @param {string} filename - File name
+     * @param {string} category - Category
+     * @param {string} sub_category - Sub category
+     * @returns {Promise<string>} - URL for the requested file
      */
-    async asyncGetPresignedUrl(sn, filename, category, sub_category) {
+    async asyncGetPresignedUrl(serialNumber, filename, category, sub_category) {
         this.checkToken();
 
         const params = new URLSearchParams({
             filename,
-            sn,
+            sn: serialNumber,
             category,
             sub_category,
-            verification_token: this.buildVerificationToken(sn),
+            verification_token: this.buildVerificationToken(serialNumber),
         });
         const url = `https://${this.endpointHost}/api/v1/device/v2/presigned_url?${params}`;
         const response = await this.fetch(url, {
@@ -269,16 +289,15 @@ class AnthbotCloudApiClient {
             throw new Error(`Request to ${url} failed, response ${response.status}`);
         }
 
-        return /** @type {{ data:  {presigned_url: string } }} */ (await response.json()).data?.presigned_url;
+        return /** @type {{data?: any}} */ (await response.json()).data?.presigned_url;
     }
 
     /**
      * Decodes a TAR.GZ archive from a Buffer and returns an array of file entries with filename, type and content.
      *
-     * @param {Buffer} buffer
-     * @returns {Promise<Array<{ filename: string; type: 'json' | 'blob'; content: unknown }>>}
+     * @param {Buffer} buffer - The TAR.GZ buffer to decode
+     * @returns {Promise<Array<{ filename: string; type: 'json' | 'blob'; content: unknown }>>} - Array of file contents
      */
-
     decodeTgzBuffer(buffer) {
         return new Promise((resolve, reject) => {
             const results = [];
@@ -337,6 +356,12 @@ class AnthbotCloudApiClient {
         });
     }
 
+    /**
+     * Fetch device map
+     *
+     * @param {string} serialNumber - Device serial number
+     * @returns {Promise<Array<{ filename: string; type: 'json' | 'blob'; content: unknown }>>} - Decoded map data
+     */
     async asyncGetDeviceMap(serialNumber) {
         const url = await this.asyncGetPresignedUrl(
             serialNumber,
@@ -360,6 +385,9 @@ class AnthbotCloudApiClient {
 
     /**
      * Fetch device cloud region metadata
+     *
+     * @param {string} serialNumber - Device serial number
+     * @returns {Promise<{regionName: string; iotEndpoint: string}>} - Region metadata
      */
     async asyncGetDeviceRegion(serialNumber) {
         if (this.verboseLogger) {
@@ -382,9 +410,7 @@ class AnthbotCloudApiClient {
 
         let payload;
         try {
-            payload = /** @type {{ code: number; data: {region_name: string; iot_endpoint: string } }} */ (
-                await response.json()
-            );
+            payload = /** @type {{code: number, data?: any}} */ (await response.json());
         } catch {
             throw new Error('Invalid JSON response from device region');
         }
@@ -417,6 +443,74 @@ class AnthbotCloudApiClient {
         return deviceRegion;
     }
 
+    /**
+     * Retrieve temporary IoT credentials for a device.
+     *
+     * @param {string} serialNumber - Device serial number
+     * @returns {Promise<object>} - IoT credentials and expiration
+     */
+    async asyncGetDeviceIotCredentials(serialNumber) {
+        this.checkToken();
+
+        const params = {
+            sn: serialNumber,
+            verification_token: this.buildVerificationToken(serialNumber),
+        };
+
+        const response = await this.fetch(`https://${this.endpointHost}/api/v1/device/v2/iot/sts/arn`, {
+            method: 'POST',
+            headers: { ...this.authHeaders, 'content-type': 'application/json' },
+            body: JSON.stringify(params),
+        });
+
+        if (response.status !== 200) {
+            const body = await response.text();
+            throw new Error(`IoT credentials failed (${response.status}): ${body.slice(0, 300)}`);
+        }
+
+        let payload;
+        try {
+            payload = /** @type {{code: number, data?: any}} */ (await response.json());
+        } catch {
+            throw new Error('Invalid JSON response from IoT credentials');
+        }
+
+        if (typeof payload !== 'object' || payload === null) {
+            throw new Error('Invalid IoT credentials payload type');
+        }
+        if (payload.code !== 0) {
+            throw new Error(`IoT credentials returned code=${payload.code}`);
+        }
+
+        const data = payload.data;
+        if (typeof data !== 'object' || data === null) {
+            throw new Error('IoT credentials payload missing data object');
+        }
+
+        const expiration = data.expiration;
+        const expiresAt =
+            expiration == null ? null : expiration > 2000000000 ? expiration * 1000 : Date.now() + expiration * 1000;
+
+        const iotCredentials = {
+            accessKeyId: data.access_key_id,
+            secretAccessKey: data.secret_access_key,
+            sessionToken: data.session_token,
+            regionName: data.region_name,
+            endpoint: data.endpoint,
+            expiresAt,
+        };
+        if (this.verboseLogger) {
+            this.verboseLogger(`IoT credentials for ${serialNumber}: ${JSON.stringify(iotCredentials)}`);
+        }
+        return iotCredentials;
+    }
+
+    /**
+     * Ensure shadow client is initialized
+     *
+     * @param {string} serialNumber - Device serial number
+     * @returns {Promise<void>}
+     */
     async checkShadowClient(serialNumber) {
         // TODO: Handle multiple devices with different shadow clients instead of caching just one
         if (!this.shadowClient) {
@@ -431,13 +525,40 @@ class AnthbotCloudApiClient {
                 verboseLogger: this.verboseLogger,
             });
         }
+
+        // Get new credentials if we have none or they have expired
+        if (
+            !this.iotCredentials ||
+            this.iotCredentials.expiresAt === null ||
+            this.iotCredentials.expiresAt - Date.now() <= 60000
+        ) {
+            if (this.verboseLogger) {
+                this.verboseLogger(`No/expired IoT Credentaials for ${serialNumber}, fetching them`);
+            }
+            this.iotCredentials = await this.asyncGetDeviceIotCredentials(serialNumber);
+            this.shadowClient.iotCredentials = this.iotCredentials;
+        }
     }
 
+    /**
+     * Get shadow reported state
+     *
+     * @param {string} serialNumber - Device serial number
+     * @returns {Promise<unknown>} - Reported state
+     */
     async asyncGetShadowReportedState(serialNumber) {
         await this.checkShadowClient(serialNumber);
         return await this.shadowClient?.asyncGetShadowReportedState();
     }
 
+    /**
+     * Send service command
+     *
+     * @param {string} serialNumber - Device serial number
+     * @param {string} cmd - Command
+     * @param {unknown} data - ommand data
+     * @returns {Promise<void>}
+     */
     async asyncSendServiceCommand(serialNumber, cmd, data) {
         await this.checkShadowClient(serialNumber);
         return await this.shadowClient?.asyncPublishServiceCommand({ cmd, data });
@@ -449,12 +570,13 @@ class AnthbotCloudApiClient {
  */
 class AnthbotShadowApiClient {
     /**
-     * @param {{serialNumber: string, regionName?: string | null, iotEndpoint?: string | null, verboseLogger?: ((message: string) => void) | null}} options
+     * @param {{serialNumber: string, regionName?: string | null, iotEndpoint?: string | null, verboseLogger?: ((message: string) => void) | null}} options - Configuration options
      */
     constructor({ serialNumber, regionName = null, iotEndpoint = null, verboseLogger = null }) {
         this._serialNumber = serialNumber;
         this._regionName = typeof regionName === 'string' && regionName ? regionName : null;
         this._iotEndpoint = AnthbotShadowApiClient._normalizeEndpoint(iotEndpoint);
+        this._iotCredentials = null;
         this.verboseLogger = verboseLogger;
         this.fetch = new AnthotCloudApi({ verboseLogger }).fetch;
 
@@ -491,6 +613,10 @@ class AnthbotShadowApiClient {
         return AnthbotShadowApiClient._guessRegionFromEndpoint(iotEndpoint);
     }
 
+    set iotCredentials(iotCredentals) {
+        this._iotCredentials = iotCredentals;
+    }
+
     get serialNumber() {
         return this._serialNumber;
     }
@@ -508,6 +634,9 @@ class AnthbotShadowApiClient {
     }
 
     _accessKeyId() {
+        if (this._iotCredentials?.accessKeyId) {
+            return this._iotCredentials.accessKeyId;
+        }
         if (this._iotEndpoint === CN_NORTHWEST_IOT_ENDPOINT) {
             return AWS_ACCESS_KEY_CN_NORTHWEST;
         }
@@ -518,6 +647,9 @@ class AnthbotShadowApiClient {
     }
 
     _secretAccessKey() {
+        if (this._iotCredentials?.secretAccessKey) {
+            return this._iotCredentials.secretAccessKey;
+        }
         if (this._iotEndpoint === CN_NORTHWEST_IOT_ENDPOINT) {
             return AWS_SECRET_KEY_CN_NORTHWEST;
         }
@@ -527,6 +659,10 @@ class AnthbotShadowApiClient {
         return AWS_SECRET_KEY_DEFAULT;
     }
 
+    _sessionToken() {
+        return this._iotCredentials?.sessionToken;
+    }
+
     static _sign(key, msg) {
         if (typeof key === 'string') {
             key = Buffer.from(key, 'utf-8');
@@ -546,18 +682,11 @@ class AnthbotShadowApiClient {
         const algorithm = 'AWS4-HMAC-SHA256';
         const signedHeaders = AnthbotShadowApiClient._signedHeadersFromRequest(canonicalRequest);
         const credentialScope = `${dateStamp}/${this.signingRegion}/iotdata/aws4_request`;
-        const stringToSign =
-            `${algorithm}\n` +
-            `${amzDate}\n` +
-            `${credentialScope}\n` +
-            crypto.createHash('sha256').update(canonicalRequest).digest('hex');
+        const stringToSign = `${algorithm}\n${amzDate}\n${credentialScope}\n${crypto.createHash('sha256').update(canonicalRequest).digest('hex')}`;
 
         const signature = crypto.createHmac('sha256', this._signingKey(dateStamp)).update(stringToSign).digest('hex');
 
-        return (
-            `${algorithm} Credential=${this._accessKeyId()}/${credentialScope}, ` +
-            `SignedHeaders=${signedHeaders}, Signature=${signature}`
-        );
+        return `${algorithm} Credential=${this._accessKeyId()}/${credentialScope}, SignedHeaders=${signedHeaders}, Signature=${signature}`;
     }
 
     static _normalizeHeaderValue(value) {
@@ -632,17 +761,12 @@ class AnthbotShadowApiClient {
             host: this._iotEndpoint,
             'x-amz-content-sha256': payloadHash,
             'x-amz-date': amzDate,
+            'x-amz-security-token': this._sessionToken(),
         };
 
         const [canonicalHeaders, signedHeaders] = AnthbotShadowApiClient._canonicalHeaders(signedHeaderValues);
 
-        const canonicalRequest =
-            `GET\n` +
-            `${canonicalUri}\n` +
-            `${canonicalQuery}\n` +
-            `${canonicalHeaders}\n` +
-            `${signedHeaders}\n` +
-            `${payloadHash}`;
+        const canonicalRequest = `GET\n${canonicalUri}\n${canonicalQuery}\n${canonicalHeaders}\n${signedHeaders}\n${payloadHash}`;
 
         const authorization = this._buildAuthorization(amzDate, dateStamp, canonicalRequest);
 
@@ -652,6 +776,7 @@ class AnthbotShadowApiClient {
             Host: this._iotEndpoint,
             'x-amz-date': amzDate,
             'x-amz-content-sha256': payloadHash,
+            'x-amz-security-token': this._sessionToken(),
             Authorization: authorization,
             'User-Agent': CLIENT_USER_AGENT,
         };
@@ -668,7 +793,7 @@ class AnthbotShadowApiClient {
 
         let payload;
         try {
-            payload = /** @type {{ state: { reported: unknown } }} */ (await response.json());
+            payload = /** @type {{state?: any}} */ (await response.json());
         } catch {
             throw new Error('Invalid JSON response from shadow request');
         }
@@ -688,6 +813,9 @@ class AnthbotShadowApiClient {
 
     /**
      * Encode path component for AWS SigV4
+     *
+     * @param {string} component - Component to encode
+     * @returns {string} - Encoded component
      */
     _encodePathComponent(component) {
         return encodeURIComponent(component).replace(/[!'()*]/g, ch => {
@@ -705,7 +833,6 @@ class AnthbotShadowApiClient {
 
         // Different AWS clients canonicalize the URI slightly differently.
         // Try the app-observed mode first, then fall back to alternatives.
-        /** @type {[string, boolean, string | null, boolean][]} */
         const attempts = [
             // 1) SDK headers + encoded URI + app-style canonical URI (trace match)
             [requestUriEncoded, true, null, true],
@@ -763,7 +890,7 @@ class AnthbotShadowApiClient {
             }
 
             if (this.verboseLogger) {
-                this.verboseLogger(`Anthbot command publish attempt failed (${status}`);
+                this.verboseLogger(`Anthbot command publish attempt failed (${status})`);
             }
         }
 
@@ -776,7 +903,7 @@ class AnthbotShadowApiClient {
     }
 
     /**
-     * @param {{requestUri: string, canonicalQuery: string, payloadBytes: Buffer, includeSdkHeaders: boolean, canonicalUriOverride?: string | null, signContentLength?: boolean}} options
+     * @param {{requestUri: string | boolean | null, canonicalQuery: string, payloadBytes: Buffer, includeSdkHeaders: string | boolean | null, canonicalUriOverride?: string | boolean | null, signContentLength?: string | boolean | null}} options - Request options
      */
     async _asyncSignedPost({
         requestUri,
@@ -800,6 +927,7 @@ class AnthbotShadowApiClient {
             'content-type': 'application/octet-stream',
             'x-amz-content-sha256': payloadHash,
             'x-amz-date': amzDate,
+            'x-amz-security-token': this._sessionToken(),
         };
 
         const headers = {
@@ -808,6 +936,7 @@ class AnthbotShadowApiClient {
             'Content-Type': 'application/octet-stream',
             'x-amz-content-sha256': payloadHash,
             'x-amz-date': amzDate,
+            'x-amz-security-token': this._sessionToken(),
         };
 
         if (signContentLength) {
@@ -836,13 +965,7 @@ class AnthbotShadowApiClient {
                 ? canonicalUriOverride
                 : AnthbotShadowApiClient._canonicalUriForSigv4(requestUri);
 
-        const canonicalRequest =
-            `POST\n` +
-            `${canonicalUri}\n` +
-            `${canonicalQuery}\n` +
-            `${canonicalHeaders}\n` +
-            `${signedHeaders}\n` +
-            `${payloadHash}`;
+        const canonicalRequest = `POST\n${canonicalUri}\n${canonicalQuery}\n${canonicalHeaders}\n${signedHeaders}\n${payloadHash}`;
 
         headers['Authorization'] = this._buildAuthorization(amzDate, dateStamp, canonicalRequest);
 

package/main.js

@@ -50,7 +50,7 @@ class Anthbot extends utils.Adapter {
         // Verify we have credentials
         if (this.config.username == '' || this.config.password == '' || !this.config.regionCode) {
             this.log.error('Incomplete adapter configuration! Please check settings.');
-            this.terminate();
+            // Don't actually terminate - when the adapter config is updated that will trigger a restart
         } else {
             this.loginAndStart();
         }
@@ -82,143 +82,153 @@ class Anthbot extends utils.Adapter {
                 idParts.pop();
 
                 const serialNumber = idParts.pop();
-                const device = this.devices.find(checkDevice => checkDevice.sn === serialNumber);
-
-                if (!device) {
-                    this.log.error(`Could not find device for command with serial number: ${serialNumber}`);
+                if (!serialNumber) {
+                    this.log.error(`No serial number found in command ${id}`);
                 } else {
-                    switch (command) {
-                        case 'area_set': {
-                            let customAreas;
-                            if (typeof state?.val !== 'string') {
-                                this.log.error('Command custom_areas for ${serialNumber} is not a string');
-                            } else {
-                                try {
-                                    customAreas = JSON.parse(state.val);
-                                } catch (error) {
-                                    this.log.error(`Failed to parse for ${id}: ${error.message}`);
+                    const device = this.devices.find(checkDevice => checkDevice.sn === serialNumber);
+
+                    if (!serialNumber || !device) {
+                        this.log.error(`Could not find device for command with serial number: ${serialNumber}`);
+                    } else {
+                        switch (command) {
+                            case 'area_set': {
+                                let customAreas;
+                                if (typeof state?.val !== 'string') {
+                                    this.log.error('Command custom_areas for ${serialNumber} is not a string');
+                                } else {
+                                    try {
+                                        customAreas = JSON.parse(state.val);
+                                    } catch (error) {
+                                        this.log.error(`Failed to parse for ${id}: ${error.message}`);
+                                    }
                                 }
-                            }
 
-                            // Overlay elements from the state onto existing zones so user only has to set
-                            // the items they are changing and rest will be preserved.
+                                // Overlay elements from the state onto existing zones so user only has to set
+                                // the items they are changing and rest will be preserved.
 
-                            // Variable named to match asyncSendServiceCommand data
-                            const custom_areas = this.validateCustomAreas(device, customAreas);
+                                // Variable named to match asyncSendServiceCommand data
+                                const custom_areas = this.validateCustomAreas(device, customAreas);
+
+                                if (!custom_areas) {
+                                    this.log.error(`Bad area data in ${id}`);
+                                } else {
+                                    // Write the given area (zone) data
+                                    this.log.info(`${device.alias}: area_set ${JSON.stringify(customAreas)}`);
+                                    await this.client.asyncSendServiceCommand(serialNumber, 'area_set', {
+                                        custom_areas,
+                                    });
 
-                            if (!custom_areas) {
-                                this.log.error(`Bad area data in ${id}`);
-                            } else {
-                                // Write the given area (zone) data
-                                this.log.info(`${device.alias}: area_set ${JSON.stringify(customAreas)}`);
-                                await this.client.asyncSendServiceCommand(serialNumber, 'area_set', {
-                                    custom_areas,
-                                });
+                                    ackState = JSON.stringify(customAreas);
+                                }
 
-                                ackState = JSON.stringify(customAreas);
+                                break;
                             }
 
-                            break;
-                        }
+                            case 'custom_area_mow_start': {
+                                // Get/check command zone_list
+                                // This could be done in one shot, but get the state first for debug logging
+                                const command_zone_list_state = await this.getStateAsync(
+                                    `${device.sn}.command.zone_list`,
+                                );
+                                this.log.debug(
+                                    `Current command.zone_list state: ${JSON.stringify(command_zone_list_state)}`,
+                                );
+
+                                let command_zone_list;
+                                if (typeof command_zone_list_state?.val !== 'string') {
+                                    this.log.error('Command zone list for ${serialNumber} is not a string');
+                                } else {
+                                    try {
+                                        command_zone_list = JSON.parse(command_zone_list_state.val);
+                                    } catch (error) {
+                                        this.log.error(
+                                            `Failed to parse command zone list for ${serialNumber}: ${error.message}`,
+                                        );
+                                    }
+                                }
 
-                        case 'custom_area_mow_start': {
-                            // Get/check command zone_list
-                            // This could be done in one shot, but get the state first for debug logging
-                            const command_zone_list_state = await this.getStateAsync(`${device.sn}.command.zone_list`);
-                            this.log.debug(
-                                `Current command.zone_list state: ${JSON.stringify(command_zone_list_state)}`,
-                            );
-
-                            let command_zone_list;
-                            if (typeof command_zone_list_state?.val !== 'string') {
-                                this.log.error('Command zone list for ${serialNumber} is not a string');
-                            } else {
-                                try {
-                                    command_zone_list = JSON.parse(command_zone_list_state.val);
-                                } catch (error) {
-                                    this.log.error(
-                                        `Failed to parse command zone list for ${serialNumber}: ${error.message}`,
-                                    );
+                                if (Array.isArray(command_zone_list) && command_zone_list.length > 0) {
+                                    if (!this.isGoodZoneList(device, command_zone_list)) {
+                                        this.log.error(
+                                            'Cannot start custom_area_mow_start due to invalid command.zone_list',
+                                        );
+                                    } else {
+                                        this.log.info(
+                                            `${device.alias}: custom_area_mow_start ${JSON.stringify(command_zone_list)}`,
+                                        );
+                                        await this.client.asyncSendServiceCommand(
+                                            serialNumber,
+                                            'custom_area_mow_start',
+                                            {
+                                                id: command_zone_list,
+                                            },
+                                        );
+                                        ackState = true;
+                                    }
                                 }
+                                break;
                             }
 
-                            if (Array.isArray(command_zone_list) && command_zone_list.length > 0) {
-                                if (!this.isGoodZoneList(device, command_zone_list)) {
-                                    this.log.error(
-                                        'Cannot start custom_area_mow_start due to invalid command.zone_list',
-                                    );
+                            case 'zone_list': {
+                                let zoneList;
+                                // This will affect the next start command only.
+                                if (typeof state?.val === 'string' && state.val !== '') {
+                                    // Some kind of non-blank value given
+                                    try {
+                                        zoneList = JSON.parse(state.val);
+                                    } catch (error) {
+                                        this.log.error(`Failed to parse zone list for ${id}: ${error.message}`);
+                                    }
+
+                                    // Make sure all IDs in list are valid
+                                    if (!this.isGoodZoneList(device, zoneList)) {
+                                        // Set to null so we don't ack it
+                                        zoneList = null;
+                                    }
                                 } else {
-                                    this.log.info(
-                                        `${device.alias}: custom_area_mow_start ${JSON.stringify(command_zone_list)}`,
-                                    );
-                                    await this.client.asyncSendServiceCommand(serialNumber, 'custom_area_mow_start', {
-                                        id: command_zone_list,
-                                    });
-                                    ackState = true;
+                                    // No value given, so ack an empty list
+                                    zoneList = [];
                                 }
-                            }
-                            break;
-                        }
 
-                        case 'zone_list': {
-                            let zoneList;
-                            // This will affect the next start command only.
-                            if (typeof state?.val === 'string' && state.val !== '') {
-                                // Some kind of non-blank value given
-                                try {
-                                    zoneList = JSON.parse(state.val);
-                                } catch (error) {
-                                    this.log.error(`Failed to parse zone list for ${id}: ${error.message}`);
+                                // Ack only if we now have a list
+                                if (Array.isArray(zoneList)) {
+                                    ackState = JSON.stringify(zoneList);
+                                    // We don't need to sync after this as no command was actually sent yet
+                                    doSync = false;
                                 }
 
-                                // Make sure all IDs in list are valid
-                                if (!this.isGoodZoneList(device, zoneList)) {
-                                    // Set to null so we don't ack it
-                                    zoneList = null;
-                                }
-                            } else {
-                                // No value given, so ack an empty list
-                                zoneList = [];
+                                break;
                             }
 
-                            // Ack only if we now have a list
-                            if (Array.isArray(zoneList)) {
-                                ackState = JSON.stringify(zoneList);
-                                // We don't need to sync after this as no command was actually sent yet
-                                doSync = false;
+                            case 'mow_start':
+                                // To start mowing have to put app_state first.
+                                await this.client.asyncSendServiceCommand(serialNumber, 'app_state', 1);
+                            // Purposfully fall through to send the actual command!
+
+                            // Generic one-shot commands
+                            /* falls through */
+                            case 'charge_start':
+                            case 'mow_pause':
+                            case 'stop_all_tasks': {
+                                this.log.info(`${device.alias}: ${command}`);
+                                await this.client.asyncSendServiceCommand(serialNumber, command, 1);
+                                ackState = true;
+                                break;
                             }
 
-                            break;
-                        }
-
-                        case 'mow_start':
-                            // To start mowing have to put app_state first.
-                            await this.client.asyncSendServiceCommand(serialNumber, 'app_state', 1);
-                        // Purposfully fall through to send the actual command!
-
-                        // Generic one-shot commands
-                        /* falls through */
-                        case 'charge_start':
-                        case 'mow_pause':
-                        case 'stop_all_tasks': {
-                            this.log.info(`${device.alias}: ${command}`);
-                            await this.client.asyncSendServiceCommand(serialNumber, command, 1);
-                            ackState = true;
-                            break;
+                            default:
+                                this.log.warn(`Unknown command: ${command}`);
                         }
-
-                        default:
-                            this.log.warn(`Unknown command: ${command}`);
                     }
-                }
 
-                // Ack command if verified valid above
-                if (ackState) {
-                    await this.setState(id, ackState, true);
+                    // Ack command if verified valid above
+                    if (ackState) {
+                        await this.setState(id, ackState, true);
 
-                    // Sync device if no explicitally set not to
-                    if (doSync) {
-                        this.syncDevice(device);
+                        // Sync device if no explicitally set not to
+                        if (doSync) {
+                            this.syncDevice(device);
+                        }
                     }
                 }
             }
@@ -261,11 +271,7 @@ class Anthbot extends utils.Adapter {
 
         this.log.info('Connecting to Anthbot cloud...');
         try {
-            await this.client.asyncLogin({
-                username: this.config.username,
-                password: this.config.password,
-                areaCode: this.config.regionCode,
-            });
+            await this.client.asyncLogin(this.config.username, this.config.password, this.config.regionCode);
         } catch (error) {
             this.log.error(`Failed to login to Anthbot cloud: ${error.message}`);
             await this.retryConnection();

package/package.json

@@ -1,27 +1,27 @@
 {
   "name": "iobroker.anthbot",
-  "version": "0.0.2",
+  "version": "0.0.4",
   "description": "Connect with Anthbot devices such as their robot mowers",
-  "author": {
-    "name": "Robin Rainton",
-    "email": "robin@rainton.com"
-  },
-  "contributors": [],
-  "homepage": "https://github.com/raintonr/ioBroker.anthbot",
+  "author": "Robin Rainton <robin@rainton.com>",
+  "contributors": [
+    "iobroker-community-adapters <iobroker-community-adapters@gmx.de>"
+  ],
+  "homepage": "https://github.com/iobroker-community-adapters/ioBroker.anthbot",
   "license": "MIT",
   "keywords": [
     "robot",
     "mower",
     "IoT",
     "Anthbot",
-    "lawn"
+    "lawn",
+    "ioBroker"
   ],
   "repository": {
     "type": "git",
-    "url": "https://github.com/raintonr/ioBroker.anthbot.git"
+    "url": "https://github.com/iobroker-community-adapters/ioBroker.anthbot.git"
   },
   "engines": {
-    "node": ">= 20"
+    "node": ">= 22"
   },
   "dependencies": {
     "@iobroker/adapter-core": "^3.3.2",
@@ -64,7 +64,7 @@
     "dev-server": "dev-server"
   },
   "bugs": {
-    "url": "https://github.com/raintonr/ioBroker.anthbot/issues"
+    "url": "https://github.com/iobroker-community-adapters/ioBroker.anthbot/issues"
   },
   "readmeFilename": "README.md"
 }