iobroker.acinfinity 0.7.1 → 0.7.3

package/admin/jsonConfig.json

@@ -2,76 +2,38 @@
     "i18n": true,
     "type": "panel",
     "items": {
-        "warning": {
-            "type": "panel",
-            "items": {
-                "warningTitle": {
-                    "type": "staticText",
-                    "text": "WARNING / WARNUNG",
-                    "style": {
-                        "color": "red",
-                        "fontSize": "18px",
-                        "fontWeight": "bold",
-                        "textAlign": "center"
-                    },
-                    "sm": 12,
-                    "md": 12,
-                    "lg": 12,
-                    "xl": 12,
-                    "xs": 12
-                },
-                "warningText": {
-                    "type": "staticText",
-                    "text": "This adapter is in an early development stage. You use this adapter at your own risk. The author assumes no liability for any damage.<br><br>Dieser Adapter befindet sich in einem frühen Entwicklungsstadium. Sie verwenden diesen Adapter auf eigene Gefahr. Der Autor übernimmt keine Haftung für eventuelle Schäden.",
-                    "style": {
-                        "color": "red",
-                        "fontWeight": "bold",
-                        "textAlign": "center",
-                        "marginBottom": "20px"
-                    },
-                    "sm": 12,
-                    "md": 12,
-                    "lg": 12,
-                    "xl": 12,
-                    "xs": 12
-                }
-            }
+        "email": {
+            "type": "text",
+            "label": "AC Infinity Email",
+            "sm": 12,
+            "md": 8,
+            "lg": 6,
+            "xl": 6,
+            "xs": 12
         },
-        "settings": {
-            "type": "panel",
-            "items": {
-                "email": {
-                    "type": "text",
-                    "label": "AC Infinity E-Mail",
-                    "newLine": true,
-                    "sm": 12,
-                    "md": 12,
-                    "lg": 12,
-                    "xl": 12,
-                    "xs": 12
-                },
-                "password": {
-                    "type": "password",
-                    "label": "AC Infinity Password / Passwort",
-                    "newLine": true,
-                    "sm": 12,
-                    "md": 12,
-                    "lg": 12,
-                    "xl": 12,
-                    "xs": 12
-                },
-                "pollingInterval": {
-                    "type": "number",
-                    "label": "Polling Interval / Abfrageintervall (seconds)",
-                    "min": 5,
-                    "default": 30,
-                    "sm": 12,
-                    "md": 6,
-                    "lg": 4,
-                    "xl": 3,
-                    "xs": 12
-                }
-            }
+        "password": {
+            "type": "password",
+            "label": "AC Infinity Password",
+            "help": "Note: AC Infinity truncates passwords to 25 characters.",
+            "newLine": true,
+            "sm": 12,
+            "md": 8,
+            "lg": 6,
+            "xl": 6,
+            "xs": 12
+        },
+        "pollingInterval": {
+            "type": "number",
+            "label": "Polling Interval (seconds)",
+            "help": "Minimum polling interval is 5 seconds.",
+            "newLine": true,
+            "min": 5,
+            "default": 30,
+            "sm": 6,
+            "md": 4,
+            "lg": 3,
+            "xl": 2,
+            "xs": 6
         }
     }
-}
+}

package/io-package.json

@@ -1,8 +1,34 @@
 {
   "common": {
     "name": "acinfinity",
-    "version": "0.7.1",
+    "version": "0.7.3",
     "news": {
+      "0.7.3": {
+        "en": "Admin UI: remove warning box, clean up settings layout, fix help link",
+        "de": "Admin-UI: Warnhinweis entfernt, Einstellungslayout bereinigt, Hilfe-Link korrigiert",
+        "ru": "Admin UI: убран блок предупреждения, улучшен макет настроек, исправлена ссылка на справку",
+        "pt": "Admin UI: caixa de aviso removida, layout de configurações limpo, link de ajuda corrigido",
+        "nl": "Admin UI: waarschuwingsvak verwijderd, instellingen layout verbeterd, helplink gecorrigeerd",
+        "fr": "Admin UI: bloc d'avertissement supprimé, mise en page des paramètres améliorée, lien d'aide corrigé",
+        "it": "Admin UI: riquadro di avviso rimosso, layout impostazioni migliorato, link guida corretto",
+        "es": "Admin UI: cuadro de advertencia eliminado, diseño de configuración mejorado, enlace de ayuda corregido",
+        "pl": "Admin UI: usunięto pole ostrzeżenia, poprawiono układ ustawień, naprawiono link pomocy",
+        "uk": "Admin UI: видалено блок попередження, покращено макет налаштувань, виправлено посилання на довідку",
+        "zh-cn": "管理界面：移除警告框，优化设置布局，修复帮助链接"
+      },
+      "0.7.2": {
+        "en": "Code quality: migrate to ESLint 9 with @iobroker/eslint-config",
+        "de": "Codequalität: Migration auf ESLint 9 mit @iobroker/eslint-config",
+        "ru": "Качество кода: миграция на ESLint 9 с @iobroker/eslint-config",
+        "pt": "Qualidade do código: migração para ESLint 9 com @iobroker/eslint-config",
+        "nl": "Codekwaliteit: migratie naar ESLint 9 met @iobroker/eslint-config",
+        "fr": "Qualité du code: migration vers ESLint 9 avec @iobroker/eslint-config",
+        "it": "Qualità del codice: migrazione a ESLint 9 con @iobroker/eslint-config",
+        "es": "Calidad del código: migración a ESLint 9 con @iobroker/eslint-config",
+        "pl": "Jakość kodu: migracja do ESLint 9 z @iobroker/eslint-config",
+        "uk": "Якість коду: міграція на ESLint 9 з @iobroker/eslint-config",
+        "zh-cn": "代码质量：迁移到 ESLint 9 并使用 @iobroker/eslint-config"
+      },
       "0.7.1": {
         "en": "Add value ranges to state names for better readability",
         "de": "Wertebereiche zu Datenpunkt-Namen hinzugefügt für bessere Lesbarkeit",
@@ -137,7 +163,7 @@
     "icon": "acinfinity.png",
     "enabled": true,
     "extIcon": "https://raw.githubusercontent.com/raspilaurent/ioBroker.acinfinity/master/admin/acinfinity.png",
-    "readme": "https://github.com/raspilaurent/ioBroker.acinfinity/blob/master/README.md",
+    "readme": "https://github.com/raspilaurent/ioBroker.acinfinity/blob/main/README.md",
     "loglevel": "info",
     "mode": "daemon",
     "type": "climate-control",

package/lib/client.js

@@ -3,14 +3,15 @@
  * Handles all API communication with AC Infinity servers
  */
 
-"use strict";
+'use strict';
 
-const axios = require("axios");
-const { API_BASE_URL, API_ENDPOINTS } = require("./constants");
+const axios = require('axios');
+const { API_BASE_URL, API_ENDPOINTS } = require('./constants');
 
 class ACInfinityClient {
     /**
      * Creates a new AC Infinity API client
+     *
      * @param {string} email - AC Infinity account email
      * @param {string} password - AC Infinity account password
      * @param {object} log - Logger object
@@ -22,19 +23,20 @@ class ACInfinityClient {
         this.token = null;
         this.axiosInstance = axios.create({
             timeout: 30000,
-            validateStatus: status => status >= 200 && status < 300
+            validateStatus: status => status >= 200 && status < 300,
         });
     }
 
     /**
      * Creates headers for API requests
+     *
      * @param {boolean} useAuthToken - Whether to include authentication token
      * @returns {object}
      */
     createHeaders(useAuthToken = false) {
         const headers = {
-            "User-Agent": "ACController/1.8.5 (com.acinfinity.humiture; build:500; iOS 17.0.1) Alamofire/5.7.1",
-            "Content-Type": "application/x-www-form-urlencoded; charset=utf-8"
+            'User-Agent': 'ACController/1.8.5 (com.acinfinity.humiture; build:500; iOS 17.0.1) Alamofire/5.7.1',
+            'Content-Type': 'application/x-www-form-urlencoded; charset=utf-8',
         };
         if (useAuthToken && this.token) {
             headers.token = this.token;
@@ -44,6 +46,7 @@ class ACInfinityClient {
 
     /**
      * Performs API login and obtains authentication token
+     *
      * @returns {Promise<void>}
      */
     async login() {
@@ -52,21 +55,21 @@ class ACInfinityClient {
             const formData = `appEmail=${encodeURIComponent(this.email)}&appPasswordl=${encodeURIComponent(normalizedPassword)}`;
             this.log.debug(`Login attempt with: ${this.email}`);
 
-            const response = await this.axiosInstance.post(
-                `${API_BASE_URL}${API_ENDPOINTS.LOGIN}`,
-                formData,
-                { headers: this.createHeaders(false) }
-            );
+            const response = await this.axiosInstance.post(`${API_BASE_URL}${API_ENDPOINTS.LOGIN}`, formData, {
+                headers: this.createHeaders(false),
+            });
 
             if (response.data && response.data.code === 200) {
                 this.token = response.data.data.appId;
-                this.log.debug("Login successful");
+                this.log.debug('Login successful');
                 return;
             }
-            throw new Error(`Login failed: ${response.data ? response.data.msg : "Unknown error"}`);
+            throw new Error(`Login failed: ${response.data ? response.data.msg : 'Unknown error'}`);
         } catch (error) {
             if (error.response) {
-                throw new Error(`Login failed with status ${error.response.status}: ${error.response.data ? error.response.data.msg : "Unknown error"}`);
+                throw new Error(
+                    `Login failed with status ${error.response.status}: ${error.response.data ? error.response.data.msg : 'Unknown error'}`,
+                );
             }
             throw new Error(`Login failed: ${error.message}`);
         }
@@ -74,6 +77,7 @@ class ACInfinityClient {
 
     /**
      * Checks if client is logged in
+     *
      * @returns {boolean}
      */
     isLoggedIn() {
@@ -82,6 +86,7 @@ class ACInfinityClient {
 
     /**
      * General API call with automatic re-login on 401
+     *
      * @param {string} endpoint
      * @param {object} data
      * @param {boolean} needsAuth
@@ -95,21 +100,19 @@ class ACInfinityClient {
         try {
             const formData = Object.entries(data)
                 .map(([key, value]) => `${encodeURIComponent(key)}=${encodeURIComponent(value)}`)
-                .join("&");
+                .join('&');
 
-            const response = await this.axiosInstance.post(
-                `${API_BASE_URL}${endpoint}`,
-                formData,
-                { headers: this.createHeaders(needsAuth) }
-            );
+            const response = await this.axiosInstance.post(`${API_BASE_URL}${endpoint}`, formData, {
+                headers: this.createHeaders(needsAuth),
+            });
 
             if (response.data && response.data.code === 200) {
                 return response.data.data || {};
             }
-            throw new Error(`API call to ${endpoint} failed: ${response.data ? response.data.msg : "Unknown error"}`);
+            throw new Error(`API call to ${endpoint} failed: ${response.data ? response.data.msg : 'Unknown error'}`);
         } catch (error) {
             if (error.response && error.response.status === 401 && needsAuth) {
-                this.log.info("Token expired, attempting to re-login");
+                this.log.info('Token expired, attempting to re-login');
                 await this.login();
                 return this.apiCall(endpoint, data, needsAuth);
             }
@@ -122,6 +125,7 @@ class ACInfinityClient {
 
     /**
      * Gets list of all AC Infinity devices
+     *
      * @returns {Promise<Array>}
      */
     async getDevicesList() {
@@ -130,35 +134,46 @@ class ACInfinityClient {
 
     /**
      * Gets mode settings for a specific device port
+     *
      * @param {string|number} deviceId
      * @param {number} portId
      * @returns {Promise<object>}
      */
     async getDeviceModeSettings(deviceId, portId) {
         this.log.debug(`Getting mode settings for deviceId=${deviceId}, portId=${portId}`);
-        return this.apiCall(API_ENDPOINTS.DEVICE_MODE_SETTINGS, {
-            devId: deviceId,
-            port: portId
-        }, true);
+        return this.apiCall(
+            API_ENDPOINTS.DEVICE_MODE_SETTINGS,
+            {
+                devId: deviceId,
+                port: portId,
+            },
+            true,
+        );
     }
 
     /**
      * Gets advanced settings for a device or port
+     *
      * @param {string|number} deviceId
      * @param {number} portId - 0 for controller-level settings
      * @returns {Promise<object>}
      */
     async getDeviceSettings(deviceId, portId) {
         this.log.debug(`Getting device settings for deviceId=${deviceId}, portId=${portId}`);
-        return this.apiCall(API_ENDPOINTS.DEVICE_SETTINGS, {
-            devId: deviceId,
-            port: portId
-        }, true);
+        return this.apiCall(
+            API_ENDPOINTS.DEVICE_SETTINGS,
+            {
+                devId: deviceId,
+                port: portId,
+            },
+            true,
+        );
     }
 
     /**
      * Sends a raw URL-encoded form payload to the addDevMode endpoint.
      * This is the single write path for all mode and speed changes.
+     *
      * @param {string} formData - URL-encoded form data string
      * @returns {Promise<boolean>}
      */
@@ -173,17 +188,17 @@ class ACInfinityClient {
             const response = await this.axiosInstance.post(
                 `${API_BASE_URL}${API_ENDPOINTS.UPDATE_DEVICE_MODE}`,
                 formData,
-                { headers: this.createHeaders(true) }
+                { headers: this.createHeaders(true) },
             );
 
             if (response.data && response.data.code === 200) {
-                this.log.debug("Mode update successful");
+                this.log.debug('Mode update successful');
                 return true;
             }
-            throw new Error(`Mode update failed: ${response.data ? response.data.msg : "Unknown error"}`);
+            throw new Error(`Mode update failed: ${response.data ? response.data.msg : 'Unknown error'}`);
         } catch (error) {
             if (error.response && error.response.status === 401) {
-                this.log.info("Token expired, re-logging in");
+                this.log.info('Token expired, re-logging in');
                 await this.login();
                 return this.sendRawModeUpdate(formData);
             }
@@ -213,10 +228,10 @@ class ACInfinityClient {
 
         const settings = await this.getDeviceModeSettings(deviceId, portId);
         const modeSetid = settings.modeSetid;
-        const vpdnums = (settings.vpdnums !== undefined && settings.vpdnums !== null) ? settings.vpdnums : 0;
+        const vpdnums = settings.vpdnums !== undefined && settings.vpdnums !== null ? settings.vpdnums : 0;
 
         // speak = active speed; 0 when mode is Off (atType=1)
-        const speak = (atType === 2) ? onSpeed : 0;
+        const speak = atType === 2 ? onSpeed : 0;
 
         const formData = [
             `modeSetid=${encodeURIComponent(modeSetid)}`,
@@ -228,16 +243,19 @@ class ACInfinityClient {
             `speak=${encodeURIComponent(speak)}`,
             `curMode=${encodeURIComponent(atType)}`,
             `vpdstatus=0`,
-            `vpdnums=${encodeURIComponent(vpdnums)}`
-        ].join("&");
+            `vpdnums=${encodeURIComponent(vpdnums)}`,
+        ].join('&');
 
-        this.log.info(`setDeviceMode: deviceId=${deviceId}, portId=${portId}, atType=${atType}, onSpeed=${onSpeed}, offSpeed=${offSpeed}`);
+        this.log.info(
+            `setDeviceMode: deviceId=${deviceId}, portId=${portId}, atType=${atType}, onSpeed=${onSpeed}, offSpeed=${offSpeed}`,
+        );
         return this.sendRawModeUpdate(formData);
     }
 
     /**
      * Updates specific mode settings parameters (timer/cycle/auto/vpd/schedule values).
      * Fetches current settings, applies overrides, and sends the full payload.
+     *
      * @param {string|number} deviceId
      * @param {number} portId
      * @param {Array<Array<string|number>>} keyValues - Array of [key, value] pairs to override
@@ -255,23 +273,27 @@ class ACInfinityClient {
         this.log.debug(`Current mode settings fetched for update`);
 
         // Remove fields that the API rejects in write calls
-        const fieldsToRemove = ["devMacAddr", "ipcSetting", "devSetting"];
+        const fieldsToRemove = ['devMacAddr', 'ipcSetting', 'devSetting'];
         for (const field of fieldsToRemove) {
             delete settings[field];
         }
 
         // Ensure required fields exist
-        if (!("vpdstatus" in settings)) settings.vpdstatus = 0;
-        if (!("vpdnums" in settings)) settings.vpdnums = 0;
+        if (!('vpdstatus' in settings)) {
+            settings.vpdstatus = 0;
+        }
+        if (!('vpdnums' in settings)) {
+            settings.vpdnums = 0;
+        }
 
         settings.devId = parseInt(deviceIdStr);
-        if ("modeSetid" in settings) {
+        if ('modeSetid' in settings) {
             settings.modeSetid = String(settings.modeSetid);
         }
 
         // Apply the requested overrides
         for (const [key, value] of keyValues) {
-            settings[key] = (typeof value === "number") ? value : parseInt(String(value));
+            settings[key] = typeof value === 'number' ? value : parseInt(String(value));
         }
 
         // Replace any remaining null/undefined with 0
@@ -283,13 +305,14 @@ class ACInfinityClient {
 
         const formData = Object.entries(settings)
             .map(([key, value]) => `${encodeURIComponent(key)}=${encodeURIComponent(value)}`)
-            .join("&");
+            .join('&');
 
         return this.sendRawModeUpdate(formData);
     }
 
     /**
      * Updates advanced (device/port-level) settings
+     *
      * @param {string|number} deviceId
      * @param {number} portId - 0 for controller-level settings
      * @param {string} deviceName - Device name (prevents API from resetting it to "None")
@@ -309,22 +332,29 @@ class ACInfinityClient {
         settings.devName = deviceName;
 
         const fieldsToRemove = [
-            "setId", "devMacAddr", "portResistance", "devTimeZone",
-            "sensorSetting", "sensorTransBuff", "subDeviceVersion",
-            "secFucReportTime", "updateAllPort", "calibrationTime"
+            'setId',
+            'devMacAddr',
+            'portResistance',
+            'devTimeZone',
+            'sensorSetting',
+            'sensorTransBuff',
+            'subDeviceVersion',
+            'secFucReportTime',
+            'updateAllPort',
+            'calibrationTime',
         ];
         for (const field of fieldsToRemove) {
             delete settings[field];
         }
 
-        const stringFields = ["sensorTransBuffStr", "sensorSettingStr", "portParamData", "paramSensors"];
+        const stringFields = ['sensorTransBuffStr', 'sensorSettingStr', 'portParamData', 'paramSensors'];
         for (const field of stringFields) {
             if (!(field in settings) || settings[field] === null) {
-                settings[field] = "";
+                settings[field] = '';
             }
         }
 
-        const defaultFields = ["sensorOneType", "isShare", "targetVpdSwitch", "sensorTwoType", "zoneSensorType"];
+        const defaultFields = ['sensorOneType', 'isShare', 'targetVpdSwitch', 'sensorTwoType', 'zoneSensorType'];
         for (const field of defaultFields) {
             if (!(field in settings)) {
                 settings[field] = 0;
@@ -345,12 +375,12 @@ class ACInfinityClient {
 
         const formData = Object.entries(settings)
             .map(([key, value]) => `${encodeURIComponent(key)}=${encodeURIComponent(value)}`)
-            .join("&");
+            .join('&');
 
         const response = await this.axiosInstance.post(
             `${API_BASE_URL}${API_ENDPOINTS.UPDATE_ADVANCED_SETTINGS}`,
             formData,
-            { headers: this.createHeaders(true) }
+            { headers: this.createHeaders(true) },
         );
 
         if (response.data && response.data.code === 200) {
@@ -358,7 +388,7 @@ class ACInfinityClient {
             return;
         }
 
-        throw new Error(`Failed to update advanced settings: ${response.data ? response.data.msg : "Unknown error"}`);
+        throw new Error(`Failed to update advanced settings: ${response.data ? response.data.msg : 'Unknown error'}`);
     }
 }