intentdna 1.7.4 → 1.8.0

package/dist/templates/flutter-rewrite-fix-review-loop.dna.yaml

@@ -0,0 +1,260 @@
+# flutter-rewrite-fix-review-loop: diagnosis-backed fix, review, and verification loop
+# Source: extracted from Flutter rewrite dogfood fix workflow
+# Purpose: reuse the inner implementation/review/verify loop without adopting the full rewrite asset
+
+version: "0.1.0"
+id: template_flutter_rewrite_fix_review_loop
+name: Flutter Rewrite Fix Review Loop
+purpose: Run the smallest approved Flutter rewrite fix with independent review, fresh verification, and durable progress evidence.
+maturity: reviewed
+fit:
+  - Rewrite slices with an approved diagnosis and review verdict.
+  - Behavior-preserving fixes that need independent review before completion or rollout.
+not_for:
+  - Starting implementation without approved diagnosis.
+  - Broad refactors, opportunistic improvements, or self-approved fixes.
+inputs:
+  - approved diagnosis artifact
+  - diagnosis review verdict
+  - v1 behavior reference
+  - focused verification command
+outputs:
+  - scoped fix diff summary
+  - independent fix review verdict
+  - verification and progress evidence
+lineage:
+  source: Flutter rewrite dogfood fix-review-verify loop
+  reference: /Users/samuel/lawark/lwk_flutter_v2-rewrite/.dna/fix-progress
+type: project
+namespace: frfrl
+
+cascade:
+  inherits: ["species:default"]
+  priority: 100
+
+variables:
+  diagnosis_path:
+    description: "Approved diagnosis artifact path"
+    default: ".dna/specs/diagnosis-$ARGUMENTS.md"
+  diagnosis_review_path:
+    description: "Diagnosis review verdict path"
+    default: ".dna/specs/diagnosis-$ARGUMENTS.review.json"
+  progress_path:
+    description: "Module progress JSON path"
+    default: ".dna/fix-progress/$ARGUMENTS.json"
+  behavior_docs:
+    description: "Behavior evidence directory"
+    default: "docs/behavior"
+
+evidence:
+  - label: Flutter rewrite fix-loop progress
+    kind: reference
+    path: /Users/samuel/lawark/lwk_flutter_v2-rewrite/.dna/fix-progress
+    description: Module-level progress JSON and test logs showing the diagnosis-backed fix/review/verify loop.
+  - label: Flutter rewrite diagnosis specs
+    kind: reference
+    path: /Users/samuel/lawark/lwk_flutter_v2-rewrite/.dna/specs
+    description: Approved diagnosis and review artifacts consumed before implementation starts.
+
+genes:
+  approved_diagnosis_required:
+    description: Implementation can start only from an approved diagnosis and review verdict
+    codons:
+      - type: attract
+        target: reviewed_diagnosis
+      - type: repel
+        target: edit_without_diagnosis
+      - type: threshold
+        condition: "diagnosis_review_verdict == APPROVE"
+        action: block
+
+  behavior_equivalence:
+    description: Fixes preserve v1 behavior and prove equivalence with fresh evidence
+    codons:
+      - type: attract
+        target: v1_behavior_reference
+      - type: attract
+        target: logic_equivalence_check
+      - type: repel
+        target: opportunistic_improvement
+      - type: threshold
+        condition: "fresh_verification_evidence == true"
+        action: block
+
+  small_reversible_rounds:
+    description: Each fix round stays small, reviewable, and reversible
+    codons:
+      - type: attract
+        target: minimal_diff
+      - type: attract
+        target: after_change_verification
+      - type: repel
+        target: broad_refactor_batch
+      - type: threshold
+        condition: "files_changed_per_round <= 5"
+        action: escalate
+
+contexts: {}
+
+roles:
+  fixer:
+    description: Implements the smallest diagnosis-approved fix while preserving v1 behavior.
+    tool_permissions:
+      allow: [Read, Edit, Write, Grep, Glob, Bash]
+      deny: [NotebookEdit]
+    scope:
+      read: ["**/*", ".dna/**", "docs/**"]
+      write: ["lib/**", "v2/**", "test/**", ".dna/fix-progress/**"]
+    instructions:
+      - Read {{diagnosis_path}} and {{diagnosis_review_path}} before any Edit.
+      - Confirm the diagnosis review verdict is APPROVE before changing code.
+      - Read the relevant v1 source and behavior evidence before implementing.
+      - Fix only the approved breakpoint or missing implementation.
+      - Preserve behavior, including old edge cases and bugs, unless the approved diagnosis explicitly says otherwise.
+      - Keep the diff small and reversible; avoid unrelated cleanup, new abstractions, or broad refactors.
+      - Run focused verification after each meaningful change and record evidence.
+
+  fix_reviewer:
+    description: Reviews the fix against diagnosis, v1 behavior, and scope boundaries.
+    tool_permissions:
+      allow: [Read, Grep, Glob, Bash]
+      deny: [Edit, Write, NotebookEdit]
+    scope:
+      read: ["**/*", ".dna/**", "docs/**"]
+      write: []
+    instructions:
+      - Compare the diff to {{diagnosis_path}} and {{diagnosis_review_path}}.
+      - Verify every changed file is necessary for the approved diagnosis.
+      - Check for behavior drift, opportunistic improvement, unrelated refactor, or missing v1 reference.
+      - Reject the round if evidence is stale, missing, or too broad.
+      - "Produce a concise verdict: APPROVE, REQUEST_CHANGES, or BLOCKED."
+
+  verifier:
+    description: Runs focused verification and updates progress evidence for the module.
+    tool_permissions:
+      allow: [Read, Edit, Write, Grep, Glob, Bash]
+      deny: [NotebookEdit]
+    scope:
+      read: ["**/*", ".dna/**", "docs/**"]
+      write: [".dna/fix-progress/**"]
+    instructions:
+      - Run the smallest meaningful test/analyze/build command that proves the fix.
+      - Record command, result, evidence paths, remaining failures, and next focus in {{progress_path}}.
+      - If verification cannot run, record the blocker and required human/environment action.
+      - Do not claim completion without fresh evidence.
+
+  manager_reviewer:
+    description: Turns fix/review/verify results into a manager-readable route decision.
+    tool_permissions:
+      allow: [Read, Grep, Glob]
+      deny: [Edit, Write, Bash, NotebookEdit]
+    scope:
+      read: ["**/*", ".dna/**", "docs/**"]
+      write: []
+    instructions:
+      - Summarize whether the module is PASS, CONTINUE, REQUEST_CHANGES, or BLOCKED.
+      - Name the diagnosis, review verdict, test evidence, and progress artifact.
+      - If active work remains, route back to the fix loop or asset suggestions before sync/evolution.
+      - Keep Obsidian/wiki as internal memory only; use machine artifacts as workflow evidence.
+
+workflows:
+  fix-review-loop:
+    name: Fix Review Loop
+    description: Implement from approved diagnosis, independently review behavior equivalence, verify, and record manager-readable progress.
+    steps:
+      - id: fix
+        role: fixer
+        description: Implement the smallest diagnosis-approved behavior-preserving fix.
+        prompt: |
+          Fix $ARGUMENTS using {{diagnosis_path}} and {{diagnosis_review_path}}.
+          Confirm the review verdict is APPROVE, read v1 behavior references, then make the smallest necessary code/test changes.
+          Preserve v1 behavior and avoid unrelated refactors.
+        checkpoints:
+          - assert: diagnosis_review_verdict_present
+            command: "test -s \"{{diagnosis_review_path}}\""
+            message: "Diagnosis review verdict must exist before fixing."
+            action: block
+        handoff:
+          consumes:
+            - type: file
+              path: "{{diagnosis_path}}"
+              description: Approved diagnosis artifact.
+            - type: file
+              path: "{{diagnosis_review_path}}"
+              description: Diagnosis review verdict.
+          produces:
+            - type: summary
+              name: fix_diff_summary
+              description: Changed files, target diagnosis item, and verification commands run.
+      - id: review-fix
+        role: fix_reviewer
+        depends_on: [fix]
+        description: Review the fix against approved diagnosis and v1 behavior.
+        prompt: |
+          Review the current diff for $ARGUMENTS.
+          Check scope, v1 behavior equivalence, diagnosis alignment, and evidence freshness.
+          Return APPROVE, REQUEST_CHANGES, or BLOCKED with reasons.
+        handoff:
+          consumes:
+            - type: summary
+              name: fix_diff_summary
+              from: fix
+              description: Fix round summary.
+          produces:
+            - type: summary
+              name: fix_review_verdict
+              description: Independent review verdict for the fix round.
+      - id: verify
+        role: verifier
+        depends_on: [review-fix]
+        description: Run focused verification and update progress evidence.
+        prompt: |
+          Run focused verification for $ARGUMENTS after review.
+          Update {{progress_path}} with verdict, commands, evidence paths, remaining failures, and next focus.
+        checkpoints:
+          - assert: progress_artifact_written
+            command: "test -s \"{{progress_path}}\""
+            message: "Progress JSON must be written before manager route."
+            action: block
+        handoff:
+          consumes:
+            - type: summary
+              name: fix_review_verdict
+              from: review-fix
+              description: Fix review verdict.
+          produces:
+            - type: file
+              path: "{{progress_path}}"
+              description: Updated module progress evidence.
+      - id: manager-route
+        role: manager_reviewer
+        depends_on: [verify]
+        description: Produce manager-readable next action from progress evidence.
+        prompt: |
+          Read {{progress_path}}, {{diagnosis_path}}, and {{diagnosis_review_path}}.
+          State PASS, CONTINUE, REQUEST_CHANGES, or BLOCKED; include evidence paths and next command.
+        handoff:
+          consumes:
+            - type: file
+              path: "{{progress_path}}"
+              from: verify
+              description: Module progress evidence.
+          produces:
+            - type: summary
+              name: fix_loop_route
+              description: Manager-readable next action for the module.
+
+controllers:
+  fix-review-loop:
+    name: Fix Review Loop
+    description: "Run diagnosis-backed fix, independent review, verification, and manager route for one module or risky slice."
+    kind: sequential
+    workflow: fix-review-loop
+    max_rounds: 3
+    progress_artifact_path: ".dna/fix-progress/$ARGUMENTS.json"
+    roles:
+      fixer: fixer
+      fix_reviewer: fix_reviewer
+      verifier: verifier
+      manager_reviewer: manager_reviewer
+    stop_format: configured_stop_report