instbyte 1.9.0 → 1.9.1

package/client/js/app.js

@@ -1250,13 +1250,32 @@ async function uploadFiles(files) {
             const xhr = new XMLHttpRequest();
             xhr.open("POST", "/upload", true);
 
+            // Stall detection — if no progress for 30s, the connection is dead.
+            // We don't use xhr.timeout because that would kill legitimate large
+            // file uploads on slow LANs.
+            // Instead we track the last progress event and abort if nothing moves for 30 seconds.
+            const STALL_MS = 30_000;
+            let stallTimer = null;
+
+            function resetStallTimer() {
+                clearTimeout(stallTimer);
+                stallTimer = setTimeout(() => {
+                    xhr.abort();
+                    text.innerText = `⚠ ${file.name} stalled — skipped`;
+                    bar.style.width = "0%";
+                    setTimeout(resolve, 1200);
+                }, STALL_MS);
+            }
+
             xhr.upload.onprogress = e => {
                 if (e.lengthComputable) {
                     bar.style.width = Math.round((e.loaded / e.total) * 100) + "%";
                 }
+                resetStallTimer(); // data is moving, push the timer out
             };
 
             xhr.onload = () => {
+                clearTimeout(stallTimer);
                 if (xhr.status === 413) {
                     text.innerText = `⚠ ${file.name} is too large — skipped`;
                     bar.style.width = "0%";
@@ -1267,11 +1286,21 @@ async function uploadFiles(files) {
             };
 
             xhr.onerror = () => {
+                clearTimeout(stallTimer);
                 text.innerText = `⚠ ${file.name} failed — skipped`;
                 bar.style.width = "0%";
                 setTimeout(resolve, 1200);
             };
 
+            xhr.onabort = () => {
+                clearTimeout(stallTimer);
+                // ontimeout/stall already set the message — only handle
+                // explicit user-triggered aborts here if we add a cancel
+                // button in future. For now just resolve to unblock queue.
+                resolve();
+            };
+
+            resetStallTimer(); // start timer — covers stall before first progress
             xhr.send(form);
         });
     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "instbyte",
-  "version": "1.9.0",
+  "version": "1.9.1",
   "description": "A self-hosted LAN sharing utility for fast, frictionless file, link, and snippet exchange across devices — no cloud required.",
   "main": "server/server.js",
   "bin": {

package/server/db.js

@@ -6,6 +6,7 @@ const dbPath = process.env.INSTBYTE_DATA
   : path.join(__dirname, "../db.sqlite");
 
 const db = new sqlite3.Database(dbPath);
+db.configure("busyTimeout", 5000);
 
 db.serialize(() => {
 

package/server/server.js

@@ -21,6 +21,29 @@ const config = require("./config");
 const UPLOADS_DIR = process.env.INSTBYTE_UPLOADS
   || path.join(__dirname, "../uploads");
 
+/* STARTUP ORPHAN SCAN
+ Deletes any files in uploads dir that have no matching DB record.
+ Catches ghost files left by aborted uploads before fix in v1.9.1 */
+function scanOrphans() {
+  fs.readdir(UPLOADS_DIR, (err, files) => {
+    if (err || !files || !files.length) return;
+
+    db.all("SELECT filename FROM items WHERE filename IS NOT NULL", (err, rows) => {
+      if (err) return;
+
+      const known = new Set(rows.map(r => r.filename));
+      files.forEach(file => {
+        if (!known.has(file)) {
+          const orphan = path.join(UPLOADS_DIR, file);
+          fs.unlink(orphan, err => {
+            if (!err) console.log("Orphan removed:", file);
+          });
+        }
+      });
+    });
+  });
+}
+
 const CLIENT_DIR = path.join(__dirname, "../client");
 
 const app = express();
@@ -276,12 +299,35 @@ app.post("/logout", (req, res) => {
 app.post("/upload", (req, res) => {
   upload.single("file")(req, res, (err) => {
     if (err && err.code === "LIMIT_FILE_SIZE") {
-      return res.status(413).json({ error: "File exceeds 2GB limit" });
+      // Clean up in case Multer may have written a partial file before hitting limit
+      if (req.file) {
+        const partial = path.join(UPLOADS_DIR, req.file.filename);
+        if (fs.existsSync(partial)) fs.unlinkSync(partial);
+      }
+      return res.status(413).json({ error: "File exceeds limit" });
     }
     if (err) {
+      if (req.file) {
+        const partial = path.join(UPLOADS_DIR, req.file.filename);
+        if (fs.existsSync(partial)) fs.unlinkSync(partial);
+      }
       return res.status(500).json({ error: "Upload failed" });
     }
 
+    // req.file missing means the request was aborted before Multer
+    // finished. No register or clean up required
+    if (!req.file) {
+      return res.status(400).json({ error: "No file received" });
+    }
+
+    // Detect client disconnect that happened after Multer finished writing
+    // but before we could respond. Clean up the orphaned file.
+    if (req.destroyed || res.destroyed) {
+      const partial = path.join(UPLOADS_DIR, req.file.filename);
+      if (fs.existsSync(partial)) fs.unlinkSync(partial);
+      return;
+    }
+
     const { channel, uploader } = req.body;
 
     const item = {
@@ -297,7 +343,13 @@ app.post("/upload", (req, res) => {
       `INSERT INTO items (type, filename, size, channel, uploader, created_at)
        VALUES (?, ?, ?, ?, ?, ?)`,
       ["file", item.filename, item.size, channel, uploader, item.created_at],
-      function () {
+      function (dbErr) {
+        if (dbErr) {
+          // DB insert failed — don't leave the file on disk orphaned
+          const orphan = path.join(UPLOADS_DIR, item.filename);
+          if (fs.existsSync(orphan)) fs.unlinkSync(orphan);
+          return res.status(500).json({ error: "Failed to save item" });
+        }
         item.id = this.lastID;
         io.emit("new-item", item);
         res.json(item);
@@ -779,6 +831,7 @@ findFreePort(PREFERRED).then(p => {
       console.log(`(port ${PREFERRED} was busy, switched to ${PORT})`);
     }
     console.log("");
+    scanOrphans(); // clean up any pre-v1.9.1 ghost files
   });
 });