instbyte 1.8.0 → 1.9.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "instbyte",
-  "version": "1.8.0",
+  "version": "1.9.1",
   "description": "A self-hosted LAN sharing utility for fast, frictionless file, link, and snippet exchange across devices — no cloud required.",
   "main": "server/server.js",
   "bin": {

package/server/cleanup.js

@@ -3,13 +3,12 @@ const fs = require("fs");
 const path = require("path");
 const config = require("./config");
 
-const DAY = config.storage.retention;
-
 setInterval(() => {
-  const cutoff = Date.now() - DAY;
+  if (config.storage.retention === null) return;
+  const cutoff = Date.now() - config.storage.retention;
 
   db.all(
-    `SELECT * FROM items WHERE created_at < ?`,
+    `SELECT * FROM items WHERE created_at < ? AND pinned = 0`,
     [cutoff],
     (err, rows) => {
       rows.forEach((item) => {

package/server/config.js

@@ -30,6 +30,7 @@ function parseFileSize(val) {
 }
 
 function parseRetention(val) {
+    if (String(val).toLowerCase() === "never") return null;
     if (typeof val === "number") return val;
     const units = { h: 3600000, d: 86400000 };
     const match = String(val).match(/^(\d+)(h|d)$/i);

package/server/db.js

@@ -6,6 +6,7 @@ const dbPath = process.env.INSTBYTE_DATA
   : path.join(__dirname, "../db.sqlite");
 
 const db = new sqlite3.Database(dbPath);
+db.configure("busyTimeout", 5000);
 
 db.serialize(() => {
 
@@ -36,6 +37,9 @@ db.serialize(() => {
   db.run(`ALTER TABLE items ADD COLUMN size INTEGER DEFAULT 0`, () => { });
   db.run(`ALTER TABLE channels ADD COLUMN pinned INTEGER DEFAULT 0`, () => { });
 
+  db.run(`ALTER TABLE items ADD COLUMN title TEXT DEFAULT ''`, () => { });
+  db.run(`ALTER TABLE items ADD COLUMN edited_at INTEGER DEFAULT NULL`, () => { });
+
   // Insert default channels if empty
   db.get("SELECT COUNT(*) as count FROM channels", (err, row) => {
     if (err) {

package/server/server.js

@@ -21,6 +21,29 @@ const config = require("./config");
 const UPLOADS_DIR = process.env.INSTBYTE_UPLOADS
   || path.join(__dirname, "../uploads");
 
+/* STARTUP ORPHAN SCAN
+ Deletes any files in uploads dir that have no matching DB record.
+ Catches ghost files left by aborted uploads before fix in v1.9.1 */
+function scanOrphans() {
+  fs.readdir(UPLOADS_DIR, (err, files) => {
+    if (err || !files || !files.length) return;
+
+    db.all("SELECT filename FROM items WHERE filename IS NOT NULL", (err, rows) => {
+      if (err) return;
+
+      const known = new Set(rows.map(r => r.filename));
+      files.forEach(file => {
+        if (!known.has(file)) {
+          const orphan = path.join(UPLOADS_DIR, file);
+          fs.unlink(orphan, err => {
+            if (!err) console.log("Orphan removed:", file);
+          });
+        }
+      });
+    });
+  });
+}
+
 const CLIENT_DIR = path.join(__dirname, "../client");
 
 const app = express();
@@ -276,12 +299,35 @@ app.post("/logout", (req, res) => {
 app.post("/upload", (req, res) => {
   upload.single("file")(req, res, (err) => {
     if (err && err.code === "LIMIT_FILE_SIZE") {
-      return res.status(413).json({ error: "File exceeds 2GB limit" });
+      // Clean up in case Multer may have written a partial file before hitting limit
+      if (req.file) {
+        const partial = path.join(UPLOADS_DIR, req.file.filename);
+        if (fs.existsSync(partial)) fs.unlinkSync(partial);
+      }
+      return res.status(413).json({ error: "File exceeds limit" });
     }
     if (err) {
+      if (req.file) {
+        const partial = path.join(UPLOADS_DIR, req.file.filename);
+        if (fs.existsSync(partial)) fs.unlinkSync(partial);
+      }
       return res.status(500).json({ error: "Upload failed" });
     }
 
+    // req.file missing means the request was aborted before Multer
+    // finished. No register or clean up required
+    if (!req.file) {
+      return res.status(400).json({ error: "No file received" });
+    }
+
+    // Detect client disconnect that happened after Multer finished writing
+    // but before we could respond. Clean up the orphaned file.
+    if (req.destroyed || res.destroyed) {
+      const partial = path.join(UPLOADS_DIR, req.file.filename);
+      if (fs.existsSync(partial)) fs.unlinkSync(partial);
+      return;
+    }
+
     const { channel, uploader } = req.body;
 
     const item = {
@@ -297,7 +343,13 @@ app.post("/upload", (req, res) => {
       `INSERT INTO items (type, filename, size, channel, uploader, created_at)
        VALUES (?, ?, ?, ?, ?, ?)`,
       ["file", item.filename, item.size, channel, uploader, item.created_at],
-      function () {
+      function (dbErr) {
+        if (dbErr) {
+          // DB insert failed — don't leave the file on disk orphaned
+          const orphan = path.join(UPLOADS_DIR, item.filename);
+          if (fs.existsSync(orphan)) fs.unlinkSync(orphan);
+          return res.status(500).json({ error: "Failed to save item" });
+        }
         item.id = this.lastID;
         io.emit("new-item", item);
         res.json(item);
@@ -525,6 +577,45 @@ app.patch("/item/:id/move", (req, res) => {
   });
 });
 
+/* UPDATE ITEM TITLE */
+app.patch("/item/:id/title", (req, res) => {
+  const { id } = req.params;
+  const { title } = req.body;
+
+  if (title === undefined) return res.status(400).json({ error: "Title required" });
+
+  db.run(
+    "UPDATE items SET title=? WHERE id=?",
+    [title.trim(), id],
+    function (err) {
+      if (err) return res.status(500).json({ error: "Update failed" });
+      if (this.changes === 0) return res.status(404).json({ error: "Item not found" });
+      io.emit("item-updated", { id: parseInt(id), title: title.trim() });
+      res.json({ id, title: title.trim() });
+    }
+  );
+});
+
+/* UPDATE ITEM CONTENT */
+app.patch("/item/:id/content", (req, res) => {
+  const { id } = req.params;
+  const { content } = req.body;
+
+  if (content === undefined) return res.status(400).json({ error: "Content required" });
+  if (content.trim() === "") return res.status(400).json({ error: "Content cannot be empty" });
+
+  db.run(
+    "UPDATE items SET content=?, edited_at=? WHERE id=? AND type='text'",
+    [content.trim(), Date.now(), id],
+    function (err) {
+      if (err) return res.status(500).json({ error: "Update failed" });
+      if (this.changes === 0) return res.status(404).json({ error: "Item not found or not editable" });
+      io.emit("item-updated", { id: parseInt(id), content: content.trim(), edited_at: Date.now() });
+      res.json({ id, content: content.trim() });
+    }
+  );
+});
+
 /* RENAME CHANNEL */
 app.patch("/channels/:name", (req, res) => {
   const oldName = req.params.name;
@@ -573,7 +664,8 @@ app.post("/channels/:name/pin", (req, res) => {
 app.get("/info", (req, res) => {
   res.json({
     url: `http://${localIP}:${PORT}`,
-    hasAuth: !!config.auth.passphrase
+    hasAuth: !!config.auth.passphrase,
+    retention: config.storage.retention  // null means "never"
   });
 });
 
@@ -650,6 +742,9 @@ app.get("/logo-dynamic.png", (req, res) => {
 /* ============================
    SOCKET CONNECTION LOGGING
 ============================ */
+// in-memory seen tracking — item id → Set of socket ids
+// resets on server restart, no DB needed
+const seenBy = new Map();
 
 let connectedUsers = 0;
 
@@ -664,6 +759,15 @@ io.on("connection", (socket) => {
     console.log(username + " connected | total:", connectedUsers);
   });
 
+  socket.on("seen", ({ id, name }) => {
+    if (!id || !name) return;
+    if (!seenBy.has(id)) seenBy.set(id, new Set());
+    seenBy.get(id).add(name); // name instead of socket.id
+    const count = seenBy.get(id).size;
+    console.log(`seen: item ${id} | count: ${count}`);
+    io.emit("seen-update", { id, count });
+  });
+
   socket.on("disconnect", () => {
     connectedUsers--;
     console.log(username + " disconnected | total:", connectedUsers);
@@ -727,6 +831,7 @@ findFreePort(PREFERRED).then(p => {
       console.log(`(port ${PREFERRED} was busy, switched to ${PORT})`);
     }
     console.log("");
+    scanOrphans(); // clean up any pre-v1.9.1 ghost files
   });
 });