instauto 7.2.0 → 7.2.3

package/index.js

@@ -165,27 +165,45 @@ const Instauto = async (db, browser, options) => {
     return new Date().getTime() - followedUserEntry.time < dontUnfollowUntilTimeElapsed;
   }
 
-  async function safeGoto(url) {
-    logger.log(`Goto ${url}`);
-    const response = await page.goto(url);
-    await sleep(1000);
-    const status = response.status();
+  async function gotoWithRetry(url) {
+    for (let attempt = 0; ; attempt += 1) {
+      logger.log(`Goto ${url}`);
+      const response = await page.goto(url);
+      await sleep(1000);
+      const status = response.status();
+
+      // https://www.reddit.com/r/Instagram/comments/kwrt0s/error_560/
+      // https://github.com/mifi/instauto/issues/60
+      if (![560, 429].includes(status) || attempt > 3) return status;
+
+      logger.info(`Got ${status} - Retrying request later...`);
+      if (status === 429) logger.warn('429 Too Many Requests could mean that Instagram suspects you\'re using a bot. You could try to use the Instagram Mobile app from the same IP for a few days first');
+      await sleep((attempt + 1) * 30 * 60 * 1000);
+    }
+  }
+
+  async function safeGotoUser(url, checkPageForUsername) {
+    const status = await gotoWithRetry(url);
     if (status === 200) {
+      if (checkPageForUsername != null) {
+        // some pages return 200 but nothing there (I think deleted accounts)
+        // https://github.com/mifi/SimpleInstaBot/issues/48
+        // example: https://www.instagram.com/victorialarson__/
+        // so we check if the page has the user's name on it
+        return page.evaluate((username) => window.find(username), checkPageForUsername);
+      }
       return true;
-    } else if (status === 404) {
+    }
+    if (status === 404) {
       logger.log('User not found');
       return false;
-    } else if (status === 429) {
-      logger.error('Got 429 Too Many Requests, waiting...');
-      await sleep(60 * 60 * 1000);
-      throw new Error('Aborted operation due to too many requests'); // TODO retry instead
     }
-    throw new Error(`Navigate to user returned status ${response.status()}`);
+    throw new Error(`Navigate to user failed with status ${status}`);
   }
 
   async function navigateToUser(username) {
     logger.log(`Navigating to user ${username}`);
-    return safeGoto(`${instagramBaseUrl}/${encodeURIComponent(username)}`);
+    return safeGotoUser(`${instagramBaseUrl}/${encodeURIComponent(username)}`, username);
   }
 
   async function getPageJson() {
@@ -197,7 +215,7 @@ const Instauto = async (db, browser, options) => {
     if (graphqlUserMissing) {
       // https://stackoverflow.com/questions/37593025/instagram-api-get-the-userid
       // https://stackoverflow.com/questions/17373886/how-can-i-get-a-users-media-from-instagram-without-authenticating-as-a-user
-      const found = await safeGoto(`${instagramBaseUrl}/${encodeURIComponent(username)}?__a=1`);
+      const found = await safeGotoUser(`${instagramBaseUrl}/${encodeURIComponent(username)}?__a=1`);
       if (!found) throw new Error('User not found');
 
       const json = await getPageJson();
@@ -242,12 +260,31 @@ const Instauto = async (db, browser, options) => {
     }
   }
 
-  async function findFollowButton() {
-    const elementHandles = await page.$x("//header//button[text()='Follow']");
+  // How to test xpaths in the browser:
+  // document.evaluate("your xpath", document, null, XPathResult.FIRST_ORDERED_NODE_TYPE, null ).singleNodeValue
+  async function findButtonWithText(text) {
+    // todo escape text?
+
+    // button seems to look like this now:
+    // <button class="..."><div class="...">Follow</div></button>
+    // https://sqa.stackexchange.com/questions/36918/xpath-text-buy-now-is-working-but-not-containstext-buy-now
+    // https://github.com/mifi/SimpleInstaBot/issues/106
+    let elementHandles = await page.$x(`//header//button[contains(.,'${text}')]`);
     if (elementHandles.length > 0) return elementHandles[0];
 
-    const elementHandles2 = await page.$x("//header//button[text()='Follow Back']");
-    if (elementHandles2.length > 0) return elementHandles2[0];
+    // old button:
+    elementHandles = await page.$x(`//header//button[text()='${text}']`);
+    if (elementHandles.length > 0) return elementHandles[0];
+
+    return undefined;
+  }
+
+  async function findFollowButton() {
+    let button = await findButtonWithText('Follow');
+    if (button) return button;
+
+    button = await findButtonWithText('Follow Back');
+    if (button) return button;
 
     return undefined;
   }
@@ -301,7 +338,7 @@ const Instauto = async (db, browser, options) => {
       await addPrevFollowedUser(entry);
 
       if (!elementHandle2) {
-        logger.log('Button did not change state - Sleeping');
+        logger.log('Button did not change state - Sleeping 1 min');
         await sleep(60000);
         throw new Error('Button did not change state');
       }
@@ -772,6 +809,10 @@ const Instauto = async (db, browser, options) => {
   }
 
   page = await browser.newPage();
+
+  // https://github.com/mifi/SimpleInstaBot/issues/118#issuecomment-1067883091
+  await page.setExtraHTTPHeaders({ 'Accept-Language': 'en' });
+
   if (randomizeUserAgent) {
     const userAgentGenerated = new UserAgent({ deviceCategory: 'desktop' });
     await page.setUserAgent(userAgentGenerated.toString());
@@ -780,72 +821,88 @@ const Instauto = async (db, browser, options) => {
 
   if (enableCookies) await tryLoadCookies();
 
-  const goHome = async () => page.goto(`${instagramBaseUrl}/`);
+  const goHome = async () => page.goto(`${instagramBaseUrl}/?hl=en`);
 
   // https://github.com/mifi/SimpleInstaBot/issues/28
-  async function setLang(short, long) {
+  async function setLang(short, long, assumeLoggedIn = false) {
     logger.log(`Setting language to ${long} (${short})`);
 
-    // This doesn't seem to always work, hence why it's just a fallback now
-    async function fallbackSetLang() {
-      await goHome();
-      await sleep(1000);
-
-      await page.setCookie({
-        name: 'ig_lang',
-        value: short,
-        path: '/',
-      });
-      await sleep(1000);
-      await goHome();
-      await sleep(3000);
-    }
-
     try {
       await sleep(1000);
-      await goHome();
+
+      // when logged in, we need to go to account in order to be able to check/set language
+      // (need to see the footer)
+      if (assumeLoggedIn) {
+        await page.goto(`${instagramBaseUrl}/accounts/edit/`);
+      } else {
+        await goHome();
+      }
       await sleep(3000);
       const elementHandles = await page.$x(`//select[//option[@value='${short}' and text()='${long}']]`);
       if (elementHandles.length < 1) throw new Error('Language selector not found');
       logger.log('Found language selector');
 
       // https://stackoverflow.com/questions/45864516/how-to-select-an-option-from-dropdown-select
-      await page.evaluate((selectElem, short2) => {
+      const alreadyEnglish = await page.evaluate((selectElem, short2) => {
         const optionElem = selectElem.querySelector(`option[value='${short2}']`);
+        if (optionElem.selected) return true; // already selected?
         optionElem.selected = true;
         // eslint-disable-next-line no-undef
         const event = new Event('change', { bubbles: true });
         selectElem.dispatchEvent(event);
+        return false;
       }, elementHandles[0], short);
-      logger.log('Selected language');
 
+      if (alreadyEnglish) {
+        logger.log('Already English language');
+        if (!assumeLoggedIn) {
+          await goHome(); // because we were on the settings page
+          await sleep(1000);
+        }
+        return;
+      }
+
+      logger.log('Selected language');
       await sleep(3000);
       await goHome();
       await sleep(1000);
     } catch (err) {
       logger.error('Failed to set language, trying fallback (cookie)', err);
-      await fallbackSetLang();
+      // This doesn't seem to always work, hence why it's just a fallback now
+      await goHome();
+      await sleep(1000);
+
+      await page.setCookie({
+        name: 'ig_lang',
+        value: short,
+        path: '/',
+      });
+      await sleep(1000);
+      await goHome();
+      await sleep(3000);
     }
   }
 
-  const setEnglishLang = async () => setLang('en', 'English');
-  // const setEnglishLang = async () => setLang('de', 'Deutsch');
+  const setEnglishLang = async (assumeLoggedIn) => setLang('en', 'English', assumeLoggedIn);
+  // const setEnglishLang = async (assumeLoggedIn) => setLang('de', 'Deutsch', assumeLoggedIn);
 
-  async function tryPressButton(elementHandles, name) {
+  async function tryPressButton(elementHandles, name, sleepMs = 3000) {
     try {
       if (elementHandles.length === 1) {
         logger.log(`Pressing button: ${name}`);
         elementHandles[0].click();
-        await sleep(3000);
+        await sleep(sleepMs);
       }
     } catch (err) {
       logger.warn(`Failed to press button: ${name}`);
     }
   }
 
-  await setEnglishLang();
+  await setEnglishLang(false);
 
   await tryPressButton(await page.$x('//button[contains(text(), "Accept")]'), 'Accept cookies dialog');
+  await tryPressButton(await page.$x('//button[contains(text(), "Only allow essential cookies")]'), 'Accept cookies dialog 2 button 1', 10000);
+  await tryPressButton(await page.$x('//button[contains(text(), "Allow essential and optional cookies")]'), 'Accept cookies dialog 2 button 2', 10000);
 
   if (!(await isLoggedIn())) {
     if (!myUsername || !password) {
@@ -857,7 +914,7 @@ const Instauto = async (db, browser, options) => {
       await page.click('a[href="/accounts/login/?source=auth_switcher"]');
       await sleep(1000);
     } catch (err) {
-      logger.warn('Login page button not found, assuming we have login form');
+      logger.info('No login page button, assuming we are on login form');
     }
 
     // Mobile version https://github.com/mifi/SimpleInstaBot/issues/7
@@ -868,8 +925,15 @@ const Instauto = async (db, browser, options) => {
     await page.type('input[name="password"]', password, { delay: 50 });
     await sleep(1000);
 
-    const loginButton = (await page.$x("//button[.//text() = 'Log In']"))[0];
-    await loginButton.click();
+    for (;;) {
+      const loginButton = (await page.$x("//button[.//text() = 'Log In']"))[0];
+      if (loginButton) {
+        await loginButton.click();
+        break;
+      }
+      logger.warn('Login button not found. Maybe you can help me click it? And also report an issue on github with a screenshot of what you\'re seeing :)');
+      await sleep(6000);
+    }
 
     await sleep(6000);
 
@@ -889,7 +953,8 @@ const Instauto = async (db, browser, options) => {
     }
 
     // In case language gets reset after logging in
-    await setEnglishLang();
+    // https://github.com/mifi/SimpleInstaBot/issues/118
+    await setEnglishLang(true);
 
     // Mobile version https://github.com/mifi/SimpleInstaBot/issues/7
     await tryPressButton(await page.$x('//button[contains(text(), "Save Info")]'), 'Login info dialog: Save Info');

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "instauto",
-  "version": "7.2.0",
+  "version": "7.2.3",
   "description": "Instagram automation library written in Node.js",
   "main": "index.js",
   "scripts": {