instar 1.3.888 → 1.3.890

package/dashboard/glance.js

@@ -46,6 +46,7 @@ export const GLANCE_ADOPTED_TABS = [
   'machines', 'systems', 'spend', 'routing-map', // Phase 3 (the jargon belt); 'systems' is the Health tab
   // Phase 4 — the sweep: every remaining data-summary view on the floor.
   'pr-pipeline', 'tokens', 'llm-activity', 'secrets', 'resources', 'initiatives',
+  'feedback-drain', // operated summary reviewed against the F10/F11 floor
 ];
 
 export const GLANCE_GRANDFATHERED = [

package/dashboard/index.html

@@ -2942,6 +2942,7 @@
             <button class="tab" data-tab="threadline" onclick="switchTab('threadline')">Threadline</button>
             <button class="tab" data-tab="integrated-being" onclick="switchTab('integrated-being')">Integrated-Being</button>
             <button class="tab" data-tab="process-health" onclick="switchTab('process-health')">Process Health</button>
+            <button class="tab" data-tab="feedback-drain" onclick="switchTab('feedback-drain')">Feedback Drain</button>
             <button class="tab" data-tab="preferences-learning" onclick="switchTab('preferences-learning')">Preferences</button>
           </div>
           <div class="tab-group" role="group" aria-label="Content & Access">
@@ -3575,6 +3576,18 @@
       </details>
     </div>
 
+    <div id="feedbackDrainPanel" class="ph-root" style="display:none;flex-direction:column;padding:28px;gap:20px;overflow-y:auto">
+      <div style="display:flex;justify-content:space-between;align-items:baseline">
+        <h2 class="ph-title">Feedback Drain</h2>
+        <div id="fdStamp" class="ph-stamp" aria-live="polite"></div>
+      </div>
+      <p class="ph-intro">The operated path from accepted feedback through agent readiness and durable Initiative handoff.</p>
+      <div id="fdPosture" class="ph-headline-wrap" aria-live="polite"></div>
+      <section class="ph-section"><h3 class="ph-h">Backlog</h3><div id="fdBacklog" class="ph-detail-body"></div></section>
+      <section class="ph-section"><h3 class="ph-h">Progress</h3><div id="fdProgress" class="ph-detail-body"></div></section>
+      <section class="ph-section"><h3 class="ph-h">Source integrity</h3><div id="fdSource" class="ph-detail-body"></div></section>
+    </div>
+
     <!-- subscriptions tab (Subscription & Auth Standard P2.2 — live quota + pending logins) -->
     <style>
       .sub-account { border:1px solid var(--border,#2a2a2a); border-radius:10px; padding:14px 16px; margin-bottom:12px; }
@@ -3743,6 +3756,16 @@
         <p class="ph-h-sub">Patterns I've distilled from moments you corrected me. The exact words are never stored — just a short, scrubbed summary.</p>
         <div id="plCorrections"></div>
       </section>
+      <section class="ph-section">
+        <h3 class="ph-h">Class reviews and outcomes</h3>
+        <p class="ph-h-sub">The standard and process question each correction opened, with their independent durable outcomes.</p>
+        <div id="plClassReviews"></div>
+      </section>
+      <section class="ph-section">
+        <h3 class="ph-h">Verify-before-done observations</h3>
+        <p class="ph-h-sub">Advisory evidence checks from recent completion claims. This never blocks a response.</p>
+        <div id="plCompletionAudit"></div>
+      </section>
     </div>
 
     <!-- machines tab (Multi-Machine Session Pool §L2) -->
@@ -5270,6 +5293,13 @@
         onActivate: () => { if (typeof startProcessHealth === 'function') startProcessHealth(); },
         onDeactivate: () => { if (typeof stopProcessHealth === 'function') stopProcessHealth(); },
       },
+      {
+        id: 'feedback-drain',
+        panels: ['feedbackDrainPanel'],
+        display: ['flex'],
+        onActivate: () => { if (typeof startFeedbackDrain === 'function') startFeedbackDrain(); },
+        onDeactivate: () => { if (typeof stopFeedbackDrain === 'function') stopFeedbackDrain(); },
+      },
       {
         id: 'subscriptions',
         panels: ['subscriptionsPanel'],
@@ -8812,6 +8842,8 @@
           headline: document.getElementById('plHeadline'),
           preferences: document.getElementById('plPreferences'),
           corrections: document.getElementById('plCorrections'),
+          classReviews: document.getElementById('plClassReviews'),
+          completionAudit: document.getElementById('plCompletionAudit'),
           stamp: document.getElementById('plStamp'),
         };
         // Raw fetch (NOT apiFetch) so the controller sees 503 itself.
@@ -8827,17 +8859,57 @@
       if (__plController) __plController.stop();
     }
 
+    // Feedback Factory operated-drain read surface. Closed status DTO only;
+    // dynamic values are assigned with textContent and never interpreted as HTML.
+    let __fdTimer = null;
+    const fdText = (id, value) => { const node = document.getElementById(id); if (node) node.textContent = String(value ?? '—'); };
+    async function loadFeedbackDrain() {
+      try {
+        const response = await fetch('/feedback-factory/drain/status', { headers: { 'Authorization': `Bearer ${token}` } });
+        const data = await response.json();
+        const posture = data.posture || { state: 'unavailable', reason: 'initialization-failure' };
+        fdText('fdPosture', `${posture.state}: ${posture.reason}`);
+        if (!response.ok) {
+          fdText('fdBacklog', 'The drain is not accepting work in this posture.');
+          fdText('fdProgress', 'No operated run is active.');
+          fdText('fdSource', 'Source integrity is unavailable until initialization succeeds.');
+        } else {
+          const drain = data.drain || {}; const readiness = drain.readiness || {}; const work = drain.work || {};
+          fdText('fdBacklog', `collecting ${readiness.collecting || 0}; ready ${readiness.ready || 0}; queued ${work.queued || 0}; retryable ${work.retryable || 0}; held ${(readiness.held || 0) + (work.held || 0)}; dead-lettered ${work['dead-lettered'] || 0}`);
+          const run = data.lastRun;
+          fdText('fdProgress', run ? `last run ${run.state}; completed ${work.completed || 0}; oldest queued ${drain.oldestQueuedAgeMs == null ? 'none' : Math.round(drain.oldestQueuedAgeMs / 1000) + 's'}` : 'No drain run has been admitted yet.');
+          fdText('fdSource', `byte lag ${drain.sourceProjectionLagBytes || 0}; generation lag ${drain.sourceGenerationLag || 0}; checksum conflicts ${drain.sourceChecksumConflicts || 0}`);
+        }
+        fdText('fdStamp', `updated ${new Date().toLocaleTimeString()}`);
+      } catch {
+        fdText('fdPosture', 'unavailable: status request failed');
+        fdText('fdStamp', '');
+      }
+    }
+    function startFeedbackDrain() {
+      stopFeedbackDrain();
+      void loadFeedbackDrain();
+      __fdTimer = setInterval(() => { void loadFeedbackDrain(); }, 15000);
+    }
+    function stopFeedbackDrain() {
+      if (__fdTimer) clearInterval(__fdTimer);
+      __fdTimer = null;
+    }
+
     // Handle tab visibility — close SSE when tab is backgrounded
     document.addEventListener('visibilitychange', () => {
       if (document.hidden) {
         disconnectJobsSSE();
         if (currentTab === 'process-health') stopProcessHealth();
+        if (currentTab === 'feedback-drain') stopFeedbackDrain();
         if (currentTab === 'preferences-learning') stopPreferencesLearning();
       } else if (currentTab === 'jobs') {
         connectJobsSSE();
         loadJobs(); // Resync on return
       } else if (currentTab === 'process-health') {
         startProcessHealth(); // resume on return: one immediate refresh + re-arm
+      } else if (currentTab === 'feedback-drain') {
+        startFeedbackDrain();
       } else if (currentTab === 'preferences-learning') {
         startPreferencesLearning(); // resume on return
       }

package/dashboard/preferences-learning.js

@@ -227,6 +227,81 @@ export function renderCorrections(doc, target, body, now = Date.now()) {
   }
 }
 
+export function renderClassReviews(doc, target, body) {
+  if (!target) return;
+  target.replaceChildren();
+  if (body && body.disabled) {
+    target.appendChild(el(doc, 'p', 'ph-empty', 'Class review is still dark on this agent.'));
+    return;
+  }
+  const records = body && Array.isArray(body.records) ? body.records.slice(0, 20) : [];
+  if (!records.length) { target.appendChild(el(doc, 'p', 'ph-empty', 'No class reviews yet.')); return; }
+  for (const record of records) {
+    const item = doc.createElement('details');
+    item.setAttribute('class', 'ph-item');
+    const heading = doc.createElement('summary');
+    heading.setAttribute('class', 'ph-item-summary');
+    heading.appendChild(el(doc, 'div', 'ph-item-text', `${friendlyReviewValue(record.standardReview?.verdict || record.fillState, 'Review pending')} · ${friendlyReviewValue(record.processReview?.verdict, 'Process review pending')}`));
+    item.appendChild(heading);
+    const detail = el(doc, 'div', 'ph-item-body');
+    detail.appendChild(labeledRow(doc, 'Lifecycle', friendlyReviewValue(record.reviewLifecycle, 'Open')));
+    detail.appendChild(labeledRow(doc, 'Standard outcome', friendlyReviewValue(record.standardOutcome, 'Proposed')));
+    detail.appendChild(labeledRow(doc, 'Process outcome', friendlyReviewValue(record.processOutcome, 'Proposed')));
+    item.appendChild(detail);
+    target.appendChild(item);
+  }
+}
+
+export function renderCompletionAudit(doc, target, body) {
+  if (!target) return;
+  target.replaceChildren();
+  if (body && body.disabled) { target.appendChild(el(doc, 'p', 'ph-empty', 'Verify-before-done is still dark on this agent.')); return; }
+  const records = body && Array.isArray(body.records) ? body.records.slice(-20).reverse() : [];
+  if (!records.length) { target.appendChild(el(doc, 'p', 'ph-empty', 'No completion observations yet.')); return; }
+  for (const record of records) {
+    const item = doc.createElement('details');
+    item.setAttribute('class', 'ph-item');
+    const heading = doc.createElement('summary');
+    heading.setAttribute('class', 'ph-item-summary');
+    heading.appendChild(el(doc, 'div', 'ph-item-text', friendlyReviewValue(record.verdict, 'Observed')));
+    item.appendChild(heading);
+    const detail = el(doc, 'div', 'ph-item-body');
+    detail.appendChild(labeledRow(doc, 'Action', friendlyActionKind(record.actionKind)));
+    detail.appendChild(labeledRow(doc, 'Blocked', 'No — advisory only'));
+    item.appendChild(detail);
+    target.appendChild(item);
+  }
+}
+
+const REVIEW_VALUE_LABELS = Object.freeze({
+  pending: 'Review pending', filled: 'Review complete', 'dead-lettered': 'Needs a manual retry',
+  covered: 'Covered by an existing standard', 'needs-upgrade': 'Needs a standard upgrade',
+  'new-standard-needed': 'Needs a new standard', 'not-applicable': 'No class change needed',
+  'process-gap': 'Process gap found', open: 'Open', parked: 'Parked for follow-up',
+  resolved: 'Resolved', superseded: 'Combined into another review', reopened: 'Reopened',
+  proposed: 'Proposed', ratified: 'Approved', shipped: 'Shipped', rejected: 'Declined',
+  deferred: 'Parked for follow-up', 'expired-unreviewed': 'Awaiting overdue review',
+  'no-action': 'No action needed', observed: 'Observed', corroborated: 'Evidence found',
+  'uncorroborated-contradicted': 'Evidence contradicts this claim',
+  'uncorroborated-unknown': 'Evidence was not found', 'not-eligible': 'Not eligible for this check',
+  'not-evaluated': 'Not evaluated',
+});
+
+export function friendlyReviewValue(value, fallback = 'Status unavailable') {
+  return typeof value === 'string' && REVIEW_VALUE_LABELS[value]
+    ? REVIEW_VALUE_LABELS[value]
+    : fallback;
+}
+
+const ACTION_KIND_LABELS = Object.freeze({
+  sent: 'Message sent', deployed: 'Deployment', 'handed-off': 'Handoff', committed: 'Commit',
+  pushed: 'Push', merged: 'Merge', restarted: 'Restart', fixed: 'Fix', other: 'Other action',
+});
+
+export function friendlyActionKind(value) {
+  return typeof value === 'string' && ACTION_KIND_LABELS[value] ? ACTION_KIND_LABELS[value] : 'Other action';
+}
+
 /**
  * Disabled (503) state. Pinned copy + operator hint as PLAIN PROSE — no
  * `<code>`, no monospace, no config-key string (Dashboard Standard).
@@ -245,7 +320,7 @@ export function renderDisabled(doc, els) {
     det.appendChild(el(doc, 'p', 'ph-operator-hint', 'You can switch it on in this agent’s settings.'));
     els.headline.appendChild(det);
   }
-  for (const k of ['preferences', 'corrections']) {
+  for (const k of ['preferences', 'corrections', 'classReviews', 'completionAudit']) {
     if (els[k]) els[k].replaceChildren();
   }
   if (els.stamp) els.stamp.textContent = '';
@@ -255,6 +330,8 @@ export function renderDisabled(doc, els) {
 const URLS = {
   prefs: '/preferences/session-context',
   corrections: '/corrections?limit=20',
+  classReviews: '/class-reviews?limit=20',
+  completionAudit: '/completion-claim/audit?limit=20',
 };
 
 /**
@@ -280,10 +357,10 @@ export function createController(opts) {
     timerId: null,
     inFlight: null,
     active: false,
-    snapshot: { prefs: null, corrections: null },
+    snapshot: { prefs: null, corrections: null, classReviews: null, completionAudit: null },
     last200At: 0,
     consecutiveFailedTicks: 0,
-    renderedSig: { headline: null, preferences: null, corrections: null, disabled: false },
+    renderedSig: { headline: null, preferences: null, corrections: null, classReviews: null, completionAudit: null, disabled: false },
   };
 
   async function fetchOne(key, controller) {
@@ -303,7 +380,7 @@ export function createController(opts) {
     state.inFlight = controller;
     let results;
     try {
-      results = await Promise.all(['prefs', 'corrections'].map((k) => fetchOne(k, controller)));
+      results = await Promise.all(['prefs', 'corrections', 'classReviews', 'completionAudit'].map((k) => fetchOne(k, controller)));
     } catch {
       if (controller.signal && controller.signal.aborted) return;
       state.inFlight = null;
@@ -315,7 +392,7 @@ export function createController(opts) {
     if (controller.signal && controller.signal.aborted) return;
     state.inFlight = null;
     // Feature OFF (503 on EITHER endpoint) → pinned disabled copy.
-    if (results.some((r) => r.status === 503)) {
+    if (results.some((r) => ['prefs', 'corrections'].includes(r.key) && r.status === 503)) {
       state.consecutiveFailedTicks = 0;
       if (state.renderedSig.disabled !== true) {
         renderDisabled(doc, els);
@@ -327,6 +404,7 @@ export function createController(opts) {
     state.renderedSig.disabled = false;
     for (const r of results) {
       if (r.status === 200) { state.snapshot[r.key] = r.body; }
+      else if (r.status === 503) { state.snapshot[r.key] = { disabled: true }; }
     }
     state.consecutiveFailedTicks = 0;
     state.last200At = now();
@@ -350,11 +428,15 @@ export function createController(opts) {
     const stale = headlineStale();
     const prefs = state.snapshot.prefs;
     const corrections = state.snapshot.corrections;
+    const classReviews = state.snapshot.classReviews;
+    const completionAudit = state.snapshot.completionAudit;
     const prefCount = prefs && Number.isFinite(prefs.count) ? prefs.count : 0;
 
     sectionRender('headline', sig(stale, prefCount), () => renderHeadline(doc, els.headline, { prefCount, stale }));
     sectionRender('preferences', sig(prefs), () => renderPreferences(doc, els.preferences, prefs));
     sectionRender('corrections', sig(corrections), () => renderCorrections(doc, els.corrections, corrections, now()));
+    sectionRender('classReviews', sig(classReviews), () => renderClassReviews(doc, els.classReviews, classReviews));
+    sectionRender('completionAudit', sig(completionAudit), () => renderCompletionAudit(doc, els.completionAudit, completionAudit));
 
     if (els.stamp) {
       const ageS = state.last200At ? Math.max(0, Math.round((now() - state.last200At) / 1000)) : null;

package/dist/commands/init.js

@@ -4136,6 +4136,9 @@ fi
     // Unjustified Stop Gate router — Stop hook that calls the server-side gate.
     // Shadow-mode by default; enforcement is controlled server-side.
     fs.writeFileSync(path.join(hooksDir, 'stop-gate-router.js'), migrator.getHookContent('stop-gate-router'), { mode: 0o755 });
+    // Verify-Before-Done observer — structural client-side TurnEvidence, always
+    // installed; fleet-dark/dev-dry-run gating occurs inside the hook + route.
+    fs.writeFileSync(path.join(hooksDir, 'completion-claim-observe.js'), migrator.getHookContent('completion-claim-observe'), { mode: 0o755 });
     // Hook event reporter — posts hook events to the Instar server for observability
     // and session resumption (claudeSessionId). Uses command hooks because Claude Code
     // HTTP hooks (type: "http") silently fail to fire as of v2.1.78.