instar 1.3.791 → 1.3.792

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "instar",
-  "version": "1.3.791",
+  "version": "1.3.792",
   "description": "Coherence infrastructure for self-evolving AI agents — on the Claude Code or Codex subscription you already have.",
   "type": "module",
   "main": "dist/index.js",

package/src/data/builtin-manifest.json

@@ -1,8 +1,8 @@
 {
   "$schema": "./builtin-manifest.schema.json",
   "schemaVersion": 1,
-  "generatedAt": "2026-07-09T09:59:52.299Z",
-  "instarVersion": "1.3.791",
+  "generatedAt": "2026-07-09T10:17:12.654Z",
+  "instarVersion": "1.3.792",
   "entryCount": 202,
   "entries": {
     "hook:session-start": {
@@ -418,7 +418,7 @@
       "type": "route-group",
       "domain": "monitoring",
       "sourcePath": "src/server/routes.ts",
-      "contentHash": "6dd6ca2f8912d7e60e3210bb2db055b72b3c1cbb816598cff9d6a00c43413606",
+      "contentHash": "59884e1700f28276bccbc65f34b578851dd90c50ecbeb784bf32e46dd2817fb8",
       "since": "2025-01-01"
     },
     "route-group:agents": {
@@ -426,7 +426,7 @@
       "type": "route-group",
       "domain": "sessions",
       "sourcePath": "src/server/routes.ts",
-      "contentHash": "6dd6ca2f8912d7e60e3210bb2db055b72b3c1cbb816598cff9d6a00c43413606",
+      "contentHash": "59884e1700f28276bccbc65f34b578851dd90c50ecbeb784bf32e46dd2817fb8",
       "since": "2025-01-01"
     },
     "route-group:backups": {
@@ -434,7 +434,7 @@
       "type": "route-group",
       "domain": "operations",
       "sourcePath": "src/server/routes.ts",
-      "contentHash": "6dd6ca2f8912d7e60e3210bb2db055b72b3c1cbb816598cff9d6a00c43413606",
+      "contentHash": "59884e1700f28276bccbc65f34b578851dd90c50ecbeb784bf32e46dd2817fb8",
       "since": "2025-01-01"
     },
     "route-group:git": {
@@ -442,7 +442,7 @@
       "type": "route-group",
       "domain": "coordination",
       "sourcePath": "src/server/routes.ts",
-      "contentHash": "6dd6ca2f8912d7e60e3210bb2db055b72b3c1cbb816598cff9d6a00c43413606",
+      "contentHash": "59884e1700f28276bccbc65f34b578851dd90c50ecbeb784bf32e46dd2817fb8",
       "since": "2025-01-01"
     },
     "route-group:memory": {
@@ -450,7 +450,7 @@
       "type": "route-group",
       "domain": "memory",
       "sourcePath": "src/server/routes.ts",
-      "contentHash": "6dd6ca2f8912d7e60e3210bb2db055b72b3c1cbb816598cff9d6a00c43413606",
+      "contentHash": "59884e1700f28276bccbc65f34b578851dd90c50ecbeb784bf32e46dd2817fb8",
       "since": "2025-01-01"
     },
     "route-group:semantic": {
@@ -458,7 +458,7 @@
       "type": "route-group",
       "domain": "memory",
       "sourcePath": "src/server/routes.ts",
-      "contentHash": "6dd6ca2f8912d7e60e3210bb2db055b72b3c1cbb816598cff9d6a00c43413606",
+      "contentHash": "59884e1700f28276bccbc65f34b578851dd90c50ecbeb784bf32e46dd2817fb8",
       "since": "2025-01-01"
     },
     "route-group:status": {
@@ -466,7 +466,7 @@
       "type": "route-group",
       "domain": "monitoring",
       "sourcePath": "src/server/routes.ts",
-      "contentHash": "6dd6ca2f8912d7e60e3210bb2db055b72b3c1cbb816598cff9d6a00c43413606",
+      "contentHash": "59884e1700f28276bccbc65f34b578851dd90c50ecbeb784bf32e46dd2817fb8",
       "since": "2025-01-01"
     },
     "route-group:capabilities": {
@@ -474,7 +474,7 @@
       "type": "route-group",
       "domain": "mapping",
       "sourcePath": "src/server/routes.ts",
-      "contentHash": "6dd6ca2f8912d7e60e3210bb2db055b72b3c1cbb816598cff9d6a00c43413606",
+      "contentHash": "59884e1700f28276bccbc65f34b578851dd90c50ecbeb784bf32e46dd2817fb8",
       "since": "2025-01-01"
     },
     "route-group:project-map": {
@@ -482,7 +482,7 @@
       "type": "route-group",
       "domain": "mapping",
       "sourcePath": "src/server/routes.ts",
-      "contentHash": "6dd6ca2f8912d7e60e3210bb2db055b72b3c1cbb816598cff9d6a00c43413606",
+      "contentHash": "59884e1700f28276bccbc65f34b578851dd90c50ecbeb784bf32e46dd2817fb8",
       "since": "2025-01-01"
     },
     "route-group:coherence": {
@@ -490,7 +490,7 @@
       "type": "route-group",
       "domain": "coherence",
       "sourcePath": "src/server/routes.ts",
-      "contentHash": "6dd6ca2f8912d7e60e3210bb2db055b72b3c1cbb816598cff9d6a00c43413606",
+      "contentHash": "59884e1700f28276bccbc65f34b578851dd90c50ecbeb784bf32e46dd2817fb8",
       "since": "2025-01-01"
     },
     "route-group:topic-bindings": {
@@ -498,7 +498,7 @@
       "type": "route-group",
       "domain": "sessions",
       "sourcePath": "src/server/routes.ts",
-      "contentHash": "6dd6ca2f8912d7e60e3210bb2db055b72b3c1cbb816598cff9d6a00c43413606",
+      "contentHash": "59884e1700f28276bccbc65f34b578851dd90c50ecbeb784bf32e46dd2817fb8",
       "since": "2025-01-01"
     },
     "route-group:context": {
@@ -506,7 +506,7 @@
       "type": "route-group",
       "domain": "context",
       "sourcePath": "src/server/routes.ts",
-      "contentHash": "6dd6ca2f8912d7e60e3210bb2db055b72b3c1cbb816598cff9d6a00c43413606",
+      "contentHash": "59884e1700f28276bccbc65f34b578851dd90c50ecbeb784bf32e46dd2817fb8",
       "since": "2025-01-01"
     },
     "route-group:scope-coherence": {
@@ -514,7 +514,7 @@
       "type": "route-group",
       "domain": "coherence",
       "sourcePath": "src/server/routes.ts",
-      "contentHash": "6dd6ca2f8912d7e60e3210bb2db055b72b3c1cbb816598cff9d6a00c43413606",
+      "contentHash": "59884e1700f28276bccbc65f34b578851dd90c50ecbeb784bf32e46dd2817fb8",
       "since": "2025-01-01"
     },
     "route-group:canonical-state": {
@@ -522,7 +522,7 @@
       "type": "route-group",
       "domain": "state",
       "sourcePath": "src/server/routes.ts",
-      "contentHash": "6dd6ca2f8912d7e60e3210bb2db055b72b3c1cbb816598cff9d6a00c43413606",
+      "contentHash": "59884e1700f28276bccbc65f34b578851dd90c50ecbeb784bf32e46dd2817fb8",
       "since": "2025-01-01"
     },
     "route-group:ci": {
@@ -530,7 +530,7 @@
       "type": "route-group",
       "domain": "monitoring",
       "sourcePath": "src/server/routes.ts",
-      "contentHash": "6dd6ca2f8912d7e60e3210bb2db055b72b3c1cbb816598cff9d6a00c43413606",
+      "contentHash": "59884e1700f28276bccbc65f34b578851dd90c50ecbeb784bf32e46dd2817fb8",
       "since": "2025-01-01"
     },
     "route-group:sessions": {
@@ -538,7 +538,7 @@
       "type": "route-group",
       "domain": "sessions",
       "sourcePath": "src/server/routes.ts",
-      "contentHash": "6dd6ca2f8912d7e60e3210bb2db055b72b3c1cbb816598cff9d6a00c43413606",
+      "contentHash": "59884e1700f28276bccbc65f34b578851dd90c50ecbeb784bf32e46dd2817fb8",
       "since": "2025-01-01"
     },
     "route-group:jobs": {
@@ -546,7 +546,7 @@
       "type": "route-group",
       "domain": "scheduling",
       "sourcePath": "src/server/routes.ts",
-      "contentHash": "6dd6ca2f8912d7e60e3210bb2db055b72b3c1cbb816598cff9d6a00c43413606",
+      "contentHash": "59884e1700f28276bccbc65f34b578851dd90c50ecbeb784bf32e46dd2817fb8",
       "since": "2025-01-01"
     },
     "route-group:skip-ledger": {
@@ -554,7 +554,7 @@
       "type": "route-group",
       "domain": "scheduling",
       "sourcePath": "src/server/routes.ts",
-      "contentHash": "6dd6ca2f8912d7e60e3210bb2db055b72b3c1cbb816598cff9d6a00c43413606",
+      "contentHash": "59884e1700f28276bccbc65f34b578851dd90c50ecbeb784bf32e46dd2817fb8",
       "since": "2025-01-01"
     },
     "route-group:telegram": {
@@ -562,7 +562,7 @@
       "type": "route-group",
       "domain": "communication",
       "sourcePath": "src/server/routes.ts",
-      "contentHash": "6dd6ca2f8912d7e60e3210bb2db055b72b3c1cbb816598cff9d6a00c43413606",
+      "contentHash": "59884e1700f28276bccbc65f34b578851dd90c50ecbeb784bf32e46dd2817fb8",
       "since": "2025-01-01"
     },
     "route-group:attention": {
@@ -570,7 +570,7 @@
       "type": "route-group",
       "domain": "communication",
       "sourcePath": "src/server/routes.ts",
-      "contentHash": "6dd6ca2f8912d7e60e3210bb2db055b72b3c1cbb816598cff9d6a00c43413606",
+      "contentHash": "59884e1700f28276bccbc65f34b578851dd90c50ecbeb784bf32e46dd2817fb8",
       "since": "2025-01-01"
     },
     "route-group:relationships": {
@@ -578,7 +578,7 @@
       "type": "route-group",
       "domain": "relationships",
       "sourcePath": "src/server/routes.ts",
-      "contentHash": "6dd6ca2f8912d7e60e3210bb2db055b72b3c1cbb816598cff9d6a00c43413606",
+      "contentHash": "59884e1700f28276bccbc65f34b578851dd90c50ecbeb784bf32e46dd2817fb8",
       "since": "2025-01-01"
     },
     "route-group:feedback": {
@@ -586,7 +586,7 @@
       "type": "route-group",
       "domain": "feedback",
       "sourcePath": "src/server/routes.ts",
-      "contentHash": "6dd6ca2f8912d7e60e3210bb2db055b72b3c1cbb816598cff9d6a00c43413606",
+      "contentHash": "59884e1700f28276bccbc65f34b578851dd90c50ecbeb784bf32e46dd2817fb8",
       "since": "2025-01-01"
     },
     "route-group:updates": {
@@ -594,7 +594,7 @@
       "type": "route-group",
       "domain": "updates",
       "sourcePath": "src/server/routes.ts",
-      "contentHash": "6dd6ca2f8912d7e60e3210bb2db055b72b3c1cbb816598cff9d6a00c43413606",
+      "contentHash": "59884e1700f28276bccbc65f34b578851dd90c50ecbeb784bf32e46dd2817fb8",
       "since": "2025-01-01"
     },
     "route-group:dispatches": {
@@ -602,7 +602,7 @@
       "type": "route-group",
       "domain": "dispatches",
       "sourcePath": "src/server/routes.ts",
-      "contentHash": "6dd6ca2f8912d7e60e3210bb2db055b72b3c1cbb816598cff9d6a00c43413606",
+      "contentHash": "59884e1700f28276bccbc65f34b578851dd90c50ecbeb784bf32e46dd2817fb8",
       "since": "2025-01-01"
     },
     "route-group:quota": {
@@ -610,7 +610,7 @@
       "type": "route-group",
       "domain": "monitoring",
       "sourcePath": "src/server/routes.ts",
-      "contentHash": "6dd6ca2f8912d7e60e3210bb2db055b72b3c1cbb816598cff9d6a00c43413606",
+      "contentHash": "59884e1700f28276bccbc65f34b578851dd90c50ecbeb784bf32e46dd2817fb8",
       "since": "2025-01-01"
     },
     "route-group:publishing": {
@@ -618,7 +618,7 @@
       "type": "route-group",
       "domain": "publishing",
       "sourcePath": "src/server/routes.ts",
-      "contentHash": "6dd6ca2f8912d7e60e3210bb2db055b72b3c1cbb816598cff9d6a00c43413606",
+      "contentHash": "59884e1700f28276bccbc65f34b578851dd90c50ecbeb784bf32e46dd2817fb8",
       "since": "2025-01-01"
     },
     "route-group:private-views": {
@@ -626,7 +626,7 @@
       "type": "route-group",
       "domain": "publishing",
       "sourcePath": "src/server/routes.ts",
-      "contentHash": "6dd6ca2f8912d7e60e3210bb2db055b72b3c1cbb816598cff9d6a00c43413606",
+      "contentHash": "59884e1700f28276bccbc65f34b578851dd90c50ecbeb784bf32e46dd2817fb8",
       "since": "2025-01-01"
     },
     "route-group:tunnel": {
@@ -634,7 +634,7 @@
       "type": "route-group",
       "domain": "networking",
       "sourcePath": "src/server/routes.ts",
-      "contentHash": "6dd6ca2f8912d7e60e3210bb2db055b72b3c1cbb816598cff9d6a00c43413606",
+      "contentHash": "59884e1700f28276bccbc65f34b578851dd90c50ecbeb784bf32e46dd2817fb8",
       "since": "2025-01-01"
     },
     "route-group:events": {
@@ -642,7 +642,7 @@
       "type": "route-group",
       "domain": "networking",
       "sourcePath": "src/server/routes.ts",
-      "contentHash": "6dd6ca2f8912d7e60e3210bb2db055b72b3c1cbb816598cff9d6a00c43413606",
+      "contentHash": "59884e1700f28276bccbc65f34b578851dd90c50ecbeb784bf32e46dd2817fb8",
       "since": "2025-01-01"
     },
     "route-group:evolution": {
@@ -650,7 +650,7 @@
       "type": "route-group",
       "domain": "evolution",
       "sourcePath": "src/server/routes.ts",
-      "contentHash": "6dd6ca2f8912d7e60e3210bb2db055b72b3c1cbb816598cff9d6a00c43413606",
+      "contentHash": "59884e1700f28276bccbc65f34b578851dd90c50ecbeb784bf32e46dd2817fb8",
       "since": "2025-01-01"
     },
     "route-group:watchdog": {
@@ -658,7 +658,7 @@
       "type": "route-group",
       "domain": "monitoring",
       "sourcePath": "src/server/routes.ts",
-      "contentHash": "6dd6ca2f8912d7e60e3210bb2db055b72b3c1cbb816598cff9d6a00c43413606",
+      "contentHash": "59884e1700f28276bccbc65f34b578851dd90c50ecbeb784bf32e46dd2817fb8",
       "since": "2025-01-01"
     },
     "route-group:topic-memory": {
@@ -666,7 +666,7 @@
       "type": "route-group",
       "domain": "memory",
       "sourcePath": "src/server/routes.ts",
-      "contentHash": "6dd6ca2f8912d7e60e3210bb2db055b72b3c1cbb816598cff9d6a00c43413606",
+      "contentHash": "59884e1700f28276bccbc65f34b578851dd90c50ecbeb784bf32e46dd2817fb8",
       "since": "2025-01-01"
     },
     "route-group:state-sync": {
@@ -674,7 +674,7 @@
       "type": "route-group",
       "domain": "coordination",
       "sourcePath": "src/server/routes.ts",
-      "contentHash": "6dd6ca2f8912d7e60e3210bb2db055b72b3c1cbb816598cff9d6a00c43413606",
+      "contentHash": "59884e1700f28276bccbc65f34b578851dd90c50ecbeb784bf32e46dd2817fb8",
       "since": "2025-01-01"
     },
     "route-group:intent": {
@@ -682,7 +682,7 @@
       "type": "route-group",
       "domain": "intent",
       "sourcePath": "src/server/routes.ts",
-      "contentHash": "6dd6ca2f8912d7e60e3210bb2db055b72b3c1cbb816598cff9d6a00c43413606",
+      "contentHash": "59884e1700f28276bccbc65f34b578851dd90c50ecbeb784bf32e46dd2817fb8",
       "since": "2025-01-01"
     },
     "route-group:triage": {
@@ -690,7 +690,7 @@
       "type": "route-group",
       "domain": "safety",
       "sourcePath": "src/server/routes.ts",
-      "contentHash": "6dd6ca2f8912d7e60e3210bb2db055b72b3c1cbb816598cff9d6a00c43413606",
+      "contentHash": "59884e1700f28276bccbc65f34b578851dd90c50ecbeb784bf32e46dd2817fb8",
       "since": "2025-01-01"
     },
     "route-group:operations": {
@@ -698,7 +698,7 @@
       "type": "route-group",
       "domain": "safety",
       "sourcePath": "src/server/routes.ts",
-      "contentHash": "6dd6ca2f8912d7e60e3210bb2db055b72b3c1cbb816598cff9d6a00c43413606",
+      "contentHash": "59884e1700f28276bccbc65f34b578851dd90c50ecbeb784bf32e46dd2817fb8",
       "since": "2025-01-01"
     },
     "route-group:sentinel": {
@@ -706,7 +706,7 @@
       "type": "route-group",
       "domain": "safety",
       "sourcePath": "src/server/routes.ts",
-      "contentHash": "6dd6ca2f8912d7e60e3210bb2db055b72b3c1cbb816598cff9d6a00c43413606",
+      "contentHash": "59884e1700f28276bccbc65f34b578851dd90c50ecbeb784bf32e46dd2817fb8",
       "since": "2025-01-01"
     },
     "route-group:trust": {
@@ -714,7 +714,7 @@
       "type": "route-group",
       "domain": "safety",
       "sourcePath": "src/server/routes.ts",
-      "contentHash": "6dd6ca2f8912d7e60e3210bb2db055b72b3c1cbb816598cff9d6a00c43413606",
+      "contentHash": "59884e1700f28276bccbc65f34b578851dd90c50ecbeb784bf32e46dd2817fb8",
       "since": "2025-01-01"
     },
     "route-group:monitoring": {
@@ -722,7 +722,7 @@
       "type": "route-group",
       "domain": "monitoring",
       "sourcePath": "src/server/routes.ts",
-      "contentHash": "6dd6ca2f8912d7e60e3210bb2db055b72b3c1cbb816598cff9d6a00c43413606",
+      "contentHash": "59884e1700f28276bccbc65f34b578851dd90c50ecbeb784bf32e46dd2817fb8",
       "since": "2025-01-01"
     },
     "route-group:commitments": {
@@ -730,7 +730,7 @@
       "type": "route-group",
       "domain": "commitments",
       "sourcePath": "src/server/routes.ts",
-      "contentHash": "6dd6ca2f8912d7e60e3210bb2db055b72b3c1cbb816598cff9d6a00c43413606",
+      "contentHash": "59884e1700f28276bccbc65f34b578851dd90c50ecbeb784bf32e46dd2817fb8",
       "since": "2025-01-01"
     },
     "route-group:episodes": {
@@ -738,7 +738,7 @@
       "type": "route-group",
       "domain": "memory",
       "sourcePath": "src/server/routes.ts",
-      "contentHash": "6dd6ca2f8912d7e60e3210bb2db055b72b3c1cbb816598cff9d6a00c43413606",
+      "contentHash": "59884e1700f28276bccbc65f34b578851dd90c50ecbeb784bf32e46dd2817fb8",
       "since": "2025-01-01"
     },
     "route-group:messages": {
@@ -746,7 +746,7 @@
       "type": "route-group",
       "domain": "coordination",
       "sourcePath": "src/server/routes.ts",
-      "contentHash": "6dd6ca2f8912d7e60e3210bb2db055b72b3c1cbb816598cff9d6a00c43413606",
+      "contentHash": "59884e1700f28276bccbc65f34b578851dd90c50ecbeb784bf32e46dd2817fb8",
       "since": "2025-01-01"
     },
     "route-group:system-reviews": {
@@ -754,7 +754,7 @@
       "type": "route-group",
       "domain": "monitoring",
       "sourcePath": "src/server/routes.ts",
-      "contentHash": "6dd6ca2f8912d7e60e3210bb2db055b72b3c1cbb816598cff9d6a00c43413606",
+      "contentHash": "59884e1700f28276bccbc65f34b578851dd90c50ecbeb784bf32e46dd2817fb8",
       "since": "2025-01-01"
     },
     "route-group:machine-mesh": {
@@ -770,7 +770,7 @@
       "type": "route-group",
       "domain": "security",
       "sourcePath": "src/server/routes.ts",
-      "contentHash": "6dd6ca2f8912d7e60e3210bb2db055b72b3c1cbb816598cff9d6a00c43413606",
+      "contentHash": "59884e1700f28276bccbc65f34b578851dd90c50ecbeb784bf32e46dd2817fb8",
       "since": "2025-01-01"
     },
     "cli:init": {

package/upgrades/1.3.792.md

@@ -0,0 +1,77 @@
+# Upgrade Guide — vNEXT
+
+<!-- assembled-by: assemble-next-md -->
+<!-- bump: patch -->
+
+## What Changed
+
+A signal-only **red-PR watchdog** on the existing green-PR auto-merge watcher. Green-PR
+auto-merge only ever acts on GREEN PRs, so a PR of mine that goes RED and *stays* red is
+invisible to it — which is exactly how PR #1399 sat red overnight on 2026-07-08 until the
+operator found it on his morning check-in (an operator-found escape). The watchdog closes
+that gap: after the merge logic runs each tick, it checks my own open PRs and raises ONE
+deduped, age-escalating attention line — `PR #N red for Xh — <failing check names>` — for
+any PR with a required check stuck RED past a threshold (default 2h). It is SIGNAL-ONLY:
+it never merges, closes, or blocks anything.
+
+- `src/monitoring/greenPrLogic.ts` — new pure helpers `latestRunPerCheck` (dedup a rollup
+  to the newest run per check name), `failingChecksFromRollup`, and `stuckRedChecks`; plus
+  a `failingChecks` field on `PrSummary`. **Correctness fix:** `deriveRollup` now dedups to
+  the latest run per check BEFORE collapsing — a stale FAILED run superseded by a passing
+  re-run previously still read `FAILURE` (the exact bug the overnight incident surfaced),
+  which also made the green-PR merger refuse an actually-green PR.
+- `src/monitoring/greenPrAutomergeWiring.ts` — `mapPr` populates `failingChecks` from the
+  same `statusCheckRollup` the list projection already fetches (no new gh call).
+- `src/monitoring/GreenPrAutoMerger.ts` — `tick()` runs `redPrWatchdogPass` after the merge
+  logic; a per-PR `redPrRaised` memory (in state) dedups to ONE item, re-raised only on age
+  escalation or a changed failing-check set, and cleared when the PR goes green / merges /
+  closes. New `redPrWatchdog` config (`{ enabled, redThresholdMs }`, default
+  `{ enabled: true, redThresholdMs: 7_200_000 }`).
+- `src/server/routes.ts` — `GET /green-pr-automerge` now returns `stuckRed[]` +
+  `redPrWatchdog` config so "why did I get a red-PR alert?" is answerable from state.
+- `src/config/ConfigDefaults.ts`, `src/core/types.ts`, `src/commands/server.ts` — the
+  config default, type, and constructor wiring.
+
+The watchdog runs only where the parent green-PR watcher already runs (a maintainer/dev
+agent with an analyzable instar repo + safe-merge); on every other install it is inert,
+exactly like the parent feature.
+
+## What to Tell Your User
+
+- **A pull request of mine that gets stuck RED now surfaces itself.** "If one of my own PRs
+  has a required check that keeps failing for more than a couple of hours, I'll raise a
+  single quiet heads-up in your attention queue — naming the PR, how long it has been red,
+  and which checks are failing — instead of it silently sitting there unmerged. You get one
+  item per stuck PR, not a stream; it updates as the PR ages, and it clears itself the moment
+  the PR goes green, merges, or closes." This only applies on the maintainer agent that runs
+  green-PR auto-merge; it never merges or closes anything on its own — it just tells you.
+- **A subtle merge bug got fixed too.** A PR whose failed check was later re-run green used
+  to still read as failed — which could stop it from auto-merging. Now the newest run of
+  each check wins, so a re-run-green PR is correctly seen as green.
+
+## Summary of New Capabilities
+
+| Capability | How to Use |
+|-----------|-----------|
+| A self-authored PR stuck RED past 2h raises ONE deduped attention line | Automatic wherever `monitoring.greenPrAutoMerge` is enabled |
+| See which of my PRs are flagged red and for how long | `GET /green-pr-automerge` → `stuckRed[]` + `redPrWatchdog` |
+| Tune the "stuck" threshold or turn the watchdog off | `monitoring.greenPrAutoMerge.redPrWatchdog` = `{ enabled, redThresholdMs }` |
+| Re-run-green PRs are no longer misread as failed | Automatic (`deriveRollup` latest-run dedup) |
+
+## Evidence
+
+- Unit (`tests/unit/green-pr-red-watchdog.test.ts`, 24): the pure helpers on both sides —
+  `latestRunPerCheck` keeps the newest run per check; `failingChecksFromRollup` /
+  `stuckRedChecks` flag past-threshold failures and skip fresh / unknown-time ones; the
+  `deriveRollup` latest-run-dedup regression (stale FAILED + later passing re-run → SUCCESS,
+  not FAILURE); and the orchestrator pass cases (a) raises one line past threshold, (b) none
+  below threshold, (c) re-run-green not stuck, (d) same PR two ticks → ONE item, (e) green →
+  none, (f) not-authored-by-me skipped, plus recovery/close clears, age-escalation re-raise,
+  disabled no-op, and the `redPrWatchdogView` read surface.
+- Unit (existing `green-pr-logic` / `green-pr-automerger` / `green-pr-automerge-wiring` /
+  `green-pr-layer2`, 92): unchanged behavior for single-run rollups — no regression.
+- Integration (`tests/integration/green-pr-automerge-routes.test.ts`, +2): `GET
+  /green-pr-automerge` surfaces `redPrWatchdog` config + an empty `stuckRed[]` when nothing
+  is red (feature-alive), and populates `stuckRed[]` after a tick over a stuck-red PR.
+- `npx tsc --noEmit` clean; the dark-gate ConfigDefaults line-map snapshot updated for the
+  +4 line shift (no new/removed dark features).

package/upgrades/side-effects/red-pr-watchdog.md

@@ -0,0 +1,131 @@
+# Side-Effects Review — Red-PR Watchdog
+
+**Version / slug:** `red-pr-watchdog`
+**Date:** `2026-07-09`
+**Author:** `Echo (instar-dev agent)`
+**Second-pass reviewer:** `Echo (self, second pass)`
+
+## Summary of the change
+
+A signal-only watchdog on the existing green-PR auto-merge watcher tick. After the merge
+logic runs, `redPrWatchdogPass` sweeps my own open PRs and raises ONE deduped,
+age-escalating attention line for any PR with a required check stuck RED past a threshold
+(default 2h). Files touched: `src/monitoring/greenPrLogic.ts` (new pure helpers
+`latestRunPerCheck` / `failingChecksFromRollup` / `stuckRedChecks`, a `failingChecks` field
+on `PrSummary`, and a correctness fix to `deriveRollup`), `src/monitoring/greenPrAutomergeWiring.ts`
+(`mapPr` populates `failingChecks`; `deriveRollup` dedups first), `src/monitoring/GreenPrAutoMerger.ts`
+(the pass + `redPrRaised` state memory + the `redPrWatchdogView` read + config),
+`src/server/routes.ts` (GET fields), `src/config/ConfigDefaults.ts`, `src/core/types.ts`,
+`src/commands/server.ts` (defaults/type/wiring). It is a DETECTOR only — it never merges,
+closes, arms, or blocks.
+
+## Decision-point inventory
+
+- `redPrWatchdogPass` (GreenPrAutoMerger.tick) — **add** — decides whether to RAISE an
+  attention line for a stuck-red self-authored PR. Signal-only; no blocking/merge authority.
+- `deriveRollup` (greenPrAutomergeWiring) — **modify** — the SUCCESS/PENDING/FAILURE verdict
+  now dedups to the latest run per check first. This IS consumed by the merge candidate
+  gate (`classifyCandidate` reads `statusRollup`), so the change is a correctness improvement
+  to an existing authority's input, not a new authority.
+
+---
+
+## 1. Over-block
+
+**What legitimate inputs does this change reject that it shouldn't?**
+
+The watchdog has no block/allow surface — it only raises attention, so it cannot over-block
+a message or a merge. The one behavior it could over-*alert* on is a genuinely-red PR that
+the operator already knows about; that is bounded to ONE deduped line per PR and clears on
+recovery, so the cost is a single ignorable heads-up. The `deriveRollup` fix makes the merge
+gate LESS restrictive (a re-run-green PR that previously read FAILURE now reads SUCCESS) —
+this is the correct direction; safe-merge re-verifies at act time, so a misread here can only
+cause a refusal, never an unintended merge.
+
+## 2. Under-block
+
+**What failure modes does this still miss?**
+
+- A failing check with an unknown `completedAt` (0) is deliberately NOT flagged — we cannot
+  prove it has been red long enough, so we fail toward silence. A rollup shape that never
+  carries a completed time would therefore never alert. Acceptable: the common case (GitHub
+  Actions CheckRun) always carries `completedAt`.
+- A PR that is red because it is *unmergeable* (conflicts) rather than a failed check is not
+  the watchdog's target — it watches failing checks, not merge conflicts. That is a separate
+  signal the merger already skips on.
+- A PR authored by me but on a branch outside my namespace is skipped (the author proxy is
+  the branch-namespace filter, since `listOpenPrs` already passes `--author @me`).
+
+## 3. Level-of-abstraction fit
+
+Right layer. The green-PR watcher already enumerates my open PRs with their check status
+every tick; the watchdog rides that existing loop and reuses the already-fetched rollup — no
+new gh call, no parallel poller. It feeds the existing attention-queue coalescing rather than
+inventing a new notification surface. A higher layer (a generic PR monitor) would duplicate
+the enumeration; a lower layer (the pure helpers) is where the check-dedup logic correctly
+lives and is unit-tested.
+
+## 4. Signal vs authority compliance
+
+Compliant. Per `docs/signal-vs-authority.md`, the watchdog is a pure SIGNAL producer: its
+only effect is `refreshAggregate` → an attention line. It holds NO blocking authority — it
+cannot merge, close, arm, disarm, or block a message. The brittle part (heuristic "is this
+check stuck red") is confined to the signal; no authority is gated on it. The `deriveRollup`
+change improves an existing detector's accuracy; it does not add a new authority.
+
+## 5. Interactions
+
+- Runs AFTER the merge logic and the Layer-2 snapshot in the same tick, so it never shadows
+  or races the merge path. It only reads `candidates` (already gathered) and writes its own
+  `redPrRaised` state slice + the shared `attentionLines` set.
+- Shares the aggregated attention item (`green-pr-automerge:aggregate`) with the merger's
+  other lines; the P17 attention coalescing dedups the ITEM, and the `redPrRaised` memory
+  dedups the LINE, so the two dedup layers stack rather than fight.
+- The `deriveRollup` fix is consumed by `classifyCandidate` (settled-green gate) — verified
+  no other consumer exists (grep: `deriveRollup` is used only in `mapPr`). Single-run rollups
+  are unchanged, so existing green/pending/failure classification is byte-identical.
+- No double-fire: the watchdog runs once per tick; a busy/disabled/breaker-open/list-failed
+  tick returns before it, so it never runs on stale data.
+
+## 6. External surfaces
+
+Adds two fields to `GET /green-pr-automerge` (`stuckRed`, `redPrWatchdog`) — additive, no
+removed fields, no breaking change to existing consumers. Raises attention lines visible to
+the operator (the intended surface). No change visible to other agents or peers. It depends
+on the green-PR watcher's tick cadence and the gh rollup shape, both already in use.
+
+## 6b. Operator-surface quality
+
+No operator-surface file (no `dashboard/*` renderer, approval page, or grant/secret form) is
+touched — the only operator-visible output is a plain-English attention line and a JSON read
+field, both already-established surfaces. Operator-surface quality: the attention line leads
+with the action ("PR #N red for Xh — <checks>"), exposes no raw internals, and reads at phone
+width. No raw technical input is ever requested from the operator.
+
+## 7. Multi-machine posture (Cross-Machine Coherence)
+
+**Machine-local BY DESIGN**, inheriting the parent green-PR watcher's posture exactly. The
+green-PR watcher's state (`state/green-pr-automerge.json`) is per-machine and lease-gated —
+ticks run only on the lease holder. The `redPrRaised` memory lives in that same per-machine
+state file and is therefore never replicated; the watchdog only runs on the machine holding
+the serving lease, so there is no double-alert across machines. The attention item it raises
+is one-voice by construction (the shared `green-pr-automerge:aggregate` id + P17 coalescing).
+No durable state strands on topic transfer (it is watcher-state, not topic-state), and it
+generates no cross-machine URLs. This matches how green-pr-automerge already behaves.
+
+## 8. Rollback cost
+
+Cheap. Revert the PR — the watchdog is signal-only, so there is no data migration and no agent
+state to repair (the `redPrRaised` slice is ignored by older code and re-derived each tick).
+Softer levers without a revert: set `monitoring.greenPrAutoMerge.redPrWatchdog.enabled: false`
+to turn just the watchdog off, or raise `redThresholdMs`. The `deriveRollup` fix is the only
+behavioral change to an existing path; if it were ever wrong it would make the merger MORE
+conservative (skip), never over-merge — safe-merge remains the act-time authority.
+
+## Self-action note
+
+`unbounded-self-action`: n/a — the watchdog performs no self-triggered control action (no
+restart / respawn / spawn / kill / swap / retry / re-drive). Its only effect is raising an
+attention line, and that is bounded by the per-PR `redPrRaised` dedup memory (ONE line per
+stuck PR, re-raised only on age-escalation, cleared on recovery) — so it converges under
+sustained pressure rather than emitting unboundedly.