instar 1.3.1336 → 1.3.1338

package/dashboard/feedback-triage.js

@@ -70,15 +70,52 @@ export function summaryText(summary) {
   return parts.join(' ');
 }
 
+const EXECUTION_WORDS = {
+  queued: '', running: ' (being worked on)', 'pr-open': ' (fix waiting for your approval)', 'spec-pr-open': ' (design draft waiting for your approval)',
+  merged: ' (fixed — checking it stays fixed)', failed: ' (the last attempt did not work)',
+};
+
 export function queueRowText(item) {
   const sev = item.severity || 'unrated';
   const title = String(item.title || item.clusterId || 'A feedback item').slice(0, 140);
-  return `${item.rank}. [${sev}] ${title}${item.summary ? ` — ${String(item.summary).slice(0, 200)}` : ''}`;
+  const state = EXECUTION_WORDS[item.executionState] || '';
+  return `${item.rank}. [${sev}] ${title}${state}${item.summary ? ` — ${String(item.summary).slice(0, 200)}` : ''}`;
+}
+
+const EXECUTOR_REASON_WORDS = {
+  ok: 'ready to work on the top items',
+  'dry-run': 'in practice mode: it picks what it would work on but starts nothing',
+  disabled: 'turned off',
+  'no-source-repo': 'not available here (no copy of the source code on this machine)',
+  'github-unavailable': 'waiting: GitHub could not be reached',
+  'auto-merge-disabled': 'waiting: the repository does not allow auto-merge',
+  'approver-unset': 'waiting: no approver is set for this organization repository',
+  'approver-not-independent': 'waiting for you: this agent could approve its own fixes as the repository owner, so it needs your one-time PIN acceptance (or leave it off)',
+  'profile-unenforceable': 'stopped: the sandbox check did not hold, so no attempts start (retried daily)',
+  'deps-unavailable': 'waiting: installing the code dependencies failed (retrying)',
+  'publish-fork-unset': 'waiting: no fork is set to publish fixes from (feedbackFactory.execute.publishRepo), so no new attempts start',
+  'not-canonical-owner': 'runs on another machine',
+  'not-checked-yet': 'not checked yet',
+};
+
+/** One plain paragraph for the executor status. */
+export function executorText(status) {
+  if (!status) return 'The fix worker is not available on this machine.';
+  const words = EXECUTOR_REASON_WORDS[status.reason] || status.reason || 'unknown';
+  const parts = [`The fix worker is ${words}.`];
+  if (typeof status.live === 'number') parts.push(`${status.live} attempt(s) running, ${status.openPrs || 0} fix(es) waiting for review, ${status.startsToday || 0} started today.`);
+  return parts.join(' ');
+}
+
+/** Attempts parked because some files look like they contain a secret (names only). */
+export function heldSecretAttempts(status) {
+  return ((status && status.attempts) || []).filter((a) => a.state === 'held' && a.reason === 'needs-review-secret-shape');
 }
 
 /**
  * Render the Triage section into `target`.
- * handlers: submitAuthority(action, pin) → note; planIgnoreLive(enabled) → plan|null; commitPlan(plan, pin) → note.
+ * handlers: submitAuthority(action, pin) → note; planIgnoreLive(enabled) → plan|null; planExecutorAction(request) → plan|null;
+ * commitPlan(plan, pin) → note.
  */
 export function renderTriageSection(doc, target, data, handlers = {}) {
   if (!target) return;
@@ -133,6 +170,42 @@ export function renderTriageSection(doc, target, data, handlers = {}) {
   card.appendChild(note);
   target.appendChild(card);
 
+  // Executor card: its state in plain words, and the two PIN-only executor actions.
+  if (data.execute !== undefined) {
+    const ex = el(doc, 'div', 'spend-arm-plan');
+    ex.appendChild(el(doc, 'div', 'spend-arm-plan-label', 'Fixing the top items'));
+    ex.appendChild(el(doc, 'div', 'ph-detail-body', executorText(data.execute)));
+    const exBtns = el(doc, 'div', 'spend-arm-btns');
+    const exPlan = el(doc, 'div', 'spend-arm-plan-text');
+    const offer = (label, actionKey, request) => {
+      if (typeof handlers.planExecutorAction !== 'function' || typeof handlers.commitPlan !== 'function') return;
+      const b = el(doc, 'button', 'spend-arm-btn', label);
+      b.setAttribute('data-ft-action', `plan-${actionKey}`);
+      b.addEventListener('click', async () => {
+        note.textContent = 'Working…';
+        const plan = await handlers.planExecutorAction(request);
+        if (!plan || !plan.planId) { note.textContent = 'Could not prepare that change. Nothing has changed.'; return; }
+        exPlan.textContent = plan.renderedText;
+        ex.insertBefore(exPlan, exBtns);
+        const confirm = el(doc, 'button', 'spend-arm-btn spend-arm-btn-commit', 'Confirm with PIN');
+        confirm.setAttribute('data-ft-action', `commit-${actionKey}`);
+        confirm.addEventListener('click', async () => { note.textContent = 'Working…'; note.textContent = await handlers.commitPlan(plan, (pin.value || '').trim()); });
+        exBtns.appendChild(confirm);
+        note.textContent = 'Read the change above, enter your PIN in the box above, then confirm.';
+      });
+      exBtns.appendChild(b);
+    };
+    if (data.execute && data.execute.reason === 'approver-not-independent') {
+      offer('Let it run anyway…', 'accept-approver-dependence', { action: 'accept-approver-dependence' });
+    }
+    for (const attempt of heldSecretAttempts(data.execute).slice(0, 5)) {
+      ex.appendChild(el(doc, 'div', 'spend-arm-note', `Held: a fix touched files that look like they hold a secret (${(attempt.secretFiles || []).slice(0, 5).join(', ')}).`));
+      offer('Review and publish…', 'publish-secret-shape', { action: 'publish-secret-shape', attemptId: attempt.attemptId });
+    }
+    ex.appendChild(exBtns);
+    target.appendChild(ex);
+  }
+
   // Ranked queue.
   const items = (data.queue && Array.isArray(data.queue.items)) ? data.queue.items : [];
   const list = el(doc, 'div', 'ph-detail-body');

package/dashboard/index.html

@@ -10557,8 +10557,9 @@
       }
       const M = __ftModule;
       const get = async (url) => { try { return await apiFetch(url); } catch { return null; } };
-      const [summary, queue, proposal] = await Promise.all([
+      const [summary, queue, proposal, execute] = await Promise.all([
         get('/feedback-factory/triage/summary'), get('/feedback-factory/triage/queue'), get('/feedback-factory/triage/authority/proposal'),
+        get('/feedback-factory/execute/status'),
       ]);
       const post = async (url, body) => {
         const response = await fetch(url, {
@@ -10568,7 +10569,7 @@
         });
         return { ok: response.ok, data: await response.json().catch(() => ({})) };
       };
-      M.renderTriageSection(document, root, { summary, queue, proposal }, {
+      M.renderTriageSection(document, root, { summary, queue, proposal, execute }, {
         submitAuthority: async (action, pin) => {
           const r = await post('/feedback-factory/triage/authority', M.triageAuthorityRequest(action, pin, M.newTriageDecisionRef()));
           const note = M.triageResultNote(r.ok, r.data);
@@ -10579,9 +10580,16 @@
           const r = await post('/feedback-factory/triage/plan', { action: 'ignore-live', enabled });
           return r.ok ? r.data : null;
         },
+        planExecutorAction: async (request) => {
+          const r = await post('/feedback-factory/triage/plan', request);
+          return r.ok ? r.data : null;
+        },
         commitPlan: async (plan, pin) => {
           const r = await post('/feedback-factory/triage/commit', { pin, planId: plan.planId, nonce: plan.nonce });
-          const note = r.ok ? (r.data.ignoreLive ? 'Done: ignores are live.' : 'Done: ignores are back in practice mode.') : M.triageResultNote(false, r.data);
+          const note = !r.ok ? M.triageResultNote(false, r.data)
+            : r.data.action === 'accept-approver-dependence' ? 'Done: the fix worker may run. Every fix still needs your GitHub approval to merge.'
+            : r.data.action === 'publish-secret-shape' ? `Done: published as pull request #${r.data.prNumber}.`
+            : (r.data.ignoreLive ? 'Done: ignores are live.' : 'Done: ignores are back in practice mode.');
           if (r.ok) await loadFeedbackTriage(note);
           return note;
         },

package/dist/commands/server.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"server.d.ts","sourceRoot":"","sources":["../../src/commands/server.ts"],"names":[],"mappings":"AAuGA,OAAO,EAAE,cAAc,EAAwD,MAAM,2BAA2B,CAAC;AAUjH,OAAO,EAAE,eAAe,EAAiC,MAAM,iCAAiC,CAAC;AA4BjG,OAAO,EAAE,WAAW,EAAE,MAAM,0BAA0B,CAAC;AAGvD,OAAO,EAAE,YAAY,EAAE,MAAM,+BAA+B,CAAC;AAqI7D,OAAO,KAAK,EAAW,oBAAoB,EAAE,WAAW,EAAE,YAAY,EAAE,MAAM,kBAAkB,CAAC;AACjG,OAAO,EAAE,WAAW,EAAE,MAAM,yBAAyB,CAAC;AAmFtD;;;;;;;;;;;;;;;;;GAiBG;AACH,wBAAgB,yBAAyB,CACvC,IAAI,EAAE,MAAM,EACZ,OAAO,EAAE,MAAM,EACf,gBAAgB,EAAE,MAAM,GAAG,IAAI,GAAG,SAAS,GAC1C,OAAO,CAUT;AA0ID,UAAU,YAAY;IACpB,UAAU,CAAC,EAAE,OAAO,CAAC;IACrB,GAAG,CAAC,EAAE,MAAM,CAAC;IACb;2DACuD;IACvD,QAAQ,CAAC,EAAE,OAAO,CAAC;CACpB;AAoDD,+EAA+E;AAC/E,wBAAgB,qCAAqC,CACnD,SAAS,EAAE,IAAI,CAAC,OAAO,2BAA2B,EAAE,cAAc,EAAE,QAAQ,CAAC,GAAG,IAAI,EACpF,OAAO,EAAE,MAAM,GACd,IAAI,CAEN;AA8fD,wBAAsB,oBAAoB,CACxC,cAAc,EAAE,cAAc,EAC9B,QAAQ,EAAE,eAAe,EACzB,WAAW,EAAE,MAAM,EACnB,OAAO,EAAE,MAAM,EACf,aAAa,CAAC,EAAE,MAAM,EACtB,WAAW,CAAC,EAAE,WAAW,EACzB,WAAW,CAAC,EAAE,WAAW,EACzB,kBAAkB,CAAC,EAAE,MAAM;AAC3B;;qCAEqC;AACrC,WAAW,CAAC,EAAE;IAAE,UAAU,CAAC,EAAE,MAAM,CAAC;IAAC,SAAS,CAAC,EAAE,MAAM,CAAA;CAAE;AACzD;;wEAEwE;AACxE,SAAS,CAAC,EAAE;IACV,GAAG,CAAC,EAAE,MAAM,CAAC;IACb,qBAAqB,CAAC,EAAE,OAAO,CAAC;IAChC;;;sEAGkE;IAClE,WAAW,CAAC,EAAE,OAAO,CAAC;CACvB,GACA,OAAO,CAAC,MAAM,CAAC,CAqYjB;AA02BD;;;;;;;;GAQG;AACH,wBAAgB,wBAAwB,CACtC,MAAM,EAAE,YAAY,EACpB,YAAY,EAAE,oBAAoB,GAAG,IAAI,GACxC;IACD,YAAY,EAAE,oBAAoB,GAAG,IAAI,CAAC;IAC1C,OAAO,EAAE,OAAO,CAAC;IACjB,MAAM,EAAE,OAAO,CAAC;IAChB,aAAa,EAAE,MAAM,CAAC;IACtB,SAAS,EAAE,MAAM,CAAC;IAClB,YAAY,EAAE,MAAM,CAAC;IACrB,SAAS,EAAE,MAAM,GAAG,UAAU,GAAG,SAAS,CAAC;IAC3C,QAAQ,EAAE,MAAM,CAAC;CAClB,CAqBA;AAED,wBAAgB,mBAAmB,CACjC,QAAQ,EAAE,eAAe,EACzB,cAAc,EAAE,cAAc,EAC9B,YAAY,CAAC,EAAE,YAAY,EAC3B,WAAW,CAAC,EAAE,WAAW,EACzB,WAAW,CAAC,EAAE,WAAW,EACzB,iBAAiB,CAAC,EAAE,CAAC,OAAO,EAAE,MAAM,EAAE,IAAI,EAAE,MAAM,KAAK,OAAO,CAAC,OAAO,CAAC,EAGvE,UAAU,CAAC,EAAE,MAAM,OAAO,8BAA8B,EAAE,WAAW,GAAG,IAAI,EAK5E,qBAAqB,CAAC,EAAE,MAAM,OAAO,gCAAgC,EAAE,kBAAkB,GAAG,IAAI,EAKhG,mBAAmB,CAAC,EAAE,MAAM,MAAM,GAAG,IAAI,GAAG,SAAS,EAQrD,oBAAoB,CAAC,EAAE,MAAM;IAC3B,YAAY,EAAE,OAAO,kBAAkB,EAAE,oBAAoB,GAAG,IAAI,CAAC;IACrE,OAAO,EAAE,OAAO,CAAC;IACjB,MAAM,EAAE,OAAO,CAAC;IAChB,aAAa,EAAE,MAAM,CAAC;IACtB,SAAS,EAAE,MAAM,CAAC;IAClB,YAAY,EAAE,MAAM,CAAC;IACrB,SAAS,EAAE,MAAM,GAAG,UAAU,GAAG,SAAS,CAAC;IAC3C,QAAQ,EAAE,MAAM,CAAC;CAClB,GAAG,IAAI,GACP,IAAI,CA8yBN;AAgmBD,wBAAsB,WAAW,CAAC,OAAO,EAAE,YAAY,GAAG,OAAO,CAAC,IAAI,CAAC,CAw8wBtE;AAED,wBAAsB,UAAU,CAAC,OAAO,EAAE;IAAE,GAAG,CAAC,EAAE,MAAM,CAAA;CAAE,GAAG,OAAO,CAAC,IAAI,CAAC,CAsDzE;AAED;;;;;;;;;;;GAWG;AACH,wBAAsB,aAAa,CAAC,OAAO,EAAE;IAAE,GAAG,CAAC,EAAE,MAAM,CAAA;CAAE,GAAG,OAAO,CAAC,IAAI,CAAC,CAuD5E"}
+{"version":3,"file":"server.d.ts","sourceRoot":"","sources":["../../src/commands/server.ts"],"names":[],"mappings":"AAwGA,OAAO,EAAE,cAAc,EAAwD,MAAM,2BAA2B,CAAC;AAUjH,OAAO,EAAE,eAAe,EAAiC,MAAM,iCAAiC,CAAC;AA4BjG,OAAO,EAAE,WAAW,EAAE,MAAM,0BAA0B,CAAC;AAGvD,OAAO,EAAE,YAAY,EAAE,MAAM,+BAA+B,CAAC;AAqI7D,OAAO,KAAK,EAAW,oBAAoB,EAAE,WAAW,EAAE,YAAY,EAAE,MAAM,kBAAkB,CAAC;AACjG,OAAO,EAAE,WAAW,EAAE,MAAM,yBAAyB,CAAC;AAmFtD;;;;;;;;;;;;;;;;;GAiBG;AACH,wBAAgB,yBAAyB,CACvC,IAAI,EAAE,MAAM,EACZ,OAAO,EAAE,MAAM,EACf,gBAAgB,EAAE,MAAM,GAAG,IAAI,GAAG,SAAS,GAC1C,OAAO,CAUT;AA0ID,UAAU,YAAY;IACpB,UAAU,CAAC,EAAE,OAAO,CAAC;IACrB,GAAG,CAAC,EAAE,MAAM,CAAC;IACb;2DACuD;IACvD,QAAQ,CAAC,EAAE,OAAO,CAAC;CACpB;AAoDD,+EAA+E;AAC/E,wBAAgB,qCAAqC,CACnD,SAAS,EAAE,IAAI,CAAC,OAAO,2BAA2B,EAAE,cAAc,EAAE,QAAQ,CAAC,GAAG,IAAI,EACpF,OAAO,EAAE,MAAM,GACd,IAAI,CAEN;AA8fD,wBAAsB,oBAAoB,CACxC,cAAc,EAAE,cAAc,EAC9B,QAAQ,EAAE,eAAe,EACzB,WAAW,EAAE,MAAM,EACnB,OAAO,EAAE,MAAM,EACf,aAAa,CAAC,EAAE,MAAM,EACtB,WAAW,CAAC,EAAE,WAAW,EACzB,WAAW,CAAC,EAAE,WAAW,EACzB,kBAAkB,CAAC,EAAE,MAAM;AAC3B;;qCAEqC;AACrC,WAAW,CAAC,EAAE;IAAE,UAAU,CAAC,EAAE,MAAM,CAAC;IAAC,SAAS,CAAC,EAAE,MAAM,CAAA;CAAE;AACzD;;wEAEwE;AACxE,SAAS,CAAC,EAAE;IACV,GAAG,CAAC,EAAE,MAAM,CAAC;IACb,qBAAqB,CAAC,EAAE,OAAO,CAAC;IAChC;;;sEAGkE;IAClE,WAAW,CAAC,EAAE,OAAO,CAAC;CACvB,GACA,OAAO,CAAC,MAAM,CAAC,CAqYjB;AA02BD;;;;;;;;GAQG;AACH,wBAAgB,wBAAwB,CACtC,MAAM,EAAE,YAAY,EACpB,YAAY,EAAE,oBAAoB,GAAG,IAAI,GACxC;IACD,YAAY,EAAE,oBAAoB,GAAG,IAAI,CAAC;IAC1C,OAAO,EAAE,OAAO,CAAC;IACjB,MAAM,EAAE,OAAO,CAAC;IAChB,aAAa,EAAE,MAAM,CAAC;IACtB,SAAS,EAAE,MAAM,CAAC;IAClB,YAAY,EAAE,MAAM,CAAC;IACrB,SAAS,EAAE,MAAM,GAAG,UAAU,GAAG,SAAS,CAAC;IAC3C,QAAQ,EAAE,MAAM,CAAC;CAClB,CAqBA;AAED,wBAAgB,mBAAmB,CACjC,QAAQ,EAAE,eAAe,EACzB,cAAc,EAAE,cAAc,EAC9B,YAAY,CAAC,EAAE,YAAY,EAC3B,WAAW,CAAC,EAAE,WAAW,EACzB,WAAW,CAAC,EAAE,WAAW,EACzB,iBAAiB,CAAC,EAAE,CAAC,OAAO,EAAE,MAAM,EAAE,IAAI,EAAE,MAAM,KAAK,OAAO,CAAC,OAAO,CAAC,EAGvE,UAAU,CAAC,EAAE,MAAM,OAAO,8BAA8B,EAAE,WAAW,GAAG,IAAI,EAK5E,qBAAqB,CAAC,EAAE,MAAM,OAAO,gCAAgC,EAAE,kBAAkB,GAAG,IAAI,EAKhG,mBAAmB,CAAC,EAAE,MAAM,MAAM,GAAG,IAAI,GAAG,SAAS,EAQrD,oBAAoB,CAAC,EAAE,MAAM;IAC3B,YAAY,EAAE,OAAO,kBAAkB,EAAE,oBAAoB,GAAG,IAAI,CAAC;IACrE,OAAO,EAAE,OAAO,CAAC;IACjB,MAAM,EAAE,OAAO,CAAC;IAChB,aAAa,EAAE,MAAM,CAAC;IACtB,SAAS,EAAE,MAAM,CAAC;IAClB,YAAY,EAAE,MAAM,CAAC;IACrB,SAAS,EAAE,MAAM,GAAG,UAAU,GAAG,SAAS,CAAC;IAC3C,QAAQ,EAAE,MAAM,CAAC;CAClB,GAAG,IAAI,GACP,IAAI,CA8yBN;AAgmBD,wBAAsB,WAAW,CAAC,OAAO,EAAE,YAAY,GAAG,OAAO,CAAC,IAAI,CAAC,CAk9wBtE;AAED,wBAAsB,UAAU,CAAC,OAAO,EAAE;IAAE,GAAG,CAAC,EAAE,MAAM,CAAA;CAAE,GAAG,OAAO,CAAC,IAAI,CAAC,CAsDzE;AAED;;;;;;;;;;;GAWG;AACH,wBAAsB,aAAa,CAAC,OAAO,EAAE;IAAE,GAAG,CAAC,EAAE,MAAM,CAAA;CAAE,GAAG,OAAO,CAAC,IAAI,CAAC,CAuD5E"}

package/dist/commands/server.js

@@ -59,6 +59,7 @@ import { TopicReachabilityVerifier } from '../monitoring/TopicReachabilityVerifi
 import { probeTranscript } from '../monitoring/transcriptProber.js';
 import { SingleInstanceLock, installReleaseHandlers } from '../core/SingleInstanceLock.js';
 import { resolveDevAgentGate, resolveStateSyncStores } from '../core/devAgentGate.js';
+import { resolveRelayUnknownSenderTrustMode } from '../threadline/relayUnknownSenderTrust.js';
 import { resolveAntiThrashKnobs, readingValidity } from '../core/SwapAntiThrash.js';
 import { shouldReleaseOnComplete, planClaimOnSpawn, ownershipNonce } from '../core/ownershipFollowsLiveWork.js';
 import { PrHandLease } from '../core/PrHandLease.js';
@@ -17130,6 +17131,13 @@ export async function startServer(options) {
                         credentialShareEnforced: vp?.credentialShareEnforced ?? false,
                     };
                 },
+                // Relay unknown-sender trust (docs/specs/a2a-relay-unknown-sender-trust.md).
+                // Read live per message: `enabled` omitted rides the developmentAgent gate,
+                // `dryRun` defaults true (observe + count, deliver as today).
+                getRelayUnknownSenderTrustMode: () => resolveRelayUnknownSenderTrustMode({
+                    enabled: liveConfig.get('threadline.relayUnknownSenderTrust.enabled', undefined),
+                    dryRun: liveConfig.get('threadline.relayUnknownSenderTrust.dryRun', undefined),
+                }, config),
             });
             threadlineHandshake = threadline.handshakeManager;
             threadlineShutdown = threadline.shutdown;