insta 0.0.42 → 0.0.44

package/README.md

@@ -157,7 +157,7 @@ That host is a CloudFront cache, so after a change to the installer it can serve
 previous copy for up to about a day. This form is equivalent and always current:
 
 ```bash
-curl -fsSL https://raw.githubusercontent.com/InsForge/insta-cli/main/install.sh | sh -s -- --agents --staging -y
+curl -fsSL https://raw.githubusercontent.com/InsForge/insta-cli/main/install.sh | sh -s -- --agents --staging
 ```
 
 If the environment cannot be applied — an installed CLI older than 0.0.23 has no `insta

package/dist/commands/setup.js

@@ -6,7 +6,7 @@
 // Stack skills (tigris/better-auth) intentionally stay per-project: their presence in a
 // project doubles as its stack manifest — that install happens on `project create|link`.
 import { spawn } from 'node:child_process';
-import { existsSync, readFileSync, statSync } from 'node:fs';
+import { closeSync, createReadStream, existsSync, openSync, readFileSync, statSync } from 'node:fs';
 import { dirname, join } from 'node:path';
 import os from 'node:os';
 import { createInterface } from 'node:readline';
@@ -74,13 +74,13 @@ export function parseInstalledAgents(output) {
 export function summarizeInstall(output) {
     const { count, names } = parseInstalledAgents(output);
     if (count === 0)
-        return '✓ insta skill installed for your coding agents';
+        return '✓ Agents set up';
     const shown = names.slice(0, 6);
     const more = count - shown.length;
     const list = shown.length
         ? shown.join(', ') + (more > 0 ? `, +${more} more` : '')
         : `${count} agent${count === 1 ? '' : 's'}`;
-    return `✓ Agent skills — ${list}`;
+    return `✓ Agents — ${list}`;
 }
 // ---- CLI self-install (makes `npx -y insta setup agent` a complete one-liner) ----
 // Under npx the CLI runs from the npm cache and vanishes when the process exits — but the skill
@@ -357,8 +357,55 @@ export function shouldOfferLogin(yes, loggedIn, stdinTty, stdoutTty) {
 // One Enter continues into the browser login; only an explicit n/no declines. Matches the
 // curl-installer feel: the single command carries you as far as automation can go, and the one
 // genuinely human step (authorizing in the browser) starts itself instead of being homework.
+// Where to read the answer from. Under `curl … | sh` stdin is the SCRIPT pipe, not the human —
+// but the controlling terminal can still answer, via /dev/tty (the standard installer trick;
+// Homebrew prompts the same way). Never on Windows (no /dev/tty, and the curl path doesn't exist
+// there), and never without one (agents, CI, cron — openSync fails, so they can't be prompted).
+/** Wrap an already-open fd as a prompt input with SINGLE-OWNER cleanup: the stream owns the fd
+ *  (autoClose), close() only destroys the stream, and post-close stream errors are swallowed.
+ *  ReadStream.destroy() closes the fd asynchronously on Node 20, so a second closeSync here
+ *  would race it into an unhandled EBADF right after the user answers. */
+export function makePromptSource(fd) {
+    const stream = createReadStream('', { fd, autoClose: true });
+    stream.on('error', () => { });
+    return { input: stream, close: () => { try {
+            stream.destroy();
+        }
+        catch { /* already destroyed */ } } };
+}
+const openPromptInput = () => {
+    if (process.stdin.isTTY)
+        return { input: process.stdin, close: () => { } };
+    if (process.platform === 'win32')
+        return null;
+    try {
+        return makePromptSource(openSync('/dev/tty', 'r'));
+    }
+    catch {
+        return null;
+    }
+};
+/** Whether a human can answer a prompt at all: an interactive stdin, or a reachable /dev/tty
+ *  (the curl|sh case). The stdout-TTY requirement lives in shouldOfferLogin — an agent piping
+ *  our output must never be prompted even though its process may have a controlling terminal. */
+export function canPromptViaTty() {
+    if (process.stdin.isTTY)
+        return true;
+    if (process.platform === 'win32')
+        return false;
+    try {
+        closeSync(openSync('/dev/tty', 'r'));
+        return true;
+    }
+    catch {
+        return false;
+    }
+}
 const defaultAsk = async (question) => {
-    const rl = createInterface({ input: process.stdin, output: process.stdout });
+    const src = openPromptInput();
+    if (!src)
+        return false; // gate said yes but the terminal vanished — decline, never hang
+    const rl = createInterface({ input: src.input, output: process.stdout });
     // EOF (Ctrl-D) closes the interface without ever answering the question — resolve that as a
     // decline instead of hanging forever after the checkmarks.
     const answer = await new Promise((resolve) => {
@@ -366,12 +413,13 @@ const defaultAsk = async (question) => {
         rl.question(question, resolve);
     });
     rl.close();
+    src.close();
     return !/^n/i.test(answer.trim());
 };
 export async function setupAgent(opts, run = defaultRunner, mint, installConfigs = installAgentConfigs, ensure = (r) => ensureCliInstalled(r), readStored = readPersistedGlobal, switchEnv = (n) => envUse(n), loginFlow = {
     ask: defaultAsk,
     login: () => loginOauth('github', {}),
-    stdinTty: !!process.stdin.isTTY,
+    stdinTty: canPromptViaTty(),
     stdoutTty: !!process.stdout.isTTY,
 }) {
     if (!opts.yes && !process.stdout.isTTY) {
@@ -392,8 +440,8 @@ export async function setupAgent(opts, run = defaultRunner, mint, installConfigs
     const { env, skills } = await resolveEnv();
     const args = setupArgs(skills);
     info(env && env !== DEFAULT_ENV
-        ? `setting up coding-agent skills (${env}) …`
-        : 'setting up coding-agent skills …');
+        ? `setting up your coding agents (${env}) …`
+        : 'setting up your coding agents …');
     const res = await run('npx', args);
     if (!res.ok) {
         info('  skill install failed — install manually with:');
@@ -409,9 +457,9 @@ export async function setupAgent(opts, run = defaultRunner, mint, installConfigs
         process.exitCode = 1;
         return;
     }
-    info(summarizeInstall(res.output ?? ''));
-    // Register everything first, summarize ONCE below: Claude Code via `claude mcp add`, every other
-    // agent via a config-file entry — different mechanisms, one outcome, one line.
+    // Register everything first, then summarize ONCE below: the skill files, Claude Code's
+    // `claude mcp add`, and the config-file MCP entries are three mechanisms with one outcome —
+    // "your agents are ready" — so they get one line, not three inventories of agent names.
     let claude = await registerMcp(run, mint, !!opts.mcpToken, false);
     const others = await installConfigs();
     // Default into login on an interactive terminal (see shouldOfferLogin) BEFORE the MCP summary:
@@ -434,21 +482,18 @@ export async function setupAgent(opts, run = defaultRunner, mint, installConfigs
             }
         }
     }
-    // The one MCP line. The restart note exists because config-file agents only read their config
-    // at startup; Claude Code picks it up live.
-    const mcpTargets = [...(claude === 'new' || claude === 'existing' ? ['Claude Code'] : []), ...others];
-    if (mcpTargets.length) {
-        info(`✓ MCP — ${mcpTargets.join(', ')}${others.length ? ' (already-running tools load it on restart)' : ''}`);
-    }
+    // THE summary line. The restart note exists because config-file agents only read their MCP
+    // config at startup; the skill files need no restart.
+    const mcpOk = claude === 'new' || claude === 'existing' || others.length > 0;
+    info(`${summarizeInstall(res.output ?? '')} — ready to use InstaCloud${mcpOk ? ' (skill + MCP; restart any open tools)' : ''}`);
     if (claude === 'new' && !opts.mcpToken) {
         info('  Claude Code first use: run `/mcp` and authorize in the browser (headless machines: `insta setup agent --mcp-token`)');
     }
-    // The checkmarks end the install, but the user's next move shouldn't be guesswork. Agent-first:
-    // the whole point of setup is that the machine's coding agents now know InstaCloud (skill + MCP)
-    // and can drive `insta` themselves — project create/link, deploys, and (via the device flow)
-    // even login. The human's next move is simply to go build.
+    // The user's next move: one concrete action, not a concept. The agents drive `insta` themselves
+    // (project create/link, deploys, login via the device flow), so the human just asks for the
+    // thing they actually want.
     info(loggedIn
-        ? 'next: open a coding-agent session in your app directory and keep building — your agents know InstaCloud now'
-        : 'next: open a coding-agent session in your app directory and keep building — your agents know InstaCloud now (they will walk you through `insta login` when it is needed)');
+        ? 'next: open your coding agent inside your app and start building — ask it to "deploy this app on InstaCloud" when you\'re ready'
+        : 'next: open your coding agent inside your app and start building — ask it to "deploy this app on InstaCloud" when you\'re ready (it will walk you through `insta login`)');
 }
 //# sourceMappingURL=setup.js.map

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "insta",
-  "version": "0.0.42",
+  "version": "0.0.44",
   "type": "module",
   "description": "InstaCloud CLI — a thin client of the platform control-plane API.",
   "keywords": [