ingeni-validation 1.1.9 → 1.1.10

package/ingeni-validation.js

@@ -339,6 +339,7 @@ async function isValidStopDetails(stop_details){
 
         const stop_id = keys[0];
 
+        // stop id must be numeric
         if (!/^\d+$/.test(stop_id)){
             return false;
         }
@@ -351,32 +352,34 @@ async function isValidStopDetails(stop_details){
 
         let [stop_name, arrival_time, departure_time, latlong] = values;
 
+        // stop name
         if (typeof stop_name !== "string" || stop_name.trim().length === 0){
             return false;
         }
 
+        // time validation
         if (!timeRegex.test(arrival_time) || !timeRegex.test(departure_time)){
             return false;
         }
 
-        // allow equal time
+        // arrival must be <= departure
         if (toMinutes(arrival_time) > toMinutes(departure_time)){
             return false;
         }
 
-        // lat,long optional
-        if (latlong !== ""){
-
-            if (typeof latlong !== "string" || !latlongRegex.test(latlong)){
-                return false;
-            }
-
-            let [lat, lon] = latlong.split(",").map(Number);
+        // coordinates mandatory
+        if (typeof latlong !== "string" || latlong.trim().length === 0){
+            return false;
+        }
 
-            if (lat < -90 || lat > 90) return false;
-            if (lon < -180 || lon > 180) return false;
+        if (!latlongRegex.test(latlong)){
+            return false;
         }
 
+        let [lat, lon] = latlong.split(",").map(Number);
+
+        if (lat < -90 || lat > 90) return false;
+        if (lon < -180 || lon > 180) return false;
     }
 
     return true;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ingeni-validation",
-  "version": "1.1.9",
+  "version": "1.1.10",
   "description": "Ingeni Validation",
   "license": "ISC",
   "author": "",