indexeddbshim 16.1.0 → 17.1.0

package/src/IDBObjectStore.js

@@ -18,8 +18,9 @@ const readonlyProperties = ['keyPath', 'indexNames', 'transaction', 'autoIncreme
 
 /**
  * IndexedDB Object Store.
- * @see http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#idl-def-IDBObjectStore
+ * @see https://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#idl-def-IDBObjectStore
  * @class
+ * @throws {TypeError}
  */
 function IDBObjectStore () {
     throw new TypeError('Illegal constructor');
@@ -85,89 +86,93 @@ IDBObjectStore.__createInstance = function (storeProperties, transaction) {
         me.__indexNames = DOMStringList.__createInstance();
         const {indexList} = storeProperties;
         for (const indexName in indexList) {
-            if (Object.hasOwn(indexList, indexName)) {
-                const index = IDBIndex.__createInstance(me, indexList[indexName]);
-                me.__indexes[index.name] = index;
-                if (!index.__deleted) {
-                    me.indexNames.push(index.name);
-                }
+            if (!Object.hasOwn(indexList, indexName)) {
+                continue;
+            }
+
+            const index = IDBIndex.__createInstance(me, indexList[indexName]);
+            me.__indexes[index.name] = index;
+            if (!index.__deleted) {
+                me.indexNames.push(index.name);
             }
         }
         me.__oldIndexNames = me.indexNames.clone();
-        Object.defineProperty(this, '__currentName', {
-            get () {
-                return '__pendingName' in this ? this.__pendingName : this.name;
-            }
-        });
-        Object.defineProperty(this, 'name', {
-            enumerable: false,
-            configurable: false,
-            /**
-             * @this {IDBObjectStoreFull}
-             * @returns {string}
-             */
-            get () {
-                return this.__name;
-            },
-            /**
-             * @param {string} name
-             * @this {IDBObjectStoreFull}
-             * @returns {void}
-             */
-            set (name) {
-                const me = this;
-                name = util.convertToDOMString(name);
-                const oldName = me.name;
-                IDBObjectStoreAlias.__invalidStateIfDeleted(me);
-                IDBTransaction.__assertVersionChange(me.transaction);
-                IDBTransaction.__assertActive(me.transaction);
-                if (oldName === name) {
-                    return;
-                }
-                if (me.__idbdb.__objectStores[name] && !me.__idbdb.__objectStores[name].__pendingDelete) {
-                    throw createDOMException('ConstraintError', 'Object store "' + name + '" already exists in ' + me.__idbdb.name);
+        Object.defineProperties(this, {
+            __currentName: {
+                get () {
+                    return '__pendingName' in this ? this.__pendingName : this.name;
                 }
+            },
+            name: {
+                enumerable: false,
+                configurable: false,
+                /**
+                 * @this {IDBObjectStoreFull}
+                 * @returns {string}
+                 */
+                get () {
+                    return this.__name;
+                },
+                /**
+                 * @param {string} name
+                 * @this {IDBObjectStoreFull}
+                 * @returns {void}
+                 */
+                set (name) {
+                    const me = this;
+                    name = util.convertToDOMString(name);
+                    const oldName = me.name;
+                    IDBObjectStoreAlias.__invalidStateIfDeleted(me);
+                    IDBTransaction.__assertVersionChange(me.transaction);
+                    IDBTransaction.__assertActive(me.transaction);
+                    if (oldName === name) {
+                        return;
+                    }
+                    if (Object.hasOwn(me.__idbdb.__objectStores, name) && !me.__idbdb.__objectStores[name].__pendingDelete) {
+                        throw createDOMException('ConstraintError', 'Object store "' + name + '" already exists in ' + me.__idbdb.name);
+                    }
 
-                me.__name = name;
+                    me.__name = name;
 
-                const oldStore = me.__idbdb.__objectStores[oldName];
-                oldStore.__name = name; // Fix old references
-                me.__idbdb.__objectStores[name] = oldStore; // Ensure new reference accessible
-                delete me.__idbdb.__objectStores[oldName]; // Ensure won't be found
+                    const oldStore = me.__idbdb.__objectStores[oldName];
+                    oldStore.__name = name; // Fix old references
+                    me.__idbdb.__objectStores[name] = oldStore; // Ensure new reference accessible
+                    delete me.__idbdb.__objectStores[oldName]; // Ensure won't be found
 
-                me.__idbdb.objectStoreNames.splice(me.__idbdb.objectStoreNames.indexOf(oldName), 1, name);
+                    me.__idbdb.objectStoreNames.splice(me.__idbdb.objectStoreNames.indexOf(oldName), 1, name);
 
-                const oldHandle = /** @type {IDBObjectStoreFull} */ (
+                    const oldHandle = /** @type {IDBObjectStoreFull} */ (
+                        /** @type {import('./IDBTransaction.js').IDBTransactionFull} */ (
+                            me.transaction
+                        ).__storeHandles[oldName]
+                    );
+                    oldHandle.__name = name; // Fix old references
                     /** @type {import('./IDBTransaction.js').IDBTransactionFull} */ (
                         me.transaction
-                    ).__storeHandles[oldName]
-                );
-                oldHandle.__name = name; // Fix old references
-                /** @type {import('./IDBTransaction.js').IDBTransactionFull} */ (
-                    me.transaction
-                ).__storeHandles[name] = oldHandle; // Ensure new reference accessible
-
-                me.__pendingName = oldName;
-
-                const sql = 'UPDATE __sys__ SET "name" = ? WHERE "name" = ?';
-                const sqlValues = [util.escapeSQLiteStatement(name), util.escapeSQLiteStatement(oldName)];
-                if (CFG.DEBUG) { console.log(sql, sqlValues); }
-                /** @type {import('./IDBTransaction.js').IDBTransactionFull} */ (
-                    me.transaction
-                ).__addNonRequestToTransactionQueue(function objectStoreClear (tx, args, success, error) {
-                    tx.executeSql(sql, sqlValues, function (tx) {
-                        // This SQL preserves indexes per https://www.sqlite.org/lang_altertable.html
-                        const sql = 'ALTER TABLE ' + util.escapeStoreNameForSQL(oldName) + ' RENAME TO ' + util.escapeStoreNameForSQL(name);
-                        if (CFG.DEBUG) { console.log(sql); }
-                        tx.executeSql(sql, [], function () {
-                            delete me.__pendingName;
-                            success();
+                    ).__storeHandles[name] = oldHandle; // Ensure new reference accessible
+
+                    me.__pendingName = oldName;
+
+                    const sql = 'UPDATE __sys__ SET "name" = ? WHERE "name" = ?';
+                    const sqlValues = [util.escapeSQLiteStatement(name), util.escapeSQLiteStatement(oldName)];
+                    if (CFG.DEBUG) { console.log(sql, sqlValues); }
+                    /** @type {import('./IDBTransaction.js').IDBTransactionFull} */ (
+                        me.transaction
+                    ).__addNonRequestToTransactionQueue(function objectStoreClear (tx, args, success, error) {
+                        tx.executeSql(sql, sqlValues, function (tx) {
+                            // This SQL preserves indexes per https://www.sqlite.org/lang_altertable.html
+                            const sql = 'ALTER TABLE ' + util.escapeStoreNameForSQL(oldName) + ' RENAME TO ' + util.escapeStoreNameForSQL(name);
+                            if (CFG.DEBUG) { console.log(sql); }
+                            tx.executeSql(sql, [], function () {
+                                delete me.__pendingName;
+                                success();
+                            });
+                        }, function (tx, err) {
+                            error(err);
+                            return false;
                         });
-                    }, function (tx, err) {
-                        error(err);
-                        return false;
                     });
-                });
+                }
             }
         });
     }
@@ -239,7 +244,7 @@ IDBObjectStore.__createObjectStore = function (db, store) {
     );
 
     const storeHandles = transaction.__storeHandles;
-    if (!storeHandles[storeName] ||
+    if (!Object.hasOwn(storeHandles, storeName) ||
         // These latter conditions are to allow store
         //   recreation to create new clone object
         storeHandles[storeName].__pendingDelete ||
@@ -609,7 +614,6 @@ IDBObjectStore.prototype.__insertData = function (tx, encoded, value, clonedKeyO
             return false;
         });
         return undefined;
-    // eslint-disable-next-line sonarjs/no-invariant-returns -- Convenient
     }).catch(function (err) {
         /**
          * @returns {void}
@@ -1036,7 +1040,7 @@ IDBObjectStore.prototype.index = function (indexName) {
         throw createDOMException('NotFoundError', 'Index "' + indexName + '" does not exist on ' + me.__currentName);
     }
 
-    if (!me.__indexHandles[indexName] ||
+    if (!Object.hasOwn(me.__indexHandles, indexName) ||
         me.__indexes[indexName].__pendingDelete ||
         me.__indexes[indexName].__deleted
     ) {
@@ -1069,7 +1073,7 @@ IDBObjectStore.prototype.createIndex = function (indexName, keyPath /* , optiona
     IDBTransaction.__assertVersionChange(me.transaction);
     IDBObjectStore.__invalidStateIfDeleted(me);
     IDBTransaction.__assertActive(me.transaction);
-    if (me.__indexes[indexName] && !me.__indexes[indexName].__deleted && !me.__indexes[indexName].__pendingDelete) {
+    if (Object.hasOwn(me.__indexes, indexName) && !me.__indexes[indexName].__deleted && !me.__indexes[indexName].__pendingDelete) {
         throw createDOMException('ConstraintError', 'Index "' + indexName + '" already exists on ' + me.__currentName);
     }
 
@@ -1081,7 +1085,7 @@ IDBObjectStore.prototype.createIndex = function (indexName, keyPath /* , optiona
         throw createDOMException('InvalidAccessError', 'The keyPath argument was an array and the multiEntry option is true.');
     }
 
-    optionalParameters = optionalParameters || {};
+    optionalParameters ||= {};
     /** @type {import('./IDBIndex.js').IDBIndexProperties} */
     const indexProperties = {
         columnName: indexName,
@@ -1121,6 +1125,7 @@ IDBObjectStore.prototype.deleteIndex = function (name) {
     IDBIndex.__deleteIndex(me, index);
 };
 
+/* eslint-disable unicorn/no-top-level-side-effects -- Would be good */
 util.defineReadonlyOuterInterface(IDBObjectStore.prototype, readonlyProperties);
 util.defineOuterInterface(IDBObjectStore.prototype, ['name']);
 
@@ -1129,5 +1134,6 @@ IDBObjectStore.prototype[Symbol.toStringTag] = 'IDBObjectStorePrototype';
 Object.defineProperty(IDBObjectStore, 'prototype', {
     writable: false
 });
+/* eslint-enable unicorn/no-top-level-side-effects -- Would be good */
 
 export default IDBObjectStore;

package/src/IDBRequest.js

@@ -8,8 +8,9 @@ const doneFlagGetters = ['result', 'error'];
 
 /**
  * The IDBRequest Object that is returns for all async calls.
- * @see http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#request-api
+ * @see https://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#request-api
  * @class
+ * @throws {TypeError}
  */
 function IDBRequest () {
     throw new TypeError('Illegal constructor');
@@ -48,21 +49,26 @@ IDBRequest.__super = function IDBRequest () {
         legacyOutputDidListenersThrowFlag: true // Event hook for IndexedB
     });
     doneFlagGetters.forEach((prop) => {
-        Object.defineProperty(this, '__' + prop, {
-            enumerable: false,
-            configurable: false,
-            writable: true
-        });
-        Object.defineProperty(this, prop, {
-            enumerable: true,
-            configurable: true,
-            get () {
-                if (!this.__done) {
-                    throw createDOMException('InvalidStateError', "Can't get " + prop + '; the request is still pending.');
+        Object.defineProperties(
+            this,
+            {
+                ['__' + prop]: {
+                    enumerable: false,
+                    configurable: false,
+                    writable: true
+                },
+                [prop]: {
+                    enumerable: true,
+                    configurable: true,
+                    get () {
+                        if (!this.__done) {
+                            throw createDOMException('InvalidStateError', "Can't get " + prop + '; the request is still pending.');
+                        }
+                        return this['__' + prop];
+                    }
                 }
-                return this['__' + prop];
             }
-        });
+        );
     });
     util.defineReadonlyProperties(this, readonlyProperties, {
         readyState: {
@@ -106,6 +112,7 @@ IDBRequest.prototype.__getParent = function () {
     return this.__transaction;
 };
 
+/* eslint-disable unicorn/no-top-level-side-effects -- Would be good */
 // Illegal invocations
 util.defineReadonlyOuterInterface(IDBRequest.prototype, readonlyProperties);
 util.defineReadonlyOuterInterface(IDBRequest.prototype, doneFlagGetters);
@@ -123,16 +130,18 @@ IDBRequest.__super.prototype = IDBRequest.prototype;
 Object.defineProperty(IDBRequest, 'prototype', {
     writable: false
 });
+/* eslint-enable unicorn/no-top-level-side-effects -- Would be good */
 
 const openListeners = ['onblocked', 'onupgradeneeded'];
 
 /**
- * @typedef {IDBRequestFull & IDBOpenDBRequest & {}} IDBOpenDBRequestFull
+ * @typedef {IDBRequestFull & IDBOpenDBRequest} IDBOpenDBRequestFull
  */
 
 /**
  * The IDBOpenDBRequest called when a database is opened.
  * @class
+ * @throws {TypeError}
  */
 function IDBOpenDBRequest () {
     throw new TypeError('Illegal constructor');
@@ -141,12 +150,14 @@ function IDBOpenDBRequest () {
 // @ts-expect-error It's ok
 IDBOpenDBRequest.prototype = Object.create(IDBRequest.prototype);
 
+/* eslint-disable unicorn/no-top-level-side-effects -- Would be good */
 Object.defineProperty(IDBOpenDBRequest.prototype, 'constructor', {
     enumerable: false,
     writable: true,
     configurable: true,
     value: IDBOpenDBRequest
 });
+/* eslint-enable unicorn/no-top-level-side-effects -- Would be good */
 
 const IDBOpenDBRequestAlias = IDBOpenDBRequest;
 /**
@@ -175,6 +186,7 @@ IDBOpenDBRequest.__createInstance = function () {
     return new IDBOpenDBRequest();
 };
 
+/* eslint-disable unicorn/no-top-level-side-effects -- Would be good */
 util.defineOuterInterface(IDBOpenDBRequest.prototype, openListeners);
 
 IDBOpenDBRequest.prototype[Symbol.toStringTag] = 'IDBOpenDBRequestPrototype';
@@ -182,5 +194,6 @@ IDBOpenDBRequest.prototype[Symbol.toStringTag] = 'IDBOpenDBRequestPrototype';
 Object.defineProperty(IDBOpenDBRequest, 'prototype', {
     writable: false
 });
+/* eslint-enable unicorn/no-top-level-side-effects -- Would be good */
 
 export {IDBRequest, IDBOpenDBRequest};

package/src/IDBTransaction.js

@@ -50,6 +50,7 @@ const readonlyProperties = ['objectStoreNames', 'mode', 'db', 'error'];
  *   },
  *   __requestsFinished: boolean,
  *   __transFinishedCb: (err: boolean, cb: ((bool?: boolean) => void)) => void,
+ *   __callTransFinishedCb: (err: boolean, cb: ((bool?: boolean) => void)) => void,
  *   __transactionEndCallback: () => void,
  *   __transactionFinished: boolean,
  *   __completed: boolean,
@@ -85,8 +86,9 @@ const readonlyProperties = ['objectStoreNames', 'mode', 'db', 'error'];
 
 /**
  * The IndexedDB Transaction.
- * @see http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#idl-def-IDBTransaction
+ * @see https://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#idl-def-IDBTransaction
  * @class
+ * @throws {TypeError}
  */
 function IDBTransaction () {
     throw new TypeError('Illegal constructor');
@@ -108,6 +110,7 @@ IDBTransaction.__createInstance = function (db, storeNames, mode) {
         // @ts-expect-error It's ok
         me[Symbol.toStringTag] = 'IDBTransaction';
         util.defineReadonlyProperties(me, readonlyProperties);
+        // eslint-disable-next-line unicorn/no-top-level-assignment-in-function -- Debugging only
         me.__id = ++uniqueID; // for debugging simultaneous transactions
         me.__active = true;
         me.__running = false;
@@ -155,6 +158,35 @@ IDBTransaction.prototype = EventTargetFactory.createInstance({
 IDBTransaction.prototype.__transFinishedCb = function (err, cb) {
     cb(Boolean(err));
 };
+
+/**
+ * In Node, the real (SQL-commit-capable) `__transFinishedCb` is only
+ * installed once the underlying WebSQL driver's own SQL-queue-idle check
+ * has fired at least once for this transaction (asynchronously, via the
+ * `nonstandardTransCb` passed to `db.transaction`/`.readTransaction`).
+ * Since our own request processing can now finish synchronously (e.g., a
+ * trivial upgrade using a synchronous SQL driver), it is possible to reach
+ * transaction completion here before that has happened, in which case
+ * `__transFinishedCb` is still the non-committing default above. Calling
+ * that default directly would silently skip the actual SQL commit and
+ * leave the underlying WebSQL transaction "running" forever, hanging any
+ * later transaction on that same database connection. So, if the real
+ * callback isn't installed yet, defer and retry until it is.
+ * @this {IDBTransactionFull}
+ * @param {boolean} err
+ * @param {(bool?: boolean) => void} cb
+ * @returns {void}
+ */
+IDBTransaction.prototype.__callTransFinishedCb = function (err, cb) {
+    const me = this;
+    if (me.__transFinishedCb === IDBTransaction.prototype.__transFinishedCb) {
+        setTimeout(() => {
+            me.__callTransFinishedCb(err, cb);
+        }, 0);
+        return;
+    }
+    me.__transFinishedCb(err, cb);
+};
 /**
  * @this {IDBTransactionFull}
  * @returns {void}
@@ -212,7 +244,7 @@ IDBTransaction.prototype.__executeRequests = function () {
                     me.__abortTransaction(createDOMException('AbortError', 'A request was aborted (in user handler after success).'));
                     return;
                 }
-                executeNextRequest();
+                util.runContinuationSafely(executeNextRequest);
             }
 
             /**
@@ -280,7 +312,7 @@ IDBTransaction.prototype.__executeRequests = function () {
                     try {
                         q = me.__requests[i];
                         if (!q.req) {
-                            q.op(tx, q.args, executeNextRequest, error);
+                            q.op(tx, q.args, () => util.runContinuationSafely(executeNextRequest), error);
                             return;
                         }
                         if (q.req.__done) { // Avoid continuing with aborted requests
@@ -509,7 +541,7 @@ IDBTransaction.prototype.objectStore = function (objectStoreName) {
         throw createDOMException('NotFoundError', objectStoreName + ' does not exist in ' + me.db.name);
     }
 
-    if (!me.__storeHandles[objectStoreName] ||
+    if (!Object.hasOwn(me.__storeHandles, objectStoreName) ||
         // These latter conditions are to allow store
         //   recreation to create new clone object
         me.__storeHandles[objectStoreName].__pendingDelete ||
@@ -615,7 +647,7 @@ IDBTransaction.prototype.__abortTransaction = function (err) {
                             }
                             q.req.dispatchEvent(reqEvt); // No need to catch errors
                             resolve();
-                        });
+                        }, 0);
                     }
                 );
             });
@@ -626,7 +658,7 @@ IDBTransaction.prototype.__abortTransaction = function (err) {
                 me.dispatchEvent(evt);
                 me.__storeHandles = {};
                 me.dispatchEvent(createEvent('__abort'));
-            });
+            }, 0);
             return undefined;
         }).catch((err) => {
             console.log('Abort error');
@@ -752,6 +784,7 @@ IDBTransaction.prototype.__getParent = function () {
     return this.db;
 };
 
+/* eslint-disable unicorn/no-top-level-side-effects -- Would be good */
 util.defineOuterInterface(IDBTransaction.prototype, listeners);
 util.defineReadonlyOuterInterface(IDBTransaction.prototype, readonlyProperties);
 
@@ -765,5 +798,6 @@ Object.defineProperty(IDBTransaction.prototype, 'constructor', {
 Object.defineProperty(IDBTransaction, 'prototype', {
     writable: false
 });
+/* eslint-enable unicorn/no-top-level-side-effects -- Would be good */
 
 export default IDBTransaction;

package/src/IDBVersionChangeEvent.js

@@ -29,6 +29,7 @@ IDBVersionChangeEvent.prototype[Symbol.toStringTag] = 'IDBVersionChangeEventProt
  * @typedef {number} Integer
  */
 
+/* eslint-disable unicorn/no-top-level-side-effects -- Would be good */
 readonlyProperties.forEach((prop) => {
     // Ensure for proper interface testing that "get <name>" is the function name
     const o = {
@@ -73,5 +74,6 @@ Object.defineProperty(IDBVersionChangeEvent.prototype, 'constructor', {
 Object.defineProperty(IDBVersionChangeEvent, 'prototype', {
     writable: false
 });
+/* eslint-enable unicorn/no-top-level-side-effects -- Would be good */
 
 export default IDBVersionChangeEvent;

package/src/Key.js

@@ -64,12 +64,15 @@ const keyTypeToEncodedChar = {
     binary: 500,
     array: 600
 };
+
+/* eslint-disable unicorn/no-top-level-side-effects -- Would be good */
 const keyTypes = /** @type {(KeyType|"invalid")[]} */ (Object.keys(keyTypeToEncodedChar));
 keyTypes.forEach((k) => {
     keyTypeToEncodedChar[k] = String.fromCodePoint(
         /** @type {number} */ (keyTypeToEncodedChar[k])
     );
 });
+/* eslint-enable unicorn/no-top-level-side-effects -- Would be good */
 
 const encodedCharToKeyType = keyTypes.reduce((o, k) => {
     o[keyTypeToEncodedChar[k]] = k;
@@ -160,15 +163,14 @@ const types = {
                     if (key > -1) {
                         sign = signValues.indexOf('smallNegative');
                         exponent = padBase32Exponent(significantDigitIndex);
-                        mantissa = flipBase32(padBase32Mantissa(key32));
                     // Non-negative exponent case:
                     } else {
                         sign = signValues.indexOf('bigNegative');
                         exponent = flipBase32(padBase32Exponent(
                             (decimalIndex !== -1) ? decimalIndex : key32.length
                         ));
-                        mantissa = flipBase32(padBase32Mantissa(key32));
                     }
+                    mantissa = flipBase32(padBase32Mantissa(key32));
                 // Non-negative cases:
                 // Negative exponent case:
                 } else if (key < 1) {
@@ -208,9 +210,9 @@ const types = {
 
             switch (signValues[sign]) {
             case 'negativeInfinity':
-                return Number.NEGATIVE_INFINITY;
+                return -Infinity;
             case 'positiveInfinity':
-                return Number.POSITIVE_INFINITY;
+                return Infinity;
             case 'bigPositive':
                 return pow32(mantissa, exponent);
             case 'smallPositive':
@@ -281,14 +283,22 @@ const types = {
                 encoded[i] = encodedItem;
             }
             encoded.push(keyTypeToEncodedChar.invalid + '-'); // append an extra item, so empty arrays sort correctly
-            return keyTypeToEncodedChar.array + '-' + JSON.stringify(encoded);
+            let encodedKey = JSON.stringify(encoded);
+            if (CFG.escapeNULForSQLiteStatements === false) {
+                encodedKey = encodedKey.replaceAll(String.raw`\u0000`, '\0');
+            }
+            return keyTypeToEncodedChar.array + '-' + encodedKey;
         },
         /**
          * @param {string} key
          * @returns {ValueTypeArray}
          */
         decode (key) {
-            const decoded = JSON.parse(key.slice(2));
+            let decodedKey = key.slice(2);
+            if (CFG.escapeNULForSQLiteStatements === false) {
+                decodedKey = decodedKey.replaceAll('\0', String.raw`\u0000`);
+            }
+            const decoded = JSON.parse(decodedKey);
             decoded.pop(); // remove the extra item
             for (let i = 0; i < decoded.length; i++) {
                 const item = decoded[i];
@@ -336,7 +346,7 @@ const types = {
         decode (key) {
             // Set the entries in buffer's [[ArrayBufferData]] to those in `value`
             const k = key.slice(2);
-            const arr = k.length ? k.split(',').map((s) => Number.parseInt(s)) : [];
+            const arr = k.length ? k.split(',').map(Number) : [];
             const buffer = new ArrayBuffer(arr.length);
             const uint8 = new Uint8Array(buffer);
             uint8.set(arr);
@@ -417,7 +427,7 @@ function pow32 (mantissa, exponent) {
  * @returns {Float}
  */
 function roundToPrecision (num, precision = 16) {
-    return Number.parseFloat(num.toPrecision(precision));
+    return Number(num.toPrecision(precision));
 }
 
 /**
@@ -481,7 +491,7 @@ function convertValueToMultiEntryKey (input) {
  */
 function getCopyBytesHeldByBufferSource (O) {
     let offset = 0;
-    let length = 0;
+    let length;
     if (ArrayBuffer.isView(O)) { // Has [[ViewedArrayBuffer]] internal slot
         const arrayBuffer = O.buffer;
         if (arrayBuffer === undefined) {
@@ -518,7 +528,7 @@ function getCopyBytesHeldByBufferSource (O) {
 * @returns {KeyValueObject}
 */
 function convertValueToKeyValueDecoded (input, seen, multiEntry, fullKeys) {
-    seen = seen || [];
+    seen ||= [];
     if (seen.includes(input)) {
         return {
             type: 'array',
@@ -868,7 +878,6 @@ function findMultiEntryMatches (keyEntry, range) {
                     continue;
                 }
                 if (key.length === 1) {
-                    // eslint-disable-next-line sonarjs/updated-loop-counter -- Convenient
                     key = key[0];
                 } else {
                     const nested = findMultiEntryMatches(key, range);
@@ -1041,9 +1050,14 @@ function assignCurrentNumber (tx, store, num, successCb, failCb) {
  * @returns {void}
  */
 function setCurrentNumber (tx, store, num, successCb, failCb) {
-    num = num === MAX_ALLOWED_CURRENT_NUMBER
-        ? num + 2 // Since incrementing by one will have no effect in JavaScript on this unsafe max, we represent the max as a number incremented by two. The getting of the current number is never returned to the user and is only used in safe comparisons, so it is safe for us to represent it in this manner
-        : num + 1;
+    num = 1 + (num === MAX_ALLOWED_CURRENT_NUMBER
+        // Since incrementing by one will have no effect in JavaScript on this
+        // unsafe max, we represent the max as a number incremented by two.
+        // The getting of the current number is never returned to the user and
+        // is only used in safe comparisons, so it is safe for us to represent
+        // it in this manner
+        ? num + 1
+        : num);
     return assignCurrentNumber(tx, store, num, successCb, failCb);
 }
 

package/src/Sca.js

@@ -4,7 +4,7 @@ import {
 
 import {createDOMException, ShimDOMException} from './DOMException.js';
 
-// See: http://stackoverflow.com/questions/42170826/categories-for-rejection-by-the-structured-cloning-algorithm
+// See: https://stackoverflow.com/questions/42170826/categories-for-rejection-by-the-structured-cloning-algorithm
 
 let typeson = new Typeson().register(structuredCloningThrowing);
 
@@ -14,6 +14,7 @@ let typeson = new Typeson().register(structuredCloningThrowing);
  * @returns {void}
  */
 function register (func) {
+    // eslint-disable-next-line unicorn/no-top-level-assignment-in-function -- Should be one-time cache
     typeson = new Typeson().register(func(structuredCloningThrowing));
 }