incyclist-services 1.7.91 → 1.7.93

package/lib/cjs/activities/base/api/fitconvert/fitconvert.js

@@ -60,14 +60,14 @@ let IncyclistFitConvertApi = (() => {
                 url = response.data;
             }
             catch (error) {
-                throw new Error(`convert failed: (phase convert), reason: ${error.message}`);
+                throw new Error(`convert failed: (phase convert), reason: ${error.message}`, { cause: error });
             }
             try {
                 const response = await this.getApi().get(url, { responseType: 'arraybuffer' });
                 return response.data;
             }
             catch (error) {
-                throw new Error(`convert failed: (phase download), reason: ${error.message}`);
+                throw new Error(`convert failed: (phase download), reason: ${error.message}`, { cause: error });
             }
         }
         getApi() {

package/lib/cjs/activities/base/repo/db.js

@@ -265,8 +265,8 @@ let ActivitiesRepository = (() => {
             if (typeof endPos !== 'number' && endPos?.value !== undefined) {
                 endPos = this.getUnitConverter().convert(endPos.value, 'distance', { from: endPos.unit, to: 'm' });
             }
-            if (result?.length > 0 && criteria?.endPos !== undefined) {
-                result = result.filter(ai => ai.summary.endPos === criteria.endPos);
+            if (result?.length > 0 && endPos !== undefined) {
+                result = result.filter(ai => ai.summary.endPos === endPos);
             }
             return result;
         }

package/lib/cjs/activities/base/utils/activity.js

@@ -236,6 +236,7 @@ let Activity = (() => {
                 }
                 catch (err) {
                     this.logError(err, 'upload');
+                    error = err.message;
                 }
             }
             this.markUploading(connectedApp, false);

package/lib/cjs/apps/base/api/velohero/api.js

@@ -38,7 +38,7 @@ class VeloHeroApi extends base_1.AppApiBase {
                 const { response } = err;
                 error = `HTTP error ${response.status}: ${response.statusText}`;
             }
-            throw new Error(error);
+            throw new Error(error, { cause: err });
         }
     }
     getAccountType() {

package/lib/cjs/apps/intervals/IntervalsAppConnection.js

@@ -122,7 +122,7 @@ let IntervalsAppConnection = (() => {
             return this.api;
         }
         initAuth() {
-            let isInitialized = false;
+            let isInitialized;
             try {
                 const auth = this.getCredentials();
                 if (auth) {

package/lib/cjs/apps/komoot/KomootAppConnection.js

@@ -119,7 +119,7 @@ let KomootAppConnection = (() => {
             return false;
         }
         checkAuth() {
-            let isInitialized = false;
+            let isInitialized;
             let credentials;
             if (!this.getUserSettings().isInitialized) {
                 return false;

package/lib/cjs/apps/strava/StravaAppConnection.js

@@ -120,7 +120,7 @@ let StravaAppConnection = (() => {
             return this.api;
         }
         initAuth() {
-            let isInitialized = false;
+            let isInitialized;
             try {
                 const auth = this.getCredentials();
                 const clientId = this.getSecret('STRAVA_CLIENT_ID');

package/lib/cjs/apps/velohero/VeloHeroAppConnection.js

@@ -105,7 +105,7 @@ let VeloHeroAppConnection = (() => {
             return this.api;
         }
         initAuth() {
-            let isInitialized = false;
+            let isInitialized;
             if (!this.getUserSettings().isInitialized) {
                 return false;
             }

package/lib/cjs/autoupdate/api.js

@@ -42,6 +42,7 @@ const service_1 = require("../base/service");
 const decorators_1 = require("../base/decorators");
 const UPDATE_SERVER_URL = 'UPDATE_SERVER_URL';
 const DEFAULT_DOMAIN = 'incyclist.com';
+const UPDATE_CHECK_TIMEOUT_MS = 5000;
 let IncyclistUpdatesApi = (() => {
     let _classDecorators = [types_1.Singleton];
     let _classDescriptor;
@@ -96,10 +97,19 @@ let IncyclistUpdatesApi = (() => {
             const base = this.getSetting(UPDATE_SERVER_URL, defaultUrl);
             return base;
         }
-        async _get(url, ...args) {
+        async _get(url, config = {}) {
             const api = this.getApi();
             const baseUrl = this.getBaseUrl();
-            return await api.get(baseUrl + url, ...args);
+            return await api.get(baseUrl + url, { timeout: UPDATE_CHECK_TIMEOUT_MS, ...config });
+        }
+        isExpectedError(err) {
+            if (!err)
+                return false;
+            if (err.message === 'Network Error')
+                return true;
+            if (/timeout/i.test(err.message ?? ''))
+                return true;
+            return false;
         }
         async getLatestMacAppVersion() {
             try {
@@ -114,7 +124,7 @@ let IncyclistUpdatesApi = (() => {
                 return { version, path, url, downloadUrl };
             }
             catch (err) {
-                if (err.message !== 'Network Error') {
+                if (!this.isExpectedError(err)) {
                     this.logError(err, 'getLatestMacAppVersion');
                 }
             }
@@ -142,7 +152,7 @@ let IncyclistUpdatesApi = (() => {
                 return { version, path, url, downloadUrl };
             }
             catch (err) {
-                if (err.message !== 'Network Error') {
+                if (!this.isExpectedError(err)) {
                     this.logError(err, 'getLatestLinuxAppVersion');
                 }
             }
@@ -165,7 +175,7 @@ let IncyclistUpdatesApi = (() => {
                 return { version, path, url, downloadUrl };
             }
             catch (err) {
-                if (err.message !== 'Network Error') {
+                if (!this.isExpectedError(err)) {
                     this.logError(err, 'getLatestWindowsAppVersion');
                 }
             }

package/lib/cjs/coaches/service.js

@@ -257,9 +257,8 @@ let CoachesService = (() => {
             if (!route)
                 return;
             const prevPosition = coach.getPosition() || route.points[0];
-            let nextPosition = undefined;
             if (distance > 0) {
-                nextPosition = (0, route_1.getNextPosition)(route, { distance, prev: prevPosition });
+                const nextPosition = (0, route_1.getNextPosition)(route, { distance, prev: prevPosition });
                 if (nextPosition) {
                     const { slope } = nextPosition;
                     coach.sendDeviceUpdate({ slope: slope * realityFactor / 100 });

package/lib/cjs/devices/ride/service.js

@@ -1134,7 +1134,7 @@ let DeviceRideService = (() => {
             const adapters = this.getRideAdapters();
             const config = this.getDeviceConfiguration();
             const selectedDevices = selected ?? config.getSelectedDevices();
-            let enabledCapabilities = [];
+            let enabledCapabilities;
             const duplicates = this.checkAntSameDeviceID(adapters);
             const toBeReplaced = duplicates.filter(dai => dai.udid === adapterInfo.udid).map(dai => dai.info.udid);
             if (this.simulatorEnforced) {

package/lib/cjs/maps/MapArea/MapArea.js

@@ -146,7 +146,6 @@ class MapArea {
         };
         const addOption = (newPath, res, reverse) => {
             const optWay = way;
-            let path = [];
             if (newPath.length === 1) {
                 addWaysCrossing(res);
             }
@@ -156,7 +155,7 @@ class MapArea {
                         newPath[0].id === way.path.at(-1).id)) {
                     addWaysCrossing(res);
                 }
-                path = newPath;
+                const path = newPath;
                 if (reverse)
                     path.reverse();
                 res.push({ wayId: optWay.id, path });

package/lib/cjs/maps/MapArea/service.js

@@ -172,6 +172,7 @@ let MapAreaService = (() => {
             let ts;
             for (let i = 0; i < 2; i++) {
                 try {
+                    ts = Date.now();
                     const bounds = (0, utils_1.getBounds)(location?.lat, location?.lng, this.radius);
                     const query = (0, utils_1.buildQuery)(consts_1.GET_WAYS_IN_AREA, bounds);
                     const openmapData = await this.getOverpassAPI().query(query, DEFAULT_TIMEOUT);

package/lib/cjs/ride/display/service.js

@@ -873,7 +873,7 @@ let RideDisplayService = (() => {
         }
         simulatorPowerUp(mode, powerInc) {
             const simMode = mode.getSetting('mode');
-            let request = {};
+            let request;
             if (simMode === 'Power') {
                 const currentPowerTarget = mode.getSetting('power');
                 const targetPower = Number(currentPowerTarget) + powerInc;

package/lib/cjs/ride/route/FreeRideDisplayService.js

@@ -202,7 +202,6 @@ let FreeRideDisplayService = (() => {
         findPointBeforeOrAtTurn(path) {
             let prevPointIdx;
             let atPoint = false;
-            let found = false;
             let idx = path.findIndex(p => p.routeDistance >= this.position.routeDistance);
             if (idx > 0) {
                 const point = path[idx];
@@ -212,7 +211,7 @@ let FreeRideDisplayService = (() => {
                 }
                 prevPointIdx = idx;
             }
-            found = idx !== -1;
+            const found = idx !== -1;
             return { prevPointIdx, atPoint, found };
         }
         getDisplayProperties(props) {

package/lib/cjs/ride/route/RLVDisplayService.js

@@ -403,6 +403,11 @@ let RLVDisplayService = (() => {
             }
             this.emit('state-update');
         }
+        onConvertError(message, video = this.currentVideo) {
+            if (!video)
+                return;
+            this.onVideoLoadError({ message }, video);
+        }
         onVideoStalled(time, bufferedTime, buffers, video = this.currentVideo) {
             video.syncHelper.onVideoStalled(time, bufferedTime);
         }
@@ -509,25 +514,10 @@ let RLVDisplayService = (() => {
             video.playback = 'converted';
             video.source = new video_1.VideoConversion(this.cleanupUrl(src), video?.route);
             video.source.getObserver().on('convert-progress', this.onConvertUpdate.bind(this));
+            video.source.getObserver().on('convert-error', (message) => this.onConvertError(message, video));
         }
         cleanupUrl(url) {
-            if (!url)
-                return;
-            let fileName = url;
-            const lc = url.toLowerCase();
-            if (fileName.startsWith('incyclist:'))
-                fileName = fileName.replace('incyclist:', 'file:');
-            if (fileName.startsWith('video:') && !lc.endsWith('.avi'))
-                return fileName.replace('video:', 'file:');
-            if (fileName.startsWith('file:') && !lc.endsWith('.avi') && !this.isMobile())
-                return fileName.replace('file:', 'video:');
-            if (fileName.startsWith('video:') && lc.endsWith('.avi'))
-                return fileName;
-            if (fileName.startsWith('file:') || fileName.startsWith('http:') || fileName.startsWith('https:') || fileName.startsWith('/'))
-                return fileName;
-            if (fileName.startsWith('content:'))
-                return fileName;
-            return `./${fileName}`;
+            return (0, video_1.resolvePlaybackUrl)(url, this.isMobile());
         }
         isLoopEnabled() {
             return this.isLoop() && !this.startSettings?.loopOverwrite;

package/lib/cjs/routes/base/parsers/incyclist.js

@@ -89,7 +89,7 @@ class IncyclistXMLParser extends xml_1.XMLParser {
         }
         catch (err) {
             if (!data['gpx-file-path'])
-                throw new Error('<gpx-file-path> missing in XML');
+                throw new Error('<gpx-file-path> missing in XML', { cause: err });
             throw err;
         }
     }

package/lib/cjs/routes/base/parsers/xml.js

@@ -244,7 +244,7 @@ class XMLParser {
             }
             catch (err) {
                 this.getLogger().logEvent({ message: 'xml details', error: err.message, mappings });
-                throw new Error('Could not parse XML File');
+                throw new Error('Could not parse XML File', { cause: err });
             }
         }
     }

package/lib/cjs/routes/base/utils/points.js

@@ -57,7 +57,7 @@ const detectAnomalies = (points, maxCount) => {
     };
     const onSpeedJumpDetected = (point, idx) => {
         const prevPoint = data[lastValidSpeedIdx];
-        let nextJumpIdx, nextNullIdx;
+        let nextNullIdx;
         if (prevPoint.speed === 0) {
             anomalies.push({ idx: lastValidSpeedIdx, type: 'noDistance', point });
         }
@@ -72,7 +72,7 @@ const detectAnomalies = (points, maxCount) => {
                     continue;
                 }
             }
-            anomalies.push({ idx, type: 'speedJump', point, nextNullIdx, nextJumpIdx });
+            anomalies.push({ idx, type: 'speedJump', point, nextNullIdx });
         }
     };
     data.forEach((point, idx) => {
@@ -106,7 +106,7 @@ const fixAnomaly = (anomaly, points) => {
 exports.fixAnomaly = fixAnomaly;
 const fixAnomalies = (points, maxAttempts = 1000) => {
     let fixed = 0;
-    let anomalies = [];
+    let anomalies;
     const tsStart = Date.now();
     let prev;
     let stuck = false;

package/lib/cjs/routes/list/cards/RouteCard.js

@@ -159,11 +159,12 @@ let RouteCard = (() => {
             const videoUrl = descr.videoUrl;
             if (!descr.videoUrl)
                 return true;
+            const normalizedUrl = videoUrl.replace('video:////', 'video:///').replace('file:////', 'file:///');
             let path = undefined;
-            if (videoUrl.startsWith('file:///'))
-                path = videoUrl.replace('file:///', '');
-            if (videoUrl.startsWith('video:///'))
-                path = videoUrl.replace('video:///', '');
+            if (normalizedUrl.startsWith('file:///'))
+                path = normalizedUrl.replace('file://', '');
+            if (normalizedUrl.startsWith('video:///'))
+                path = normalizedUrl.replace('video://', '');
             if (path) {
                 return await this.fileExists(path);
             }

package/lib/cjs/routes/list/loaders/db.js

@@ -83,7 +83,7 @@ let RoutesDbLoader = (() => {
             } };
             const updatedDescr = this.buildRouteDBInfo(route.description);
             const idx = this.routeDescriptions.findIndex(d => d.id === route.description.id);
-            let changed = false;
+            let changed;
             if (idx === -1) {
                 this.routeDescriptions.push((0, clone_1.default)(updatedDescr));
                 this.routeHashes[route.description.id] = stringify(updatedDescr);

package/lib/cjs/ui/service.js

@@ -50,7 +50,9 @@ const monitoring_1 = require("../monitoring");
 const appstate_1 = require("../appstate");
 const pages_1 = require("../base/pages");
 const utils_1 = require("../utils");
+const sleep_1 = require("../utils/sleep");
 const BACKGROUND_PAUSE_TIMEOUT_MS = 300000;
+const APP_EXIT_TIMEOUT_MS = 5000;
 let UserInterfaceServcie = (() => {
     let _classDecorators = [decorators_1.Singleton];
     let _classDescriptor;
@@ -146,9 +148,12 @@ let UserInterfaceServcie = (() => {
                     this.stopHeartbeatWorker();
                     this.sendAppExitMessage();
                     pages_1.IncyclistPageService.closePage();
-                    await (0, utils_1.waitNextTick)();
-                    await (0, devices_1.useDevicePairing)().exit();
-                    await (0, devices_1.useDeviceAccess)().terminate();
+                    const cleanup = async () => {
+                        await (0, utils_1.waitNextTick)();
+                        await (0, devices_1.useDevicePairing)().exit();
+                        await (0, devices_1.useDeviceAccess)().terminate();
+                    };
+                    await Promise.race([cleanup(), (0, sleep_1.sleep)(APP_EXIT_TIMEOUT_MS)]);
                     this.appState = 'Stopped';
                     this.logEvent({ message: 'onAppExit finished' });
                     this.isTerminated = true;

package/lib/cjs/video/Mp4BoxParser.js

@@ -0,0 +1,145 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.parseMp4Boxes = void 0;
+const readBoxHeader = (buf, offset) => {
+    if (offset + 8 > buf.length)
+        return undefined;
+    const size32 = buf.readUInt32BE(offset);
+    const type = buf.toString('ascii', offset + 4, offset + 8);
+    let headerSize = 8;
+    let size = size32;
+    if (size32 === 1) {
+        if (offset + 16 > buf.length)
+            return undefined;
+        const high = buf.readUInt32BE(offset + 8);
+        const low = buf.readUInt32BE(offset + 12);
+        size = high * 2 ** 32 + low;
+        headerSize = 16;
+    }
+    else if (size32 === 0) {
+        size = buf.length - offset;
+    }
+    return { type, start: offset, size, headerSize, bodyStart: offset + headerSize, bodyEnd: offset + size };
+};
+const findBoxes = (buf, start, end) => {
+    const boxes = [];
+    let offset = start;
+    while (offset < end) {
+        const box = readBoxHeader(buf, offset);
+        if (!box || box.size <= 0 || box.bodyEnd > end)
+            break;
+        boxes.push(box);
+        offset = box.bodyEnd;
+    }
+    return boxes;
+};
+const findBox = (boxes, type) => boxes.find(b => b.type === type);
+const findMoovBySignature = (buf) => {
+    const signature = Buffer.from('moov', 'ascii');
+    let searchFrom = 0;
+    while (searchFrom < buf.length) {
+        const typeOffset = buf.indexOf(signature, searchFrom);
+        if (typeOffset === -1 || typeOffset < 4)
+            return undefined;
+        const box = readBoxHeader(buf, typeOffset - 4);
+        if (box?.type === 'moov' && box.bodyEnd <= buf.length)
+            return box;
+        searchFrom = typeOffset + 4;
+    }
+    return undefined;
+};
+const parseFtyp = (buf, box) => {
+    if (box.bodyStart + 4 > buf.length)
+        return undefined;
+    return buf.toString('ascii', box.bodyStart, box.bodyStart + 4);
+};
+const parseHandlerType = (buf, hdlrBox) => {
+    const offset = hdlrBox.bodyStart + 8;
+    if (offset + 4 > buf.length)
+        return undefined;
+    return buf.toString('ascii', offset, offset + 4);
+};
+const parseStsdCodec = (buf, stsdBox) => {
+    const entryOffset = stsdBox.bodyStart + 8;
+    if (entryOffset + 8 > buf.length)
+        return undefined;
+    return buf.toString('ascii', entryOffset + 4, entryOffset + 8);
+};
+const parseTkhdDimensions = (buf, tkhdBox) => {
+    if (tkhdBox.bodyStart >= buf.length)
+        return {};
+    const version = buf.readUInt8(tkhdBox.bodyStart);
+    const fixedFieldsSize = version === 1 ? 96 : 76;
+    const offset = tkhdBox.bodyStart + fixedFieldsSize;
+    if (offset + 8 > buf.length)
+        return {};
+    const width = buf.readUInt32BE(offset) >> 16;
+    const height = buf.readUInt32BE(offset + 4) >> 16;
+    return { width, height };
+};
+const parseTrak = (buf, trakBox) => {
+    const trakChildren = findBoxes(buf, trakBox.bodyStart, trakBox.bodyEnd);
+    const tkhdBox = findBox(trakChildren, 'tkhd');
+    const mdiaBox = findBox(trakChildren, 'mdia');
+    if (!mdiaBox)
+        return {};
+    const mdiaChildren = findBoxes(buf, mdiaBox.bodyStart, mdiaBox.bodyEnd);
+    const hdlrBox = findBox(mdiaChildren, 'hdlr');
+    const minfBox = findBox(mdiaChildren, 'minf');
+    const handlerType = hdlrBox ? parseHandlerType(buf, hdlrBox) : undefined;
+    let codec;
+    if (minfBox) {
+        const minfChildren = findBoxes(buf, minfBox.bodyStart, minfBox.bodyEnd);
+        const stblBox = findBox(minfChildren, 'stbl');
+        if (stblBox) {
+            const stblChildren = findBoxes(buf, stblBox.bodyStart, stblBox.bodyEnd);
+            const stsdBox = findBox(stblChildren, 'stsd');
+            if (stsdBox)
+                codec = parseStsdCodec(buf, stsdBox);
+        }
+    }
+    const dimensions = (handlerType === 'vide' && tkhdBox) ? parseTkhdDimensions(buf, tkhdBox) : {};
+    return { handlerType, codec, ...dimensions };
+};
+const parseMp4Boxes = (headBuffer, tailBuffer) => {
+    const result = { moovLocation: 'not-found', incomplete: true };
+    if (headBuffer?.length > 0) {
+        const headBoxes = findBoxes(headBuffer, 0, headBuffer.length);
+        const ftypBox = findBox(headBoxes, 'ftyp');
+        if (ftypBox)
+            result.containerBrand = parseFtyp(headBuffer, ftypBox);
+        const moovBox = findBox(headBoxes, 'moov');
+        if (moovBox) {
+            applyMoov(headBuffer, moovBox, result);
+            result.moovLocation = 'head';
+            result.incomplete = false;
+        }
+    }
+    if (result.moovLocation === 'not-found' && tailBuffer?.length > 0) {
+        const moovBox = findMoovBySignature(tailBuffer);
+        if (moovBox) {
+            applyMoov(tailBuffer, moovBox, result);
+            result.moovLocation = 'tail';
+            result.incomplete = false;
+        }
+    }
+    return result;
+};
+exports.parseMp4Boxes = parseMp4Boxes;
+const applyMoov = (buf, moovBox, result) => {
+    const moovChildren = findBoxes(buf, moovBox.bodyStart, moovBox.bodyEnd);
+    const trakBoxes = moovChildren.filter(b => b.type === 'trak');
+    trakBoxes.forEach(trakBox => {
+        const { handlerType, codec, width, height } = parseTrak(buf, trakBox);
+        if (handlerType === 'vide') {
+            result.videoCodec = codec;
+            if (width)
+                result.width = width;
+            if (height)
+                result.height = height;
+        }
+        else if (handlerType === 'soun') {
+            result.audioCodec = codec;
+        }
+    });
+};

package/lib/cjs/video/VideoConversion.js

@@ -115,7 +115,7 @@ let VideoConversion = (() => {
                     return undefined;
                 const clean = str.trim();
                 const parts = clean.split(':');
-                let seconds = 0;
+                let seconds;
                 if (parts.length === 3) {
                     const [h, m, s] = parts;
                     seconds = Number(h) * 3600 + Number(m) * 60 + Number.parseFloat(s);

package/lib/cjs/video/index.js

@@ -17,3 +17,5 @@ Object.defineProperty(exports, "__esModule", { value: true });
 __exportStar(require("./types"), exports);
 __exportStar(require("./VideoSyncHelper"), exports);
 __exportStar(require("./VideoConversion"), exports);
+__exportStar(require("./Mp4BoxParser"), exports);
+__exportStar(require("./resolvePlaybackUrl"), exports);

package/lib/cjs/video/resolvePlaybackUrl.js

@@ -0,0 +1,23 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.resolvePlaybackUrl = void 0;
+const resolvePlaybackUrl = (url, isMobile = false) => {
+    if (!url)
+        return undefined;
+    let fileName = url;
+    const lc = url.toLowerCase();
+    if (fileName.startsWith('incyclist:'))
+        fileName = fileName.replace('incyclist:', 'file:');
+    if (fileName.startsWith('video:') && !lc.endsWith('.avi'))
+        return fileName.replace('video:', 'file:');
+    if (fileName.startsWith('file:') && !lc.endsWith('.avi') && !isMobile)
+        return fileName.replace('file:', 'video:');
+    if (fileName.startsWith('video:') && lc.endsWith('.avi'))
+        return fileName;
+    if (fileName.startsWith('file:') || fileName.startsWith('http:') || fileName.startsWith('https:') || fileName.startsWith('/'))
+        return fileName;
+    if (fileName.startsWith('content:'))
+        return fileName;
+    return `./${fileName}`;
+};
+exports.resolvePlaybackUrl = resolvePlaybackUrl;

package/lib/cjs/workouts/list/cards/WorkoutCard.js

@@ -203,7 +203,7 @@ let WorkoutCard = (() => {
         }
         async _delete() {
             await (0, utils_1.waitNextTick)();
-            let deleted = false;
+            let deleted;
             try {
                 this.deleteObserver.emit('started');
                 await this.getRepo().delete(this.workout);

package/lib/cjs/workouts/list/loaders/db.js

@@ -97,7 +97,7 @@ let WorkoutsDbLoader = (() => {
             };
             let prev;
             const idx = this.workouts.findIndex(d => d.id === workout.id);
-            let changed = false;
+            let changed;
             if (idx === -1) {
                 changed = true;
                 this.workouts.push(workout);

package/lib/esm/activities/base/api/fitconvert/fitconvert.js

@@ -57,14 +57,14 @@ let IncyclistFitConvertApi = (() => {
                 url = response.data;
             }
             catch (error) {
-                throw new Error(`convert failed: (phase convert), reason: ${error.message}`);
+                throw new Error(`convert failed: (phase convert), reason: ${error.message}`, { cause: error });
             }
             try {
                 const response = await this.getApi().get(url, { responseType: 'arraybuffer' });
                 return response.data;
             }
             catch (error) {
-                throw new Error(`convert failed: (phase download), reason: ${error.message}`);
+                throw new Error(`convert failed: (phase download), reason: ${error.message}`, { cause: error });
             }
         }
         getApi() {

package/lib/esm/activities/base/repo/db.js

@@ -262,8 +262,8 @@ let ActivitiesRepository = (() => {
             if (typeof endPos !== 'number' && endPos?.value !== undefined) {
                 endPos = this.getUnitConverter().convert(endPos.value, 'distance', { from: endPos.unit, to: 'm' });
             }
-            if (result?.length > 0 && criteria?.endPos !== undefined) {
-                result = result.filter(ai => ai.summary.endPos === criteria.endPos);
+            if (result?.length > 0 && endPos !== undefined) {
+                result = result.filter(ai => ai.summary.endPos === endPos);
             }
             return result;
         }

package/lib/esm/activities/base/utils/activity.js

@@ -233,6 +233,7 @@ let Activity = (() => {
                 }
                 catch (err) {
                     this.logError(err, 'upload');
+                    error = err.message;
                 }
             }
             this.markUploading(connectedApp, false);

package/lib/esm/apps/base/api/velohero/api.js

@@ -35,7 +35,7 @@ export class VeloHeroApi extends AppApiBase {
                 const { response } = err;
                 error = `HTTP error ${response.status}: ${response.statusText}`;
             }
-            throw new Error(error);
+            throw new Error(error, { cause: err });
         }
     }
     getAccountType() {

package/lib/esm/apps/intervals/IntervalsAppConnection.js

@@ -119,7 +119,7 @@ let IntervalsAppConnection = (() => {
             return this.api;
         }
         initAuth() {
-            let isInitialized = false;
+            let isInitialized;
             try {
                 const auth = this.getCredentials();
                 if (auth) {

package/lib/esm/apps/komoot/KomootAppConnection.js

@@ -116,7 +116,7 @@ let KomootAppConnection = (() => {
             return false;
         }
         checkAuth() {
-            let isInitialized = false;
+            let isInitialized;
             let credentials;
             if (!this.getUserSettings().isInitialized) {
                 return false;