incyclist-devices 2.3.0-beta.2 → 2.3.0-beta.20

package/lib/ble/fm/adapter.js

@@ -20,11 +20,12 @@ const sensor_1 = __importDefault(require("./sensor"));
 const adapter_1 = __importDefault(require("../base/adapter"));
 const consts_1 = require("./consts");
 const types_1 = require("../../types");
-const task_1 = require("../../utils/task");
+const utils_1 = require("../../utils/utils");
 class BleFmAdapter extends adapter_1.default {
     constructor(settings, props) {
         super(settings, props);
         this.distanceInternal = 0;
+        this.requestControlRetryDelay = 1000;
         this.logger = new gd_eventlog_1.EventLogger('BLE-FM');
         this.device = new sensor_1.default(this.getPeripheral(), { logger: this.logger });
         this.capabilities = [
@@ -46,7 +47,7 @@ class BleFmAdapter extends adapter_1.default {
     getSupportedCyclingModes() {
         var _a;
         const modes = [power_meter_1.default];
-        const features = (_a = this.getComms()) === null || _a === void 0 ? void 0 : _a.features;
+        const features = (_a = this.getSensor()) === null || _a === void 0 ? void 0 : _a.features;
         if (!features)
             return [power_meter_1.default, antble_smarttrainer_1.default, antble_erg_1.default];
         if (features.setPower === undefined || features.setPower)
@@ -57,7 +58,7 @@ class BleFmAdapter extends adapter_1.default {
     }
     getDefaultCyclingMode() {
         var _a;
-        const features = (_a = this.getComms()) === null || _a === void 0 ? void 0 : _a.features;
+        const features = (_a = this.getSensor()) === null || _a === void 0 ? void 0 : _a.features;
         if (!features)
             return new antble_smarttrainer_1.default(this);
         if (features.setSlope === undefined || features.setSlope)
@@ -117,15 +118,16 @@ class BleFmAdapter extends adapter_1.default {
     }
     initControl(_startProps) {
         return __awaiter(this, void 0, void 0, function* () {
+            if (!this.isStarting())
+                return;
             this.setConstants();
             yield this.establishControl();
-            this.setConstants();
             yield this.sendInitialRequest();
         });
     }
     setConstants() {
         const mode = this.getCyclingMode();
-        const sensor = this.getComms();
+        const sensor = this.getSensor();
         if (mode === null || mode === void 0 ? void 0 : mode.getSetting('bikeType')) {
             const bikeType = mode.getSetting('bikeType').toLowerCase();
             sensor.setCrr(consts_1.cRR);
@@ -146,38 +148,30 @@ class BleFmAdapter extends adapter_1.default {
         return __awaiter(this, void 0, void 0, function* () {
             if (!this.isStarting())
                 return false;
-            let waitTask;
-            let iv;
-            const sensor = this.getComms();
-            const wait = () => {
-                const res = new Promise((resolve) => {
-                    iv = setInterval(() => __awaiter(this, void 0, void 0, function* () {
-                        if (!this.isStarting() || !(waitTask === null || waitTask === void 0 ? void 0 : waitTask.isRunning)) {
-                            resolve(false);
-                            clearInterval(iv);
-                            return;
+            let hasControl = false;
+            let tryCnt = 0;
+            const sensor = this.getSensor();
+            return new Promise((resolve) => {
+                this.startTask.notifyOnStop(() => {
+                    resolve(false);
+                });
+                const waitUntilControl = () => __awaiter(this, void 0, void 0, function* () {
+                    while (!hasControl && this.isStarting()) {
+                        if (tryCnt++ === 0) {
+                            this.logEvent({ message: 'requesting control', device: this.getName(), interface: this.getInterface() });
                         }
-                        const hasControl = yield sensor.requestControl();
+                        hasControl = yield sensor.requestControl();
                         if (hasControl) {
-                            clearInterval(iv);
-                            resolve(true);
+                            this.logEvent({ message: 'control granted', device: this.getName(), interface: this.getInterface() });
+                            resolve(this.isStarting());
                         }
-                        else if (!this.isStarting() || !(waitTask === null || waitTask === void 0 ? void 0 : waitTask.isRunning)) {
-                            resolve(false);
-                            clearInterval(iv);
+                        else {
+                            yield (0, utils_1.sleep)(this.requestControlRetryDelay);
                         }
-                    }), 1000);
+                    }
                 });
-                return res;
-            };
-            waitTask = new task_1.InteruptableTask(wait(), {
-                errorOnTimeout: false,
-                timeout: 10000
+                waitUntilControl();
             });
-            const hasControl = yield waitTask.run();
-            clearInterval(iv);
-            if (!hasControl && this.isStarting())
-                throw new Error('could not establish control');
         });
     }
     sendInitialRequest() {
@@ -187,23 +181,33 @@ class BleFmAdapter extends adapter_1.default {
         });
     }
     checkCapabilities() {
-        var _a, _b, _c;
-        const before = this.capabilities.join(',');
-        const sensor = this.getComms();
-        if (((_a = sensor.features) === null || _a === void 0 ? void 0 : _a.heartrate) && !this.hasCapability(types_1.IncyclistCapability.HeartRate)) {
-            this.capabilities.push(types_1.IncyclistCapability.HeartRate);
-        }
-        if (((_b = sensor.features) === null || _b === void 0 ? void 0 : _b.cadence) && !this.hasCapability(types_1.IncyclistCapability.Cadence)) {
-            this.capabilities.push(types_1.IncyclistCapability.Cadence);
-        }
-        if (((_c = sensor.features) === null || _c === void 0 ? void 0 : _c.power) && !this.hasCapability(types_1.IncyclistCapability.Power)) {
-            this.capabilities.push(types_1.IncyclistCapability.Power);
-        }
-        const after = this.capabilities.join(',');
-        if (before !== after) {
-            this.logEvent({ message: 'device capabilities updated', name: this.getSettings().name, interface: this.getSettings().interface, capabilities: this.capabilities });
-            this.emit('device-info', this.getSettings(), { capabilities: this.capabilities });
-        }
+        return __awaiter(this, void 0, void 0, function* () {
+            var _a, _b, _c;
+            const before = this.capabilities.join(',');
+            const sensor = this.getSensor();
+            if (!sensor.features) {
+                try {
+                    yield sensor.getFitnessMachineFeatures();
+                }
+                catch (err) {
+                    this.logEvent({ message: 'error getting fitness machine features', device: this.getName(), interface: this.getInterface(), error: err });
+                }
+            }
+            if (((_a = sensor.features) === null || _a === void 0 ? void 0 : _a.heartrate) && !this.hasCapability(types_1.IncyclistCapability.HeartRate)) {
+                this.capabilities.push(types_1.IncyclistCapability.HeartRate);
+            }
+            if (((_b = sensor.features) === null || _b === void 0 ? void 0 : _b.cadence) && !this.hasCapability(types_1.IncyclistCapability.Cadence)) {
+                this.capabilities.push(types_1.IncyclistCapability.Cadence);
+            }
+            if (((_c = sensor.features) === null || _c === void 0 ? void 0 : _c.power) && !this.hasCapability(types_1.IncyclistCapability.Power)) {
+                this.capabilities.push(types_1.IncyclistCapability.Power);
+            }
+            const after = this.capabilities.join(',');
+            if (before !== after) {
+                this.logEvent({ message: 'device capabilities updated', name: this.getSettings().name, interface: this.getSettings().interface, capabilities: this.capabilities });
+                this.emit('device-info', this.getSettings(), { capabilities: this.capabilities });
+            }
+        });
     }
     sendUpdate(request_1) {
         return __awaiter(this, arguments, void 0, function* (request, enforced = false) {
@@ -212,7 +216,7 @@ class BleFmAdapter extends adapter_1.default {
             try {
                 const update = this.getCyclingMode().sendBikeUpdate(request);
                 this.logEvent({ message: 'send bike update requested', profile: this.getProfile(), update, request });
-                const device = this.device;
+                const device = this.getSensor();
                 if (update.slope !== undefined) {
                     yield device.setSlope(update.slope);
                 }

package/lib/ble/fm/comms.d.ts

@@ -1,6 +1,6 @@
 import { BleProtocol, BleWriteProps, IBlePeripheralConnector } from "../types";
 import { IndoorBikeData, IndoorBikeFeatures } from "./types";
-import { BleComms } from "../base/sensor";
+import { BleComms } from "../base/comms";
 import { LegacyProfile } from "../../antv2/types";
 export default class BleFitnessMachineDevice extends BleComms {
     static protocol: BleProtocol;

package/lib/ble/fm/comms.js

@@ -10,7 +10,7 @@ var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, ge
 };
 Object.defineProperty(exports, "__esModule", { value: true });
 const consts_1 = require("../consts");
-const sensor_1 = require("../base/sensor");
+const comms_1 = require("../base/comms");
 const utils_1 = require("../utils");
 const bit = (nr) => (1 << nr);
 const IndoorBikeDataFlag = {
@@ -66,7 +66,7 @@ const TargetSettingFeatureFlag = {
     SpinDownControlSupported: bit(15),
     TargetedCadenceConfigurationSupported: bit(16)
 };
-class BleFitnessMachineDevice extends sensor_1.BleComms {
+class BleFitnessMachineDevice extends comms_1.BleComms {
     constructor(props) {
         super(props);
         this.features = undefined;
@@ -92,7 +92,7 @@ class BleFitnessMachineDevice extends sensor_1.BleComms {
     subscribeWriteResponse(cuuid) {
         return __awaiter(this, void 0, void 0, function* () {
             this.logEvent({ message: 'subscribe to CP response', characteristics: cuuid });
-            const connector = this.getPeripheral();
+            const connector = this.ble.peripheralCache.getConnector(this.peripheral);
             const isAlreadySubscribed = connector.isSubscribed(cuuid);
             if (!isAlreadySubscribed) {
                 connector.removeAllListeners(cuuid);

package/lib/ble/fm/sensor.d.ts

@@ -34,7 +34,7 @@ export default class BleFitnessMachineDevice extends TBleSensor {
     protected parseHrm(_data: Uint8Array): IndoorBikeData;
     protected parseIndoorBikeData(_data: Uint8Array): IndoorBikeData;
     protected parseFitnessMachineStatus(_data: Uint8Array): IndoorBikeData;
-    protected getFitnessMachineFeatures(): Promise<IndoorBikeFeatures | undefined>;
+    getFitnessMachineFeatures(): Promise<IndoorBikeFeatures | undefined>;
     protected writeFtmsMessage(requestedOpCode: any, data: any, props?: BleWriteProps): Promise<number>;
     setTargetInclination(inclination: number): Promise<boolean>;
     setIndoorBikeSimulation(windSpeed: number, gradient: number, crr: number, cw: number): Promise<boolean>;

package/lib/ble/fm/sensor.js

@@ -100,8 +100,6 @@ class BleFitnessMachineDevice extends sensor_1.TBleSensor {
             this.logEvent({ message: 'setTargetPower', power, skip: (this.data.targetPower !== undefined && this.data.targetPower === power) });
             if (this.data.targetPower !== undefined && this.data.targetPower === power)
                 return true;
-            if (!this.hasControl)
-                return;
             const hasControl = yield this.requestControl();
             if (!hasControl) {
                 this.logEvent({ message: 'setTargetPower failed', reason: 'control is disabled' });
@@ -111,15 +109,15 @@ class BleFitnessMachineDevice extends sensor_1.TBleSensor {
             data.writeUInt8(5, 0);
             data.writeInt16LE(Math.round(power), 1);
             const res = yield this.writeFtmsMessage(5, data);
+            if (res === 5) {
+                this.hasControl = false;
+            }
             return (res === 1);
         });
     }
     setSlope(slope) {
         return __awaiter(this, void 0, void 0, function* () {
             this.logEvent({ message: 'setSlope', slope });
-            const hasControl = yield this.requestControl();
-            if (!hasControl)
-                return;
             const { windSpeed, crr, cw } = this;
             return yield this.setIndoorBikeSimulation(windSpeed, slope, crr, cw);
         });
@@ -331,6 +329,9 @@ class BleFitnessMachineDevice extends sensor_1.TBleSensor {
             data.writeUInt8(Math.round(crr * 10000), 5);
             data.writeUInt8(Math.round(cw * 100), 6);
             const res = yield this.writeFtmsMessage(17, data);
+            if (res === 5) {
+                this.hasControl = false;
+            }
             return (res === 1);
         });
     }

package/lib/ble/hr/comm.d.ts

@@ -1,5 +1,5 @@
 import { LegacyProfile } from '../../antv2/types';
-import { BleComms } from '../base/sensor';
+import { BleComms } from '../base/comms';
 import { BleProtocol } from '../types';
 import { HrmData } from './types';
 export default class BleHrmDevice extends BleComms {

package/lib/ble/hr/comm.js

@@ -1,9 +1,9 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-const sensor_1 = require("../base/sensor");
+const comms_1 = require("../base/comms");
 const consts_1 = require("../consts");
 const utils_1 = require("../utils");
-class BleHrmDevice extends sensor_1.BleComms {
+class BleHrmDevice extends comms_1.BleComms {
     constructor(props) {
         super(props);
         this.heartrate = undefined;

package/lib/ble/index.js

@@ -30,6 +30,7 @@ Object.defineProperty(exports, "BleInterface", { enumerable: true, get: function
 const factories_1 = require("./factories");
 Object.defineProperty(exports, "BleInterfaceFactory", { enumerable: true, get: function () { return factories_1.BleMultiTransportInterfaceFactory; } });
 Object.defineProperty(exports, "BleAdapterFactory", { enumerable: true, get: function () { return factories_1.BleAdapterFactory; } });
+const csc_1 = require("./csc");
 ['ble', 'wifi'].forEach(i => {
     const af = factories_1.BleAdapterFactory.getInstance(i);
     af.register('hr', hr_1.BleHrmAdapter, hr_1.BleHrmComms);
@@ -37,6 +38,7 @@ Object.defineProperty(exports, "BleAdapterFactory", { enumerable: true, get: fun
     af.register('fm', fm_1.BleFmAdapter, fm_1.BleFmComms);
     af.register('wahoo', wahoo_1.BleWahooAdapter, wahoo_1.BleWahooComms);
     af.register('tacx', tacx_1.BleTacxAdapter, tacx_1.BleTacxComms);
+    af.register('csc', csc_1.BleCSCAdapter, csc_1.BleCyclingSpeedCadenceDevice);
 });
 factories_1.BleMultiTransportInterfaceFactory.register('ble', interface_1.BleInterfaceFactory);
 __exportStar(require("./utils"), exports);

package/lib/ble/tacx/adapter.d.ts

@@ -9,5 +9,5 @@ export default class BleTacxAdapter extends BleFmAdapter {
     updateSensor(peripheral: IBlePeripheral): void;
     getProfile(): LegacyProfile;
     protected initControl(props?: BleStartProperties): Promise<void>;
-    protected checkCapabilities(): void;
+    protected checkCapabilities(): Promise<void>;
 }

package/lib/ble/tacx/adapter.js

@@ -41,7 +41,7 @@ class BleTacxAdapter extends fm_1.BleFmAdapter {
     initControl(props) {
         return __awaiter(this, void 0, void 0, function* () {
             var _a;
-            const sensor = this.getComms();
+            const sensor = this.getSensor();
             const { user, wheelDiameter, gearRatio, bikeWeight = consts_1.DEFAULT_BIKE_WEIGHT } = props || {};
             const userWeight = ((_a = user === null || user === void 0 ? void 0 : user.weight) !== null && _a !== void 0 ? _a : consts_1.DEFAULT_USER_WEIGHT);
             sensor.sendTrackResistance(0.0);
@@ -51,15 +51,17 @@ class BleTacxAdapter extends fm_1.BleFmAdapter {
         });
     }
     checkCapabilities() {
-        const before = this.capabilities.join(',');
-        const sensor = this.getComms();
-        if (sensor.features && sensor.features.heartrate && !this.hasCapability(types_1.IncyclistCapability.HeartRate)) {
-            this.capabilities.push(types_1.IncyclistCapability.HeartRate);
-        }
-        const after = this.capabilities.join(',');
-        if (before !== after) {
-            this.emit('device-info', this.getSettings(), { capabilities: this.capabilities });
-        }
+        return __awaiter(this, void 0, void 0, function* () {
+            const before = this.capabilities.join(',');
+            const sensor = this.getSensor();
+            if (sensor.features && sensor.features.heartrate && !this.hasCapability(types_1.IncyclistCapability.HeartRate)) {
+                this.capabilities.push(types_1.IncyclistCapability.HeartRate);
+            }
+            const after = this.capabilities.join(',');
+            if (before !== after) {
+                this.emit('device-info', this.getSettings(), { capabilities: this.capabilities });
+            }
+        });
     }
 }
 BleTacxAdapter.INCYCLIST_PROFILE_NAME = 'Smart Trainer';

package/lib/ble/tacx/comms.d.ts

@@ -1,7 +1,7 @@
 import { LegacyProfile } from "../../antv2/types";
 import { CrankData } from "../cp";
 import { IndoorBikeData } from "../fm";
-import BleFitnessMachineDevice from "../fm/sensor";
+import BleFitnessMachineDevice from "../fm/comms";
 import { BleProtocol, IBlePeripheralConnector } from "../types";
 import { BleFeBikeData } from "./types";
 export default class TacxAdvancedFitnessMachineDevice extends BleFitnessMachineDevice {

package/lib/ble/tacx/comms.js

@@ -13,7 +13,7 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
 };
 Object.defineProperty(exports, "__esModule", { value: true });
 const consts_1 = require("../consts");
-const sensor_1 = __importDefault(require("../fm/sensor"));
+const comms_1 = __importDefault(require("../fm/comms"));
 const utils_1 = require("../utils");
 var ANTMessages;
 (function (ANTMessages) {
@@ -37,7 +37,7 @@ const PROFILE_ID = 'Tacx SmartTrainer';
 const SYNC_BYTE = 0xA4;
 const DEFAULT_CHANNEL = 5;
 const ACKNOWLEDGED_DATA = 0x4F;
-class TacxAdvancedFitnessMachineDevice extends sensor_1.default {
+class TacxAdvancedFitnessMachineDevice extends comms_1.default {
     constructor(props) {
         super(props);
         this.prevCrankData = undefined;

package/lib/ble/tacx/sensor.js

@@ -43,7 +43,7 @@ class TacxAdvancedFitnessMachineDevice extends sensor_1.default {
         }
         this.messageCnt++;
         try {
-            const uuid = characteristic.toLocaleLowerCase();
+            const uuid = (0, utils_1.beautifyUUID)(characteristic).toLowerCase();
             let res = undefined;
             if (uuid && (0, utils_1.matches)(uuid, this.tacxRx)) {
                 res = this.parseFECMessage(data);
@@ -452,8 +452,14 @@ class TacxAdvancedFitnessMachineDevice extends sensor_1.default {
     sendMessage(message) {
         return __awaiter(this, void 0, void 0, function* () {
             this.logEvent({ message: 'write', characteristic: this.tacxTx, data: message.toString('hex') });
-            yield this.write(this.tacxTx, message, { withoutResponse: true });
-            return true;
+            try {
+                yield this.write(this.tacxTx, message, { withoutResponse: true });
+                return true;
+            }
+            catch (err) {
+                this.logEvent({ message: 'write failed', characteristic: this.tacxTx, reason: err.message });
+                return false;
+            }
         });
     }
     sendUserConfiguration(userWeight, bikeWeight, wheelDiameter, gearRatio) {

package/lib/ble/types.d.ts

@@ -1,7 +1,7 @@
 import EventEmitter from "events";
 import { EventLogger } from "gd-eventlog";
 import { DeviceProperties, DeviceSettings, DeviceStartProperties, IncyclistInterface, IncyclistScanProps, InterfaceProps } from "../types";
-export type BleProtocol = 'hr' | 'fm' | 'cp' | 'tacx' | 'wahoo' | 'elite';
+export type BleProtocol = 'hr' | 'fm' | 'cp' | 'tacx' | 'wahoo' | 'elite' | 'csc';
 export type BleInterfaceState = 'unknown' | 'resetting' | 'unsupported' | 'unauthorized' | 'poweredOff' | 'poweredOn';
 export interface BleBinding extends EventEmitter {
     startScanning(serviceUUIDs?: string[], allowDuplicates?: boolean, callback?: (error?: Error) => void): void;
@@ -13,11 +13,17 @@ export interface BleBinding extends EventEmitter {
     state: BleInterfaceState;
     on(eventName: string | symbol, listener: (...args: any[]) => void): this;
 }
+export interface BleRawAdvertisement {
+    address?: string;
+    localName?: string;
+    serviceUuids?: string[];
+    rssi?: number;
+}
 export interface BleRawPeripheral extends EventEmitter {
     id?: string;
     address?: string;
     name?: string;
-    services: [];
+    services: any[];
     advertisement: any;
     state: string;
     connectAsync(): Promise<void>;

package/lib/ble/utils.d.ts

@@ -19,4 +19,5 @@ export declare const beautifyUUID: (str: string, withX?: boolean) => string;
 export declare const fullUUID: (str: string) => string;
 export declare const propertyVal: (properties: BleProperty[]) => number;
 export declare const propertyFromVal: (val: number) => BleProperty[];
+export declare const bit: (nr: any) => number;
 export {};

package/lib/ble/utils.js

@@ -1,6 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.propertyFromVal = exports.propertyVal = exports.fullUUID = exports.beautifyUUID = exports.parseUUID = void 0;
+exports.bit = exports.propertyFromVal = exports.propertyVal = exports.fullUUID = exports.beautifyUUID = exports.parseUUID = void 0;
 exports.mapLegacyProfile = mapLegacyProfile;
 exports.uuid = uuid;
 exports.matches = matches;
@@ -138,3 +138,7 @@ const propertyFromVal = (val) => {
     return res;
 };
 exports.propertyFromVal = propertyFromVal;
+const bit = (nr) => {
+    return (1 << nr);
+};
+exports.bit = bit;

package/lib/ble/wahoo/adapter.d.ts

@@ -8,4 +8,5 @@ export default class BleWahooAdapter extends BleFmAdapter {
     isSame(device: IAdapter): boolean;
     getProfile(): LegacyProfile;
     updateSensor(peripheral: IBlePeripheral): void;
+    protected checkCapabilities(): Promise<void>;
 }

package/lib/ble/wahoo/adapter.js

@@ -1,4 +1,13 @@
 "use strict";
+var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, generator) {
+    function adopt(value) { return value instanceof P ? value : new P(function (resolve) { resolve(value); }); }
+    return new (P || (P = Promise))(function (resolve, reject) {
+        function fulfilled(value) { try { step(generator.next(value)); } catch (e) { reject(e); } }
+        function rejected(value) { try { step(generator["throw"](value)); } catch (e) { reject(e); } }
+        function step(result) { result.done ? resolve(result.value) : adopt(result.value).then(fulfilled, rejected); }
+        step((generator = generator.apply(thisArg, _arguments || [])).next());
+    });
+};
 var __importDefault = (this && this.__importDefault) || function (mod) {
     return (mod && mod.__esModule) ? mod : { "default": mod };
 };
@@ -28,6 +37,11 @@ class BleWahooAdapter extends fm_1.BleFmAdapter {
     updateSensor(peripheral) {
         this.device = new sensor_1.default(peripheral, { logger: this.logger });
     }
+    checkCapabilities() {
+        return __awaiter(this, void 0, void 0, function* () {
+            this.logEvent({ message: 'device capabilities updated', name: this.getSettings().name, interface: this.getSettings().interface, capabilities: this.capabilities });
+        });
+    }
 }
 BleWahooAdapter.INCYCLIST_PROFILE_NAME = 'Smart Trainer';
 exports.default = BleWahooAdapter;

package/lib/ble/wahoo/comms.d.ts

@@ -1,7 +1,7 @@
 import { LegacyProfile } from "../../antv2/types";
 import { CrankData } from "../cp";
 import { IndoorBikeData } from "../fm";
-import BleFitnessMachineDevice from "../fm/sensor";
+import BleFitnessMachineDevice from "../fm/comms";
 import { BleProtocol, BleWriteProps, IBlePeripheralConnector } from "../types";
 export declare const enum OpCode {
     unlock = 32,

package/lib/ble/wahoo/comms.js

@@ -15,10 +15,10 @@ Object.defineProperty(exports, "__esModule", { value: true });
 const _1 = require(".");
 const consts_1 = require("../../base/consts");
 const consts_2 = require("../consts");
-const sensor_1 = __importDefault(require("../fm/sensor"));
+const comms_1 = __importDefault(require("../fm/comms"));
 const utils_1 = require("../utils");
 const ErgWriteDelay = 2000;
-class BleWahooDevice extends sensor_1.default {
+class BleWahooDevice extends comms_1.default {
     constructor(props) {
         super(props);
         this.prevCrankData = undefined;

package/lib/ble/wahoo/sensor.js

@@ -43,11 +43,8 @@ class BleWahooDevice extends sensor_1.default {
         return [consts_2.INDOOR_BIKE_DATA, consts_2.FTMS_STATUS, consts_2.CSP_MEASUREMENT, consts_2.HR_MEASUREMENT];
     }
     onData(characteristic, data) {
-        const hasData = super.onData(characteristic, data);
-        if (!hasData)
-            return false;
-        const uuid = characteristic.toLowerCase();
-        let res = undefined;
+        const uuid = (0, utils_1.beautifyUUID)(characteristic).toLowerCase();
+        let res;
         switch (uuid) {
             case consts_2.CSP_MEASUREMENT:
                 res = this.parsePower(data);
@@ -62,7 +59,7 @@ class BleWahooDevice extends sensor_1.default {
                 res = this.parseFitnessMachineStatus(data);
                 break;
             default:
-                this.logEvent({ message: 'data', uuid, data: data.toString('hex') });
+                this.logEvent({ message: 'data', uuid, data: Buffer.from(data).toString('hex') });
                 break;
         }
         if (res) {

package/lib/direct-connect/base/interface.d.ts

@@ -29,6 +29,7 @@ export default class DirectConnectInterface extends EventEmitter implements IBle
     protected connected: boolean;
     static getInstance(props?: InterfaceProps): DirectConnectInterface;
     constructor(props: InterfaceProps);
+    setProps(props: InterfaceProps): void;
     createPeripheral(announcement: MulticastDnsAnnouncement): IBlePeripheral;
     createDeviceSetting(service: MulticastDnsAnnouncement): BleDeviceSettings;
     createPeripheralFromSettings(settings: DeviceSettings): IBlePeripheral;

package/lib/direct-connect/base/interface.js

@@ -27,6 +27,7 @@ class DirectConnectInterface extends events_1.default {
         if (DirectConnectInterface._instance === undefined)
             DirectConnectInterface._instance = new DirectConnectInterface(props);
         else {
+            DirectConnectInterface._instance.setProps(props);
             if (props.binding) {
                 DirectConnectInterface._instance.setBinding(props.binding);
             }
@@ -54,9 +55,13 @@ class DirectConnectInterface extends events_1.default {
         }
         this.internalEvents = new events_1.default();
         this.instance = ++instanceId;
-        if (this.binding)
+        const { enabled } = props;
+        if (this.binding && (enabled !== null && enabled !== void 0 ? enabled : false))
             this.autoConnect();
     }
+    setProps(props) {
+        this.props = props;
+    }
     createPeripheral(announcement) {
         return peripheral_1.DirectConnectPeripheral.create(announcement);
     }
@@ -83,7 +88,7 @@ class DirectConnectInterface extends events_1.default {
     setBinding(binding) {
         const prev = this.binding;
         this.binding = binding;
-        if (!prev)
+        if (!prev && this.props.enabled)
             this.autoConnect();
     }
     getBinding() {
@@ -238,10 +243,10 @@ class DirectConnectInterface extends events_1.default {
                 this.services[idx] = { ts: Date.now(), service };
             }
             else {
-                this.logEvent({ message: 'device announced', device: service.name, announcement: service, source });
                 this.services.push({ ts: Date.now(), service });
-                if (service.type !== DC_TYPE && ((_a = service.serviceUUIDs) === null || _a === void 0 ? void 0 : _a.length) === 0)
+                if (!((_a = service.serviceUUIDs) === null || _a === void 0 ? void 0 : _a.length))
                     return;
+                this.logEvent({ message: 'device announced', device: service.name, announcement: service, source });
                 this.emitDevice(service);
                 (_b = this.matching) === null || _b === void 0 ? void 0 : _b.push(service.name);
             }

package/lib/direct-connect/base/peripheral.d.ts

@@ -21,24 +21,24 @@ export declare class DirectConnectPeripheral implements IBlePeripheral {
     constructor(announcement: MulticastDnsAnnouncement);
     get services(): BleService[];
     connect(): Promise<boolean>;
-    disconnect(): Promise<boolean>;
+    disconnect(connectionLost?: boolean): Promise<boolean>;
     isConnected(): boolean;
     isConnecting(): boolean;
     onDisconnect(callback: () => void): void;
     discoverServices(): Promise<string[]>;
     discoverCharacteristics(serviceUUID: string): Promise<BleCharacteristic[]>;
-    subscribe(characteristicUUID: string, callback: (characteristicUuid: string, data: Buffer) => void): Promise<boolean>;
+    subscribe(characteristicUUID: string, callback?: (characteristicUuid: string, data: Buffer) => void): Promise<boolean>;
     unsubscribe(characteristicUUID: string): Promise<boolean>;
     subscribeAll(callback: (characteristicUuid: string, data: Buffer) => void): Promise<boolean>;
     subscribeSelected(characteristics: string[], callback: (characteristicUuid: string, data: Buffer) => void): Promise<boolean>;
-    unsubscribeAll(): Promise<boolean>;
+    unsubscribeAll(connectionLost?: boolean): Promise<void>;
     read(characteristicUUID: string): Promise<Buffer>;
     write(characteristicUUID: string, data: Buffer, options?: BleWriteProps): Promise<Buffer>;
     protected startConnection(): Promise<boolean>;
     protected onPortError(err: Error): void;
     protected onPortClose(): Promise<void>;
     protected getPath(): string;
-    protected stopConnection(): Promise<boolean>;
+    protected stopConnection(connectionLost?: boolean): Promise<boolean>;
     protected getNextSeqNo(): number;
     protected send(seqNo: number, data: Buffer): Promise<Buffer>;
     protected getNextMessage(data: Buffer): Buffer;