incyclist-devices 2.1.11 → 2.1.12

package/lib/serial/base/comms.d.ts

@@ -37,6 +37,8 @@ export default class SerialPortComms<T extends CommsState, C extends Request, R
     isConnected(): boolean;
     pauseLogging(): void;
     resumeLogging(): void;
+    pause(): void;
+    resume(): void;
     logEvent(e: any): void;
     connect(): Promise<boolean>;
     onConnected(): void;

package/lib/serial/base/comms.js

@@ -51,6 +51,12 @@ class SerialPortComms {
     resumeLogging() {
         this.isLoggingPaused = false;
     }
+    pause() {
+        this.pauseLogging();
+    }
+    resume() {
+        this.resumeLogging();
+    }
     logEvent(e) {
         if (this.isLoggingPaused)
             return;

package/lib/serial/bindings/tcp.d.ts

@@ -24,10 +24,16 @@ export declare class TCPPortBinding implements BindingPortInterface {
     writeOperation: null | Promise<any>;
     data: Buffer;
     private pendingRead;
+    private onDataHandler;
+    private onErrorHandler;
+    private onTimeoutHandler;
+    private onCloseHandler;
     constructor(socket: net.Socket, options: Required<OpenOptions>);
     get isOpen(): boolean;
     onData(data: Buffer): void;
     onError(err: Error): void;
+    onTimeout(): void;
+    onClose(): void;
     close(): Promise<void>;
     read(buffer: Buffer, offset: number, length: number): Promise<{
         buffer: Buffer;

package/lib/serial/bindings/tcp.js

@@ -141,6 +141,10 @@ exports.TCPBinding = {
 };
 class TCPPortBinding {
     constructor(socket, options) {
+        this.onDataHandler = this.onData.bind(this);
+        this.onErrorHandler = this.onError.bind(this);
+        this.onTimeoutHandler = this.onTimeout.bind(this);
+        this.onCloseHandler = this.onClose.bind(this);
         this.logger = new gd_eventlog_1.EventLogger('TCPPort');
         this.socket = socket;
         this.openOptions = options;
@@ -148,11 +152,11 @@ class TCPPortBinding {
         this.writeOperation = null;
         this.data = null;
         this.socket.removeAllListeners();
-        this.socket.on('data', this.onData.bind(this));
-        this.socket.on('error', this.onError.bind(this));
-        this.socket.on('close', () => { this.close(); });
-        this.socket.on('end', () => { this.close(); });
-        this.socket.on('timeout', () => { this.onError(new Error('socket timeout')); });
+        this.socket.on('data', this.onDataHandler);
+        this.socket.on('error', this.onErrorHandler);
+        this.socket.on('close', this.onCloseHandler);
+        this.socket.on('end', this.onCloseHandler);
+        this.socket.on('timeout', this.onTimeoutHandler);
     }
     get isOpen() {
         return this.socket !== null;
@@ -168,11 +172,21 @@ class TCPPortBinding {
         }
     }
     onError(err) {
+        this.logger.logEvent({ message: 'Port Error', error: err.message });
         if (this.pendingRead) {
             this.pendingRead(err);
             this.socket = null;
         }
     }
+    onTimeout() {
+        this.logger.logEvent({ message: 'Port Timeout' });
+        if (this.pendingRead) {
+            this.pendingRead(new Error('timeout'));
+        }
+    }
+    onClose() {
+        this.close();
+    }
     close() {
         return __awaiter(this, void 0, void 0, function* () {
             if (!this.isOpen)
@@ -217,6 +231,10 @@ class TCPPortBinding {
                 return new Promise((resolve, reject) => {
                     this.pendingRead = err => {
                         if (err) {
+                            if (err.message === 'timeout') {
+                                resolve({ buffer: Buffer.from([]), bytesRead: 0 });
+                                return;
+                            }
                             return reject(err);
                         }
                         this.read(buffer, offset, length).then(resolve, reject);

package/lib/serial/daum/DaumAdapter.js

@@ -117,7 +117,7 @@ class DaumAdapter extends adapter_1.SerialIncyclistDevice {
         return __awaiter(this, void 0, void 0, function* () {
             yield this.stopUpdatePull();
             const paused = yield _super.pause.call(this);
-            (_a = this.comms) === null || _a === void 0 ? void 0 : _a.pauseLogging();
+            (_a = this.comms) === null || _a === void 0 ? void 0 : _a.pause();
             return paused;
         });
     }
@@ -128,7 +128,7 @@ class DaumAdapter extends adapter_1.SerialIncyclistDevice {
         var _a;
         return __awaiter(this, void 0, void 0, function* () {
             const resumed = yield _super.resume.call(this);
-            (_a = this.comms) === null || _a === void 0 ? void 0 : _a.resumeLogging();
+            (_a = this.comms) === null || _a === void 0 ? void 0 : _a.resume();
             if (startUpdatePull)
                 yield this.startUpdatePull();
             return resumed;
@@ -256,9 +256,14 @@ class DaumAdapter extends adapter_1.SerialIncyclistDevice {
         });
     }
     cleanupInterval() {
-        clearInterval(this.iv.sync);
-        clearInterval(this.iv.update);
-        this.iv.emitter.removeAllListeners();
+        if (!this.iv)
+            return;
+        if (this.iv.sync)
+            clearInterval(this.iv.sync);
+        if (this.iv.sync)
+            clearInterval(this.iv.update);
+        if (this.iv.emitter)
+            this.iv.emitter.removeAllListeners();
         this.iv = undefined;
     }
     stopUpdatePull() {

package/lib/serial/daum/premium/comms.d.ts

@@ -5,6 +5,7 @@ import { DaumSerialComms } from "../types";
 import { OnDeviceStartCallback, DaumPremiumCommsState, DaumPremiumRequest, ResponseObject, Route } from "./types";
 import SerialPortComms from "../../base/comms";
 export default class Daum8i extends SerialPortComms<DaumPremiumCommsState, DaumPremiumRequest, ResponseObject> implements DaumSerialComms {
+    private onDataHandler;
     validatePath(path: string): string;
     getDefaultLoggerName(): string;
     getAckTimeoutValue(): number;
@@ -43,4 +44,6 @@ export default class Daum8i extends SerialPortComms<DaumPremiumCommsState, DaumP
     programUploadDone(): Promise<boolean>;
     startProgram(programId?: number): Promise<boolean>;
     programUpload(bikeType: string, route: Route, onStatusUpdate?: OnDeviceStartCallback): Promise<boolean>;
+    pause(): void;
+    resume(): void;
 }

package/lib/serial/daum/premium/comms.js

@@ -20,6 +20,10 @@ const utils_2 = require("../../../utils/utils");
 const comms_1 = __importDefault(require("../../base/comms"));
 const consts_1 = require("./consts");
 class Daum8i extends comms_1.default {
+    constructor() {
+        super(...arguments);
+        this.onDataHandler = this.onData.bind(this);
+    }
     validatePath(path) {
         return (0, utils_1.validatePath)(path);
     }
@@ -33,7 +37,7 @@ class Daum8i extends comms_1.default {
         return consts_1.DEFAULT_TIMEOUT;
     }
     onConnected() {
-        this.sp.on('data', this.onData.bind(this));
+        this.sp.on('data', this.onDataHandler);
     }
     getInitialCommsState() {
         const state = super.getInitialCommsState();
@@ -574,5 +578,11 @@ class Daum8i extends comms_1.default {
             }
         });
     }
+    pause() {
+        super.pause();
+    }
+    resume() {
+        super.resume();
+    }
 }
 exports.default = Daum8i;

package/lib/serial/daum/types.d.ts

@@ -1,8 +1,8 @@
 export declare abstract class DaumSerialComms {
     serial: any;
     abstract getPort(): string;
-    abstract pauseLogging(): void;
-    abstract resumeLogging(): void;
+    abstract pause(): void;
+    abstract resume(): void;
     abstract isConnected(): boolean;
     abstract connect(): Promise<boolean>;
     abstract close(): Promise<boolean>;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "incyclist-devices",
-  "version": "2.1.11",
+  "version": "2.1.12",
   "dependencies": {
     "@serialport/bindings-interface": "^1.2.2",
     "@serialport/parser-byte-length": "^9.0.1",