incremnt 0.7.1 → 0.7.2

package/src/sync-service.js

@@ -690,6 +690,42 @@ function parseLimit(value, { defaultValue, max }) {
   return Number.isFinite(parsed) && parsed > 0 ? Math.min(parsed, max) : defaultValue;
 }
 
+function coachObservationSourceTriggerForScoreSnapshots(snapshots) {
+  if (!Array.isArray(snapshots)) return undefined;
+  const reasons = snapshots.map((snapshot) => snapshot?.triggerReason);
+  if (reasons.length === 0 || reasons.some((reason) => !reason)) return undefined;
+  if (reasons.includes('sessionSave')) return 'session_completed';
+  if (reasons.every((reason) => reason === 'historicalBackfill')) {
+    return 'manual_backfill';
+  }
+  if (reasons.every((reason) => reason === 'dailyRefresh')) {
+    return 'daily_refresh';
+  }
+  return undefined;
+}
+
+function coachObservationGenerationMetadata(result, sourceTrigger) {
+  return {
+    attempted: true,
+    generated: Number(result?.generated ?? 0),
+    persisted: Number(result?.persisted ?? 0),
+    skippedReason: result?.skippedReason ?? null,
+    sourceTrigger: sourceTrigger ?? null
+  };
+}
+
+function normalizeAskCoachObservationFollowUp(value) {
+  if (!value || typeof value !== 'object') return null;
+  const id = String(value.id ?? '').trim();
+  return id ? { id: id.slice(0, 128) } : null;
+}
+
+function selectAskCoachObservationFollowUp(requested, observations) {
+  if (!requested) return null;
+  return (Array.isArray(observations) ? observations : [])
+    .find((observation) => String(observation?.id ?? '') === requested.id);
+}
+
 function routeRequest(url, method) {
   const pathname = url.pathname;
 
@@ -1064,7 +1100,13 @@ function routeRequest(url, method) {
   }
 
   if (pathname === '/cli/coach-observations/current') {
-    return { command: 'coach-observations-current', options: { limit: url.searchParams.get('limit') ?? undefined } };
+    return {
+      command: 'coach-observations-current',
+      options: {
+        limit: url.searchParams.get('limit') ?? undefined,
+        refresh: url.searchParams.get('refresh') ?? undefined
+      }
+    };
   }
 
   {
@@ -2037,6 +2079,7 @@ export function createSyncServiceRequestHandler({
   insertScoreSnapshotsForAccount = null,
   listScoreSnapshotsForAccount = null,
   getCurrentWeeklyScoreDigestForAccount = null,
+  generateCoachObservationsForAccount = null,
   listCurrentCoachObservationsForAccount = null,
   markCoachObservationSeenForAccount = null,
   dismissCoachObservationForAccount = null,
@@ -2906,6 +2949,22 @@ export function createSyncServiceRequestHandler({
               return;
             }
             const result = await insertScoreSnapshotsForAccount(account, body.snapshots);
+            if (generateCoachObservationsForAccount) {
+              const sourceTrigger = coachObservationSourceTriggerForScoreSnapshots(body.snapshots);
+              try {
+                const generationResult = await generateCoachObservationsForAccount(account, { sourceTrigger });
+                result.coachObservations = coachObservationGenerationMetadata(generationResult, sourceTrigger);
+              } catch (error) {
+                console.error('Coach observation generation after score upload failed:', error.message);
+                result.coachObservations = {
+                  attempted: true,
+                  generated: 0,
+                  persisted: 0,
+                  skippedReason: 'generation_failed',
+                  sourceTrigger
+                };
+              }
+            }
             json(response, 200, result);
             return;
           } catch (error) {
@@ -3549,16 +3608,62 @@ export function createSyncServiceRequestHandler({
           methodNotAllowed(response, 'Use GET for /cli/coach-observations/current.');
           return;
         }
+        if (route.options.refresh && route.options.refresh !== 'morning_open') {
+          badRequest(response, 'Unsupported coach observations refresh value.');
+          return;
+        }
         if (!listCurrentCoachObservationsForAccount) {
           json(response, 503, { error: 'Coach observations not available' });
           return;
         }
         try {
           const limit = parseLimit(route.options.limit, { defaultValue: 5, max: 20 });
+          let refresh = null;
+          if (route.options.refresh === 'morning_open') {
+            const writeAccount = writeAuthenticator
+              ? await writeAuthenticator(requestToken)
+              : requestToken === token
+                ? account
+                : null;
+            if (!writeAccount) {
+              unauthorized(response, request);
+              return;
+            }
+            const sourceTrigger = 'daily_refresh';
+            if (generateCoachObservationsForAccount) {
+              try {
+                const generationResult = await generateCoachObservationsForAccount(writeAccount, {
+                  sourceTrigger,
+                  refresh: route.options.refresh
+                });
+                refresh = coachObservationGenerationMetadata(generationResult, sourceTrigger);
+              } catch (error) {
+                console.error('Coach observation generation on morning open failed:', error.message);
+                refresh = {
+                  attempted: true,
+                  generated: 0,
+                  persisted: 0,
+                  skippedReason: 'generation_failed',
+                  sourceTrigger
+                };
+              }
+            } else {
+              refresh = {
+                attempted: false,
+                generated: 0,
+                persisted: 0,
+                skippedReason: 'generation_unavailable',
+                sourceTrigger
+              };
+            }
+          }
           const observations = await listCurrentCoachObservationsForAccount(account, {
             limit
           });
-          json(response, 200, { observations: observations ?? [] });
+          json(response, 200, {
+            observations: observations ?? [],
+            ...(refresh ? { refresh } : {})
+          });
         } catch (err) {
           console.error('Coach observations read error:', err.message);
           json(response, 500, { error: 'Failed to read coach observations' });
@@ -4274,6 +4379,7 @@ export function createSyncServiceRequestHandler({
 
         const queries = await import('./queries.js');
         const exclude = parseExclude(body?.exclude);
+        const requestedCoachObservation = normalizeAskCoachObservationFollowUp(body?.coachObservation);
         let coachFacts = [];
         if (listCoachFactsForAccount) {
           try {
@@ -4303,15 +4409,18 @@ export function createSyncServiceRequestHandler({
         let coachObservations = [];
         if (listCurrentCoachObservationsForAccount) {
           try {
-            coachObservations = await listCurrentCoachObservationsForAccount(account, { limit: 3 }) ?? [];
+            coachObservations = await listCurrentCoachObservationsForAccount(account, { limit: requestedCoachObservation ? 10 : 3 }) ?? [];
           } catch (observationErr) {
             console.error('Coach observations read error (ask):', observationErr.message);
           }
         }
+        const coachObservationFollowUp = selectAskCoachObservationFollowUp(requestedCoachObservation, coachObservations);
 
-        const routedContext = queries.askRoutedContext
-          ? queries.askRoutedContext(snapshot, question, { exclude, coachFacts, coachObservations })
-          : { context: queries.askContext(snapshot, { exclude }), metadata: { route: 'legacy' } };
+        const routedContext = coachObservationFollowUp && queries.askObservationFollowUpContext
+          ? queries.askObservationFollowUpContext(snapshot, question, coachObservationFollowUp, { exclude, coachFacts })
+          : queries.askRoutedContext
+            ? queries.askRoutedContext(snapshot, question, { exclude, coachFacts, coachObservations })
+            : { context: queries.askContext(snapshot, { exclude }), metadata: { route: 'legacy' } };
         const persistedKind = persistedConversation?.kind ?? (conversationId?.startsWith('weekly-checkin:') ? 'weekly-checkin' : 'ask');
         const incrementScorePrelude = formatIncrementScorePrelude(scoreSnapshots);