import-in-the-middle 1.14.0 → 1.14.2

package/.release-please-manifest.json

@@ -1,3 +1,3 @@
 {
-  ".": "1.14.0"
+  ".": "1.14.2"
 }

package/CHANGELOG.md

@@ -1,5 +1,19 @@
 # Changelog
 
+## [1.14.2](https://github.com/nodejs/import-in-the-middle/compare/import-in-the-middle-v1.14.1...import-in-the-middle-v1.14.2) (2025-06-13)
+
+
+### Bug Fixes
+
+* do not replace dollar sign in shim variable name ([#200](https://github.com/nodejs/import-in-the-middle/issues/200)) ([20bf0e5](https://github.com/nodejs/import-in-the-middle/commit/20bf0e5c5f6f44f42a8618ad45d08622a63d4d45))
+
+## [1.14.1](https://github.com/nodejs/import-in-the-middle/compare/import-in-the-middle-v1.14.0...import-in-the-middle-v1.14.1) (2025-06-12)
+
+
+### Bug Fixes
+
+* Account for invalid identifiers ([#198](https://github.com/nodejs/import-in-the-middle/issues/198)) ([2cc8207](https://github.com/nodejs/import-in-the-middle/commit/2cc82070a5ca947463b70f28647b03496a9526f0))
+
 ## [1.14.0](https://github.com/nodejs/import-in-the-middle/compare/import-in-the-middle-v1.13.2...import-in-the-middle-v1.14.0) (2025-05-24)
 
 

package/hook.js

@@ -254,19 +254,23 @@ async function processModule ({ srcUrl, context, parentGetSource, parentResolve,
         addSetter(name, setter, true)
       }
     } else {
+      const variableName = `$${n.replace(/[^a-zA-Z0-9_$]/g, '_')}`
+      const objectKey = JSON.stringify(n)
+      const reExportedName = n === 'default' || NODE_MAJOR < 16 ? n : objectKey
+
       addSetter(n, `
-      let $${n}
+      let ${variableName}
       try {
-        $${n} = _.${n} = namespace.${n}
+        ${variableName} = _[${objectKey}] = namespace[${objectKey}]
       } catch (err) {
         if (!(err instanceof ReferenceError)) throw err
       }
-      export { $${n} as ${n} }
-      set.${n} = (v) => {
-        $${n} = v
+      export { ${variableName} as ${reExportedName} }
+      set[${objectKey}] = (v) => {
+        ${variableName} = v
         return true
       }
-      get.${n} = () => $${n}
+      get[${objectKey}] = () => ${variableName}
       `)
     }
   }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "import-in-the-middle",
-  "version": "1.14.0",
+  "version": "1.14.2",
   "description": "Intercept imports in Node.js",
   "main": "index.js",
   "scripts": {

package/test/fixtures/invalid-identifier.js

@@ -0,0 +1,8 @@
+// These export identifiers are only supported in Node 16+
+exports['one.two'] = () => console.log('b')
+
+// See: https://github.com/nodejs/import-in-the-middle/issues/94
+exports['unsigned short'] = 'something'
+
+exports._ = 'foo'
+exports.$ = 'bar'

package/test/fixtures/module-exports-cjs-shim.mjs

@@ -0,0 +1,7 @@
+// Regression test for https://github.com/nodejs/import-in-the-middle/issues/196
+
+export default function foo () {
+  // do nothing
+}
+
+export { foo as 'module.exports' }

package/test/hook/v16-fake-cjs-export.mjs

@@ -0,0 +1,4 @@
+import ui from '../fixtures/module-exports-cjs-shim.mjs'
+import { notStrictEqual } from 'assert'
+
+notStrictEqual(ui, undefined)

package/test/hook/v16-invalid-identifier.mjs

@@ -0,0 +1,5 @@
+import * as lib from '../fixtures/invalid-identifier.js'
+import { strictEqual } from 'assert'
+
+strictEqual(typeof lib['one.two'], 'function')
+strictEqual(typeof lib['unsigned short'], 'string')