impermax-sdk 2.1.186 → 2.1.188

package/lib/onchain/interactions/lendingPool/nftlp/onchainInteractionsNftlpUniswapV3.js

@@ -81,7 +81,6 @@ class OnchainInteractionsNftlpUniswapV3 extends onchainInteractionsNftlp_1.defau
         // Borrow and mint
         if ((borrowADelta > 0 && depositADelta > 0) || (borrowBDelta > 0 && depositBDelta > 0)) {
             // slightly increase borrowDelta in order to avoid amountUser to be dust
-            // TODO what if one of these is negative?
             const actualBorrowADelta = Math.max(borrowADelta * this.getDust(), 0);
             const actualBorrowBDelta = Math.max(borrowBDelta * this.getDust(), 0);
             const amountAUser = Math.max(depositADelta - actualBorrowADelta, 0);

package/lib/utils/position/uniswapV3/index.js

@@ -316,9 +316,9 @@ class UniswapV3Position {
     }
     // amountX and amountY are expected to have the same sign
     getOptimalLiquidity(amountX, amountY) {
-        if (amountX != 0 && amountY != 0) {
-            const sampleX = this.getRealXGivenLiquidity(1);
-            const sampleY = this.getRealYGivenLiquidity(1);
+        const sampleX = this.getRealXGivenLiquidity(1);
+        const sampleY = this.getRealYGivenLiquidity(1);
+        if (sampleX != 0 && sampleY != 0) {
             if (sampleX == 0)
                 amountX = 0;
             else if (sampleY == 0)
@@ -369,6 +369,8 @@ class UniswapV3Position {
     getMaxWithdrawable() {
         const depositedX = this.getDepositedX();
         const depositedY = this.getDepositedY();
+        const additionalDepositX = this.getRealX() - this.getInitialRealX();
+        const additionalDepositY = this.getRealY() - this.getInitialRealY();
         let percentage = 0;
         if (!this.isLiquidatable()) {
             if (this.debtX == 0 && this.debtY == 0) {
@@ -382,8 +384,8 @@ class UniswapV3Position {
             }
         }
         return {
-            amountX: depositedX * percentage,
-            amountY: depositedY * percentage,
+            amountX: depositedX * percentage - additionalDepositX,
+            amountY: depositedY * percentage - additionalDepositY,
         };
     }
     getMaxBorrowableX() {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "impermax-sdk",
-  "version": "2.1.186",
+  "version": "2.1.188",
   "description": "",
   "main": "./lib/index.js",
   "module": "./lib/index.js",