npm - impel-cli - Versions diffs - 0.20.47 → 0.20.49 - Mend

impel-cli 0.20.47 → 0.20.49

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (4) hide show

package/RELEASE_NOTES.md +37 -0
package/package.json +1 -1
package/src/desktopTasks.js +94 -62
package/src/managedProfileVersion.js +3 -3

package/RELEASE_NOTES.md CHANGED Viewed

@@ -1,5 +1,42 @@
 # Release notes
+## 0.20.49 — Restore managed app startup
+- Restores normal ChatGPT and Claude startup by disabling the experimental
+  embedded Tasks UI in managed vendor apps. The fallback's Electron window and
+  DOM-injection paths no longer run in production.
+- Retains tenant-bound Tasks through the CLI and MCP while the desktop entry
+  point is redesigned against an explicitly supported vendor integration seam.
+- Makes every production-generated main preload an exact inert stub. The
+  reviewed prototype remains test-only and cannot be enabled by a managed app
+  environment variable.
+- Advances the managed profile contract to v40 so every existing macOS app
+  rewrites and reloads the corrected external Tasks preload. Vendor pins and
+  built bundle bytes remain unchanged.
+- Adds a production-default contract proving the embedded path is inert, while
+  retaining deterministic coverage for the prototype behind its opt-in. The
+  pinned managed-app smoke also requires the normal working surface, the exact
+  inert preload bytes, zero injected controls, and zero Tasks web requests.
+## 0.20.48 — Confine Tasks to the primary app window
+- Fixes the remaining `0.20.47` regression that let an auxiliary ChatGPT or
+  Claude renderer attach a second authenticated Tasks board in a large framed
+  window, obscuring the normal app.
+- Binds Tasks once to the canonical primary vendor window, rejects child,
+  internal, auxiliary, and unowned renderers fail-closed, and removes focused-
+  window guessing from navigation ownership.
+- Couples fallback installation to the canonical renderer and deduplicates
+  paired Electron navigation events so one user action creates at most one
+  board view.
+- Advances the managed profile contract to v39 so every existing install
+  rewrites and reloads the corrected external Tasks preload. Vendor pins and
+  built bundle bytes remain unchanged.
+- Adds a behavioral reproduction of the production screenshot: an auxiliary
+  renderer fires both navigation events before the fallback is clicked, while
+  the test proves exactly one board attaches to the primary window and the
+  fallback remains a frameless 120×38 control.
 ## 0.20.47 — Keep Tasks on the primary app window
 - Makes the native Tasks fallback choose the earliest surviving primary host

package/package.json CHANGED Viewed

@@ -1,6 +1,6 @@
 {
   "name": "impel-cli",
-  "version": "0.20.47",
+  "version": "0.20.49",
   "description": "Prepare isolated Claude and Codex workspaces for every accessible Impel tenant",
   "type": "module",
   "bin": {

package/src/desktopTasks.js CHANGED Viewed

@@ -103,6 +103,7 @@ const NAVIGATION_SOURCE = String.raw`(() => {
   let slot = null;
   let active = false;
   let lastAnchor = null;
+  let readySignalled = false;
   const roots = () => {
     const result = [document];
     for (let index = 0; index < result.length; index += 1) {
@@ -233,6 +234,10 @@ const NAVIGATION_SOURCE = String.raw`(() => {
       slot = nav;
     }
     select(active);
+    if (nav?.isConnected && !readySignalled) {
+      readySignalled = true;
+      setTimeout(() => signal("ready"), 0);
+    }
   };
   const style = document.createElement("style");
   style.textContent = "#" + NAV_ID + " svg{width:16px;height:16px;flex:0 0 auto}#" + NAV_ID + "." + ACTIVE_CLASS + "{background:color-mix(in srgb,CanvasText 10%,transparent)}#" + NAV_ID + ":focus-visible{outline:2px solid #7c8cff;outline-offset:2px}";
@@ -260,13 +265,19 @@ const NAVIGATION_SOURCE = String.raw`(() => {
     style.remove();
     delete window.__impelDesktopTasksSetActive;
   };
-  return { anchor: lastAnchor ? label(lastAnchor) : null, connected: Boolean(nav?.isConnected) };
+  const shellControls = controls().filter((element) => visible(element) && Boolean(label(element)));
+  return {
+    anchor: lastAnchor ? label(lastAnchor) : null,
+    connected: Boolean(nav?.isConnected),
+    shellReady: shellControls.length >= 2,
+  };
 })();`;
 const NATIVE_NAVIGATION_HTML = `<!doctype html><html lang="en"><head><meta charset="utf-8"><meta http-equiv="Content-Security-Policy" content="default-src 'none';script-src 'unsafe-inline';style-src 'unsafe-inline'"><style>:root{color-scheme:light dark;font-family:-apple-system,BlinkMacSystemFont,"Segoe UI",sans-serif}*{box-sizing:border-box}html,body{width:100%;height:100%;margin:0;overflow:hidden}button{width:100%;height:100%;display:flex;align-items:center;gap:9px;border:0;border-radius:8px;padding:0 12px;background:color-mix(in srgb,Canvas 92%,CanvasText 8%);color:CanvasText;cursor:pointer}svg{width:16px;height:16px}</style></head><body><button id="tasks" type="button" aria-label="Tasks">${TASKS_ICON}<span>Tasks</span></button><script>const button=document.getElementById("tasks");button.addEventListener("click",()=>{button.dataset.active="true";window.impelDesktopTasks.show()});window.__impelDesktopTasksSetActive=active=>{button.dataset.active=String(Boolean(active))}</script></body></html>`;
-export function desktopTasksMainPreload(appUrl) {
+export function desktopTasksMainPreload(appUrl, { enableEmbed = false } = {}) {
   const appOrigin = desktopTasksAppOrigin(appUrl);
+  if (!enableEmbed) return `"use strict";\n`;
   const parserSource = parseDesktopTasksCredential.toString();
   const escapeRegexSource = escapeRegex.toString();
   return `"use strict";
@@ -367,13 +378,8 @@ if (
     const internalContents = new Set();
     const nativeNavOwners = new Map();
     const configuredSessions = new WeakSet();
-    let creatingInternalWindow = false;
     let hasDomNavigation = false;
-    const createInternalWindow = (options) => {
-      creatingInternalWindow = true;
-      try { return new BrowserWindow(options); }
-      finally { creatingInternalWindow = false; }
-    };
+    let primaryHost = null;
     const stateFor = (window) => {
       let state = windows.get(window.id);
       if (!state) {
@@ -467,7 +473,25 @@ if (
         }
       }
     };
+    const isHostWindow = (window) => {
+      if (!window || window.isDestroyed() || window.getParentWindow?.()) return false;
+      try {
+        const rawUrl = window.webContents.getURL();
+        if (!rawUrl || rawUrl === "about:blank") return false;
+        const url = new URL(rawUrl);
+        if (url.searchParams.has("initialRoute")) return false;
+      } catch { return false; }
+      return true;
+    };
+    const primaryHostWindow = () => {
+      if (isHostWindow(primaryHost)) return primaryHost;
+      primaryHost = BrowserWindow.getAllWindows()
+        .filter(isHostWindow)
+        .sort((left, right) => left.id - right.id)[0] || null;
+      return primaryHost;
+    };
     const hide = (window) => {
+      if (window !== primaryHostWindow()) return;
       const state = windows.get(window.id);
       if (!state) return;
       state.visible = false;
@@ -476,17 +500,14 @@ if (
       deactivateNavigation();
     };
     const isPrimaryWindow = (window) => {
-      if (!window || window.isDestroyed() || window.getParentWindow?.()) return false;
-      try {
-        const url = new URL(window.webContents.getURL());
-        if (url.searchParams.has("initialRoute")) return false;
-      } catch {}
-      return window.isVisible?.() !== false;
+      return isHostWindow(window) && window === primaryHostWindow() && window.isVisible?.() !== false;
+    };
+    const fallbackHostWindow = () => {
+      const window = primaryHostWindow();
+      return isPrimaryWindow(window) ? window : null;
     };
-    const fallbackHostWindow = () => BrowserWindow.getAllWindows()
-      .filter(isPrimaryWindow)
-      .sort((left, right) => left.id - right.id)[0] || null;
     const createView = (window) => {
+      if (!window || window !== primaryHostWindow() || !isHostWindow(window)) return null;
       const state = stateFor(window);
       if (state.view && !state.view.webContents.isDestroyed()) return state;
       const view = new WebContentsView({
@@ -532,6 +553,7 @@ if (
     };
     const show = (window, bounds) => {
       const state = createView(window);
+      if (!state) return;
       state.bounds = bounds;
       state.view.setBounds(bounds);
       state.view.setVisible(true);
@@ -542,6 +564,7 @@ if (
       record("board-shown");
     };
     const layoutBoard = (window, bounds = null) => {
+      if (window !== primaryHostWindow()) return;
       const state = windows.get(window.id);
       if (!state?.visible || !state.view || state.view.webContents.isDestroyed()) return;
       if (bounds) state.bounds = bounds;
@@ -572,32 +595,25 @@ if (
     };
     const layoutNativeNav = (window) => {
       const state = windows.get(window.id);
-      if (!state?.nativeNav || state.nativeNav.isDestroyed()) return;
+      if (!state?.nativeNav || state.nativeNav.webContents.isDestroyed()) return;
       const content = window.getContentBounds();
-      state.nativeNav.setBounds({ x: content.x + 12, y: content.y + Math.max(48, content.height - 92), width: Math.min(120, Math.max(80, content.width - 24)), height: 38 });
+      state.nativeNav.setBounds({ x: 12, y: Math.max(48, content.height - 92), width: Math.min(120, Math.max(80, content.width - 24)), height: 38 });
     };
-    const ensureNativeNav = () => {
-      // Renderer probes finish independently. Always bind the singleton
-      // fallback to the earliest surviving host window, not whichever visible
-      // auxiliary renderer happens to exhaust its probe retries first.
+    const ensureNativeNav = (probeWindow) => {
+      // Renderer probes finish independently. Only the canonical host may
+      // install the singleton fallback; an auxiliary renderer cannot redirect
+      // it or acquire its own authenticated board view.
       const window = fallbackHostWindow();
-      if (!window) return;
+      if (!window || probeWindow !== window) return;
       const state = stateFor(window);
-      if (state.nativeNav && !state.nativeNav.isDestroyed()) return;
+      if (state.nativeNav && !state.nativeNav.webContents.isDestroyed()) return;
       // Auxiliary vendor windows (for example Codex's hidden avatar overlay)
       // are also top-level BrowserWindows. Never give them their own Tasks
-      // fallback: duplicate child windows interfere with first-run navigation
-      // and can cover the primary shell.
+      // fallback: duplicate views can cover the primary shell.
       if ([...windows.values()].some((candidate) => (
-        candidate.nativeNav && !candidate.nativeNav.isDestroyed()
+        candidate.nativeNav && !candidate.nativeNav.webContents.isDestroyed()
       ))) return;
-      const nativeNav = createInternalWindow({
-        parent: window,
-        frame: false,
-        show: false,
-        resizable: false,
-        skipTaskbar: true,
-        backgroundColor: "#292929",
+      const nativeNav = new WebContentsView({
         webPreferences: {
           preload: process.env.IMPEL_DESKTOP_TASKS_VIEW_PRELOAD,
           contextIsolation: true,
@@ -608,15 +624,19 @@ if (
       state.nativeNav = nativeNav;
       internalContents.add(nativeNav.webContents);
       nativeNavOwners.set(nativeNav.webContents, window);
+      window.contentView.addChildView(nativeNav);
+      nativeNav.setVisible(false);
+      nativeNav.setBackgroundColor("#292929");
       nativeNav.webContents.setWindowOpenHandler(() => ({ action: "deny" }));
       nativeNav.webContents.on("will-navigate", (event, url) => { if (url !== nativeNavUrl) event.preventDefault(); });
       nativeNav.webContents.on("destroyed", () => {
         internalContents.delete(nativeNav.webContents);
         nativeNavOwners.delete(nativeNav.webContents);
+        if (state.nativeNav === nativeNav) state.nativeNav = null;
       });
       nativeNav.webContents.loadURL(nativeNavUrl).catch(() => record("native-navigation-load-failed"));
       layoutNativeNav(window);
-      nativeNav.showInactive();
+      nativeNav.setVisible(true);
       record("native-navigation-installed");
     };
     const removeNativeNav = (window) => {
@@ -626,13 +646,18 @@ if (
       state.nativeNav = null;
       internalContents.delete(nativeNav.webContents);
       nativeNavOwners.delete(nativeNav.webContents);
-      try { nativeNav.destroy(); } catch {}
+      try { window.contentView.removeChildView(nativeNav); } catch {}
+      try { nativeNav.webContents.close(); } catch {}
+    };
+    const markDomNavigation = (window) => {
+      hasDomNavigation = true;
+      stateFor(window).hasDomNavigation = true;
+      for (const owner of BrowserWindow.getAllWindows()) removeNativeNav(owner);
+    };
+    const ownerWindow = (contents) => {
+      const window = BrowserWindow.fromWebContents(contents) || contents.getOwnerBrowserWindow?.() || null;
+      return isHostWindow(window) ? window : null;
     };
-    const ownerWindow = (contents) => BrowserWindow.fromWebContents(contents)
-      || contents.getOwnerBrowserWindow?.()
-      || BrowserWindow.getFocusedWindow()
-      || BrowserWindow.getAllWindows().find((window) => !window.isDestroyed())
-      || null;
     const attachContents = (contents) => {
       if (!contents || contents.isDestroyed() || contents.__impelDesktopTasksAttached || internalContents.has(contents)) return;
       contents.__impelDesktopTasksAttached = true;
@@ -641,28 +666,33 @@ if (
         Promise.all((contents.mainFrame?.framesInSubtree || []).map((frame) => frame.executeJavaScript(navSource, true)))
           .then((results) => {
             const window = ownerWindow(contents);
-            if (!window) return;
+            if (!window || window !== primaryHostWindow()) return;
             const state = stateFor(window);
+            const shellReady = results.some((result) => result?.shellReady);
             if (results.some((result) => result?.anchor)) {
-              hasDomNavigation = true;
-              state.hasDomNavigation = true;
-              for (const owner of BrowserWindow.getAllWindows()) removeNativeNav(owner);
-            } else if (attempt < 3) setTimeout(() => inject(attempt + 1), 1000);
-            else if (!state.hasDomNavigation && !hasDomNavigation) ensureNativeNav();
+              markDomNavigation(window);
+            } else if (!shellReady && attempt < 30) setTimeout(() => inject(attempt + 1), 1000);
+            else if (shellReady && !state.hasDomNavigation && !hasDomNavigation) ensureNativeNav(window);
+            else if (!shellReady) record("navigation-shell-unready");
           })
           .catch(() => record("navigation-injection-failed"));
       };
       contents.on("did-finish-load", () => inject());
       contents.on("did-frame-finish-load", () => inject());
       if (!contents.isLoadingMainFrame()) setTimeout(() => inject(), 0);
+      let handledNavigation = null;
       const handleNavigation = (event, url) => {
         if (!String(url).startsWith("impel-tasks://")) return;
         event.preventDefault();
         const window = ownerWindow(contents);
-        if (!window) return;
+        if (!window || window !== primaryHostWindow()) return;
+        if (handledNavigation === url) return;
+        handledNavigation = url;
+        queueMicrotask(() => { if (handledNavigation === url) handledNavigation = null; });
         let action;
         try { action = new URL(url).hostname; } catch { return; }
-        if (action === "hide") hide(window);
+        if (action === "ready") markDomNavigation(window);
+        else if (action === "hide") hide(window);
         else if (action === "show") show(window, parseBounds(url, window));
         else if (action === "layout") layoutBoard(window, parseBounds(url, window));
       };
@@ -670,40 +700,42 @@ if (
       contents.on("will-frame-navigate", handleNavigation);
     };
     const attachWindow = (window) => {
-      if (!window || window.isDestroyed() || creatingInternalWindow || window.getParentWindow?.() || window.__impelDesktopTasksWindowAttached) return;
+      if (!window || window.isDestroyed() || window.getParentWindow?.() || window.__impelDesktopTasksWindowAttached) return;
       window.__impelDesktopTasksWindowAttached = true;
       attachContents(window.webContents);
       window.on("resize", () => { layoutNativeNav(window); layoutBoard(window); });
       window.on("focus", () => {
         const state = windows.get(window.id);
-        state?.nativeNav?.showInactive();
+        state?.nativeNav?.setVisible(true);
         if (state?.visible) state.view?.setVisible(true);
       });
       window.on("blur", () => setTimeout(() => {
         const state = windows.get(window.id);
-        if (BrowserWindow.getFocusedWindow() === state?.nativeNav) return;
         // Keep the only path to Tasks available while the app is frontmost.
-        // BrowserWindow blur also fires when a user clicks the child fallback;
-        // hiding it here made the button disappear before its click arrived.
-        if (state?.nativeNav && (!window.isVisible() || window.isMinimized())) state.nativeNav.hide();
+        // Moving focus into the fallback view must not hide it before the click
+        // arrives; only a hidden or minimized host hides the affordance.
+        if (state?.nativeNav && (!window.isVisible() || window.isMinimized())) state.nativeNav.setVisible(false);
       }, 150));
       window.on("minimize", () => {
         const state = windows.get(window.id);
-        state?.nativeNav?.hide();
+        state?.nativeNav?.setVisible(false);
         state?.view?.setVisible(false);
       });
       window.on("restore", () => {
         const state = windows.get(window.id);
-        state?.nativeNav?.showInactive();
+        state?.nativeNav?.setVisible(true);
         if (state?.visible) state.view?.setVisible(true);
       });
       window.on("closed", () => {
         const state = windows.get(window.id);
-        if (!state) return;
-        try { if (state.view) window.contentView.removeChildView(state.view); } catch {}
-        try { state.view?.webContents.close(); } catch {}
-        try { state.nativeNav?.destroy(); } catch {}
+        if (state) {
+          try { if (state.view) window.contentView.removeChildView(state.view); } catch {}
+          try { state.view?.webContents.close(); } catch {}
+          try { if (state.nativeNav) window.contentView.removeChildView(state.nativeNav); } catch {}
+          try { state.nativeNav?.webContents.close(); } catch {}
+        }
         windows.delete(window.id);
+        if (primaryHost === window) primaryHost = null;
       });
     };
     ipcMain.on(nativeShowChannel, (event) => {

package/src/managedProfileVersion.js CHANGED Viewed

@@ -1,6 +1,6 @@
 // Fleet generation shared by managed-profile writers and upstream clients.
 // Keep this isolated from apps.js so latency-sensitive transports do not load
 // desktop bundle machinery just to identify their managed config contract.
-// v38 replaces the generated desktop MCP Apps host with the authenticated web
-// board and removes the desktop-only Codex renderer flag.
-export const CURRENT_CONFIG_VERSION = 38;
+// v40 renders the Tasks fallback inside the vendor window and waits for the app
+// shell, so no child BrowserWindow can pin ChatGPT's transient startup splash.
+export const CURRENT_CONFIG_VERSION = 40;