impeccable 3.5.0 → 3.6.1
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/README.md +4 -4
- package/README.npm.md +4 -4
- package/README.repo.md +61 -10
- package/cli/bin/cli.js +6 -0
- package/cli/bin/commands/ignores.mjs +4 -0
- package/cli/bin/commands/skills.mjs +294 -82
- package/cli/engine/browser/injected/index.mjs +192 -11
- package/cli/engine/cli/main.mjs +10 -16
- package/cli/engine/design-system.mjs +339 -11
- package/cli/engine/detect-antipatterns-browser.js +1482 -722
- package/cli/engine/detect-antipatterns.mjs +1 -0
- package/cli/engine/engines/browser/detect-url.mjs +64 -2
- package/cli/engine/engines/regex/detect-text.mjs +580 -29
- package/cli/engine/engines/static-html/css-cascade.mjs +62 -7
- package/cli/engine/engines/static-html/detect-html.mjs +31 -7
- package/cli/engine/node/file-system.mjs +23 -22
- package/cli/engine/registry/antipatterns.mjs +18 -0
- package/cli/engine/rules/checks.mjs +471 -370
- package/cli/engine/shared/color.mjs +474 -2
- package/cli/engine/shared/constants.mjs +17 -2
- package/cli/lib/download-providers.js +8 -0
- package/cli/lib/impeccable-config.mjs +41 -59
- package/package.json +5 -4
package/README.md
CHANGED
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
# Impeccable CLI
|
|
2
2
|
|
|
3
|
-
Detect UI anti-patterns and design quality issues from the command line. Scans HTML, CSS, JSX, TSX, Vue, and Svelte files for
|
|
3
|
+
Detect UI anti-patterns and design quality issues from the command line. Scans HTML, CSS, JSX, TSX, Vue, and Svelte files for 61 deterministic rules, including AI-generated UI tells, accessibility violations, and general design quality problems.
|
|
4
4
|
|
|
5
5
|
## Quick Start
|
|
6
6
|
|
|
@@ -56,7 +56,7 @@ npx impeccable detect --fast src/
|
|
|
56
56
|
|
|
57
57
|
**Quality**: tiny body text, cramped padding, long line lengths, small touch targets
|
|
58
58
|
|
|
59
|
-
|
|
59
|
+
61 deterministic detector rules in total. See the full catalog at [impeccable.style/slop](https://impeccable.style/slop).
|
|
60
60
|
|
|
61
61
|
## Exit Codes
|
|
62
62
|
|
|
@@ -75,13 +75,13 @@ impeccable detect [options] [file-or-dir-or-url...]
|
|
|
75
75
|
|
|
76
76
|
## Requirements
|
|
77
77
|
|
|
78
|
-
- Node.js 22.
|
|
78
|
+
- Node.js 22.18+
|
|
79
79
|
- `jsdom` (included as dependency, used for HTML scanning)
|
|
80
80
|
- `puppeteer` (optional, only needed for URL scanning)
|
|
81
81
|
|
|
82
82
|
## Part of Impeccable
|
|
83
83
|
|
|
84
|
-
This CLI is part of [Impeccable](https://impeccable.style), a cross-provider design skill pack for AI-powered development tools. The full suite includes 23 commands for Claude, Cursor, GitHub Copilot, Gemini, Codex, and more.
|
|
84
|
+
This CLI is part of [Impeccable](https://impeccable.style), a cross-provider design skill pack for AI-powered development tools. The full suite includes 23 commands for Claude, Cursor, GitHub Copilot, Gemini, Codex, Hermes Agent, Veto, and more.
|
|
85
85
|
|
|
86
86
|
## License
|
|
87
87
|
|
package/README.npm.md
CHANGED
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
# Impeccable CLI
|
|
2
2
|
|
|
3
|
-
Detect UI anti-patterns and design quality issues from the command line. Scans HTML, CSS, JSX, TSX, Vue, and Svelte files for
|
|
3
|
+
Detect UI anti-patterns and design quality issues from the command line. Scans HTML, CSS, JSX, TSX, Vue, and Svelte files for 61 deterministic rules, including AI-generated UI tells, accessibility violations, and general design quality problems.
|
|
4
4
|
|
|
5
5
|
## Quick Start
|
|
6
6
|
|
|
@@ -56,7 +56,7 @@ npx impeccable detect --fast src/
|
|
|
56
56
|
|
|
57
57
|
**Quality**: tiny body text, cramped padding, long line lengths, small touch targets
|
|
58
58
|
|
|
59
|
-
|
|
59
|
+
61 deterministic detector rules in total. See the full catalog at [impeccable.style/slop](https://impeccable.style/slop).
|
|
60
60
|
|
|
61
61
|
## Exit Codes
|
|
62
62
|
|
|
@@ -75,13 +75,13 @@ impeccable detect [options] [file-or-dir-or-url...]
|
|
|
75
75
|
|
|
76
76
|
## Requirements
|
|
77
77
|
|
|
78
|
-
- Node.js 22.
|
|
78
|
+
- Node.js 22.18+
|
|
79
79
|
- `jsdom` (included as dependency, used for HTML scanning)
|
|
80
80
|
- `puppeteer` (optional, only needed for URL scanning)
|
|
81
81
|
|
|
82
82
|
## Part of Impeccable
|
|
83
83
|
|
|
84
|
-
This CLI is part of [Impeccable](https://impeccable.style), a cross-provider design skill pack for AI-powered development tools. The full suite includes 23 commands for Claude, Cursor, GitHub Copilot, Gemini, Codex, and more.
|
|
84
|
+
This CLI is part of [Impeccable](https://impeccable.style), a cross-provider design skill pack for AI-powered development tools. The full suite includes 23 commands for Claude, Cursor, GitHub Copilot, Gemini, Codex, Hermes Agent, Veto, and more.
|
|
85
85
|
|
|
86
86
|
## License
|
|
87
87
|
|
package/README.repo.md
CHANGED
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
# Impeccable
|
|
2
2
|
|
|
3
|
-
Design guidance for AI coding agents. 1 skill, 23 commands, live browser iteration, and
|
|
3
|
+
Design guidance for AI coding agents. 1 skill, 23 commands, live browser iteration, and 61 deterministic detector rules for AI-generated frontend design.
|
|
4
4
|
|
|
5
5
|
> **Quick start:** From your project root, run `npx impeccable install`, then run `/impeccable init` inside your AI coding tool. Full docs: [impeccable.style](https://impeccable.style).
|
|
6
6
|
|
|
@@ -11,9 +11,9 @@ Anthropic's [frontend-design](https://github.com/anthropics/skills/tree/main/ski
|
|
|
11
11
|
Every model trained on the same SaaS templates. Skip the guidance and you get the same handful of tells on every project: Inter for everything, purple-to-blue gradients, cards nested in cards, gray text on colored backgrounds, the rounded-square icon tile above every heading.
|
|
12
12
|
|
|
13
13
|
Impeccable adds:
|
|
14
|
-
- **One setup flow.** `/impeccable init`
|
|
14
|
+
- **One setup flow.** `/impeccable init` records durable product truth in `PRODUCT.md`, so later commands know the audience, purpose, operating context, constraints, voice, and evidence without confusing those facts with surface-level visual direction.
|
|
15
15
|
- **23 commands.** A shared design vocabulary with your AI: `polish`, `audit`, `critique`, `distill`, `animate`, `bolder`, `quieter`, and more.
|
|
16
|
-
- **
|
|
16
|
+
- **61 deterministic detector rules** plus LLM-only critique checks. The CLI and browser extension run the deterministic rules with no LLM and no API key.
|
|
17
17
|
|
|
18
18
|
## What's Included
|
|
19
19
|
|
|
@@ -31,7 +31,7 @@ Start every new project with:
|
|
|
31
31
|
/impeccable init
|
|
32
32
|
```
|
|
33
33
|
|
|
34
|
-
`init`
|
|
34
|
+
`init` inspects the project, asks only for material gaps in durable product truth, and writes `PRODUCT.md`. Visitor mode and visual direction are chosen later for each surface; incumbent or newly built visual systems are recorded separately in `DESIGN.md`.
|
|
35
35
|
|
|
36
36
|
### 23 Commands
|
|
37
37
|
|
|
@@ -40,7 +40,7 @@ All commands are accessed through `/impeccable`:
|
|
|
40
40
|
| Command | What it does |
|
|
41
41
|
|---------|--------------|
|
|
42
42
|
| `/impeccable craft` | Full shape-then-build flow with visual iteration |
|
|
43
|
-
| `/impeccable init` | One-time setup: gather
|
|
43
|
+
| `/impeccable init` | One-time setup: gather durable product context, write PRODUCT.md, configure live mode when applicable, recommend next steps |
|
|
44
44
|
| `/impeccable document` | Generate root DESIGN.md from existing project code |
|
|
45
45
|
| `/impeccable extract` | Pull reusable components and tokens into the design system |
|
|
46
46
|
| `/impeccable shape` | Plan UX/UI before writing code |
|
|
@@ -103,7 +103,7 @@ From the root of your project, run:
|
|
|
103
103
|
npx impeccable install
|
|
104
104
|
```
|
|
105
105
|
|
|
106
|
-
This shows the harness folders it detected (for example `~/.claude`, `~/.codex`, `~/.grok`, or project-local `.cursor`), lets you keep the detected set or customize providers, then asks whether to install into the current project or globally. Use `--providers=claude,codex,cursor,grok` and `--scope=project|global` to skip those choices in scripts. On Claude Code, Cursor, Codex, GitHub Copilot, and Grok Build, it also installs the provider-native hook manifest for the current project. Works with Cursor, Claude Code, Gemini CLI, Codex CLI, Grok Build, and every other supported tool. Reload your harness afterward.
|
|
106
|
+
This shows the harness folders or installed CLIs it detected (for example `~/.claude`, `~/.codex`, `~/.grok`, `~/.hermes`, `~/.veto`, or project-local `.cursor`), lets you keep the detected set or customize providers, then asks whether to install into the current project or globally. Use `--providers=claude,codex,cursor,grok,hermes,veto` and `--scope=project|global` to skip those choices in scripts. On Claude Code, Cursor, Codex, GitHub Copilot, and Grok Build, it also installs the provider-native hook manifest for the current project. Veto receives the packaged skill under `~/.veto/skills/` and does not run native Impeccable edit hooks. Works with Cursor, Claude Code, Gemini CLI, Codex CLI, Grok Build, Hermes Agent, Veto, and every other supported tool. Reload your harness afterward.
|
|
107
107
|
|
|
108
108
|
To refresh an existing install, run:
|
|
109
109
|
|
|
@@ -113,6 +113,8 @@ npx impeccable update
|
|
|
113
113
|
|
|
114
114
|
Codex users should open `/hooks` after install or update and approve the project hook when prompted. Codex tracks trust by hook definition, so updates that change `.codex/hooks.json` can require approval again. Grok Build users need project folder trust (`/hooks-trust` or launch with `--trust`) before `.grok/hooks/` scripts run.
|
|
115
115
|
|
|
116
|
+
See [Allow the hook in your harness](https://impeccable.style/docs/hooks#allow-the-hook-in-your-harness) for harness-specific trust and verification steps.
|
|
117
|
+
|
|
116
118
|
### Option 2: Git Submodule
|
|
117
119
|
|
|
118
120
|
For teams that want to keep Impeccable vendored and updated through Git, add this repo as a submodule and link the compiled provider build into your harness folders:
|
|
@@ -124,7 +126,7 @@ git add .gitmodules .impeccable .claude .cursor
|
|
|
124
126
|
git commit -m "Add Impeccable skills"
|
|
125
127
|
```
|
|
126
128
|
|
|
127
|
-
Use the providers your project needs, for example `claude`, `cursor`, `gemini`, `codex`, `github`, `grok`, `opencode`, `pi`, `qoder`, `trae`, `trae-cn`, `rovo-dev`, or `
|
|
129
|
+
Use the providers your project needs, for example `claude`, `cursor`, `gemini`, `codex`, `github`, `grok`, `hermes`, `opencode`, `pi`, `qoder`, `trae`, `trae-cn`, `rovo-dev`, `vibe`, or `veto`. The command links individual skill folders from `.impeccable/dist/universal/` and leaves existing real skill directories untouched unless you pass `--force`.
|
|
128
130
|
|
|
129
131
|
To update later:
|
|
130
132
|
|
|
@@ -180,6 +182,26 @@ cp -r dist/claude-code/.claude/* ~/.claude/
|
|
|
180
182
|
cp -r dist/opencode/.opencode your-project/
|
|
181
183
|
```
|
|
182
184
|
|
|
185
|
+
**Hermes Agent:**
|
|
186
|
+
```bash
|
|
187
|
+
# Global (applies to all projects; uses the active profile, or ~/.hermes by default)
|
|
188
|
+
cp -r dist/hermes/.hermes/skills/* "${HERMES_HOME:-$HOME/.hermes}/skills/"
|
|
189
|
+
|
|
190
|
+
# Or project-specific
|
|
191
|
+
cp -r dist/hermes/.hermes your-project/
|
|
192
|
+
```
|
|
193
|
+
|
|
194
|
+
> **Note:** Hermes gates project-local skills behind a per-repo trust decision
|
|
195
|
+
> (they are procedure documents, so auto-loading them from any cloned repo is
|
|
196
|
+
> treated as a prompt-injection vector). After a project-scoped install, run
|
|
197
|
+
> `hermes skills trust` once from the project root. Global installs into the
|
|
198
|
+
> active `$HERMES_HOME/skills/` (or `~/.hermes/skills/` when unset) load without
|
|
199
|
+
> a trust step. `/impeccable <command>` then
|
|
200
|
+
> routes through the skill's Commands table; the design hook does not install
|
|
201
|
+
> on Hermes (no hook surface).
|
|
202
|
+
>
|
|
203
|
+
> [Learn more about Hermes skills](https://hermes-agent.nousresearch.com/docs/user-guide/features/skills)
|
|
204
|
+
|
|
183
205
|
**Pi:**
|
|
184
206
|
```bash
|
|
185
207
|
cp -r dist/pi/.pi your-project/
|
|
@@ -270,6 +292,16 @@ cp -r dist/grok/.grok/skills/* ~/.grok/skills/
|
|
|
270
292
|
|
|
271
293
|
> Prefer `npx impeccable install --providers=grok` or `grok plugin install pbakaus/impeccable#plugin --trust` so the design hook installs too. Project hooks need `/hooks-trust` (or `--trust`) once per folder.
|
|
272
294
|
|
|
295
|
+
**Google Antigravity:**
|
|
296
|
+
```bash
|
|
297
|
+
# Project-specific
|
|
298
|
+
cp -r dist/antigravity/.agent your-project/
|
|
299
|
+
|
|
300
|
+
# Or global (applies to all projects)
|
|
301
|
+
mkdir -p ~/.gemini/config/skills
|
|
302
|
+
cp -r dist/antigravity/.agent/skills/* ~/.gemini/config/skills/
|
|
303
|
+
```
|
|
304
|
+
|
|
273
305
|
## Usage
|
|
274
306
|
|
|
275
307
|
Once installed, every command runs through the single `/impeccable` skill:
|
|
@@ -304,11 +336,13 @@ As you run commands, Impeccable writes working files under `.impeccable/`: criti
|
|
|
304
336
|
# Unanchored: .impeccable may sit at the repo root or under a nested
|
|
305
337
|
# workspace (apps/web/.impeccable/...); anchored patterns would miss it.
|
|
306
338
|
# Shared artifacts stay tracked: config.json, live/config.json,
|
|
307
|
-
# design.json, critique/*.md.
|
|
339
|
+
# design.json, surfaces/*.md, critique/*.md.
|
|
308
340
|
.impeccable/config.local.json
|
|
309
341
|
.impeccable/hook.cache.json
|
|
310
342
|
.impeccable/hook.pending.json
|
|
311
343
|
.impeccable/*.png
|
|
344
|
+
.impeccable/review/
|
|
345
|
+
.impeccable/questions/
|
|
312
346
|
.impeccable/live/server.json
|
|
313
347
|
.impeccable/live/sessions/
|
|
314
348
|
.impeccable/live/previews/
|
|
@@ -330,13 +364,14 @@ The block is wrapped in `# impeccable-ignore-start` / `# impeccable-ignore-end`
|
|
|
330
364
|
- `.impeccable/config.json` (unified shared config)
|
|
331
365
|
- `.impeccable/live/config.json` (live-mode framework wiring)
|
|
332
366
|
- `.impeccable/design.json` (shared design spec)
|
|
367
|
+
- `.impeccable/surfaces/*.md` (route- or artifact-specific strategy and direction contracts)
|
|
333
368
|
- `.impeccable/critique/*.md` (review reports)
|
|
334
369
|
|
|
335
370
|
If an ephemeral file (a screenshot, `config.local.json`) was committed before you added the block, `.gitignore` will not untrack it automatically. Run `git rm --cached <path>` to stop tracking it without deleting your local copy.
|
|
336
371
|
|
|
337
372
|
## Design hook
|
|
338
373
|
|
|
339
|
-
On Claude Code, GitHub Copilot, Codex, Cursor, and Grok Build, `npx impeccable install` and `npx impeccable update` install a provider-native hook manifest along with the skill payload. The hook runs the Impeccable design detector on direct UI file edits and surfaces findings back into the agent flow. Claude Code, GitHub Copilot,
|
|
374
|
+
On Claude Code, GitHub Copilot, Codex, Cursor, and Grok Build, `npx impeccable install` and `npx impeccable update` install a provider-native hook manifest along with the skill payload. The hook runs the Impeccable design detector on direct UI file edits and surfaces findings back into the agent flow. Claude Code, GitHub Copilot, and Codex surface findings after the edit (and run a deeper pass on Stop where supported). Grok Build scans after the edit to warm Stop, then surfaces on Stop; PostToolUse stdout never reaches the model. Cursor blocks bad proposed writes before they land.
|
|
340
375
|
|
|
341
376
|
Installed hook surfaces:
|
|
342
377
|
|
|
@@ -344,6 +379,7 @@ Installed hook surfaces:
|
|
|
344
379
|
- GitHub Copilot: `.github/hooks/impeccable.json` (committed, shared by the Copilot CLI and the cloud agent) runs `.github/skills/impeccable/scripts/hook.mjs`. The Copilot CLI activates it once the file is on the repository's default branch and the folder is trusted.
|
|
345
380
|
- Cursor: `.cursor/hooks.json` runs `.cursor/skills/impeccable/scripts/hook-before-edit.mjs`.
|
|
346
381
|
- Codex: `.codex/hooks.json` runs `.agents/skills/impeccable/scripts/hook.mjs`.
|
|
382
|
+
- Grok Build: `.grok/hooks/impeccable.json` runs `.grok/skills/impeccable/scripts/hook.mjs`. Requires `/hooks-trust` or `--trust`. Findings reach the model on Stop, not after each edit.
|
|
347
383
|
|
|
348
384
|
The installer preserves unrelated hook entries and settings. If a hook manifest is malformed, install/update aborts by default; rerun with `--force` to back up the malformed file as `.bak` and replace it.
|
|
349
385
|
|
|
@@ -351,6 +387,18 @@ On an interactive `install`/`update`, Impeccable explains the hook and offers to
|
|
|
351
387
|
|
|
352
388
|
For debugging, set `hook.auditLog` in `.impeccable/config.json` to a path (or the legacy `IMPECCABLE_HOOK_LOG` env var) to write one NDJSON line per hook invocation. Leave it unset for normal use.
|
|
353
389
|
|
|
390
|
+
## Build path: comp-first or code-first
|
|
391
|
+
|
|
392
|
+
When a new surface gets designed, Impeccable either generates a full-fidelity comp first and builds to match it, or builds straight in code with the ambition written into a development-only direction contract in the surface brief and checked at the finish. Comp-first composes bolder and takes longer; code-first is leaner and faster. `/impeccable init` asks once and records the answer as `buildPath` in `.impeccable/config.json`:
|
|
393
|
+
|
|
394
|
+
```json
|
|
395
|
+
{ "buildPath": "comp" }
|
|
396
|
+
```
|
|
397
|
+
|
|
398
|
+
The values are `comp` and `code`, and nothing else is read. Set it in the gitignored `.impeccable/config.local.json` to override the team's committed value on one machine, which is what you want when your harness has no image generation. In a monorepo, commit it once at the repo root and any workspace that wants something else sets its own. The choice appears at all only where image generation is available, since without it there is nothing to comp.
|
|
399
|
+
|
|
400
|
+
You do not have to re-run `init` to set it on a project that predates the setting, and you do not have to edit the file by hand either. Whatever is recorded is a default rather than a lock: every decision page carries a footer toggle, and flipping it binds that session only. Flip it on a project that has recorded nothing and Impeccable asks once, after the round, whether to keep it, then writes your answer. That is the whole migration path for an existing project: use the toggle when the default is wrong, and answer the question that follows.
|
|
401
|
+
|
|
354
402
|
Codex requires one platform step that Impeccable cannot safely skip: open `/hooks` after install or update and approve the project hook. There is no Codex marketplace/plugin install flow for this hook.
|
|
355
403
|
|
|
356
404
|
Full hook docs: [impeccable.style/docs/hooks](https://impeccable.style/docs/hooks).
|
|
@@ -377,7 +425,7 @@ npx impeccable ignores add-file "src/legacy/**"
|
|
|
377
425
|
npx impeccable ignores add-value overused-font Inter --reason "Brand font"
|
|
378
426
|
```
|
|
379
427
|
|
|
380
|
-
The detector catches
|
|
428
|
+
The detector catches 61 deterministic issues across AI slop (side-tab borders, purple gradients, bounce easing, dark glows) and general design quality (line length, cramped padding, small touch targets, skipped headings, and more).
|
|
381
429
|
|
|
382
430
|
By default, `detect` respects the same `.impeccable/config.json` and `.impeccable/config.local.json` detector config as the design hook: `detector.ignoreRules`, `detector.ignoreFiles`, `detector.ignoreValues`, and `detector.designSystem.enabled`. Hook lifecycle settings such as `hook.enabled` only affect automatic hook execution.
|
|
383
431
|
|
|
@@ -393,6 +441,7 @@ Full detector docs: [impeccable.style/docs/detector](https://impeccable.style/do
|
|
|
393
441
|
- [Gemini CLI](https://github.com/google-gemini/gemini-cli)
|
|
394
442
|
- [Codex CLI](https://github.com/openai/codex)
|
|
395
443
|
- [Grok Build](https://x.ai/cli)
|
|
444
|
+
- [Hermes Agent](https://hermes-agent.nousresearch.com)
|
|
396
445
|
- [OpenCode](https://opencode.ai)
|
|
397
446
|
- [Pi](https://pi.dev)
|
|
398
447
|
- [Kiro](https://kiro.dev)
|
|
@@ -400,6 +449,8 @@ Full detector docs: [impeccable.style/docs/detector](https://impeccable.style/do
|
|
|
400
449
|
- [Rovo Dev](https://www.atlassian.com/software/rovo)
|
|
401
450
|
- [Qoder](https://qoder.com)
|
|
402
451
|
- [Mistral Vibe](https://docs.mistral.ai/vibe/code/overview)
|
|
452
|
+
- [Veto](https://github.com/oleg-koval/veto)
|
|
453
|
+
- [Google Antigravity](https://antigravity.google)
|
|
403
454
|
|
|
404
455
|
## Community & Ecosystem
|
|
405
456
|
|
package/cli/bin/cli.js
CHANGED
|
@@ -77,6 +77,12 @@ Compatibility:
|
|
|
77
77
|
process.argv = [process.argv[0], process.argv[1], ...args];
|
|
78
78
|
const { detectCli } = await import('../engine/detect-antipatterns.mjs');
|
|
79
79
|
await detectCli();
|
|
80
|
+
} else if (command === 'init') {
|
|
81
|
+
// The follow-up mistake from issue #472: `/impeccable init` belongs in an AI
|
|
82
|
+
// coding agent's chat, and a user who typed it into their shell is likely to
|
|
83
|
+
// retry it here as `npx impeccable init`.
|
|
84
|
+
console.error(`"init" is not a CLI command. Type /impeccable init in your AI coding agent's chat (Claude Code, Cursor, Codex, ...), not in this terminal.`);
|
|
85
|
+
process.exit(1);
|
|
80
86
|
} else {
|
|
81
87
|
// An unknown bareword: a mistyped command (or an old cached version run
|
|
82
88
|
// against newer docs). Fail loudly instead of silently statting it as a path.
|
|
@@ -7,6 +7,7 @@ import {
|
|
|
7
7
|
readDetectionConfig,
|
|
8
8
|
readRawDetectionConfig,
|
|
9
9
|
writeDetectionConfig,
|
|
10
|
+
extractFindingIgnoreValue,
|
|
10
11
|
} from '../../lib/impeccable-config.mjs';
|
|
11
12
|
|
|
12
13
|
const ACTION_ALIASES = new Map([
|
|
@@ -235,6 +236,9 @@ function addFile(cwd, args) {
|
|
|
235
236
|
function addValue(cwd, args) {
|
|
236
237
|
const { local, rest } = parseScope(args);
|
|
237
238
|
const parsed = parseValueArgs(rest);
|
|
239
|
+
if (parsed.value !== '*' && !extractFindingIgnoreValue({ antipattern: parsed.rule, ignoreValue: parsed.value })) {
|
|
240
|
+
throw new Error(`${parsed.rule} has no extractable ignore value. Use impeccable ignores add-value ${parsed.rule} "*" --file <glob> to suppress it in matching files.`);
|
|
241
|
+
}
|
|
238
242
|
const config = readScopeConfig(cwd, local);
|
|
239
243
|
const key = ignoreValueKey(parsed);
|
|
240
244
|
const existing = config.ignoreValues.find((entry) => ignoreValueKey(entry) === key);
|