impact-ui 4.0.15 → 4.0.16

package/dist/components/Table/filterUtils.d.ts

@@ -30,10 +30,18 @@ export declare const roundedFilterValueGetter: (decimals?: number) => (params: a
 /**
  * Matches any value that is, or could still become, a decimal number.
  * Intermediate states such as "", "-", "1." are allowed so the user can keep typing.
+ * Underscores are also allowed between digits (and trailing, mid-type) since they are
+ * used as a digit-group separator by some data sources — e.g. "124_56", "1_234_567" —
+ * mirroring the underscore support already in `cleanNumericValue`/`GROUPED_DIGITS`.
  * @param {string} value - The candidate input value
  * @returns {boolean} - true when the value may be entered into a numeric field
  */
 export declare const isPartialNumericInput: (value: any) => boolean;
+/**
+ * Maps a keydown event to the character that would be inserted into a numeric field.
+ * Shift+Minus is often reported as key "-" (not "_"), which must still become "_".
+ */
+export declare const resolveNumericKeyInsert: (event: any) => any;
 /**
  * Inserts a pasted value into a numeric field, reading it the way it was rendered:
  * currency symbols, thousands separators and percent signs are dropped, accounting
@@ -57,6 +65,11 @@ export declare const handleNumericPaste: (event: any, applyValue: any) => void;
  * Rejecting the key press rather than the resulting value keeps the caret in place;
  * pasting is handled by handleNumericPaste, and drag-drop by the isPartialNumericInput
  * check on change.
+ *
+ * The resulting value (current value with this key spliced in at the caret/selection) is
+ * checked against `isPartialNumericInput` directly, rather than hand-rolling per-character
+ * rules, so every character this gate accepts — digits, one ".", a leading "-", and now
+ * "_" as a digit-group separator — stays in lockstep with what onChange/paste allow.
  * @param {object} event - React keyboard event from a numeric input
  */
 export declare const handleNumericKeyDown: (event: any) => void;

package/dist/components/Table/filterUtils.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"filterUtils.d.ts","sourceRoot":"","sources":["../../../src/components/Table/filterUtils.ts"],"names":[],"mappings":"AAUA,eAAO,MAAM,wBAAwB,GAAI,cAAS,EAAE,MAAC,QAoDpD,CAAC;AAGF,eAAO,MAAM,4BAA4B,GAAI,cAAS,EAAE,wBAAa,EAAE,MAAC,QAyBvE,CAAC;AAEF;;;;;GAKG;AACH,eAAO,MAAM,iBAAiB,GAAI,UAAK,QAMtC,CAAC;AAEF;;;;;;GAMG;AACH,eAAO,MAAM,oBAAoB,GAAI,cAAS,YAa7C,CAAC;AAEF;;;;;;;;;;GAUG;AACH,eAAO,MAAM,wBAAwB,GAClC,iBAAY,MACZ,WAAM,QAMN,CAAC;AAEJ;;;;;GAKG;AACH,eAAO,MAAM,qBAAqB,GAAI,UAAK,YAAsC,CAAC;AAuDlF;;;;;;;;;;;;;;;;GAgBG;AACH,eAAO,MAAM,kBAAkB,GAAI,UAAK,EAAE,eAAU,SA4BnD,CAAC;AAEF;;;;;;GAMG;AACH,eAAO,MAAM,oBAAoB,GAAI,UAAK,SAwBzC,CAAC;AAEF;;;;;GAKG;AACH,eAAO,MAAM,gBAAgB,GAAI,UAAK,EAAE,cAAS;;;CA4EhD,CAAC;AAEF;;;;;;GAMG;AACH,eAAO,MAAM,kBAAkB,GAAI,QAAG,EAAE,aAAQ,YAQ/C,CAAC;AAEF;;;;;;;;;;;;GAYG;AACH,eAAO,MAAM,qBAAqB,GAAI,gBAAW,EAAE,eAAU,EAAE,cAAS,EAAE,oBAAoB,QAsI7F,CAAC;AAEF;;;;;GAKG;AACH,eAAO,MAAM,aAAa,GAAI,YAAO,EAAE,UAAK,QAoB3C,CAAC;AAEF;;;;;;;;GAQG;AACH,eAAO,MAAM,sBAAsB,GAAI,UAAK,EAAE,cAAS,EAAE,QAAG,EAAE,aAAQ;;;CA0ErE,CAAC;AAEF;;;;GAIG;AACH,eAAO,MAAM,kBAAkB,GAAI,gBAAW,YAwB7C,CAAC;AAEF;;;;;;GAMG;AACH,eAAO,MAAM,cAAc,GAAI,aAAQ,EAAE,cAAS,EAAE,YAAO,QAc1D,CAAC;AAEF;;;;GAIG;AACH,eAAO,MAAM,mBAAmB,GAAI,WAAM,YAUzC,CAAC;AAEF;;;;;;;GAOG;AACH,eAAO,MAAM,0BAA0B,GAAI,aAAQ,EAAE,WAAM,EAAE,cAAS,EAAE,YAAO;;;;;;;;;;;CA4C9E,CAAC;AAqGF;;;;;;;;GAQG;AACH,eAAO,MAAM,iBAAiB,GAAI,oBAAe,EAAE,aAAQ,EAAE,UAAK,EAAE,cAAS,EAAE,YAAO,QAUrF,CAAC;AAEF;;;;;;;;;;;;GAYG;AACH,eAAO,MAAM,oBAAoB,GAC/B,QAAG,EACH,oBAAe,EACf,eAAU,EACV,cAAS,EACT,YAAO,EACP,aAAQ,EACR,sBAAiB,EACjB,+BAA0B,SA2B3B,CAAC;AAEF;;;;;GAKG;AACH,eAAO,MAAM,6BAA6B,GAAI,eAAU,EAAE,YAAO,OAqChE,CAAC"}
+{"version":3,"file":"filterUtils.d.ts","sourceRoot":"","sources":["../../../src/components/Table/filterUtils.ts"],"names":[],"mappings":"AAUA,eAAO,MAAM,wBAAwB,GAAI,cAAS,EAAE,MAAC,QAoDpD,CAAC;AAGF,eAAO,MAAM,4BAA4B,GAAI,cAAS,EAAE,wBAAa,EAAE,MAAC,QAyBvE,CAAC;AAEF;;;;;GAKG;AACH,eAAO,MAAM,iBAAiB,GAAI,UAAK,QAMtC,CAAC;AAEF;;;;;;GAMG;AACH,eAAO,MAAM,oBAAoB,GAAI,cAAS,YAa7C,CAAC;AAEF;;;;;;;;;;GAUG;AACH,eAAO,MAAM,wBAAwB,GAClC,iBAAY,MACZ,WAAM,QAMN,CAAC;AAEJ;;;;;;;;GAQG;AACH,eAAO,MAAM,qBAAqB,GAAI,UAAK,YACc,CAAC;AAE1D;;;GAGG;AACH,eAAO,MAAM,uBAAuB,GAAI,UAAK,QAM5C,CAAC;AAuDF;;;;;;;;;;;;;;;;GAgBG;AACH,eAAO,MAAM,kBAAkB,GAAI,UAAK,EAAE,eAAU,SA4BnD,CAAC;AAEF;;;;;;;;;;;GAWG;AACH,eAAO,MAAM,oBAAoB,GAAI,UAAK,SAwBzC,CAAC;AAEF;;;;;GAKG;AACH,eAAO,MAAM,gBAAgB,GAAI,UAAK,EAAE,cAAS;;;CA4EhD,CAAC;AAEF;;;;;;GAMG;AACH,eAAO,MAAM,kBAAkB,GAAI,QAAG,EAAE,aAAQ,YAQ/C,CAAC;AAEF;;;;;;;;;;;;GAYG;AACH,eAAO,MAAM,qBAAqB,GAAI,gBAAW,EAAE,eAAU,EAAE,cAAS,EAAE,oBAAoB,QAsI7F,CAAC;AAEF;;;;;GAKG;AACH,eAAO,MAAM,aAAa,GAAI,YAAO,EAAE,UAAK,QAoB3C,CAAC;AAEF;;;;;;;;GAQG;AACH,eAAO,MAAM,sBAAsB,GAAI,UAAK,EAAE,cAAS,EAAE,QAAG,EAAE,aAAQ;;;CA0ErE,CAAC;AAEF;;;;GAIG;AACH,eAAO,MAAM,kBAAkB,GAAI,gBAAW,YAwB7C,CAAC;AAEF;;;;;;GAMG;AACH,eAAO,MAAM,cAAc,GAAI,aAAQ,EAAE,cAAS,EAAE,YAAO,QAc1D,CAAC;AAEF;;;;GAIG;AACH,eAAO,MAAM,mBAAmB,GAAI,WAAM,YAUzC,CAAC;AAEF;;;;;;;GAOG;AACH,eAAO,MAAM,0BAA0B,GAAI,aAAQ,EAAE,WAAM,EAAE,cAAS,EAAE,YAAO;;;;;;;;;;;CA4C9E,CAAC;AAqGF;;;;;;;;GAQG;AACH,eAAO,MAAM,iBAAiB,GAAI,oBAAe,EAAE,aAAQ,EAAE,UAAK,EAAE,cAAS,EAAE,YAAO,QAUrF,CAAC;AAEF;;;;;;;;;;;;GAYG;AACH,eAAO,MAAM,oBAAoB,GAC/B,QAAG,EACH,oBAAe,EACf,eAAU,EACV,cAAS,EACT,YAAO,EACP,aAAQ,EACR,sBAAiB,EACjB,+BAA0B,SA2B3B,CAAC;AAEF;;;;;GAKG;AACH,eAAO,MAAM,6BAA6B,GAAI,eAAU,EAAE,YAAO,OAqChE,CAAC"}

package/dist/components/Table/filterUtils.js

@@ -51,7 +51,7 @@ const cleanNumericValue = (value) => {
   if (typeof value !== "string") {
     return value;
   }
-  return value.replace(/[$€£¥₹,\s%]/g, "");
+  return value.replace(/[$€£¥₹,_\s%]/g, "");
 };
 const isNumericValueColumn = (columnDef) => {
   if (!columnDef || columnDef.thirdOptionAsDropdown) {
@@ -62,9 +62,16 @@ const isNumericValueColumn = (columnDef) => {
   }
   return columnDef.filter === "agNumberColumnFilter" || columnDef.type === "number";
 };
-const isPartialNumericInput = (value) => /^-?\d*\.?\d*$/.test(value ?? "");
+const isPartialNumericInput = (value) => /^-?(\d(_?\d)*_?)?\.?(\d(_?\d)*_?)?$/.test(value ?? "");
+const resolveNumericKeyInsert = (event) => {
+  const { key, shiftKey } = event;
+  if (key === "_" || key === "-" && shiftKey) {
+    return "_";
+  }
+  return key;
+};
 const CURRENCY_SYMBOL = String.raw`[$€£¥₹]`;
-const GROUPED_DIGITS = String.raw`\d{1,3}(?:[,\u202f\u00a0 ]\d{3})+`;
+const GROUPED_DIGITS = String.raw`\d{1,3}(?:[,\u202f\u00a0 _]\d{3})+`;
 const MAGNITUDES = { k: 1e3, m: 1e6, mn: 1e6, b: 1e9, bn: 1e9, t: 1e12 };
 const UNSIGNED_NUMBER = new RegExp(
   String.raw`^${CURRENCY_SYMBOL}?\s*((?:${GROUPED_DIGITS}|\d+)(?:\.\d+)?|\.\d+)\s*(mn|bn|[kmbt])?%?$`,
@@ -110,15 +117,16 @@ const handleNumericKeyDown = (event) => {
   if (event.ctrlKey || event.metaKey || event.altKey || event.key.length > 1) {
     return;
   }
-  if (/^\d$/.test(event.key)) {
+  const insertKey = resolveNumericKeyInsert(event);
+  if (insertKey.length !== 1) {
+    event.preventDefault();
     return;
   }
   const { value = "", selectionStart, selectionEnd } = event.target;
-  const remaining = value.slice(0, selectionStart ?? 0) + value.slice(selectionEnd ?? 0);
-  if (event.key === "." && !remaining.includes(".")) {
-    return;
-  }
-  if (event.key === "-" && !remaining.includes("-") && (selectionStart ?? 0) === 0) {
+  const start = selectionStart ?? value.length;
+  const end = selectionEnd ?? value.length;
+  const next = value.slice(0, start) + insertKey + value.slice(end);
+  if (isPartialNumericInput(next)) {
     return;
   }
   event.preventDefault();
@@ -547,6 +555,7 @@ export {
   isValidFilterValue,
   parseFilterValue,
   parseInlineSearchValue,
+  resolveNumericKeyInsert,
   syncFiltersWithModal,
   updateOrAddFilter
 };

package/dist/components/Table/index.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"index.d.ts","sourceRoot":"","sources":["../../../src/components/Table/index.tsx"],"names":[],"mappings":"AAuBA,OAAO,sCAAsC,CAAC;AAC9C,OAAO,8CAA8C,CAAC;AACtD,OAAO,qBAAqB,CAAC;AAK7B,OAAO,KAAK,EAAE,UAAU,EAAE,MAAM,eAAe,CAAC;AAsnDhD,eAAO,MAAM,KAAK,6GAUhB,CAAC"}
+{"version":3,"file":"index.d.ts","sourceRoot":"","sources":["../../../src/components/Table/index.tsx"],"names":[],"mappings":"AAuBA,OAAO,sCAAsC,CAAC;AAC9C,OAAO,8CAA8C,CAAC;AACtD,OAAO,qBAAqB,CAAC;AAK7B,OAAO,KAAK,EAAE,UAAU,EAAE,MAAM,eAAe,CAAC;AA8nDhD,eAAO,MAAM,KAAK,6GAUhB,CAAC"}