imdone-core 2.0.10 → 2.0.11

package/lib/plugins/plugin-manager.js

@@ -185,8 +185,10 @@ export class PluginManager extends Emitter {
   
   async createPlugin(pluginClass, path = undefined) {
     const name = pluginClass.pluginName
-    if (!name || !this.isPlugin(pluginClass))
+    if (!name) {
       throw new Error(`${pluginClass.name} is not a plugin`)
+    }
+    
     const pluginInstance = new pluginClass(this.project)
     const packageInfo = await this.getPackageInfo(path)
     let info = {
@@ -220,18 +222,6 @@ export class PluginManager extends Emitter {
     })
   }
 
-  isPlugin(pluginClass) {
-    // const pluginClassName = Plugin.name.toString()
-    // return pluginClass.proname.toString() === pluginClassName
-    const pluginClassPrototypeName = Object.getPrototypeOf(pluginClass.prototype).constructor.name
-    const pluginClassName = Plugin.name.toString()
-    logger.log('pluginClassPrototypeName', pluginClassPrototypeName)
-    logger.log('pluginClassName', pluginClassName)
-    return pluginClassPrototypeName === pluginClassName
-   
-    // return Object.getPrototypeOf(pluginClass.prototype) === Plugin.prototype
-  }
-
   eachPlugin(cb) {
     Object.keys(this.pluginsMap).forEach((key) => {
       cb(this.getPlugin(key))

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "imdone-core",
-  "version": "2.0.10",
+  "version": "2.0.11",
   "description": "imdone-core",
   "repository": {
     "type": "git",

package/types/plugins/plugin-manager.d.ts

@@ -22,7 +22,6 @@ export class PluginManager extends Emitter<[never]> {
     getPackageInfo(path: any): Promise<{} | undefined>;
     createPlugin(pluginClass: any, path?: undefined): Promise<any>;
     destroyPlugins(): void;
-    isPlugin(pluginClass: any): boolean;
     eachPlugin(cb: any): void;
     eachPluginAsync(cb: any): Promise<void>;
     getPlugins(): any[];