imdone-core 1.54.2 → 1.54.4

package/lib/migrate-config.js

@@ -135,7 +135,7 @@ module.exports = function (repo, defaultSettings = defaultSettingsObject) {
       }
 
       // Remove settings.filteredLists
-      if (config.settings.filteredLists && config.settings.filteredLists.length > 0) {
+      if (config.settings.filteredLists) {
         delete config.settings.filteredLists
       }
 

package/lib/plugins/default-board-properties-plugin.js

@@ -95,7 +95,9 @@ module.exports = class DefaultBoardPropertiesPlugin extends Plugin {
     };
 
     const templatesFromTemplateDir = await readMarkdownFiles(templateDir);
-    const templatesFromGithubDir = await readMarkdownFiles(githubDir, 'github_');
+    const templatesFromGithubDir = await stat(githubDir)
+      ? await readMarkdownFiles(githubDir, 'github_')
+      : {};
 
     return { simple: simpleTemplate, ...templatesFromTemplateDir, ...templatesFromGithubDir };
   }

package/lib/project.js

@@ -363,6 +363,7 @@ module.exports = class WorkerProject extends Project {
   }
 
   filterCards(cards, filter) {
+    this.hideLists = []
     const {
       result,
       hideLists
@@ -415,7 +416,6 @@ module.exports = class WorkerProject extends Project {
 
   set filter(filter) {
     this.innerFilter = filter
-    this.hideLists = []
   }
 
   async addMetadata(task, key, value) {

package/lib/repository.js

@@ -34,12 +34,10 @@ var _isFunction = require('lodash.isfunction'),
   newCard = require('./card'),
   { replaceDateLanguage } = require('./adapters/parsers/DateLanguageParser'),
   { getRawTask, isNumber, LIST_NAME_PATTERN } = require('./adapters/parsers/task/CardContentParser'),
-  XRegExp = require('xregexp')
-
-
+  XRegExp = require('xregexp'),
+  promisify = require('util').promisify
 
 const appContext = require('./context/ApplicationContext')
-const get = require('lodash.get')
 
 var ERRORS = constants.ERRORS,
   DEFAULT_FILE_PATTERN = constants.DEFAULT_FILE_PATTERN,
@@ -212,24 +210,28 @@ Repository.prototype.addAllMeta = function (meta) {
  * @param {} list
  * @return
  */
-Repository.prototype.addList = function (list, cb) {
-  cb = tools.cb(cb)
-  if (this.listExists(list.name)) return cb()
-  var self = this
-  var fn = function (err) {
-    if (!err) self.emit('list.modified', list)
-    cb(err)
-  }
-  list = _omit(list, 'tasks')
-  this.config.lists.push(new List(list))
-  if (!list.filter && !/[a-z]/.test(list.name)) {
-    const codeList = list.name.replace(/\s+/g, '-').toUpperCase()
-    if (!this.config.code.include_lists.find((name) => name === codeList)) {
-      this.config.code.include_lists.push(codeList)
+Repository.prototype.addList = async function (list, cb) {
+  cb = tools.cb(cb);
+  if (this.listExists(list.name)) return cb();
+
+  try {
+    list = _omit(list, 'tasks');
+    this.config.lists.push(new List(list));
+
+    if (!list.filter && !/[a-z]/.test(list.name)) {
+      const codeList = list.name.replace(/\s+/g, '-').toUpperCase();
+      if (!this.config.code.include_lists.find((name) => name === codeList)) {
+        this.config.code.include_lists.push(codeList);
+      }
     }
+
+    await promisify(this.saveConfig).bind(this)();
+    this.emit('list.modified', list);
+    cb();
+  } catch (err) {
+    cb(err);
   }
-  this.saveConfig(fn)
-}
+};
 
 Repository.prototype.removeList = function (list, cb) {
   return new Promise((resolve, reject) => {
@@ -273,7 +275,7 @@ Repository.prototype.getConfig = function () {
  * @return MemberExpression
  */
 Repository.prototype.getLists = function () {
-  return this.getConfig().lists
+  return this.getConfig().lists.map(obj => ({...obj}));
 }
 
 Repository.prototype.getVisibleLists = function () {
@@ -771,8 +773,8 @@ Repository.prototype.getList = function (name) {
 }
 
 
-Repository.prototype.getListById = function(id) {
-  return this.getLists().find((list) => list.id === id)
+Repository.prototype.getListById = function(id, lists = this.getLists()) {
+  return lists.find((list) => list.id === id)
 }
 
 Repository.prototype.hideList = function (name, cb) {
@@ -867,11 +869,11 @@ Repository.prototype.updateList = function(id, {name, filter}) {
     if (!filter && this.listExists(name)) return resolve()
 
     const lists = this.getLists()
-    const list = this.getListById(id)
+    const list = this.getListById(id, lists)
     const oldName = list.name
     const oldFilter = list.filter
     list.name = name
-     if (oldFilter) list.filter = filter
+    if (oldFilter) list.filter = filter
     this.setLists(lists)
 
     if (oldName === name || oldFilter) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "imdone-core",
-  "version": "1.54.2",
+  "version": "1.54.4",
   "description": "imdone-core",
   "main": "index.js",
   "bin": {