imapflow 1.6.4 → 1.6.5

package/test/search-compiler-test.js

@@ -87,13 +87,49 @@ module.exports['Search Compiler: SEQ with number'] = test => {
     test.done();
 };
 
-module.exports['Search Compiler: SEQ ignores invalid values'] = test => {
+module.exports['Search Compiler: SEQ passes invalid values through to the compiler guard'] = test => {
     let connection = createMockConnection();
 
-    // Whitespace in sequence is invalid
+    // An invalid sequence string used to be dropped silently here, which turned the
+    // filter into an unrestricted search matching every message. It is now emitted as
+    // a SEQUENCE token so the IMAP compiler rejects it with a coded error instead.
     let compiled = searchCompiler(connection, { seq: '1 2 3' });
-    test.equal(compiled.length, 0);
+    let seqAttr = compiled.find(a => a.type === 'SEQUENCE');
+    test.ok(seqAttr, 'the sequence value must not be dropped');
+    test.equal(seqAttr.value, '1 2 3');
+
+    // Junk values pass through too, so they fail loudly at the compiler instead of
+    // silently widening the search
+    let junk = searchCompiler(connection, { seq: {} });
+    test.ok(
+        junk.find(a => a.type === 'SEQUENCE'),
+        'a junk value must not be dropped'
+    );
+
+    // Zero is not a valid IMAP sequence number but it is a valid filter value,
+    // so it must reach the compiler guard rather than be dropped as falsy
+    let zero = searchCompiler(connection, { seq: 0 });
+    test.equal(zero.find(a => a.type === 'SEQUENCE').value, '0', 'zero must not be dropped');
+
+    test.done();
+};
+
+module.exports['Search Compiler: SEQ array compiles to a single comma-joined set'] = test => {
+    let connection = createMockConnection();
+    let compiled = searchCompiler(connection, { seq: [1, 3] });
+
+    let seqAttr = compiled.find(a => a.type === 'SEQUENCE');
+    test.ok(seqAttr, 'array must produce a sequence set');
+    test.equal(seqAttr.value, '1,3');
+    test.done();
+};
 
+module.exports['Search Compiler: SEQ empty string compiles to nothing'] = test => {
+    let connection = createMockConnection();
+    let compiled = searchCompiler(connection, { seq: '' });
+
+    test.ok(!compiled.find(a => a.type === 'SEQUENCE'), 'an empty set adds no SEQUENCE attribute');
+    test.equal(compiled.length, 0);
     test.done();
 };
 
@@ -366,6 +402,30 @@ module.exports['Search Compiler: UID with number'] = test => {
     test.done();
 };
 
+module.exports['Search Compiler: UID array compiles to a single comma-joined set'] = test => {
+    let connection = createMockConnection();
+    let compiled = searchCompiler(connection, { uid: [5, 7, 9] });
+
+    // Separate tokens ("UID 5 7 9") would be parsed by the server as extra
+    // sequence-number search keys ANDed to the query - the array means the set {5,7,9}
+    test.ok(hasAttr(compiled, 'UID'));
+    let uidValueAttr = compiled.find(a => a.value === '5,7,9');
+    test.ok(uidValueAttr, 'array must be joined into one sequence set');
+    test.equal(uidValueAttr.type, 'SEQUENCE');
+    test.done();
+};
+
+module.exports['Search Compiler: UID accepts the SEARCHRES $ marker'] = test => {
+    let connection = createMockConnection();
+    let compiled = searchCompiler(connection, { uid: '$' });
+
+    test.ok(hasAttr(compiled, 'UID'));
+    let uidValueAttr = compiled.find(a => a.value === '$');
+    test.ok(uidValueAttr, 'the saved-result marker must pass through');
+    test.equal(uidValueAttr.type, 'SEQUENCE');
+    test.done();
+};
+
 // ============================================
 // EMAILID / THREADID tests
 // ============================================
@@ -488,6 +548,19 @@ module.exports['Search Compiler: LABELS not compiles to -label: via X-GM-RAW'] =
     test.done();
 };
 
+module.exports['Search Compiler: LABELS with a non-object value is ignored'] = test => {
+    let connection = createMockConnection();
+
+    // Neither a falsy value nor a plain string is a { has, not } filter - both
+    // must compile to nothing even without the Gmail extension
+    let compiledNull = searchCompiler(connection, { labels: null });
+    test.equal(compiledNull.length, 0);
+
+    let compiledString = searchCompiler(connection, { labels: 'Horizon' });
+    test.equal(compiledString.length, 0);
+    test.done();
+};
+
 module.exports['Search Compiler: LABELS has and not combined'] = test => {
     let connection = createMockConnection({
         capabilities: [['X-GM-EXT-1', true]]
@@ -991,6 +1064,20 @@ module.exports['Search Compiler: non-ASCII GMRAW adds CHARSET UTF-8'] = test =>
     test.done();
 };
 
+module.exports['Search Compiler: non-ASCII LABELS adds CHARSET UTF-8'] = test => {
+    let connection = createMockConnection({
+        capabilities: [['X-GM-EXT-1', true]],
+        enabled: new Set()
+    });
+    // The label filter compiles into an X-GM-RAW query, and a non-ASCII label name
+    // must mark the compiled query as Unicode the same way a direct gmraw value does
+    let compiled = searchCompiler(connection, { labels: { has: ['Tähtis'] } });
+    test.ok(hasAttr(compiled, 'CHARSET'));
+    test.ok(hasAttr(compiled, 'X-GM-RAW'));
+    test.ok(hasAttr(compiled, 'label:Tähtis'));
+    test.done();
+};
+
 // ============================================
 // Complex query tests
 // ============================================