imapflow 1.2.2 → 1.2.4

package/.release-please-manifest.json

@@ -1,3 +1,3 @@
 {
-    ".": "1.2.2"
+    ".": "1.2.4"
 }

package/CHANGELOG.md

@@ -1,5 +1,19 @@
 # Changelog
 
+## [1.2.4](https://github.com/postalsys/imapflow/compare/v1.2.3...v1.2.4) (2025-12-28)
+
+
+### Bug Fixes
+
+* Improve resource cleanup on connection close ([7c3244c](https://github.com/postalsys/imapflow/commit/7c3244cd2d6c7c3d7be54ba26ad2ce5d8b9ddae9))
+
+## [1.2.3](https://github.com/postalsys/imapflow/compare/v1.2.2...v1.2.3) (2025-12-22)
+
+
+### Bug Fixes
+
+* Add logging for silently swallowed download errors ([b9f1012](https://github.com/postalsys/imapflow/commit/b9f101249236f55c48a68fd6f320d550055dd4e4))
+
 ## [1.2.2](https://github.com/postalsys/imapflow/compare/v1.2.1...v1.2.2) (2025-12-22)
 
 

package/lib/imap-flow.js

@@ -1788,6 +1788,29 @@ class ImapFlow extends EventEmitter {
                 }
             }
 
+            // cleanup streamer
+            if (this.streamer) {
+                try {
+                    // remove our listeners
+                    if (this.socketReadable) {
+                        this.streamer.removeListener('readable', this.socketReadable);
+                    }
+                    this.streamer.removeAllListeners('error');
+                    if (!this.streamer.destroyed) {
+                        this.streamer.destroy();
+                    }
+                } catch (err) {
+                    this.log.error({ err, info: 'Failed to cleanup streamer', cid: this.id });
+                }
+            }
+
+            // clear socket handlers
+            this.clearSocketHandlers();
+
+            // clear cached data
+            this.folders.clear();
+            this.requestTagMap.clear();
+
             this.state = this.states.LOGOUT;
             if (this.isClosed) {
                 return;
@@ -3100,6 +3123,15 @@ class ImapFlow extends EventEmitter {
                             .catch(err => {
                                 if (!fetchAborted && stream && !stream.destroyed) {
                                     stream.emit('error', err);
+                                } else {
+                                    // Log when error cannot be emitted to stream
+                                    this.log.warn({
+                                        msg: 'Download error after stream closed',
+                                        err,
+                                        fetchAborted,
+                                        streamDestroyed: stream?.destroyed,
+                                        cid: this.id
+                                    });
                                 }
                             })
                             .finally(() => {
@@ -3114,6 +3146,15 @@ class ImapFlow extends EventEmitter {
                     .catch(err => {
                         if (!fetchAborted && stream && !stream.destroyed) {
                             stream.emit('error', err);
+                        } else {
+                            // Log when error cannot be emitted to stream
+                            this.log.warn({
+                                msg: 'Download error after stream closed',
+                                err,
+                                fetchAborted,
+                                streamDestroyed: stream?.destroyed,
+                                cid: this.id
+                            });
                         }
                     })
                     .finally(() => {

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "imapflow",
-    "version": "1.2.2",
+    "version": "1.2.4",
     "description": "IMAP Client for Node",
     "main": "lib/imap-flow.js",
     "types": "lib/imap-flow.d.ts",
@@ -35,9 +35,9 @@
         "@babel/plugin-syntax-class-properties": "7.12.13",
         "@babel/preset-env": "7.28.5",
         "@eslint/eslintrc": "3.3.3",
-        "@eslint/js": "9.39.1",
-        "@types/node": "25.0.0",
-        "eslint": "9.39.1",
+        "@eslint/js": "9.39.2",
+        "@types/node": "25.0.3",
+        "eslint": "9.39.2",
         "eslint-config-nodemailer": "1.2.0",
         "eslint-config-prettier": "10.1.8",
         "grunt": "1.6.1",
@@ -52,12 +52,12 @@
     },
     "dependencies": {
         "encoding-japanese": "2.2.0",
-        "iconv-lite": "0.7.0",
+        "iconv-lite": "0.7.1",
         "libbase64": "1.3.0",
         "libmime": "5.3.7",
         "libqp": "2.1.1",
         "@zone-eu/mailsplit": "5.4.8",
-        "nodemailer": "7.0.11",
+        "nodemailer": "7.0.12",
         "pino": "10.1.0",
         "socks": "2.8.7"
     }

package/test/memory-cleanup-test.js

@@ -0,0 +1,144 @@
+'use strict';
+
+/**
+ * Tests for memory cleanup on connection close
+ */
+
+const { ImapFlow } = require('../lib/imap-flow');
+
+exports['Memory Cleanup Tests'] = {
+    'should clean up streamer on close without connection'(test) {
+        const client = new ImapFlow({
+            host: '127.0.0.1',
+            port: 1,
+            secure: false,
+            logger: false
+        });
+
+        // Check initial state
+        test.ok(client.streamer, 'streamer should exist');
+        test.ok(!client.streamer.destroyed, 'streamer should not be destroyed initially');
+
+        // Close without connecting
+        client.close();
+
+        // Verify cleanup
+        test.ok(client.streamer.destroyed, 'streamer should be destroyed after close');
+        test.equal(client.streamer.listenerCount('error'), 0, 'error listeners should be removed');
+        test.equal(client.folders.size, 0, 'folders should be cleared');
+        test.equal(client.requestTagMap.size, 0, 'requestTagMap should be cleared');
+        test.ok(client.isClosed, 'client should be marked as closed');
+
+        test.done();
+    },
+
+    'should remove event listeners on close'(test) {
+        const client = new ImapFlow({
+            host: '127.0.0.1',
+            port: 1,
+            secure: false,
+            logger: false
+        });
+
+        // Add a readable listener as if connect was called
+        client.socketReadable = () => {};
+        client.streamer.on('readable', client.socketReadable);
+
+        // Verify listener was added
+        test.equal(client.streamer.listenerCount('readable'), 1, 'readable listener should be present');
+
+        client.close();
+
+        // Check listeners after close
+        test.equal(client.streamer.listenerCount('readable'), 0, 'readable listener should be removed');
+        test.equal(client.streamer.listenerCount('error'), 0, 'error listeners should be removed');
+
+        test.done();
+    },
+
+    'should clear internal structures on close'(test) {
+        const client = new ImapFlow({
+            host: '127.0.0.1',
+            port: 1,
+            secure: false,
+            logger: false
+        });
+
+        // Add some data to internal structures
+        client.folders.set('INBOX', { path: 'INBOX' });
+        client.folders.set('Sent', { path: 'Sent' });
+        client.requestTagMap.set('A001', { tag: 'A001' });
+        client.requestTagMap.set('A002', { tag: 'A002' });
+
+        test.equal(client.folders.size, 2, 'folders should have entries');
+        test.equal(client.requestTagMap.size, 2, 'requestTagMap should have entries');
+
+        client.close();
+
+        test.equal(client.folders.size, 0, 'folders should be cleared after close');
+        test.equal(client.requestTagMap.size, 0, 'requestTagMap should be cleared after close');
+
+        test.done();
+    },
+
+    'should handle multiple close calls gracefully'(test) {
+        const client = new ImapFlow({
+            host: '127.0.0.1',
+            port: 1,
+            secure: false,
+            logger: false
+        });
+
+        // Call close multiple times
+        test.doesNotThrow(() => {
+            client.close();
+            client.close();
+            client.close();
+        }, 'multiple close calls should not throw');
+
+        test.ok(client.isClosed, 'client should be marked as closed');
+
+        test.done();
+    },
+
+    'should properly set state on close'(test) {
+        const client = new ImapFlow({
+            host: '127.0.0.1',
+            port: 1,
+            secure: false,
+            logger: false
+        });
+
+        test.equal(client.state, client.states.NOT_AUTHENTICATED, 'initial state should be NOT_AUTHENTICATED');
+        test.equal(client.usable, false, 'usable should be false initially');
+        test.equal(client.isClosed, false, 'isClosed should be false initially');
+
+        client.close();
+
+        test.equal(client.state, client.states.LOGOUT, 'state should be LOGOUT after close');
+        test.equal(client.usable, false, 'usable should be false after close');
+        test.equal(client.isClosed, true, 'isClosed should be true after close');
+
+        test.done();
+    },
+
+    'should emit close event'(test) {
+        const client = new ImapFlow({
+            host: '127.0.0.1',
+            port: 1,
+            secure: false,
+            logger: false
+        });
+
+        let closeEmitted = false;
+        client.on('close', () => {
+            closeEmitted = true;
+        });
+
+        client.close();
+
+        test.ok(closeEmitted, 'close event should be emitted');
+
+        test.done();
+    }
+};