imapflow 1.0.183 → 1.0.184

package/CHANGELOG.md

@@ -1,5 +1,13 @@
 # Changelog
 
+## [1.0.184](https://github.com/postalsys/imapflow/compare/v1.0.183...v1.0.184) (2025-03-11)
+
+
+### Bug Fixes
+
+* Allow to call the connect method only once ([ca7ec96](https://github.com/postalsys/imapflow/commit/ca7ec969f19a93c5dc574bf3873cd7afc4d7af47))
+* **Authentication:** Report errors; Fix LOGINDISABLED ([#275](https://github.com/postalsys/imapflow/issues/275)) ([a3a3fb9](https://github.com/postalsys/imapflow/commit/a3a3fb993dee66c02b34bba0e0b26fc349487b26))
+
 ## [1.0.183](https://github.com/postalsys/imapflow/compare/v1.0.182...v1.0.183) (2025-03-09)
 
 

package/lib/imap-flow.js

@@ -38,6 +38,7 @@ const {
     packMessageRange,
     normalizePath,
     expandRange,
+    AuthenticationFailure,
     getColorFlags
 } = require('./tools');
 
@@ -370,6 +371,9 @@ class ImapFlow extends EventEmitter {
             setImmediate(() => this.close());
             this.emitError(err);
         });
+
+        // Has the `connect` method already been called
+        this._connectCalled = false;
     }
 
     emitError(err) {
@@ -796,11 +800,7 @@ class ImapFlow extends EventEmitter {
 
         await this.upgradeToSTARTTLS();
 
-        let authenticated = await this.authenticate();
-        if (!authenticated) {
-            // nothing to do here
-            return await this.logout();
-        }
+        await this.authenticate();
 
         if (!this.idRequested && this.capabilities.has('ID')) {
             // re-request ID after LOGIN
@@ -812,8 +812,7 @@ class ImapFlow extends EventEmitter {
         if (nsResponse && nsResponse.error && nsResponse.status === 'BAD' && /User is authenticated but not connected/i.test(nsResponse.text)) {
             // Not a NAMESPACE failure but authentication failure, so report as
             this.authenticated = false;
-            let err = new Error('Authentication failed');
-            err.authenticationFailed = true;
+            let err = new AuthenticationFailure('Authentication failed');
             err.response = nsResponse.text;
             throw err;
         }
@@ -1043,14 +1042,17 @@ class ImapFlow extends EventEmitter {
     }
 
     async authenticate() {
+        if (this.state === this.states.LOGOUT) {
+            throw new AuthenticationFailure('Already logged out');
+        }
+
         if (this.state !== this.states.NOT_AUTHENTICATED) {
             // nothing to do here, usually happens with PREAUTH greeting
-            return this.state !== this.states.LOGOUT;
+            return true;
         }
 
-        if (this.capabilities.has('LOGINDISABLED') || !this.options.auth) {
-            // can not log in
-            return false;
+        if (!this.options.auth) {
+            throw new AuthenticationFailure('Please configure the login');
         }
 
         this.expectCapabilityUpdate = true;
@@ -1067,8 +1069,13 @@ class ImapFlow extends EventEmitter {
             if ((this.capabilities.has('AUTH=LOGIN') || this.capabilities.has('AUTH=PLAIN')) && loginMethod !== 'LOGIN') {
                 this.authenticated = await this.run('AUTHENTICATE', this.options.auth.user, { password: this.options.auth.pass, loginMethod });
             } else {
+                if (this.capabilities.has('LOGINDISABLED')) {
+                    throw new AuthenticationFailure('Login is disabled');
+                }
                 this.authenticated = await this.run('LOGIN', this.options.auth.user, this.options.auth.pass);
             }
+        } else {
+            throw new AuthenticationFailure('No password configured');
         }
 
         if (this.authenticated) {
@@ -1082,7 +1089,7 @@ class ImapFlow extends EventEmitter {
             return true;
         }
 
-        return false;
+        throw new AuthenticationFailure('No matching authentication method');
     }
 
     async initialOK(message) {
@@ -1405,6 +1412,12 @@ class ImapFlow extends EventEmitter {
      * await client.connect();
      */
     async connect() {
+        if (this._connectCalled) {
+            // Prevent re-using ImapFlow instances by allowing to call connect just once.
+            throw new Error('Can not re-use ImapFlow instance');
+        }
+        this._connectCalled = true;
+
         let connector = this.secureConnection ? tls : net;
 
         let opts = Object.assign(

package/lib/tools.js

@@ -11,6 +11,10 @@ const iconv = require('iconv-lite');
 
 const FLAG_COLORS = ['red', 'orange', 'yellow', 'green', 'blue', 'purple', 'grey'];
 
+class AuthenticationFailure extends Error {
+    authenticationFailed = true;
+}
+
 const tools = {
     encodePath(connection, path) {
         path = (path || '').toString();
@@ -90,6 +94,8 @@ const tools = {
         return map;
     },
 
+    AuthenticationFailure,
+
     getStatusCode(response) {
         return response &&
             response.attributes &&

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "imapflow",
-    "version": "1.0.183",
+    "version": "1.0.184",
     "description": "IMAP Client for Node",
     "main": "./lib/imap-flow.js",
     "scripts": {