icore 2.0.0 → 2.0.1

package/CHANGELOG.md

@@ -14,6 +14,19 @@ Version boundaries from `1.0.12` through `1.0.19` were checked against npm
 
 ## [Unreleased]
 
+### Fixed
+
+- Built package output automatically before npm and Yarn packing.
+- Preserved option names that overlap properties inherited from
+  `Object.prototype`.
+- Rejected malformed nested records, table rows, and CSV rows in presentation
+  result guards.
+- Quoted CSV cells containing carriage returns.
+- Rejected backpressured writes when EventEmitter-compatible sinks error or
+  close before `drain`.
+- Rejected top-level values without a JSON representation instead of emitting
+  invalid JSON text.
+
 ## [2.0.0] - 2026-07-14
 
 ### Added

package/dist/argv/parser.js

@@ -18,7 +18,7 @@ const icore_error_1 = require("../errors/icore-error");
  */
 function parseArgv(args, schema) {
     const positionals = [];
-    const options = {};
+    const options = Object.create(null);
     const aliases = buildShortAliasMap(schema);
     let parseOptions = true;
     for (let index = 0; index < args.length; index += 1) {
@@ -68,10 +68,10 @@ function parseArgv(args, schema) {
         if (name === '') {
             throw createUnexpectedArgumentError(arg);
         }
-        const definition = schema?.[name];
+        const definition = getOwnOptionDefinition(schema, name);
         if (separatorIndex === -1 && definition === undefined && name.startsWith('no-')) {
             const negatedName = name.slice(3);
-            const negatedDefinition = schema?.[negatedName];
+            const negatedDefinition = getOwnOptionDefinition(schema, negatedName);
             if (negatedDefinition?.type === 'boolean') {
                 if (Object.hasOwn(options, negatedName)) {
                     throw createDuplicateArgumentError(negatedName);
@@ -106,9 +106,15 @@ function parseArgv(args, schema) {
     }
     return {
         positionals,
-        options
+        options: { ...options }
     };
 }
+function getOwnOptionDefinition(schema, name) {
+    if (schema === undefined || !Object.hasOwn(schema, name)) {
+        return undefined;
+    }
+    return schema[name];
+}
 function buildShortAliasMap(schema) {
     const aliases = new Map();
     if (schema === undefined) {

package/dist/options/parser.js

@@ -26,8 +26,8 @@ function parseOptions(schema, values) {
  * metadata.
  */
 function parseOptionsDetailed(schema, values) {
-    const parsed = {};
-    const provided = {};
+    const parsed = Object.create(null);
+    const provided = Object.create(null);
     for (const name of Object.keys(values)) {
         if (!Object.hasOwn(schema, name)) {
             throw createUnexpectedArgumentError(name);
@@ -35,27 +35,30 @@ function parseOptionsDetailed(schema, values) {
     }
     for (const name of Object.keys(schema)) {
         const definition = schema[name];
-        const value = values[String(name)];
+        const optionName = String(name);
+        const value = Object.hasOwn(values, optionName)
+            ? values[optionName]
+            : undefined;
         if (definition === undefined) {
             continue;
         }
         provided[name] = value !== undefined;
         if (value === undefined) {
             if ('default' in definition) {
-                parsed[name] = parseDefaultOptionValue(String(name), definition);
+                parsed[name] = parseDefaultOptionValue(optionName, definition);
                 continue;
             }
             if (definition.required === true) {
-                throw createExpectedRequiredArgumentError(String(name));
+                throw createExpectedRequiredArgumentError(optionName);
             }
             parsed[name] = undefined;
             continue;
         }
-        parsed[name] = parseOptionValue(String(name), definition, value);
+        parsed[name] = parseOptionValue(optionName, definition, value);
     }
     return {
-        options: parsed,
-        provided: provided
+        options: { ...parsed },
+        provided: { ...provided }
     };
 }
 /**
@@ -63,8 +66,8 @@ function parseOptionsDetailed(schema, values) {
  * remaining raw options untouched.
  */
 function parseOptionsSubsetDetailed(schema, values) {
-    const subsetValues = {};
-    const rest = {};
+    const subsetValues = Object.create(null);
+    const rest = Object.create(null);
     for (const [name, value] of Object.entries(values)) {
         if (Object.hasOwn(schema, name)) {
             subsetValues[name] = value;
@@ -74,7 +77,7 @@ function parseOptionsSubsetDetailed(schema, values) {
     }
     return {
         ...parseOptionsDetailed(schema, subsetValues),
-        rest
+        rest: { ...rest }
     };
 }
 function parseOptionValue(name, definition, value) {

package/dist/options/schema.js

@@ -19,5 +19,6 @@ exports.mergeOptionsSchema = mergeOptionsSchema;
  * Later schemas override earlier schemas with the same option name.
  */
 function mergeOptionsSchema(schema, ...schemas) {
-    return Object.assign({}, schema, ...schemas);
+    const merged = Object.assign(Object.create(null), schema, ...schemas);
+    return { ...merged };
 }

package/dist/output/text-writer.d.ts

@@ -5,7 +5,7 @@
  * Allowed here:
  * - the minimal text writer contract;
  * - promise-returning sink support;
- * - Node-style `drain` waiting when a writable sink reports backpressure;
+ * - Node-style backpressure and writable lifecycle handling;
  *
  * This file must not contain stdout/stderr selection or command semantics.
  */
@@ -24,6 +24,7 @@ export type BackpressureTextSink = {
  * Creates a text writer that preserves writable-stream backpressure.
  *
  * Promise-returning sinks are awaited, and Node-style sinks returning `false`
- * are resumed after their next `drain` event.
+ * are resumed after their next `drain` event. EventEmitter-compatible sinks
+ * reject when they emit `error` or `close` before draining.
  */
 export declare function createBackpressureTextWriter(sink: BackpressureTextSink): TextWriter;

package/dist/output/text-writer.js

@@ -6,7 +6,7 @@
  * Allowed here:
  * - the minimal text writer contract;
  * - promise-returning sink support;
- * - Node-style `drain` waiting when a writable sink reports backpressure;
+ * - Node-style backpressure and writable lifecycle handling;
  *
  * This file must not contain stdout/stderr selection or command semantics.
  */
@@ -16,7 +16,8 @@ exports.createBackpressureTextWriter = createBackpressureTextWriter;
  * Creates a text writer that preserves writable-stream backpressure.
  *
  * Promise-returning sinks are awaited, and Node-style sinks returning `false`
- * are resumed after their next `drain` event.
+ * are resumed after their next `drain` event. EventEmitter-compatible sinks
+ * reject when they emit `error` or `close` before draining.
  */
 function createBackpressureTextWriter(sink) {
     return {
@@ -32,6 +33,10 @@ function createBackpressureTextWriter(sink) {
             if (typeof sink.once !== 'function') {
                 return;
             }
+            if (isEventedBackpressureTextSink(sink)) {
+                await waitForEventedDrain(sink);
+                return;
+            }
             await waitForDrain(sink.once.bind(sink));
         }
     };
@@ -47,3 +52,38 @@ function waitForDrain(onceDrain) {
         onceDrain('drain', resolve);
     });
 }
+function waitForEventedDrain(sink) {
+    return new Promise((resolve, reject) => {
+        let settled = false;
+        function cleanup() {
+            sink.off('drain', handleDrain);
+            sink.off('error', handleError);
+            sink.off('close', handleClose);
+        }
+        function settle(action) {
+            if (settled) {
+                return;
+            }
+            settled = true;
+            cleanup();
+            action();
+        }
+        function handleDrain() {
+            settle(resolve);
+        }
+        function handleError(error) {
+            settle(() => reject(error));
+        }
+        function handleClose() {
+            settle(() => reject(new Error('Writable sink closed before drain')));
+        }
+        sink.once('error', handleError);
+        sink.once('close', handleClose);
+        sink.once('drain', handleDrain);
+    });
+}
+function isEventedBackpressureTextSink(sink) {
+    const candidate = sink;
+    return (typeof sink.once === 'function'
+        && typeof candidate.off === 'function');
+}

package/dist/presentation/renderers/csv.d.ts

@@ -3,7 +3,7 @@
  *
  * Allowed here:
  * - CSV row joining;
- * - CSV cell escaping for comma, quote, and newline values;
+ * - CSV cell escaping for comma, quote, carriage return, and newline values;
  *
  * This file must not contain application report mapping.
  */

package/dist/presentation/renderers/csv.js

@@ -4,7 +4,7 @@
  *
  * Allowed here:
  * - CSV row joining;
- * - CSV cell escaping for comma, quote, and newline values;
+ * - CSV cell escaping for comma, quote, carriage return, and newline values;
  *
  * This file must not contain application report mapping.
  */
@@ -28,7 +28,7 @@ function renderCsv(rows) {
 }
 function renderCsvValue(value) {
     const text = String(value);
-    if (!/[",\n]/.test(text)) {
+    if (!/[",\r\n]/.test(text)) {
         return text;
     }
     return `"${text.replaceAll('"', '""')}"`;

package/dist/presentation/renderers/json.d.ts

@@ -9,5 +9,7 @@
  */
 /**
  * Renders an already prepared value as pretty JSON with a trailing newline.
+ *
+ * Throws when the value has no top-level JSON representation.
  */
 export declare function renderJson(value: unknown): string;

package/dist/presentation/renderers/json.js

@@ -12,7 +12,13 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.renderJson = renderJson;
 /**
  * Renders an already prepared value as pretty JSON with a trailing newline.
+ *
+ * Throws when the value has no top-level JSON representation.
  */
 function renderJson(value) {
-    return `${JSON.stringify(value, null, 2)}\n`;
+    const json = JSON.stringify(value, null, 2);
+    if (json === undefined) {
+        throw new TypeError('Expected a JSON-serializable value');
+    }
+    return `${json}\n`;
 }

package/dist/presentation/result-renderer.js

@@ -70,10 +70,13 @@ function isPresentationResult(value) {
         return result['value'] === null || isRecord(result['value']);
     }
     if (result['type'] === 'records') {
-        return Array.isArray(result['value']);
+        return isArrayOf(result['value'], isRecord);
     }
-    if (result['type'] === 'table' || result['type'] === 'csv') {
-        return Array.isArray(result['rows']);
+    if (result['type'] === 'table') {
+        return isArrayOf(result['rows'], isTextTableRow);
+    }
+    if (result['type'] === 'csv') {
+        return isArrayOf(result['rows'], isCsvRow);
     }
     return false;
 }
@@ -182,3 +185,25 @@ function assertNever(value) {
 function isRecord(value) {
     return typeof value === 'object' && value !== null && !Array.isArray(value);
 }
+function isTextTableRow(value) {
+    return isArrayOf(value, (cell) => typeof cell === 'string');
+}
+function isCsvRow(value) {
+    return isArrayOf(value, isCsvCell);
+}
+function isCsvCell(value) {
+    return (typeof value === 'string'
+        || typeof value === 'number'
+        || typeof value === 'boolean');
+}
+function isArrayOf(value, isValue) {
+    if (!Array.isArray(value)) {
+        return false;
+    }
+    for (const element of value) {
+        if (!isValue(element)) {
+            return false;
+        }
+    }
+    return true;
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "icore",
-  "version": "2.0.0",
+  "version": "2.0.1",
   "description": "Declarative command line interface and terminal presentation mechanics for Node.js",
   "keywords": [
     "command-line",
@@ -33,6 +33,7 @@
   "types": "dist/index.d.ts",
   "scripts": {
     "build": "tsc",
+    "prepack": "tsc",
     "test": "fwa --prune",
     "lint": "eslint"
   },