ic-mops 2.4.0 → 2.5.1

package/commands/add.ts

@@ -101,9 +101,12 @@ export async function add(
   }
 
   if (pkgDetails.repo) {
-    await installFromGithub(pkgDetails.name, pkgDetails.repo, {
+    let res = await installFromGithub(pkgDetails.name, pkgDetails.repo, {
       verbose: verbose,
     });
+    if (!res) {
+      process.exit(1);
+    }
   } else if (!pkgDetails.path) {
     let res = await installMopsDep(pkgDetails.name, pkgDetails.version, {
       verbose: verbose,

package/commands/build.ts

@@ -24,7 +24,7 @@ export async function build(
   canisterNames: string[] | undefined,
   options: Partial<BuildOptions>,
 ): Promise<void> {
-  if (canisterNames?.length == 0) {
+  if (canisterNames?.length === 0) {
     cliError("No canisters specified to build");
   }
 
@@ -41,16 +41,11 @@ export async function build(
   }
 
   if (canisterNames) {
-    canisterNames = canisterNames.filter((name) => name in canisters);
-    if (canisterNames.length === 0) {
-      throw new Error("No valid canister names specified");
-    }
-    for (let name of canisterNames) {
-      if (!(name in canisters)) {
-        cliError(
-          `Motoko canister '${name}' not found in mops.toml configuration`,
-        );
-      }
+    let invalidNames = canisterNames.filter((name) => !(name in canisters));
+    if (invalidNames.length) {
+      cliError(
+        `Motoko canister(s) not found in mops.toml configuration: ${invalidNames.join(", ")}`,
+      );
     }
   }
 
@@ -184,7 +179,7 @@ export async function build(
 
   console.log(
     chalk.green(
-      `\n✓ Built ${Object.keys(filteredCanisters).length} canister${Object.keys(filteredCanisters).length == 1 ? "" : "s"} successfully`,
+      `\n✓ Built ${Object.keys(filteredCanisters).length} canister${Object.keys(filteredCanisters).length === 1 ? "" : "s"} successfully`,
     ),
   );
 }

package/commands/install/install-dep.ts

@@ -20,12 +20,11 @@ export async function installDep(
   parentPkgPath?: string,
 ): Promise<boolean> {
   if (dep.repo) {
-    await installFromGithub(dep.name, dep.repo, {
+    return installFromGithub(dep.name, dep.repo, {
       silent,
       verbose,
       ignoreTransitive,
     });
-    return true;
   } else if (dep.path) {
     let depPath = dep.path;
     parentPkgPath = parentPkgPath || getRootDir();
@@ -46,5 +45,8 @@ export async function installDep(
     });
   }
 
-  return true;
+  console.warn(
+    `Warning: dependency "${dep.name}" has no version, repo, or path`,
+  );
+  return false;
 }

package/commands/publish.ts

@@ -398,11 +398,11 @@ export async function publish(
     console.log(chalk.red("Error: ") + publishing.err);
     process.exit(1);
   }
-  let puiblishingId = publishing.ok;
+  let publishingId = publishing.ok;
 
   // upload test stats
   if (options.test) {
-    await actor.uploadTestStats(puiblishingId, {
+    await actor.uploadTestStats(publishingId, {
       passed: BigInt(reporter.passed),
       passedNames: reporter.passedNamesFlat,
     });
@@ -410,17 +410,17 @@ export async function publish(
 
   // upload benchmarks
   if (options.bench) {
-    await actor.uploadBenchmarks(puiblishingId, benchmarks);
+    await actor.uploadBenchmarks(publishingId, benchmarks);
   }
 
   // upload changelog
   if (changelog) {
-    await actor.uploadNotes(puiblishingId, changelog);
+    await actor.uploadNotes(publishingId, changelog);
   }
 
   // upload docs coverage
   if (options.docs) {
-    await actor.uploadDocsCoverage(puiblishingId, docsCov);
+    await actor.uploadDocsCoverage(publishingId, docsCov);
   }
 
   // upload files
@@ -438,7 +438,7 @@ export async function publish(
     }
 
     let res = await actor.startFileUpload(
-      puiblishingId,
+      publishingId,
       file,
       BigInt(chunkCount),
       firstChunk,
@@ -453,7 +453,7 @@ export async function publish(
       let start = i * chunkSize;
       let chunk = Array.from(content.slice(start, start + chunkSize));
       let res = await actor.uploadFileChunk(
-        puiblishingId,
+        publishingId,
         fileId,
         BigInt(i),
         chunk,
@@ -474,7 +474,7 @@ export async function publish(
   progress();
   logUpdate.done();
 
-  let res = await actor.finishPublish(puiblishingId);
+  let res = await actor.finishPublish(publishingId);
   if ("err" in res) {
     console.log(chalk.red("Error: ") + res.err);
     process.exit(1);

package/commands/remove.ts

@@ -65,7 +65,10 @@ export async function remove(
     let config = readConfig(configFile);
     let deps: Dependency[] = Object.values(config.dependencies || {})
       .map((dep) => {
-        return [dep, ...getTransitiveDependenciesOf(dep.name, dep.version)];
+        return [
+          dep,
+          ...getTransitiveDependenciesOf(dep.name, dep.version, dep.repo),
+        ];
       })
       .flat();
     return deps;
@@ -97,7 +100,7 @@ export async function remove(
   // transitive deps of this package (including itself)
   let transitiveDepsOfPackage = [
     pkgDetails,
-    ...getTransitiveDependenciesOf(name, version),
+    ...getTransitiveDependenciesOf(name, version, pkgDetails.repo),
   ];
 
   // remove local cache

package/commands/sources.ts

@@ -38,8 +38,9 @@ export async function sourcesArgs({
 
       // append baseDir
       let pkgBaseDir;
-      if (fs.existsSync(path.join(pkgDir, "mops.toml"))) {
-        let config = readConfig(path.join(pkgDir, "mops.toml"));
+      let resolvedMopsToml = path.resolve(cwd, pkgDir, "mops.toml");
+      if (fs.existsSync(resolvedMopsToml)) {
+        let config = readConfig(resolvedMopsToml);
         pkgBaseDir = path.join(pkgDir, config.package?.baseDir || "src");
       } else {
         pkgBaseDir = path.join(pkgDir, "src");

package/commands/sync.ts

@@ -8,6 +8,7 @@ import { remove } from "./remove.js";
 import { checkIntegrity } from "../integrity.js";
 import { getMocPath } from "../helpers/get-moc-path.js";
 import { MOTOKO_IGNORE_PATTERNS } from "../constants.js";
+import { getDepName } from "../helpers/get-dep-name.js";
 
 type SyncOptions = {
   lock?: "update" | "ignore";
@@ -80,26 +81,22 @@ async function getUsedPackages(): Promise<string[]> {
 
 async function getMissingPackages(): Promise<string[]> {
   let config = readConfig();
-  let allDeps = [
-    ...Object.keys(config.dependencies || {}),
-    ...Object.keys(config["dev-dependencies"] || {}),
-  ];
-  let missing = new Set(await getUsedPackages());
-  for (let pkg of allDeps) {
-    missing.delete(pkg);
-  }
-  return [...missing];
+  let allDepNames = new Set(
+    [
+      ...Object.keys(config.dependencies || {}),
+      ...Object.keys(config["dev-dependencies"] || {}),
+    ].map((key) => getDepName(key)),
+  );
+  let used = await getUsedPackages();
+  return used.filter((pkg) => !allDepNames.has(pkg));
 }
 
 async function getUnusedPackages(): Promise<string[]> {
   let config = readConfig();
-  let allDeps = new Set([
+  let allDeps = [
     ...Object.keys(config.dependencies || {}),
     ...Object.keys(config["dev-dependencies"] || {}),
-  ]);
-  let used = await getUsedPackages();
-  for (let pkg of used) {
-    allDeps.delete(pkg);
-  }
-  return [...allDeps];
+  ];
+  let used = new Set(await getUsedPackages());
+  return allDeps.filter((key) => !used.has(getDepName(key)));
 }

package/commands/test/test.ts

@@ -12,7 +12,7 @@ import debounce from "debounce";
 import { SemVer } from "semver";
 import { ActorMethod } from "@icp-sdk/core/agent";
 
-import { sources } from "../sources.js";
+import { sourcesArgs } from "../sources.js";
 import { getGlobalMocArgs, getRootDir, readConfig } from "../../mops.js";
 import { parallel } from "../../parallel.js";
 
@@ -231,7 +231,7 @@ export async function testWithReporter(
   reporter.addFiles(files);
 
   let config = readConfig();
-  let sourcesArr = await sources();
+  let sourcesArr = (await sourcesArgs()).flat();
   let globalMocArgs = getGlobalMocArgs(config);
 
   if (!mocPath) {
@@ -298,7 +298,7 @@ export async function testWithReporter(
       let mocArgs = [
         "--hide-warnings",
         "--error-detail=2",
-        ...sourcesArr.join(" ").split(" "),
+        ...sourcesArr,
         ...globalMocArgs,
         file,
       ].filter((x) => x);

package/commands/update.ts

@@ -42,12 +42,18 @@ export async function update(pkg?: string, { lock }: UpdateOptions = {}) {
   for (let dep of githubDeps) {
     let { org, gitName, branch, commitHash } = parseGithubURL(dep.repo || "");
     let dev = !!config["dev-dependencies"]?.[dep.name];
-    let commit = await getGithubCommit(`${org}/${gitName}`, branch);
-    if (commit.sha !== commitHash) {
-      await add(
-        `https://github.com/${org}/${gitName}#${branch}@${commit.sha}`,
-        { dev },
-        dep.name,
+    try {
+      let commit = await getGithubCommit(`${org}/${gitName}`, branch);
+      if (commit.sha !== commitHash) {
+        await add(
+          `https://github.com/${org}/${gitName}#${branch}@${commit.sha}`,
+          { dev, lock },
+          dep.name,
+        );
+      }
+    } catch (err: any) {
+      console.log(
+        chalk.red("Error: ") + `Failed to update ${dep.name}: ${err.message}`,
       );
     }
   }
@@ -87,7 +93,7 @@ export async function update(pkg?: string, { lock }: UpdateOptions = {}) {
           );
         }) || dep[0];
 
-      await add(`${dep[0]}@${dep[2]}`, { dev }, asName);
+      await add(`${dep[0]}@${dep[2]}`, { dev, lock }, asName);
     }
   }
 

package/commands/watch/error-checker.ts

@@ -5,7 +5,7 @@ import chalk from "chalk";
 
 import { getMocPath } from "../../helpers/get-moc-path.js";
 import { getGlobalMocArgs, getRootDir, readConfig } from "../../mops.js";
-import { sources } from "../sources.js";
+import { sourcesArgs } from "../sources.js";
 import { parallel } from "../../parallel.js";
 import { globMoFiles } from "./globMoFiles.js";
 
@@ -43,7 +43,7 @@ export class ErrorChecker {
 
     let rootDir = getRootDir();
     let mocPath = getMocPath();
-    let deps = await sources({ cwd: rootDir });
+    let deps = (await sourcesArgs({ cwd: rootDir })).flat();
     let globalMocArgs = getGlobalMocArgs(readConfig());
 
     let paths = globMoFiles(rootDir);
@@ -55,12 +55,7 @@ export class ErrorChecker {
       try {
         await promisify(execFile)(
           mocPath,
-          [
-            "--check",
-            ...deps.flatMap((x) => x.split(" ")),
-            ...globalMocArgs,
-            file,
-          ],
+          ["--check", ...deps, ...globalMocArgs, file],
           { cwd: rootDir },
         );
       } catch (error: any) {

package/commands/watch/warning-checker.ts

@@ -5,7 +5,7 @@ import chalk from "chalk";
 
 import { getMocPath } from "../../helpers/get-moc-path.js";
 import { getGlobalMocArgs, getRootDir, readConfig } from "../../mops.js";
-import { sources } from "../sources.js";
+import { sourcesArgs } from "../sources.js";
 import { ErrorChecker } from "./error-checker.js";
 import { parallel } from "../../parallel.js";
 import { globMoFiles } from "./globMoFiles.js";
@@ -69,7 +69,7 @@ export class WarningChecker {
 
     let rootDir = getRootDir();
     let mocPath = getMocPath();
-    let deps = await sources({ cwd: rootDir });
+    let deps = (await sourcesArgs({ cwd: rootDir })).flat();
     let globalMocArgs = getGlobalMocArgs(readConfig());
     let paths = globMoFiles(rootDir);
 
@@ -83,12 +83,7 @@ export class WarningChecker {
 
       let { stderr } = await promisify(execFile)(
         mocPath,
-        [
-          "--check",
-          ...deps.flatMap((x) => x.split(" ")),
-          ...globalMocArgs,
-          file,
-        ],
+        ["--check", ...deps, ...globalMocArgs, file],
         { cwd: rootDir, signal },
       ).catch((error) => {
         if (error.code === "ABORT_ERR") {

package/dist/api/network.js

@@ -1,23 +1,30 @@
 export function getNetwork() {
-    return globalThis.MOPS_NETWORK || "ic";
+    return process.env["MOPS_NETWORK"] || globalThis.MOPS_NETWORK || "ic";
 }
 export function getEndpoint(network) {
+    let endpoint;
     if (network === "staging") {
-        return {
+        endpoint = {
             host: "https://icp-api.io",
             canisterId: "2d2zu-vaaaa-aaaak-qb6pq-cai",
         };
     }
     else if (network === "ic") {
-        return {
+        endpoint = {
             host: "https://icp-api.io",
             canisterId: "oknww-riaaa-aaaam-qaf6a-cai",
         };
     }
     else {
-        return {
+        endpoint = {
             host: "http://127.0.0.1:4943",
             canisterId: "2d2zu-vaaaa-aaaak-qb6pq-cai",
         };
     }
+    const hostOverride = process.env["MOPS_REGISTRY_HOST"]?.trim();
+    const canisterOverride = process.env["MOPS_REGISTRY_CANISTER_ID"]?.trim();
+    return {
+        host: hostOverride || endpoint.host,
+        canisterId: canisterOverride || endpoint.canisterId,
+    };
 }

package/dist/commands/add.js

@@ -77,9 +77,12 @@ export async function add(name, { verbose = false, dev = false, lock } = {}, asN
         };
     }
     if (pkgDetails.repo) {
-        await installFromGithub(pkgDetails.name, pkgDetails.repo, {
+        let res = await installFromGithub(pkgDetails.name, pkgDetails.repo, {
             verbose: verbose,
         });
+        if (!res) {
+            process.exit(1);
+        }
     }
     else if (!pkgDetails.path) {
         let res = await installMopsDep(pkgDetails.name, pkgDetails.version, {

package/dist/commands/build.js

@@ -12,7 +12,7 @@ import { sourcesArgs } from "./sources.js";
 import { toolchain } from "./toolchain/index.js";
 export const DEFAULT_BUILD_OUTPUT_DIR = ".mops/.build";
 export async function build(canisterNames, options) {
-    if (canisterNames?.length == 0) {
+    if (canisterNames?.length === 0) {
         cliError("No canisters specified to build");
     }
     let config = readConfig();
@@ -26,14 +26,9 @@ export async function build(canisterNames, options) {
         cliError(`No Motoko canisters found in mops.toml configuration`);
     }
     if (canisterNames) {
-        canisterNames = canisterNames.filter((name) => name in canisters);
-        if (canisterNames.length === 0) {
-            throw new Error("No valid canister names specified");
-        }
-        for (let name of canisterNames) {
-            if (!(name in canisters)) {
-                cliError(`Motoko canister '${name}' not found in mops.toml configuration`);
-            }
+        let invalidNames = canisterNames.filter((name) => !(name in canisters));
+        if (invalidNames.length) {
+            cliError(`Motoko canister(s) not found in mops.toml configuration: ${invalidNames.join(", ")}`);
         }
     }
     if (!(await exists(outputDir))) {
@@ -131,7 +126,7 @@ export async function build(canisterNames, options) {
             cliError(`Error while compiling canister ${canisterName}${err?.message ? `\n${err.message}` : ""}`);
         }
     }
-    console.log(chalk.green(`\n✓ Built ${Object.keys(filteredCanisters).length} canister${Object.keys(filteredCanisters).length == 1 ? "" : "s"} successfully`));
+    console.log(chalk.green(`\n✓ Built ${Object.keys(filteredCanisters).length} canister${Object.keys(filteredCanisters).length === 1 ? "" : "s"} successfully`));
 }
 const managedFlags = {
     "-o": "use [build].outputDir in mops.toml or --output flag instead",

package/dist/commands/install/install-dep.js

@@ -7,12 +7,11 @@ import { getRootDir } from "../../mops.js";
 // returns false if failed
 export async function installDep(dep, { verbose, silent, threads, ignoreTransitive } = {}, parentPkgPath) {
     if (dep.repo) {
-        await installFromGithub(dep.name, dep.repo, {
+        return installFromGithub(dep.name, dep.repo, {
             silent,
             verbose,
             ignoreTransitive,
         });
-        return true;
     }
     else if (dep.path) {
         let depPath = dep.path;
@@ -34,5 +33,6 @@ export async function installDep(dep, { verbose, silent, threads, ignoreTransiti
             ignoreTransitive,
         });
     }
-    return true;
+    console.warn(`Warning: dependency "${dep.name}" has no version, repo, or path`);
+    return false;
 }

package/dist/commands/publish.js

@@ -316,25 +316,25 @@ export async function publish(options = {}) {
         console.log(chalk.red("Error: ") + publishing.err);
         process.exit(1);
     }
-    let puiblishingId = publishing.ok;
+    let publishingId = publishing.ok;
     // upload test stats
     if (options.test) {
-        await actor.uploadTestStats(puiblishingId, {
+        await actor.uploadTestStats(publishingId, {
             passed: BigInt(reporter.passed),
             passedNames: reporter.passedNamesFlat,
         });
     }
     // upload benchmarks
     if (options.bench) {
-        await actor.uploadBenchmarks(puiblishingId, benchmarks);
+        await actor.uploadBenchmarks(publishingId, benchmarks);
     }
     // upload changelog
     if (changelog) {
-        await actor.uploadNotes(puiblishingId, changelog);
+        await actor.uploadNotes(publishingId, changelog);
     }
     // upload docs coverage
     if (options.docs) {
-        await actor.uploadDocsCoverage(puiblishingId, docsCov);
+        await actor.uploadDocsCoverage(publishingId, docsCov);
     }
     // upload files
     await parallel(8, files, async (file) => {
@@ -347,7 +347,7 @@ export async function publish(options = {}) {
         if (file === docsFile) {
             file = path.basename(file);
         }
-        let res = await actor.startFileUpload(puiblishingId, file, BigInt(chunkCount), firstChunk);
+        let res = await actor.startFileUpload(publishingId, file, BigInt(chunkCount), firstChunk);
         if ("err" in res) {
             console.log(chalk.red("Error: ") + res.err);
             process.exit(1);
@@ -356,7 +356,7 @@ export async function publish(options = {}) {
         for (let i = 1; i < chunkCount; i++) {
             let start = i * chunkSize;
             let chunk = Array.from(content.slice(start, start + chunkSize));
-            let res = await actor.uploadFileChunk(puiblishingId, fileId, BigInt(i), chunk);
+            let res = await actor.uploadFileChunk(publishingId, fileId, BigInt(i), chunk);
             if ("err" in res) {
                 console.log(chalk.red("Error: ") + res.err);
                 process.exit(1);
@@ -370,7 +370,7 @@ export async function publish(options = {}) {
     // finish
     progress();
     logUpdate.done();
-    let res = await actor.finishPublish(puiblishingId);
+    let res = await actor.finishPublish(publishingId);
     if ("err" in res) {
         console.log(chalk.red("Error: ") + res.err);
         process.exit(1);

package/dist/commands/remove.js

@@ -42,7 +42,10 @@ export async function remove(name, { dev = false, verbose = false, dryRun = fals
         let config = readConfig(configFile);
         let deps = Object.values(config.dependencies || {})
             .map((dep) => {
-            return [dep, ...getTransitiveDependenciesOf(dep.name, dep.version)];
+            return [
+                dep,
+                ...getTransitiveDependenciesOf(dep.name, dep.version, dep.repo),
+            ];
         })
             .flat();
         return deps;
@@ -65,7 +68,7 @@ export async function remove(name, { dev = false, verbose = false, dryRun = fals
     // transitive deps of this package (including itself)
     let transitiveDepsOfPackage = [
         pkgDetails,
-        ...getTransitiveDependenciesOf(name, version),
+        ...getTransitiveDependenciesOf(name, version, pkgDetails.repo),
     ];
     // remove local cache
     for (let dep of transitiveDepsOfPackage) {

package/dist/commands/sources.js

@@ -27,8 +27,9 @@ export async function sourcesArgs({ conflicts = "ignore", cwd = process.cwd(), }
         }
         // append baseDir
         let pkgBaseDir;
-        if (fs.existsSync(path.join(pkgDir, "mops.toml"))) {
-            let config = readConfig(path.join(pkgDir, "mops.toml"));
+        let resolvedMopsToml = path.resolve(cwd, pkgDir, "mops.toml");
+        if (fs.existsSync(resolvedMopsToml)) {
+            let config = readConfig(resolvedMopsToml);
             pkgBaseDir = path.join(pkgDir, config.package?.baseDir || "src");
         }
         else {

package/dist/commands/sync.js

@@ -8,6 +8,7 @@ import { remove } from "./remove.js";
 import { checkIntegrity } from "../integrity.js";
 import { getMocPath } from "../helpers/get-moc-path.js";
 import { MOTOKO_IGNORE_PATTERNS } from "../constants.js";
+import { getDepName } from "../helpers/get-dep-name.js";
 export async function sync({ lock } = {}) {
     if (!checkConfigFile()) {
         return;
@@ -58,25 +59,19 @@ async function getUsedPackages() {
 }
 async function getMissingPackages() {
     let config = readConfig();
-    let allDeps = [
+    let allDepNames = new Set([
         ...Object.keys(config.dependencies || {}),
         ...Object.keys(config["dev-dependencies"] || {}),
-    ];
-    let missing = new Set(await getUsedPackages());
-    for (let pkg of allDeps) {
-        missing.delete(pkg);
-    }
-    return [...missing];
+    ].map((key) => getDepName(key)));
+    let used = await getUsedPackages();
+    return used.filter((pkg) => !allDepNames.has(pkg));
 }
 async function getUnusedPackages() {
     let config = readConfig();
-    let allDeps = new Set([
+    let allDeps = [
         ...Object.keys(config.dependencies || {}),
         ...Object.keys(config["dev-dependencies"] || {}),
-    ]);
-    let used = await getUsedPackages();
-    for (let pkg of used) {
-        allDeps.delete(pkg);
-    }
-    return [...allDeps];
+    ];
+    let used = new Set(await getUsedPackages());
+    return allDeps.filter((key) => !used.has(getDepName(key)));
 }

package/dist/commands/test/test.js

@@ -9,7 +9,7 @@ import { globSync } from "glob";
 import chokidar from "chokidar";
 import debounce from "debounce";
 import { SemVer } from "semver";
-import { sources } from "../sources.js";
+import { sourcesArgs } from "../sources.js";
 import { getGlobalMocArgs, getRootDir, readConfig } from "../../mops.js";
 import { parallel } from "../../parallel.js";
 import { MMF1 } from "./mmf1.js";
@@ -151,7 +151,7 @@ export async function testWithReporter(reporterName, filter = "", defaultMode =
     }
     reporter.addFiles(files);
     let config = readConfig();
-    let sourcesArr = await sources();
+    let sourcesArr = (await sourcesArgs()).flat();
     let globalMocArgs = getGlobalMocArgs(config);
     if (!mocPath) {
         mocPath = await toolchain.bin("moc", { fallback: true });
@@ -197,7 +197,7 @@ export async function testWithReporter(reporterName, filter = "", defaultMode =
             let mocArgs = [
                 "--hide-warnings",
                 "--error-detail=2",
-                ...sourcesArr.join(" ").split(" "),
+                ...sourcesArr,
                 ...globalMocArgs,
                 file,
             ].filter((x) => x);

package/dist/commands/update.js

@@ -25,9 +25,14 @@ export async function update(pkg, { lock } = {}) {
     for (let dep of githubDeps) {
         let { org, gitName, branch, commitHash } = parseGithubURL(dep.repo || "");
         let dev = !!config["dev-dependencies"]?.[dep.name];
-        let commit = await getGithubCommit(`${org}/${gitName}`, branch);
-        if (commit.sha !== commitHash) {
-            await add(`https://github.com/${org}/${gitName}#${branch}@${commit.sha}`, { dev }, dep.name);
+        try {
+            let commit = await getGithubCommit(`${org}/${gitName}`, branch);
+            if (commit.sha !== commitHash) {
+                await add(`https://github.com/${org}/${gitName}#${branch}@${commit.sha}`, { dev, lock }, dep.name);
+            }
+        }
+        catch (err) {
+            console.log(chalk.red("Error: ") + `Failed to update ${dep.name}: ${err.message}`);
         }
     }
     // update mops packages
@@ -58,7 +63,7 @@ export async function update(pkg, { lock } = {}) {
                 return (getDepName(d) === dep[0] &&
                     (!pinnedVersion || dep[1].startsWith(pinnedVersion)));
             }) || dep[0];
-            await add(`${dep[0]}@${dep[2]}`, { dev }, asName);
+            await add(`${dep[0]}@${dep[2]}`, { dev, lock }, asName);
         }
     }
     await checkIntegrity(lock);