hypha-rpc 0.1.0-post5 → 0.1.0-post6

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "hypha-rpc",
-  "version": "0.1.0-post5",
+  "version": "0.1.0-post6",
   "description": "Hypha RPC client for connecting to Hypha server for data management and AI model serving.",
   "main": "index.js",
   "types": "index.d.ts",

package/src/rpc.js

@@ -409,7 +409,7 @@ export class RPC extends MessageEmitter {
     }
 
     throw new Error(
-      `Permission denied for protected service: ${service_id}, workspace mismatch: ${ws} != ${context["ws"]}`,
+      `Permission denied for getting protected service: ${service_id}, workspace mismatch: ${ws} != ${context["ws"]}`,
     );
   }
   async get_remote_service(service_uri, timeout) {
@@ -591,13 +591,13 @@ export class RPC extends MessageEmitter {
     const serviceInfo = this._extract_service_info(service);
     if (notify) {
       if (this.manager_id) {
-        this.emit({
+        await this.emit({
           type: "service-added",
           to: "*/" + this.manager_id,
           service: serviceInfo,
         });
       } else {
-        this.emit({ type: "service-added", to: "*", service: serviceInfo });
+        await this.emit({ type: "service-added", to: "*", service: serviceInfo });
       }
     }
     return serviceInfo;
@@ -941,9 +941,10 @@ export class RPC extends MessageEmitter {
     let reject = null;
     let heartbeat_task = null;
     try {
-      assert(data.method && data.ctx && data.from && data.ws);
+      assert(data.method && data.ctx && data.from);
       const method_name = data.from + ":" + data.method;
       const remote_workspace = data.from.split("/")[0];
+      const remote_client_id = data.from.split("/")[1];
       // Make sure the target id is an absolute id
       data["to"] = data["to"].includes("/")
         ? data["to"]
@@ -1010,9 +1011,9 @@ export class RPC extends MessageEmitter {
       if (this._method_annotations.has(method)) {
         // For services, it should not be protected
         if (this._method_annotations.get(method).visibility === "protected") {
-          if (local_workspace !== remote_workspace) {
+          if (local_workspace !== remote_workspace && (remote_workspace !== "*" || remote_client_id !== this.manager_id)) {
             throw new Error(
-              "Permission denied for protected method " +
+              "Permission denied for invoking protected method " +
                 method_name +
                 ", workspace mismatch: " +
                 local_workspace +

package/src/webrtc-client.js

@@ -154,7 +154,7 @@ async function getRTCService(server, service_id, config) {
           const rpc = await _setupRPC(config);
           pc.rpc = rpc;
           async function getService(name) {
-            return await rpc.get_remote_service(config.peer_id + ":" + name);
+            return await rpc.get_remote_service(config.workspace + "/" + config.peer_id + ":" + name);
           }
           async function disconnect() {
             await rpc.disconnect();