hypercore 10.33.0 → 10.33.2

package/index.js

@@ -20,6 +20,7 @@ const Batch = require('./lib/batch')
 const { manifestHash, defaultSignerManifest, createManifest, isCompat, sign } = require('./lib/verifier')
 const { ReadStream, WriteStream, ByteStream } = require('./lib/streams')
 const {
+  ASSERTION,
   BAD_ARGUMENT,
   SESSION_CLOSED,
   SESSION_NOT_WRITABLE,
@@ -29,6 +30,10 @@ const {
 const promises = Symbol.for('hypercore.promises')
 const inspect = Symbol.for('nodejs.util.inspect.custom')
 
+// Hypercore actually does not have any notion of max/min block sizes
+// but we enforce 15mb to ensure smooth replication (each block is transmitted atomically)
+const MAX_SUGGESTED_BLOCK_SIZE = 15 * 1024 * 1024
+
 module.exports = class Hypercore extends EventEmitter {
   constructor (storage, key, opts) {
     super()
@@ -134,6 +139,8 @@ module.exports = class Hypercore extends EventEmitter {
       indent + ')'
   }
 
+  static MAX_SUGGESTED_BLOCK_SIZE = MAX_SUGGESTED_BLOCK_SIZE
+
   static key (manifest, { compat } = {}) {
     return compat ? manifest.signers[0].publicKey : manifestHash(createManifest(manifest))
   }
@@ -819,6 +826,7 @@ module.exports = class Hypercore extends EventEmitter {
 
   async seek (bytes, opts) {
     if (this.opened === false) await this.opening
+    if (!isValidIndex(bytes)) throw ASSERTION('seek is invalid')
 
     const tree = (opts && opts.tree) || this.core.tree
     const s = tree.seek(bytes, this.padding)
@@ -841,10 +849,9 @@ module.exports = class Hypercore extends EventEmitter {
 
   async has (start, end = start + 1) {
     if (this.opened === false) await this.opening
+    if (!isValidIndex(start) || !isValidIndex(end)) throw ASSERTION('has range is invalid')
 
-    const length = end - start
-    if (length <= 0) return false
-    if (length === 1) return this.core.bitfield.get(start)
+    if (end === start + 1) return this.core.bitfield.get(start)
 
     const i = this.core.bitfield.firstUnset(start)
     return i === -1 || i >= end
@@ -852,6 +859,7 @@ module.exports = class Hypercore extends EventEmitter {
 
   async get (index, opts) {
     if (this.opened === false) await this.opening
+    if (!isValidIndex(index)) throw ASSERTION('block index is invalid')
 
     this.tracer.trace('get', { index })
 
@@ -885,6 +893,8 @@ module.exports = class Hypercore extends EventEmitter {
       end = start + 1
     }
 
+    if (!isValidIndex(start) || !isValidIndex(end)) throw ASSERTION('clear range is invalid')
+
     const cleared = (opts && opts.diff) ? { blocks: 0 } : null
 
     if (start >= end) return cleared
@@ -1024,6 +1034,11 @@ module.exports = class Hypercore extends EventEmitter {
         buffers[i] = this._encode(this.valueEncoding, blocks[i])
       }
     }
+    for (const b of buffers) {
+      if (b.byteLength > MAX_SUGGESTED_BLOCK_SIZE) {
+        throw BAD_ARGUMENT('Appended block exceeds the maximum suggested block size')
+      }
+    }
 
     return this.core.append(buffers, { keyPair, signature, preappend })
   }
@@ -1145,3 +1160,7 @@ function ensureEncryption (core, opts) {
 function createCache (cache) {
   return cache === true ? new Xache({ maxSize: 65536, maxAge: 0 }) : (cache || null)
 }
+
+function isValidIndex (index) {
+  return index === 0 || index > 0
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "hypercore",
-  "version": "10.33.0",
+  "version": "10.33.2",
   "description": "Hypercore is a secure, distributed append-only log",
   "main": "index.js",
   "scripts": {
@@ -50,7 +50,7 @@
     "fast-fifo": "^1.3.0",
     "flat-tree": "^1.9.0",
     "hypercore-crypto": "^3.2.1",
-    "hypercore-errors": "^1.1.1",
+    "hypercore-errors": "^1.2.0",
     "hypercore-id-encoding": "^1.2.0",
     "hypertrace": "^1.2.1",
     "is-options": "^1.0.1",