hypercore-fetch 9.0.5 → 9.0.7

package/index.js

@@ -22,6 +22,7 @@ const MIME_TEXT_HTML = 'text/html; charset=utf-8'
 const MIME_EVENT_STREAM = 'text/event-stream; charset=utf-8'
 
 const HEADER_CONTENT_TYPE = 'Content-Type'
+const HEADER_LAST_MODIFIED = 'Last-Modified'
 
 export const ERROR_KEY_NOT_CREATED = 'Must create key with POST before reading'
 
@@ -208,7 +209,8 @@ export default async function makeHyperFetch ({
       }
     })
     router.get(`hyper://*/${SPECIAL_FOLDER}/${EXTENSIONS_FOLDER_NAME}/*`, async function listenExtension (request) {
-      const { hostname, pathname } = new URL(request.url)
+      const { hostname, pathname: rawPathname } = new URL(request.url)
+      const pathname = decodeURI(rawPathname)
       const name = pathname.slice(`/${SPECIAL_FOLDER}/${EXTENSIONS_FOLDER_NAME}/`.length)
 
       const core = await getCore(`hyper://${hostname}/`)
@@ -228,7 +230,9 @@ export default async function makeHyperFetch ({
       }
     })
     router.post(`hyper://*/${SPECIAL_FOLDER}/${EXTENSIONS_FOLDER_NAME}/*`, async function broadcastExtension (request) {
-      const { hostname, pathname } = new URL(request.url)
+      const { hostname, pathname: rawPathname } = new URL(request.url)
+      const pathname = decodeURI(rawPathname)
+
       const name = pathname.slice(`/${SPECIAL_FOLDER}/${EXTENSIONS_FOLDER_NAME}/`.length)
 
       const core = await getCore(`hyper://${hostname}/`)
@@ -240,7 +244,9 @@ export default async function makeHyperFetch ({
       return { status: 200 }
     })
     router.post(`hyper://*/${SPECIAL_FOLDER}/${EXTENSIONS_FOLDER_NAME}/*/*`, async function extensionToPeer (request) {
-      const { hostname, pathname } = new URL(request.url)
+      const { hostname, pathname: rawPathname } = new URL(request.url)
+      const pathname = decodeURI(rawPathname)
+
       const subFolder = pathname.slice(`/${SPECIAL_FOLDER}/${EXTENSIONS_FOLDER_NAME}/`.length)
       const [name, extensionPeer] = subFolder.split('/')
 
@@ -303,7 +309,8 @@ export default async function makeHyperFetch ({
     })
 
     router.put('hyper://*/**', async function putFiles (request) {
-      const { hostname, pathname } = new URL(request.url)
+      const { hostname, pathname: rawPathname } = new URL(request.url)
+      const pathname = decodeURI(rawPathname)
       const contentType = request.headers.get('Content-Type') || ''
       const isFormData = contentType.includes('multipart/form-data')
 
@@ -338,7 +345,8 @@ export default async function makeHyperFetch ({
       return { status: 201, headers: { Location: request.url } }
     })
     router.delete('hyper://*/**', async function putFiles (request) {
-      const { hostname, pathname } = new URL(request.url)
+      const { hostname, pathname: rawPathname } = new URL(request.url)
+      const pathname = decodeURI(rawPathname)
 
       const drive = await getDrive(`hyper://${hostname}`)
 
@@ -367,7 +375,9 @@ export default async function makeHyperFetch ({
 
   router.head('hyper://*/**', async function headFiles (request) {
     const url = new URL(request.url)
-    const { hostname, pathname, searchParams } = url
+    const { hostname, pathname: rawPathname, searchParams } = url
+    const pathname = decodeURI(rawPathname)
+
     const accept = request.headers.get('Accept') || ''
     const isRanged = request.headers.get('Range') || ''
     const noResolve = searchParams.has('noResolve')
@@ -434,16 +444,15 @@ export default async function makeHyperFetch ({
       return { status: 404, body: 'Not Found' }
     }
 
-    resHeaders.Link = new URL(path, drive.core.url).href
-
     resHeaders.ETag = `${entry.seq}`
+    resHeaders['Content-Length'] = `${entry.value.blob.byteLength}`
 
     const contentType = getMimeType(path)
-    resHeaders['Content-Type'] = contentType
+    resHeaders[HEADER_CONTENT_TYPE] = contentType
 
-    if (entry.metadata?.mtime) {
-      const date = new Date(entry.metadata.mtime)
-      resHeaders['Last-Modified'] = date.toUTCString()
+    if (entry?.value?.metadata?.mtime) {
+      const date = new Date(entry.value.metadata.mtime)
+      resHeaders[HEADER_LAST_MODIFIED] = date.toUTCString()
     }
 
     const size = entry.value.byteLength
@@ -474,7 +483,9 @@ export default async function makeHyperFetch ({
   // TODO: Redirect on directories without trailing slash
   router.get('hyper://*/**', async function getFiles (request) {
     const url = new URL(request.url)
-    const { hostname, pathname, searchParams } = url
+    const { hostname, pathname: rawPathname, searchParams } = url
+    const pathname = decodeURI(rawPathname)
+
     const accept = request.headers.get('Accept') || ''
     const noResolve = searchParams.has('noResolve')
     const isDirectory = pathname.endsWith('/')
@@ -556,9 +567,9 @@ async function serveFile (headers, drive, pathname) {
     Link: `<${fullURL}>; rel="canonical"`
   }
 
-  if (entry.metadata?.mtime) {
-    const date = new Date(entry.metadata.mtime)
-    resHeaders['Last-Modified'] = date.toUTCString()
+  if (entry?.value?.metadata?.mtime) {
+    const date = new Date(entry.value.metadata.mtime)
+    resHeaders[HEADER_LAST_MODIFIED] = date.toUTCString()
   }
 
   const size = entry.value.blob.byteLength

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "hypercore-fetch",
-  "version": "9.0.5",
+  "version": "9.0.7",
   "description": "Implementation of Fetch that uses the Dat SDK for loading p2p content",
   "type": "module",
   "main": "index.js",

package/test.js

@@ -57,7 +57,7 @@ test('Quick check', async (t) => {
 
   t.deepEqual(await existsResponse.json(), [], 'Empty dir on create')
 
-  const uploadLocation = new URL('./example.txt', created)
+  const uploadLocation = new URL('./example .txt', created)
 
   const uploadResponse = await fetch(uploadLocation, {
     method: 'put',
@@ -74,7 +74,7 @@ test('Quick check', async (t) => {
   const contentType = uploadedContentResponse.headers.get('Content-Type')
   const contentLink = uploadedContentResponse.headers.get('Link')
 
-  t.match(contentLink, /^<hyper:\/\/[0-9a-z]{52}\/example.txt>; rel="canonical"$/, 'Link header includes both public key and path.')
+  t.match(contentLink, /^<hyper:\/\/[0-9a-z]{52}\/example%20.txt>; rel="canonical"$/, 'Link header includes both public key and path.')
   t.equal(contentType, 'text/plain; charset=utf-8', 'Content got expected mime type')
   t.equal(content, SAMPLE_CONTENT, 'Got uploaded content back out')
 
@@ -82,7 +82,7 @@ test('Quick check', async (t) => {
 
   await checkResponse(dirResponse, t)
 
-  t.deepEqual(await dirResponse.json(), ['example.txt'], 'File got added')
+  t.deepEqual(await dirResponse.json(), ['example .txt'], 'File got added')
 })
 
 test('GET full url for created keys', async (t) => {
@@ -111,6 +111,31 @@ test('GET full url for created keys', async (t) => {
   t.equal(existingURL, createdURL, 'URL same as in initial create')
 })
 
+test('HEAD request', async (t) => {
+  const created = await nextURL(t)
+  const uploadLocation = new URL('./example.txt', created)
+  await fetch(uploadLocation, { method: 'put', body: SAMPLE_CONTENT })
+
+  const headResponse = await fetch(uploadLocation, { method: 'head' })
+
+  await checkResponse(headResponse, t, 'Able to load HEAD')
+
+  const headersEtag = headResponse.headers.get('Etag')
+  const headersContentType = headResponse.headers.get('Content-Type')
+  const headersContentLength = headResponse.headers.get('Content-Length')
+  const headersAcceptRanges = headResponse.headers.get('Accept-Ranges')
+  const headersLastModified = headResponse.headers.get('Last-Modified')
+  const headersLink = headResponse.headers.get('Link')
+
+  // Version at which the file was added
+  t.equal(headersEtag, '1', 'Headers got expected etag')
+  t.equal(headersContentType, 'text/plain; charset=utf-8', 'Headers got expected mime type')
+  t.ok(headersContentLength, "Headers have 'Content-Length' set.")
+  t.ok(headersLastModified, "Headers have 'Last-Modified' set.")
+  t.equal(headersAcceptRanges, 'bytes')
+  t.match(headersLink, /^<hyper:\/\/[0-9a-z]{52}\/example.txt>; rel="canonical"$/, 'Link header includes both public key and path.')
+})
+
 test('PUT file', async (t) => {
   const created = await nextURL(t)
 
@@ -129,9 +154,11 @@ test('PUT file', async (t) => {
 
   const content = await uploadedContentResponse.text()
   const contentType = uploadedContentResponse.headers.get('Content-Type')
+  const lastModified = uploadedContentResponse.headers.get('Last-Modified')
 
   t.equal(contentType, 'text/plain; charset=utf-8', 'Content got expected mime type')
   t.equal(content, SAMPLE_CONTENT, 'Got uploaded content back out')
+  t.ok(lastModified, 'Last-Modified header got set')
 })
 test('PUT FormData', async (t) => {
   const created = await nextURL(t)