humanish 0.83.1 → 0.84.0

package/dist/run.js

@@ -3605,12 +3605,29 @@ async function missingLocalEvidenceArtifacts(runPaths, bundle) {
         if (stream.ui?.nestedObserverPath && isLocalEvidenceArtifactPath(stream.ui.nestedObserverPath)) {
             addRequiredPath(stream.ui.nestedObserverPath);
         }
+        for (const reference of declaredActorScreenshotReferences(stream)) {
+            if (isRunRootEvidenceReference(reference.path)) {
+                addRequiredPath(reference.path, { screenshot: true });
+            }
+        }
     }
     for (const artifact of bundle.adapterArtifacts ?? []) {
         if (isLocalEvidenceArtifactPath(artifact.path)) {
             addRequiredPath(artifact.path, { screenshot: artifact.kind === "screenshot" });
         }
     }
+    for (const candidate of bundle.feedbackCandidates ?? []) {
+        for (const evidence of candidate.evidence) {
+            if (isRunRootEvidenceReference(evidence.path)) {
+                addRequiredPath(evidence.path, {
+                    screenshot: evidence.kind === "screenshot",
+                    // Feedback accepts an existing empty nonimage file. The conjunctive merge above
+                    // keeps any stricter stream, actor, or adapter requirement in force.
+                    allowEmpty: evidence.kind !== "screenshot"
+                });
+            }
+        }
+    }
     const missing = [];
     for (const [artifactPath, requirements] of requiredPaths) {
         const bytes = await readSafeRunArtifactBytes(runPaths, artifactPath);
@@ -3632,6 +3649,29 @@ function isZeroEventTerminalTrace(value) {
         && value.protocol === "terminal-exec" && value.lane === "terminal"
         && isRecord(value.counts) && value.counts.terminalEvents === 0;
 }
+function declaredActorScreenshotReferences(stream) {
+    const references = [];
+    for (const field of ["actor", "liveActor"]) {
+        const trace = stream[field];
+        if (!isRecord(trace) || !Array.isArray(trace.items))
+            continue;
+        trace.items.forEach((item, index) => {
+            if (!isRecord(item) || !Object.hasOwn(item, "screenshotRef"))
+                return;
+            references.push({
+                label: `${stream.id} ${field}.items[${index}].screenshotRef`,
+                path: isRecord(item.screenshotRef) ? item.screenshotRef.path : undefined,
+                redaction: isRecord(item.screenshotRef) ? item.screenshotRef.redaction : undefined
+            });
+        });
+    }
+    return references;
+}
+function isRunRootEvidenceReference(value) {
+    return typeof value === "string" && isLocalEvidenceArtifactPath(value)
+        && !path.win32.isAbsolute(value) && !value.includes("\0")
+        && !/^[a-z][a-z\d+.-]*:/i.test(value);
+}
 function invalidRunEvidenceReferences(bundle) {
     const findings = [];
     if (path.isAbsolute(bundle.cwd)) {
@@ -3648,6 +3688,13 @@ function invalidRunEvidenceReferences(bundle) {
             findings.push(`adapter artifact ${artifact.namespace}:${artifact.kind} nonlocal artifact ${artifact.path}`);
         }
     }
+    for (const candidate of bundle.feedbackCandidates ?? []) {
+        for (const evidence of candidate.evidence) {
+            if (!isRunRootEvidenceReference(evidence.path)) {
+                findings.push(`feedback candidate ${candidate.id} nonlocal evidence ${evidence.path}`);
+            }
+        }
+    }
     for (const stream of bundle.streams) {
         const seen = new Set();
         for (const artifact of stream.artifacts) {
@@ -3669,6 +3716,11 @@ function invalidRunEvidenceReferences(bundle) {
         if (stream.ui?.screenshotUrl && !normalizeLocalEvidenceReference(stream.ui.screenshotUrl)) {
             findings.push(`${stream.id} nonlocal screenshot reference ${stream.ui.screenshotUrl}`);
         }
+        for (const reference of declaredActorScreenshotReferences(stream)) {
+            if (!isRunRootEvidenceReference(reference.path)) {
+                findings.push(`${reference.label} is malformed or nonlocal`);
+            }
+        }
     }
     return findings.slice(0, 50);
 }
@@ -3967,7 +4019,11 @@ function rawScreenshotStreamIds(bundle) {
     const rawStreamIds = [];
     for (const stream of bundle.streams) {
         const trace = stream.actor;
-        if (isRecord(trace) && isRecord(trace.redaction) && trace.redaction.screenshots === "raw") {
+        const aggregateRaw = isRecord(trace) && isRecord(trace.redaction) && trace.redaction.screenshots === "raw";
+        // Partial live traces have no final actor summary. An explicit raw frame must also
+        // retain local-only posture, including when it contradicts an aggregate blur claim.
+        const frameRaw = declaredActorScreenshotReferences(stream).some((reference) => reference.redaction === "none");
+        if (aggregateRaw || frameRaw) {
             rawStreamIds.push(stream.id);
         }
     }