humanish 0.75.0 → 0.77.0

package/dist/program.js

@@ -13,7 +13,7 @@ import { runInit } from "./init.js";
 import { computeStats, formatStatsHuman } from "./stats.js";
 import { PortInUseError } from "./listen.js";
 import { DEFAULT_EXPORT_MAX_BYTES, exportRun, formatExportHuman } from "./export.js";
-import { buildPayload, disabledByEnvironment, inHumanishCheckout, durationBucket, readTelemetryState, sendTelemetry, telemetryStatePath, deriveStudyFacts, TELEMETRY_NOTICE, writeTelemetryState } from "./telemetry.js";
+import { buildPayload, disabledByEnvironment, durationBucket, readTelemetryState, sendTelemetry, telemetryStatePath, deriveStudyFacts, TELEMETRY_NOTICE, writeTelemetryState, isOwnCheckoutRun } from "./telemetry.js";
 import { inspectLabManifest, listLabManifests, resolveLabManifest } from "./labs.js";
 import { runLabPreflight } from "./lab-preflight.js";
 import { runLab, resolveLabDryRun, selectLabBackend } from "./lab-engine.js";
@@ -107,8 +107,9 @@ async function recordCommandTelemetry(command, ok, durationMs, exitCode) {
             return;
         if (disabledByEnvironment(process.env))
             return;
-        // Our own checkout never reports. See inHumanishCheckout for the measured reason.
-        if (inHumanishCheckout(process.cwd(), (p) => readFileSync(p, "utf8")))
+        // Our own checkout never reports, from whichever directory the command was started: see
+        // isOwnCheckoutRun for the measured reason both walks exist.
+        if (isOwnCheckoutRun(process.cwd(), dirname(fileURLToPath(import.meta.url)), (p) => readFileSync(p, "utf8")))
             return;
         const state = await readTelemetryState();
         if (!state.enabled)
@@ -1744,9 +1745,10 @@ function registerFeedbackCommands(parent, io) {
         .description("Generate a public-safe feedback draft from verified evidence.")
         .option("--run <id>", "Run id or latest pointer.", "latest")
         .option("--cwd <path>", "Target project directory.", ".")
+        .option("--candidate <id>", "Which finding to draft (ids from `feedback list`); default: the first.")
         .option("--json", JSON_OPTION_DESCRIPTION)
         .action(async (options, command) => {
-        const result = await draftFeedback(options.cwd, options.run);
+        const result = await draftFeedback(options.cwd, options.run, candidateOption(options));
         writeResult(command, io, result, formatFeedbackHuman);
         io.setExitCode(result.ok ? 0 : 2);
     });
@@ -1755,9 +1757,10 @@ function registerFeedbackCommands(parent, io) {
         .description("Verify the feedback draft for public issue eligibility.")
         .option("--run <id>", "Run id or latest pointer.", "latest")
         .option("--cwd <path>", "Target project directory.", ".")
+        .option("--candidate <id>", "Which finding to verify (ids from `feedback list`); default: the first.")
         .option("--json", JSON_OPTION_DESCRIPTION)
         .action(async (options, command) => {
-        const result = await verifyFeedback(options.cwd, options.run);
+        const result = await verifyFeedback(options.cwd, options.run, candidateOption(options));
         writeResult(command, io, result, formatFeedbackHuman);
         io.setExitCode(result.ok ? 0 : 2);
     });
@@ -1768,9 +1771,10 @@ function registerFeedbackCommands(parent, io) {
         .option("--cwd <path>", "Target project directory.", ".")
         .requiredOption("--repo <owner/repo>", "Repository slug used in rendered filing instructions.")
         .option("--format <format>", "Output format.", "markdown")
+        .option("--candidate <id>", "Which finding to file (ids from `feedback list`); default: the first.")
         .option("--json", JSON_OPTION_DESCRIPTION)
         .action(async (options, command) => {
-        const result = await renderIssueMarkdown(options.cwd, options.run, options.repo);
+        const result = await renderIssueMarkdown(options.cwd, options.run, options.repo, candidateOption(options));
         if (wantsJson(command)) {
             io.writeOut(`${JSON.stringify(result, null, 2)}\n`);
         }
@@ -1793,9 +1797,10 @@ function registerFeedbackCommands(parent, io) {
         .option("--run <id>", "Run id or latest pointer.", "latest")
         .option("--cwd <path>", "Target project directory.", ".")
         .requiredOption("--repo <owner/repo>", "Repository slug used in the generated URL.")
+        .option("--candidate <id>", "Which finding to link (ids from `feedback list`); default: the first.")
         .option("--json", JSON_OPTION_DESCRIPTION)
         .action(async (options, command) => {
-        const result = await renderIssueUrl(options.cwd, options.run, options.repo);
+        const result = await renderIssueUrl(options.cwd, options.run, options.repo, candidateOption(options));
         if (wantsJson(command)) {
             io.writeOut(`${JSON.stringify(result, null, 2)}\n`);
         }
@@ -3438,15 +3443,28 @@ function exitCodeForSignal(signal) {
             return 129;
     }
 }
+/** `--candidate` as the module option, absent when not given (exactOptionalPropertyTypes). */
+function candidateOption(options) {
+    return options.candidate === undefined ? {} : { candidate: options.candidate };
+}
 function formatFeedbackHuman(result) {
     if (!result.ok) {
         return `${result.error?.code}: ${result.error?.message}\n`;
     }
+    const candidates = result.candidates ?? [];
     return [
         "humanish feedback ready",
         `run: ${result.run}`,
         ...(result.draftPath ? [`draft: ${result.draftPath}`] : []),
-        ...(result.issuePath ? [`issue: ${result.issuePath}`] : [])
+        ...(result.issuePath ? [`issue: ${result.issuePath}`] : []),
+        ...(result.draft?.source_candidate_id ? [`candidate: ${result.draft.source_candidate_id}`] : []),
+        // Every finding the run produced, so the second and third are one flag away (#609).
+        ...(candidates.length > 1 || (candidates.length === 1 && result.draft === undefined)
+            ? [
+                `candidates (${candidates.length}; choose one with --candidate <id>):`,
+                ...candidates.map((item) => `- ${item.id} [${item.failure_owner}] ${item.persona_id}: ${item.summary}`)
+            ]
+            : [])
     ].join("\n") + "\n";
 }
 function formatOssLabHuman(result) {