hubot 11.1.5 → 11.1.7

package/README.md

@@ -47,4 +47,6 @@ See the [LICENSE](LICENSE.md) file for license rights and limitations (MIT).
 
 [Hubot by Hubotics](https://www.theoldrobots.com/hubot.html)
 
-[Automating Inefficiencies](https://zachholman.com/2011/01/automating-inefficiencies/)
+[Automating Inefficiencies](https://zachholman.com/2011/01/automating-inefficiencies/)
+
+[Getting Started with Hubot](https://www.youtube.com/watch?v=A7fh6RIzGrw)

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "hubot",
-  "version": "11.1.5",
+  "version": "11.1.7",
   "author": "hubot",
   "keywords": [
     "github",

package/src/GenHubot.mjs

@@ -49,7 +49,7 @@ function runCommands (hubotDirectory, options) {
 //   This is a test script.
 //
 
-export default (robot) => {
+export default async (robot) => {
   robot.respond(/helo$/, async res => {
     await res.reply("HELO World! I'm Dumbotheelephant.")
   })
@@ -92,7 +92,7 @@ export default (robot) => {
       this.robot.emit('play', envelope, ...strings)
     }
   
-    run () {
+    async run () {
       // This is required to get the scripts loaded
       this.emit('connected')
     }
@@ -108,7 +108,7 @@ export default (robot) => {
     }
   }
   export default {
-    use (robot) {
+    async use (robot) {
       return new DummyAdapter(robot)
     }
   }
@@ -128,12 +128,14 @@ export default (robot) => {
   describe('Xample testing Hubot scripts', () => {
     let robot = null
     beforeEach(async () => {
+      process.env.EXPRESS_PORT = 0
       robot = new Robot(dummyRobot, true, 'Dumbotheelephant')
       await robot.loadAdapter()
       await robot.run()
       await robot.loadFile('./scripts', 'Xample.mjs')
     })
     afterEach(() => {
+      delete process.env.EXPRESS_PORT
       robot.shutdown()
     })
     it('should handle /helo request', async () => {

package/src/Robot.mjs

@@ -332,21 +332,25 @@ class Robot {
   async loadmjs (filePath) {
     const forImport = this.prepareForImport(filePath)
     const script = await import(forImport)
+    let result = null
     if (typeof script?.default === 'function') {
-      script.default(this)
+      result = await script.default(this)
     } else {
       this.logger.warning(`Expected ${filePath} (after preparing for import ${forImport}) to assign a function to export default, got ${typeof script}`)
     }
+    return result
   }
 
   async loadjs (filePath) {
     const forImport = this.prepareForImport(filePath)
     const script = (await import(forImport)).default
+    let result = null
     if (typeof script === 'function') {
-      script(this)
+      result = await script(this)
     } else {
       this.logger.warning(`Expected ${filePath} (after preparing for import ${forImport}) to assign a function to module.exports, got ${typeof script}`)
     }
+    return result
   }
 
   // Public: Loads a file in path.
@@ -362,16 +366,17 @@ class Robot {
     // see https://github.com/hubotio/hubot/issues/1355
     if (['js', 'mjs'].indexOf(ext) === -1) {
       this.logger.debug(`Skipping unsupported file type ${full}`)
-      return
+      return null
     }
-
+    let result = null
     try {
-      await this[`load${ext}`](full)
+      result = await this[`load${ext}`](full)
       this.parseHelp(full)
     } catch (error) {
       this.logger.error(`Unable to load ${full}: ${error.stack}`)
       throw error
     }
+    return result
   }
 
   // Public: Loads every script in the given path.
@@ -381,12 +386,14 @@ class Robot {
   // Returns nothing.
   async load (path) {
     this.logger.debug(`Loading scripts from ${path}`)
+    const results = []
     try {
       const folder = await File.readdir(path, { withFileTypes: true })
       for await (const file of folder) {
         if (file.isDirectory()) continue
         try {
-          await this.loadFile(path, file.name)
+          const result = await this.loadFile(path, file.name)
+          results.push(result)
         } catch (e) {
           this.logger.error(`Error loading file ${file.name} - ${e.stack}`)
         }
@@ -394,6 +401,7 @@ class Robot {
     } catch (e) {
       this.logger.error(`Path ${path} does not exist`)
     }
+    return results
   }
 
   // Public: Load scripts from packages specified in the
@@ -460,7 +468,7 @@ class Robot {
     if (stat) {
       app.use(express.static(stat))
     }
-    const p = new Promise((resolve, reject) => {
+    return new Promise((resolve, reject) => {
       try {
         this.server = app.listen(port, address, () => {
           this.router = app
@@ -471,7 +479,6 @@ class Robot {
         reject(err)
       }
     })
-    return p
   }
 
   // Setup an empty router object

package/src/adapters/Shell.mjs

@@ -75,20 +75,15 @@ class Shell extends Adapter {
           this.#rl.prompt()
           break
       }
+      if (input.length > 0) {
+        fs.appendFileSync(historyPath, `${input}\n`)
+      }
       const history = fs.readFileSync(historyPath, 'utf-8').split('\n').reverse()
       this.#rl.history = history
-      this.#rl.on('line', line => {
-        const input = line.trim()
-        if (input.length === 0) return
-        fs.appendFile(historyPath, `${input}\n`, err => {
-          if (err) console.error(err)
-        })
-      })
       let userId = process.env.HUBOT_SHELL_USER_ID || '1'
       if (userId.match(/A\d+z/)) {
         userId = parseInt(userId)
       }
-
       const userName = process.env.HUBOT_SHELL_USER_NAME || 'Shell'
       const user = this.robot.brain.userForId(userId, { name: userName, room: 'Shell' })
       await this.receive(new TextMessage(user, input, 'messageId'))