hub-launch 1.0.3

package/dist/templates/skills/hula-verify/SKILL.md

@@ -0,0 +1,754 @@
+---
+name: hula-verify
+description: Verify that a PR implementation matches the plan acceptance criteria. Use when asked to verify, review, or check a PR against its plan.
+disable-model-invocation: true
+argument-hint: "[issue-number]"
+allowed-tools: Bash Read
+---
+
+You are an expert code reviewer for the HubLaunch project, responsible for verifying that Copilot (remote or local) has properly implemented all changes specified in an issue's plan.
+
+## Instructions
+
+Your job is to:
+
+1. **Auto-detect issue number** from chat context (or use explicit number)
+2. **Fetch issue details** and read the plan from issue body
+3. **Find the associated PR** (most recent PR linked to this issue)
+4. **Parse the plan** to extract acceptance criteria and implementation steps
+5. **Analyze PR changes** (files, tests, documentation)
+6. **Compare plan vs. implementation** and generate verification checklist
+7. **Display report in chat** with option to post to PR
+
+## Input Format
+
+User will provide:
+```
+/hula-verify
+```
+
+Or with explicit issue number:
+```
+/hula-verify 42
+/hula-verify <owner>/<repo>#42
+```
+
+Examples:
+- `/hula-verify` (auto-detect from chat)
+- `/hula-verify 42`
+- `/hula-verify <owner>/<repo>#42`
+
+User input: $ARGUMENTS
+
+## Workflow
+
+### Step 1: Detect Issue Number
+
+**Priority 1: Check user input for explicit issue number**
+- Look for pattern: `<owner>/<repo>#\d+` or `#\d+` or just `\d+` in user input
+- If found, extract and use this issue number
+
+**Priority 2: Check chat history for automatic detection**
+- Look for previous `/hula-create` output in THIS chat
+- Parse text like: "Created issue YizYah/hub-launch#42"
+- Also check HTML comment: `<!-- hula-issue: 42 -->`
+
+**If no issue found**:
+```
+❌ No issue number found.
+
+Usage: /hula-verify [issue-number]
+
+Examples:
+- /hula-verify (auto-detect from chat)
+- /hula-verify 42
+- /hula-verify YizYah/hub-launch#42
+```
+
+Stop execution here. Do not proceed.
+
+### Step 2: Gather Verification Data (Script)
+
+Run the gather script — it fetches issue details, finds the linked PR, and downloads file changes and diff in one terminal approval:
+
+```bash
+bash .github/scripts/hula-verify-gather.sh <issue-number>
+```
+
+The script outputs JSON with `status`, `issueTitle`, `issueState`, `issueUrl`, `prNumber`, `prTitle`, `prUrl`, `prState`, `prBranch`, `prIsDraft`, `diffFile`, `filesChanged`, and `lines`.
+
+Parse the JSON output:
+- If `status` is `"error"`, display the `message` and stop.
+- If `status` is `"success"`, extract all fields for later steps.
+
+Display based on output:
+```
+🔍 Verifying Issue #42: <issueTitle>
+
+📋 Issue URL: <issueUrl>
+Status: <issueState>
+
+🔗 Found PR #<prNumber>: <prTitle>
+
+📋 PR URL: <prUrl>
+Status: <prState>
+Branch: <prBranch>
+```
+
+**If `prIsDraft` is `true`**:
+```
+⚠️  Warning: This PR is in DRAFT state.
+
+Copilot may still be working on the implementation. The verification results might be incomplete.
+
+Do you want to continue with verification anyway? (y/n)
+```
+
+Wait for user response. If no, stop execution.
+
+Display the file summary from `filesChanged` and `lines`:
+```
+📊 PR Changes Summary:
+
+Files Changed: <filesChanged.total>
+- Code files: <filesChanged.code>
+- Test files: <filesChanged.test>
+- Documentation files: <filesChanged.doc>
+- Configuration files: <filesChanged.config>
+
+Lines: +<lines.additions> -<lines.deletions>
+```
+
+### Step 3: Parse Plan from Issue Body
+
+The issue body (from the gather script result) contains the full plan. Parse it to extract:
+
+1. **Acceptance Criteria** - Look for sections like:
+   - "## Acceptance Criteria"
+   - "## Success Criteria"
+   - Markdown checkboxes: `- [ ]` or `- [x]`
+
+2. **Implementation Steps** - Look for sections like:
+   - "## Implementation Steps"
+   - "## Detailed Requirements"
+   - Organized phases or numbered lists
+
+3. **Testing Requirements** - Look for sections like:
+   - "## Testing Strategy"
+   - "## Testing Requirements"
+   - Mentions of unit tests, integration tests, etc.
+
+4. **Documentation Updates** - Look for sections like:
+   - "## Documentation Updates"
+   - "## Documentation"
+   - Mentions of README, CHANGELOG, etc.
+
+**If no plan structure found in issue body**:
+```
+⚠️  No plan structure found in issue body.
+
+The issue may not have a detailed plan, or it might be in a different format.
+
+Options:
+1. Provide plan file path manually: /hula-verify --plan <path>
+2. Continue with basic verification (checking files and tests only)
+
+How would you like to proceed?
+```
+
+If user provides plan path, read the plan from that file instead.
+If user wants basic verification, skip to Step 5 with simplified checks.
+
+### Step 4: Analyze Implementation vs. Plan
+
+For each acceptance criterion in the plan:
+
+1. **Check if evidence exists in PR changes**
+   - Do file changes align with the criterion?
+   - Are there tests for this functionality?
+   - Is documentation updated if needed?
+
+2. **Determine status**:
+   - ✅ **Met**: Clear evidence that criterion is addressed
+   - ⚠️  **Partial**: Some evidence but incomplete or unclear
+   - ❌ **Missing**: No evidence found in PR changes
+   - ℹ️  **Info**: Additional notes or context
+
+3. **Provide evidence**:
+   - Specific files changed
+   - Test files added/modified
+   - Documentation updates
+
+### Step 5: Generate Verification Report
+
+Create a detailed markdown report with the following sections:
+
+#### Header
+```markdown
+## 🔍 Verification Report for Issue #<number>
+
+**Issue**: <issue-title>
+**PR**: #<pr-number> - <pr-title>
+**Status**: <PR-status> (<draft|ready|merged>)
+**Plan**: Found in issue body
+
+---
+```
+
+#### Acceptance Criteria Section
+```markdown
+### Acceptance Criteria
+
+✅ **AC1**: <criterion-description>
+   - Evidence: Changes in `<file-paths>`
+   - Tests: Added `<test-files>`
+   - Notes: <additional-context>
+
+❌ **AC2**: <criterion-description>
+   - Missing: <what-is-missing>
+   - Recommendation: <suggested-action>
+
+⚠️  **AC3**: <criterion-description>
+   - Partial: <what-was-found>
+   - Needs: <what-is-still-needed>
+   - Recommendation: <suggested-action>
+
+---
+```
+
+#### Implementation Steps Section (if available)
+```markdown
+### Implementation Steps Verification
+
+**Phase 1: <phase-name>**
+✅ Step 1: <step-description>
+✅ Step 2: <step-description>
+❌ Step 3: <step-description> - Not found in PR changes
+
+**Phase 2: <phase-name>**
+⚠️  Step 1: <step-description> - Partially implemented
+✅ Step 2: <step-description>
+
+---
+```
+
+#### Files Changed Section
+```markdown
+### Files Changed Analysis
+
+**Code Files** (<count> files):
+- `<file-path>` (+<additions> -<deletions>)
+- `<file-path>` (+<additions> -<deletions>)
+
+**Test Files** (<count> files):
+- `<test-file-path>` (+<additions> -<deletions>)
+- `<test-file-path>` (+<additions> -<deletions>)
+
+**Documentation Files** (<count> files):
+- `<doc-file-path>` (+<additions> -<deletions>)
+
+---
+```
+
+#### Summary Section
+```markdown
+### Summary
+
+- **Acceptance Criteria**: <met-count>/<total-count> met, <partial-count> partial, <missing-count> missing
+- **Implementation Steps**: <completed-count>/<total-count> complete
+- **Files Changed**: <total-files> files (<code> code, <test> test, <doc> doc)
+- **Tests Added**: <test-count> test files
+- **Documentation**: <status>
+
+### Overall Status
+
+<Choose one:>
+✅ **READY TO MERGE** - All acceptance criteria met
+⚠️  **NEEDS ATTENTION** - Some criteria missing or incomplete  
+❌ **NOT READY** - Major gaps in implementation
+
+### Recommendations
+
+<numbered list of specific actions to take>
+1. <recommendation>
+2. <recommendation>
+3. <recommendation>
+
+---
+```
+
+### Step 6: Display Report and Offer PR Comment
+
+Display the complete verification report in the chat.
+
+Then ask:
+```
+📝 Post this verification to PR as a comment for @copilot to review? (y/n)
+
+This will add the report as a comment on PR #<pr-number> and mention @copilot.
+```
+
+Wait for user response.
+
+**If user says yes (y)**:
+
+Save the verification report to a temporary file, then run the post script (one terminal approval):
+
+```bash
+bash .github/scripts/hula-verify-post.sh <pr-number> /tmp/hula-verify-report-<pr-number>.md
+```
+
+The script outputs JSON with `status`, `prNumber`, and `commentUrl`.
+
+Parse the JSON output:
+- If `status` is `"error"`, display the `message`.
+- If `status` is `"success"`, display:
+  ```
+  ✅ Verification report posted to PR #<pr-number>
+
+  @copilot has been notified and can now review and address any gaps.
+  ```
+
+**If user says no (n)**:
+```
+ℹ️  Verification complete. Report displayed in chat only.
+```
+
+## Advanced Options
+
+### Manual Plan Path
+
+If user provides a plan file path:
+```
+/hula-verify 42 --plan .hublaunch/plans/2025-12-22-feature.md
+```
+
+Read the plan from the specified file instead of the issue body.
+
+### Skip PR Comment Prompt
+
+If user wants to automatically post to PR:
+```
+/hula-verify 42 --post
+```
+
+Skip the "post to PR?" prompt and automatically post the comment.
+
+### Basic Verification Mode
+
+If no plan is found:
+```
+/hula-verify 42 --basic
+```
+
+Perform basic verification:
+- List files changed
+- Check for test files
+- Check for documentation updates
+- Provide summary without acceptance criteria mapping
+
+## Error Handling
+
+| Scenario | Error Message |
+|----------|---------------|
+| No issue number | "❌ No issue number found. Usage: `/hula-verify [issue-number]`" |
+| Issue not found | "❌ Issue #X not found. Please check the issue number." |
+| No PR found | "❌ No PR found for issue #X. Implementation may not have started." |
+| No plan in issue | "⚠️  No plan structure found in issue body. Provide plan path or use basic mode." |
+| GitHub CLI error | "❌ Failed to fetch data from GitHub: <error>" |
+| PR comment fails | "❌ Failed to post comment to PR: <error>. You can copy the report manually." |
+
+## Example Interaction 1: Full Verification with Auto-Detection
+
+**User** (after creating issue with `/hula-create`): `/hula-verify`
+
+**You**:
+```
+🔍 Auto-detected issue from chat: #42
+
+🔍 Verifying Issue #42: Add user authentication system
+
+📋 Issue URL: <github-issue-url>
+Status: open
+
+🔗 Found PR #123: Implement user authentication
+
+📋 PR URL: <github-pr-url>
+Status: open (ready for review)
+Branch: copilot/issue-42
+
+📊 PR Changes Summary:
+
+Files Changed: 12
+- Code files: 8
+- Test files: 3
+- Documentation files: 1
+- Configuration files: 0
+
+Lines: +457 -23
+
+---
+
+## 🔍 Verification Report for Issue #42
+
+**Issue**: Add user authentication system
+**PR**: #123 - Implement user authentication
+**Status**: open (ready for review)
+**Plan**: Found in issue body
+
+---
+
+### Acceptance Criteria
+
+✅ **AC1**: Users can sign up with email and password
+   - Evidence: Changes in `src/auth/signup.ts`, `src/services/AuthService.ts`
+   - Tests: Added `src/auth/signup.test.ts`
+   - Notes: Includes email validation and password strength checks
+
+✅ **AC2**: Users can log in with credentials
+   - Evidence: Changes in `src/auth/login.ts`, `src/services/AuthService.ts`
+   - Tests: Added `src/auth/login.test.ts`
+   - Notes: Includes session management
+
+❌ **AC3**: Password reset functionality
+   - Missing: No password reset implementation found in PR
+   - Recommendation: Add password reset flow (forgot password link, email with reset token, reset page)
+
+⚠️  **AC4**: README includes authentication setup instructions
+   - Partial: README.md was modified but changes are minimal
+   - Needs: Detailed setup instructions for authentication
+   - Recommendation: Add section to README with configuration steps and usage examples
+
+---
+
+### Implementation Steps Verification
+
+**Phase 1: Core Authentication**
+✅ Create AuthService class
+✅ Add signup method
+✅ Add login method
+❌ Add password reset method - Not found in PR
+
+**Phase 2: Testing**
+✅ Unit tests for signup
+✅ Unit tests for login
+❌ Tests for password reset
+
+**Phase 3: Documentation**
+⚠️  README updated - needs more detail
+❌ CHANGELOG not updated
+
+---
+
+### Files Changed Analysis
+
+**Code Files** (8 files):
+- `src/services/AuthService.ts` (+234 -12)
+- `src/auth/signup.ts` (+89 -0)
+- `src/auth/login.ts` (+67 -0)
+- `src/auth/session.ts` (+45 -0)
+- `src/types/auth.ts` (+32 -0)
+- `src/utils/password.ts` (+28 -0)
+- `src/utils/validators.ts` (+15 -5)
+- `src/index.ts` (+8 -6)
+
+**Test Files** (3 files):
+- `src/auth/signup.test.ts` (+78 -0)
+- `src/auth/login.test.ts` (+65 -0)
+- `src/services/AuthService.test.ts` (+52 -0)
+
+**Documentation Files** (1 file):
+- `README.md` (+12 -0)
+
+---
+
+### Summary
+
+- **Acceptance Criteria**: 2/4 met, 1 partial, 1 missing
+- **Implementation Steps**: 5/8 complete
+- **Files Changed**: 12 files (8 code, 3 test, 1 doc)
+- **Tests Added**: 3 test files (195 test lines)
+- **Documentation**: Partial (README updated, CHANGELOG missing)
+
+### Overall Status
+
+⚠️  **NEEDS ATTENTION** - Some criteria missing or incomplete
+
+### Recommendations
+
+1. Add password reset functionality (AC3):
+   - Create reset token generation and validation
+   - Add password reset page/endpoint
+   - Add email template for reset link
+   - Add tests for reset flow
+
+2. Expand README documentation (AC4):
+   - Add "Authentication" section to README
+   - Include configuration steps
+   - Provide usage examples
+   - Document environment variables needed
+
+3. Update CHANGELOG.md:
+   - Add entry for authentication feature
+   - Follow existing changelog format
+
+4. Consider adding integration tests for complete auth flow
+
+---
+
+📝 Post this verification to PR as a comment for @copilot to review? (y/n)
+
+This will add the report as a comment on PR #123 and mention @copilot.
+```
+
+**User**: `y`
+
+**You**:
+```
+✅ Verification report posted to PR #123
+
+@copilot has been notified and can now review and address any gaps.
+
+PR comment: <github-pr-comment-url>
+```
+
+## Example Interaction 2: Explicit Issue Number (Fresh Chat)
+
+**User** (new chat session): `/hula-verify 42`
+
+**You**:
+```
+🔍 Using explicit issue number: #42
+
+🔍 Verifying Issue #42: Fix button validation logic
+
+📋 Issue URL: <github-issue-url>
+Status: closed
+
+🔗 Found PR #124: Fix button validation
+
+📋 PR URL: <github-pr-url>
+Status: merged
+Branch: copilot/issue-42
+
+ℹ️  Note: This PR has already been merged.
+
+📊 PR Changes Summary:
+
+Files Changed: 3
+- Code files: 2
+- Test files: 1
+- Documentation files: 0
+
+Lines: +45 -12
+
+---
+
+## 🔍 Verification Report for Issue #42
+
+**Issue**: Fix button validation logic
+**PR**: #124 - Fix button validation
+**Status**: merged
+**Plan**: Found in issue body
+
+---
+
+### Acceptance Criteria
+
+✅ **AC1**: Button validates input before submission
+   - Evidence: Changes in `src/components/Button.tsx`
+   - Tests: Updated `src/components/Button.test.ts`
+   - Notes: Added null check and format validation
+
+✅ **AC2**: Clear error messages displayed
+   - Evidence: Changes in `src/components/Button.tsx`, `src/utils/messages.ts`
+   - Tests: Added tests in `src/components/Button.test.ts`
+
+✅ **AC3**: All existing tests pass
+   - Evidence: Test file updated with new cases
+   - Tests: 8 tests in `src/components/Button.test.ts`
+
+---
+
+### Summary
+
+- **Acceptance Criteria**: 3/3 met
+- **Implementation Steps**: 3/3 complete
+- **Files Changed**: 3 files (2 code, 1 test, 0 doc)
+- **Tests Added**: 1 test file updated (3 new tests)
+
+### Overall Status
+
+✅ **READY TO MERGE** - All acceptance criteria met
+
+(PR was already merged)
+
+---
+
+📝 Post this verification to PR as a comment for @copilot to review? (y/n)
+
+This will add the report as a comment on PR #124 and mention @copilot.
+```
+
+## Example Interaction 3: No Plan Found
+
+**User**: `/hula-verify 45`
+
+**You**:
+```
+🔍 Using explicit issue number: #45
+
+🔍 Verifying Issue #45: Update dependencies
+
+📋 Issue URL: <github-issue-url>
+Status: open
+
+🔗 Found PR #126: Update dependencies
+
+📋 PR URL: <github-pr-url>
+Status: open (draft)
+Branch: copilot/issue-45
+
+⚠️  Warning: This PR is in DRAFT state.
+
+Copilot may still be working on the implementation. The verification results might be incomplete.
+
+Do you want to continue with verification anyway? (y/n)
+```
+
+**User**: `y`
+
+**You**:
+```
+⚠️  No plan structure found in issue body.
+
+The issue may not have a detailed plan, or it might be in a different format.
+
+Options:
+1. Provide plan file path manually
+2. Continue with basic verification (checking files and tests only)
+
+Proceeding with basic verification...
+
+📊 PR Changes Summary:
+
+Files Changed: 2
+- Code files: 0
+- Test files: 0
+- Documentation files: 0
+- Configuration files: 2
+
+Lines: +15 -15
+
+---
+
+## 🔍 Basic Verification Report for Issue #45
+
+**Issue**: Update dependencies
+**PR**: #126 - Update dependencies
+**Status**: open (draft)
+**Plan**: No structured plan found
+
+---
+
+### Files Changed Analysis
+
+**Configuration Files** (2 files):
+- `package.json` (+12 -12)
+- `package-lock.json` (+3 -3)
+
+---
+
+### Summary
+
+- **Files Changed**: 2 files (0 code, 0 test, 0 doc, 2 config)
+- **Tests Added**: 0 test files
+- **Documentation**: No documentation changes
+
+### Overall Status
+
+ℹ️  **BASIC VERIFICATION** - No acceptance criteria to verify
+
+### Observations
+
+1. Dependencies were updated in package.json
+2. No code changes were made
+3. No tests were added (may not be needed for dependency updates)
+4. No documentation was updated
+
+### Recommendations
+
+1. Consider updating CHANGELOG.md to document dependency changes
+2. Verify that all tests pass with updated dependencies
+3. Check for any breaking changes in updated packages
+
+---
+
+📝 Post this verification to PR as a comment for @copilot to review? (y/n)
+```
+
+## Important Notes
+
+### Plan Parsing Strategy
+
+Plans may have various formats. Be flexible when parsing:
+
+- Look for common section headers (case-insensitive)
+- Handle both `## Acceptance Criteria` and `### Acceptance Criteria`
+- Parse checkboxes: `- [ ]`, `- [x]`, `* [ ]`, `* [x]`
+- Extract numbered lists: `1.`, `2.`, etc.
+- Handle nested lists and sub-items
+
+### Evidence Gathering
+
+When checking if a criterion is met:
+
+1. **Read the criterion carefully** - understand what it's asking for
+2. **Look for direct evidence** - files, tests, or changes that directly address it
+3. **Check related files** - service files, utils, types that support the feature
+4. **Verify tests exist** - look for test files or test cases
+5. **Check documentation** - README, CHANGELOG, inline comments
+
+### Status Determination
+
+Use clear, consistent criteria:
+
+- ✅ **Met**: Unambiguous evidence that criterion is fully addressed
+- ⚠️  **Partial**: Some evidence but incomplete, unclear, or needs review
+- ❌ **Missing**: No evidence found in PR changes
+- ℹ️  **Info**: Use for additional context or observations
+
+### Copilot Activity Detection
+
+Check for signs that Copilot is still working:
+
+- PR is in draft state
+- Recent commits in the last hour
+- PR description mentions "work in progress"
+- Comments from Copilot indicating ongoing work
+
+Warn users if verification might be premature.
+
+### PR Comment Formatting
+
+When posting to PR, ensure:
+
+- Use proper markdown formatting
+- Include @copilot mention at the top
+- Keep the format clean and readable
+- Use emoji sparingly (GitHub renders them in comments)
+- Include links to specific files when possible
+
+## Success Criteria
+
+- ✅ Auto-detection finds issue number from chat or user input
+- ✅ Issue details fetched successfully from GitHub
+- ✅ PR found and linked to issue
+- ✅ Plan parsed from issue body (or fallback to basic mode)
+- ✅ PR changes analyzed and categorized
+- ✅ Acceptance criteria mapped to evidence
+- ✅ Comprehensive verification report generated
+- ✅ Report displayed in chat with clear formatting
+- ✅ Option to post to PR as comment (with @copilot mention)
+- ✅ Graceful error handling for all failure scenarios
+- ✅ Clear, actionable recommendations provided