html-validate 8.19.0 → 8.19.1

package/dist/es/core.js

@@ -10035,7 +10035,10 @@ function hasAssociatedSubmit(document, form) {
 class H36 extends Rule {
   documentation() {
     return {
-      description: 'WCAG 2.1 requires all images used as submit buttons to have a textual description using the alt attribute. The alt text cannot be empty (`alt=""`).',
+      description: [
+        "WCAG 2.1 requires all images used as submit buttons to have a non-empty textual description using the `alt` attribute.",
+        'The alt text cannot be empty (`alt=""`).'
+      ].join("\n"),
       url: "https://html-validate.org/rules/wcag/h36.html"
     };
   }
@@ -10047,8 +10050,17 @@ class H36 extends Rule {
       if (node.getAttributeValue("type") !== "image") {
         return;
       }
+      if (!inAccessibilityTree(node)) {
+        return;
+      }
       if (!hasAltText(node)) {
-        this.report(node, "image used as submit button must have alt text");
+        const message = "image used as submit button must have non-empty alt text";
+        const alt = node.getAttribute("alt");
+        this.report({
+          node,
+          message,
+          location: alt ? alt.keyLocation : node.location
+        });
       }
     });
   }
@@ -10058,19 +10070,6 @@ const defaults$1 = {
   allowEmpty: true,
   alias: []
 };
-function needsAlt(node) {
-  if (node.is("img")) {
-    return true;
-  }
-  if (node.is("input") && node.getAttributeValue("type") === "image") {
-    return true;
-  }
-  return false;
-}
-function getTag(node) {
-  return node.is("input") ? `<input type="${/* istanbul ignore next */
-  node.getAttributeValue("type") ?? ""}">` : `<${node.tagName}>`;
-}
 class H37 extends Rule {
   constructor(options) {
     super({ ...defaults$1, ...options });
@@ -10107,16 +10106,13 @@ class H37 extends Rule {
   setup() {
     this.on("dom:ready", (event) => {
       const { document } = event;
-      const nodes = document.querySelectorAll("img, input");
+      const nodes = document.querySelectorAll("img");
       for (const node of nodes) {
         this.validateNode(node);
       }
     });
   }
   validateNode(node) {
-    if (!needsAlt(node)) {
-      return;
-    }
     if (!inAccessibilityTree(node)) {
       return;
     }
@@ -10128,11 +10124,12 @@ class H37 extends Rule {
         return;
       }
     }
+    const tag = node.annotatedName;
     if (node.hasAttribute("alt")) {
       const attr = node.getAttribute("alt");
-      this.report(node, `${getTag(node)} cannot have empty "alt" attribute`, attr == null ? void 0 : attr.keyLocation);
+      this.report(node, `${tag} cannot have empty "alt" attribute`, attr.keyLocation);
     } else {
-      this.report(node, `${getTag(node)} is missing required "alt" attribute`, node.location);
+      this.report(node, `${tag} is missing required "alt" attribute`, node.location);
     }
   }
 }
@@ -12719,7 +12716,7 @@ class HtmlValidate {
 }
 
 const name = "html-validate";
-const version = "8.19.0";
+const version = "8.19.1";
 const bugs = "https://gitlab.com/html-validate/html-validate/issues/new";
 
 function definePlugin(plugin) {