html-validate 8.18.2 → 8.19.1

package/dist/cjs/core.js

@@ -7,7 +7,7 @@ var utils_naturalJoin = require('./utils/natural-join.js');
 var fs = require('fs');
 var codeFrame = require('@babel/code-frame');
 var kleur = require('kleur');
-var stylish$2 = require('@html-validate/stylish');
+var stylish$1 = require('@html-validate/stylish');
 var semver = require('semver');
 
 function _interopDefault (e) { return e && e.__esModule ? e : { default: e }; }
@@ -6224,6 +6224,7 @@ class EmptyTitle extends Rule {
 
 const defaults$k = {
   allowArrayBrackets: true,
+  allowCheckboxDefault: true,
   shared: ["radio", "button", "reset", "submit"]
 };
 const UNIQUE_CACHE_KEY = Symbol("form-elements-unique");
@@ -6235,6 +6236,25 @@ function allowSharedName(node, shared) {
   const type = node.getAttribute("type");
   return Boolean(type == null ? void 0 : type.valueMatches(shared, false));
 }
+function isInputHidden(element) {
+  return element.is("input") && element.getAttributeValue("type") === "hidden";
+}
+function isInputCheckbox(element) {
+  return element.is("input") && element.getAttributeValue("type") === "checkbox";
+}
+function isCheckboxWithDefault(control, previous, options) {
+  const { allowCheckboxDefault } = options;
+  if (!allowCheckboxDefault) {
+    return false;
+  }
+  if (!previous.potentialHiddenDefault) {
+    return false;
+  }
+  if (!isInputCheckbox(control)) {
+    return false;
+  }
+  return true;
+}
 function getDocumentation(context) {
   const trailer = "Each form control must have a unique name.";
   const { name } = context;
@@ -6257,6 +6277,9 @@ class FormDupName extends Rule {
       allowArrayBrackets: {
         type: "boolean"
       },
+      allowCheckboxDefault: {
+        type: "boolean"
+      },
       shared: {
         type: "array",
         items: {
@@ -6322,14 +6345,20 @@ class FormDupName extends Rule {
       }
       if (!details && isarray) {
         elements.set(basename, {
-          array: true
+          array: true,
+          potentialHiddenDefault: false
         });
       }
       if (isarray) {
         return;
       }
     }
-    if (elements.has(name)) {
+    const previous = elements.get(name);
+    if (previous) {
+      if (isCheckboxWithDefault(control, previous, this.options)) {
+        previous.potentialHiddenDefault = false;
+        return;
+      }
       const context = {
         name,
         kind: "duplicate"
@@ -6342,7 +6371,8 @@ class FormDupName extends Rule {
       });
     } else {
       elements.set(name, {
-        array: false
+        array: false,
+        potentialHiddenDefault: isInputHidden(control)
       });
     }
   }
@@ -7196,20 +7226,23 @@ class MultipleLabeledControls extends Rule {
   }
   setup() {
     this.labelable = this.getTagsWithProperty("labelable").join(",");
-    this.on("element:ready", (event) => {
-      const { target } = event;
-      if (target.tagName !== "label") {
-        return;
-      }
-      const numControls = this.getNumLabledControls(target);
-      if (numControls <= 1) {
-        return;
+    this.on("dom:ready", (event) => {
+      const { document } = event;
+      const labels = document.querySelectorAll("label");
+      for (const label of labels) {
+        const numControls = this.getNumLabledControls(label);
+        if (numControls <= 1) {
+          continue;
+        }
+        this.report(label, "<label> is associated with multiple controls", label.location);
       }
-      this.report(target, "<label> is associated with multiple controls", target.location);
     });
   }
   getNumLabledControls(src) {
-    const controls = src.querySelectorAll(this.labelable).map((node) => node.id);
+    const controls = src.querySelectorAll(this.labelable).filter((node) => {
+      var _a;
+      return (_a = node.meta) == null ? void 0 : _a.labelable;
+    }).map((node) => node.id);
     const attr = src.getAttribute("for");
     if (!attr || attr.isDynamic || !attr.value) {
       return controls.length;
@@ -9753,7 +9786,7 @@ class ValidID extends Rule {
     const message = this.messages[context].replace("id", "ID").replace(/^(.)/, (m) => m.toUpperCase());
     const relaxedDescription = relaxed ? [] : [
       "  - ID must begin with a letter",
-      "  - ID must only contain alphanumerical characters, `-` and `_`"
+      "  - ID must only contain letters, digits, `-` and `_`"
     ];
     return {
       description: [
@@ -9788,12 +9821,12 @@ class ValidID extends Rule {
       if (relaxed) {
         return;
       }
-      if (value.match(/^[^a-zA-Z]/)) {
+      if (value.match(/^[^\p{L}]/u)) {
         const context = 3 /* LEADING_CHARACTER */;
         this.report(event.target, this.messages[context], event.valueLocation, context);
         return;
       }
-      if (value.match(/[^a-zA-Z0-9-_]/)) {
+      if (value.match(/[^\p{L}\p{N}_-]/u)) {
         const context = 4 /* DISALLOWED_CHARACTER */;
         this.report(event.target, this.messages[context], event.valueLocation, context);
       }
@@ -9804,7 +9837,7 @@ class ValidID extends Rule {
       [1 /* EMPTY */]: "element id must not be empty",
       [2 /* WHITESPACE */]: "element id must not contain whitespace",
       [3 /* LEADING_CHARACTER */]: "element id must begin with a letter",
-      [4 /* DISALLOWED_CHARACTER */]: "element id must only contain alphanumerical, dash and underscore characters"
+      [4 /* DISALLOWED_CHARACTER */]: "element id must only contain letters, digits, dash and underscore characters"
     };
   }
   isRelevant(event) {
@@ -9931,7 +9964,7 @@ function styleDescription(style) {
 class H30 extends Rule {
   documentation() {
     return {
-      description: "WCAG 2.1 requires each `<a>` anchor link to have a text describing the purpose of the link using either plain text or an `<img>` with the `alt` attribute set.",
+      description: "WCAG 2.1 requires each `<a href>` anchor link to have a text describing the purpose of the link using either plain text or an `<img>` with the `alt` attribute set.",
       url: "https://html-validate.org/rules/wcag/h30.html"
     };
   }
@@ -9939,6 +9972,9 @@ class H30 extends Rule {
     this.on("dom:ready", (event) => {
       const links = event.document.getElementsByTagName("a");
       for (const link of links) {
+        if (!link.hasAttribute("href")) {
+          continue;
+        }
         if (!inAccessibilityTree(link)) {
           continue;
         }
@@ -10009,7 +10045,10 @@ function hasAssociatedSubmit(document, form) {
 class H36 extends Rule {
   documentation() {
     return {
-      description: 'WCAG 2.1 requires all images used as submit buttons to have a textual description using the alt attribute. The alt text cannot be empty (`alt=""`).',
+      description: [
+        "WCAG 2.1 requires all images used as submit buttons to have a non-empty textual description using the `alt` attribute.",
+        'The alt text cannot be empty (`alt=""`).'
+      ].join("\n"),
       url: "https://html-validate.org/rules/wcag/h36.html"
     };
   }
@@ -10021,8 +10060,17 @@ class H36 extends Rule {
       if (node.getAttributeValue("type") !== "image") {
         return;
       }
+      if (!inAccessibilityTree(node)) {
+        return;
+      }
       if (!hasAltText(node)) {
-        this.report(node, "image used as submit button must have alt text");
+        const message = "image used as submit button must have non-empty alt text";
+        const alt = node.getAttribute("alt");
+        this.report({
+          node,
+          message,
+          location: alt ? alt.keyLocation : node.location
+        });
       }
     });
   }
@@ -10032,19 +10080,6 @@ const defaults$1 = {
   allowEmpty: true,
   alias: []
 };
-function needsAlt(node) {
-  if (node.is("img")) {
-    return true;
-  }
-  if (node.is("input") && node.getAttributeValue("type") === "image") {
-    return true;
-  }
-  return false;
-}
-function getTag(node) {
-  return node.is("input") ? `<input type="${/* istanbul ignore next */
-  node.getAttributeValue("type") ?? ""}">` : `<${node.tagName}>`;
-}
 class H37 extends Rule {
   constructor(options) {
     super({ ...defaults$1, ...options });
@@ -10081,16 +10116,13 @@ class H37 extends Rule {
   setup() {
     this.on("dom:ready", (event) => {
       const { document } = event;
-      const nodes = document.querySelectorAll("img, input");
+      const nodes = document.querySelectorAll("img");
       for (const node of nodes) {
         this.validateNode(node);
       }
     });
   }
   validateNode(node) {
-    if (!needsAlt(node)) {
-      return;
-    }
     if (!inAccessibilityTree(node)) {
       return;
     }
@@ -10102,11 +10134,12 @@ class H37 extends Rule {
         return;
       }
     }
+    const tag = node.annotatedName;
     if (node.hasAttribute("alt")) {
       const attr = node.getAttribute("alt");
-      this.report(node, `${getTag(node)} cannot have empty "alt" attribute`, attr == null ? void 0 : attr.keyLocation);
+      this.report(node, `${tag} cannot have empty "alt" attribute`, attr.keyLocation);
     } else {
-      this.report(node, `${getTag(node)} is missing required "alt" attribute`, node.location);
+      this.report(node, `${tag} is missing required "alt" attribute`, node.location);
     }
   }
 }
@@ -10207,7 +10240,6 @@ const bundledRules$1 = {
   "wcag/h67": H67,
   "wcag/h71": H71
 };
-var WCAG = bundledRules$1;
 
 const bundledRules = {
   "allowed-links": AllowedLinks,
@@ -10293,7 +10325,7 @@ const bundledRules = {
   "valid-id": ValidID,
   "void-content": VoidContent,
   "void-style": VoidStyle,
-  ...WCAG
+  ...bundledRules$1
 };
 
 var defaultConfig = {};
@@ -10330,7 +10362,6 @@ const config$4 = {
     "wcag/h71": "error"
   }
 };
-var a11y = config$4;
 
 const config$3 = {
   rules: {
@@ -10341,7 +10372,6 @@ const config$3 = {
     "require-sri": "error"
   }
 };
-var document = config$3;
 
 const config$2 = {
   rules: {
@@ -10350,7 +10380,6 @@ const config$2 = {
     "void-style": "off"
   }
 };
-var prettier = config$2;
 
 const config$1 = {
   rules: {
@@ -10434,7 +10463,6 @@ const config$1 = {
     "wcag/h71": "error"
   }
 };
-var recommended = config$1;
 
 const config = {
   rules: {
@@ -10473,18 +10501,17 @@ const config = {
     "void-content": "error"
   }
 };
-var standard = config;
 
 const presets = {
-  "html-validate:a11y": a11y,
-  "html-validate:document": document,
-  "html-validate:prettier": prettier,
-  "html-validate:recommended": recommended,
-  "html-validate:standard": standard,
+  "html-validate:a11y": config$4,
+  "html-validate:document": config$3,
+  "html-validate:prettier": config$2,
+  "html-validate:recommended": config$1,
+  "html-validate:standard": config,
   /* @deprecated aliases */
-  "htmlvalidate:recommended": recommended,
-  "htmlvalidate:document": document,
-  "html-validate:a17y": a11y
+  "htmlvalidate:recommended": config$1,
+  "htmlvalidate:document": config$3,
+  "html-validate:a17y": config$4
 };
 var Presets = presets;
 
@@ -12699,7 +12726,7 @@ class HtmlValidate {
 }
 
 const name = "html-validate";
-const version = "8.18.2";
+const version = "8.19.1";
 const bugs = "https://gitlab.com/html-validate/html-validate/issues/new";
 
 function definePlugin(plugin) {
@@ -13385,7 +13412,6 @@ function checkstyleFormatter(results) {
   return output;
 }
 const formatter$3 = checkstyleFormatter;
-var checkstyle = formatter$3;
 
 const defaults = {
   showLink: true,
@@ -13491,7 +13517,6 @@ function jsonFormatter(results) {
   return JSON.stringify(results);
 }
 const formatter$2 = jsonFormatter;
-var json = formatter$2;
 
 function linkSummary(results) {
   const urls = results.reduce((result, it) => {
@@ -13510,7 +13535,7 @@ ${lines.join("")}
 `;
 }
 function stylish(results) {
-  const errors = stylish$2.stylish(
+  const errors = stylish$1.stylish(
     results.map((it) => ({
       ...it,
       fixableErrorCount: 0,
@@ -13521,7 +13546,6 @@ function stylish(results) {
   return `${errors}${links}`;
 }
 const formatter$1 = stylish;
-var stylish$1 = formatter$1;
 
 function textFormatter(results) {
   let output = "";
@@ -13549,14 +13573,13 @@ function textFormatter(results) {
   return total > 0 ? output : "";
 }
 const formatter = textFormatter;
-var text = formatter;
 
 const availableFormatters = {
-  checkstyle,
+  checkstyle: formatter$3,
   codeframe,
-  json,
-  stylish: stylish$1,
-  text
+  json: formatter$2,
+  stylish: formatter$1,
+  text: formatter
 };
 function getFormatter(name) {
   return availableFormatters[name] ?? null;