html-validate 10.5.0 → 10.6.0

package/dist/cjs/core.js

@@ -1216,7 +1216,9 @@ class MetaTable {
         );
       }
       for (const [key, value] of Object.entries(obj)) {
-        if (key === "$schema") continue;
+        if (key === "$schema") {
+          continue;
+        }
         this.addEntry(key, migrateElement(value));
       }
     } catch (err) {
@@ -1316,7 +1318,9 @@ class MetaTable {
    * global, e.g. to assign global attributes.
    */
   resolveGlobal() {
-    if (!this.elements["*"]) return;
+    if (!this.elements["*"]) {
+      return;
+    }
     const global = this.elements["*"];
     delete this.elements["*"];
     delete global.tagName;
@@ -1490,7 +1494,9 @@ function sliceSize(size, begin, end) {
   return Math.min(size, end - begin);
 }
 function sliceLocation(location, begin, end, wrap) {
-  if (!location) return null;
+  if (!location) {
+    return null;
+  }
   const size = sliceSize(location.size, begin, end);
   const sliced = {
     filename: location.filename,
@@ -2369,7 +2375,7 @@ class Selector {
 
 const TEXT_NODE_NAME = "#text";
 function isTextNode(node) {
-  return Boolean(node && node.nodeType === NodeType.TEXT_NODE);
+  return node?.nodeType === NodeType.TEXT_NODE;
 }
 class TextNode extends DOMNode {
   text;
@@ -2413,7 +2419,7 @@ var NodeClosed = /* @__PURE__ */ ((NodeClosed2) => {
   return NodeClosed2;
 })(NodeClosed || {});
 function isElementNode(node) {
-  return Boolean(node && node.nodeType === NodeType.ELEMENT_NODE);
+  return node?.nodeType === NodeType.ELEMENT_NODE;
 }
 function isInvalidTagName(tagName) {
   return tagName === "" || tagName === "*";
@@ -3709,6 +3715,7 @@ function interpolate(text, data) {
 
 const ajv$1 = new Ajv__default.default({ strict: true, strictTuples: true, strictTypes: true });
 ajv$1.addMetaSchema(ajvSchemaDraft);
+ajv$1.addKeyword(ajvRegexpKeyword);
 function getSchemaValidator(ruleId, properties) {
   const $id = `rule/${ruleId}`;
   const cached = ajv$1.getSchema($id);
@@ -3965,6 +3972,7 @@ class Rule {
    *
    * @internal
    */
+  /* eslint-disable-next-line @typescript-eslint/max-params -- technical debt */
   static validateOptions(cls, ruleId, jsonPath, options, filename, config) {
     if (!cls) {
       return;
@@ -5189,7 +5197,9 @@ class AttributeAllowedValues extends Rule {
       const doc = event.document;
       walk.depthFirst(doc, (node) => {
         const meta = node.meta;
-        if (!meta?.attributes) return;
+        if (!meta?.attributes) {
+          return;
+        }
         for (const attr of node.attributes) {
           if (Validator.validateAttribute(attr, meta.attributes)) {
             continue;
@@ -5249,9 +5259,13 @@ class AttributeBooleanStyle extends Rule {
       const doc = event.document;
       walk.depthFirst(doc, (node) => {
         const meta = node.meta;
-        if (!meta?.attributes) return;
+        if (!meta?.attributes) {
+          return;
+        }
         for (const attr of node.attributes) {
-          if (!this.isBoolean(attr, meta.attributes)) continue;
+          if (!this.isBoolean(attr, meta.attributes)) {
+            continue;
+          }
           if (attr.originalAttribute) {
             continue;
           }
@@ -5321,7 +5335,9 @@ class AttributeEmptyStyle extends Rule {
       const doc = event.document;
       walk.depthFirst(doc, (node) => {
         const meta = node.meta;
-        if (!meta?.attributes) return;
+        if (!meta?.attributes) {
+          return;
+        }
         for (const attr of node.attributes) {
           if (!allowsEmpty(attr, meta.attributes)) {
             continue;
@@ -5414,7 +5430,22 @@ class AttributeMisuse extends Rule {
   }
 }
 
+const patternNamesValues = [
+  "kebabcase",
+  "camelcase",
+  "underscore",
+  "snakecase",
+  "bem",
+  "tailwind"
+];
+const patternNames = new Set(patternNamesValues);
+function isNamedPattern(value) {
+  return typeof value === "string" && patternNames.has(value);
+}
 function parsePattern(pattern) {
+  if (pattern instanceof RegExp) {
+    return { regexp: pattern, description: pattern.toString() };
+  }
   switch (pattern) {
     case "kebabcase":
       return { regexp: /^[a-z][a-z0-9]*(?:-[a-z0-9]+)*$/, description: pattern };
@@ -5432,7 +5463,21 @@ function parsePattern(pattern) {
         description: pattern
       };
     }
+    case "tailwind": {
+      return {
+        regexp: /^!?(?:[-a-z[]|\d+xl:)[\w\-:./\\[\]()#'&>,!=%]*$/,
+        description: "tailwind"
+      };
+    }
     default: {
+      if (pattern.startsWith("/") && pattern.endsWith("/")) {
+        const regexpSource = pattern.slice(1, -1);
+        const regexp2 = new RegExp(regexpSource);
+        return { regexp: regexp2, description: regexp2.toString() };
+      }
+      console.warn(
+        `Custom pattern "${pattern}" should be wrapped in forward slashes, e.g., "/${pattern}/". Support for unwrapped patterns is deprecated and will be removed in a future version.`
+      );
       const regexp = new RegExp(pattern);
       return { regexp, description: regexp.toString() };
     }
@@ -5440,27 +5485,49 @@ function parsePattern(pattern) {
 }
 
 function toArray$2(value) {
-  return Array.isArray(value) ? value : [value];
+  if (Array.isArray(value)) {
+    return value;
+  } else {
+    return [value];
+  }
+}
+function validateAllowedPatterns(patterns, allowedPatterns, ruleId) {
+  const extraneous = patterns.filter(isNamedPattern).filter((p) => !allowedPatterns.has(p));
+  if (extraneous.length > 0) {
+    const quote = (it) => `"${it}"`;
+    const disallowed = utils_naturalJoin.naturalJoin(extraneous.map(quote), "and");
+    const allowed = utils_naturalJoin.naturalJoin(Array.from(allowedPatterns, quote), "and");
+    throw new Error(
+      `Pattern ${disallowed} cannot be used with "${ruleId}". Allowed patterns: ${allowed}`
+    );
+  }
 }
 class BasePatternRule extends Rule {
   /** Attribute being tested */
   attr;
   /** Parsed configured patterns */
   patterns;
-  /**
-   * @param attr - Attribute holding the value.
-   * @param options - Rule options with defaults expanded.
-   */
-  constructor(attr, options) {
+  constructor({
+    ruleId,
+    attr,
+    options,
+    allowedPatterns
+  }) {
     super(options);
     const { pattern } = this.options;
     this.attr = attr;
-    this.patterns = toArray$2(pattern).map((it) => parsePattern(it));
+    const patterns = toArray$2(pattern);
+    validateAllowedPatterns(patterns, allowedPatterns, ruleId);
+    this.patterns = patterns.map((it) => parsePattern(it));
   }
   static schema() {
     return {
       pattern: {
-        oneOf: [{ type: "array", items: { type: "string" }, minItems: 1 }, { type: "string" }]
+        anyOf: [
+          { type: "array", items: { anyOf: [{ type: "string" }, { regexp: true }] }, minItems: 1 },
+          { type: "string" },
+          { regexp: true }
+        ]
       }
     };
   }
@@ -5499,7 +5566,13 @@ const defaults$q = {
 };
 class ClassPattern extends BasePatternRule {
   constructor(options) {
-    super("class", { ...defaults$q, ...options });
+    super({
+      ruleId: "class-pattern",
+      attr: "class",
+      options: { ...defaults$q, ...options },
+      allowedPatterns: patternNames
+      // allow all patterns
+    });
   }
   static schema() {
     return BasePatternRule.schema();
@@ -6449,7 +6522,9 @@ class EmptyTitle extends Rule {
   setup() {
     this.on("tag:end", (event) => {
       const node = event.previous;
-      if (node.tagName !== "title") return;
+      if (node.tagName !== "title") {
+        return;
+      }
       switch (classifyNodeText(node)) {
         case TextClassification.DYNAMIC_TEXT:
         case TextClassification.STATIC_TEXT:
@@ -6770,7 +6845,9 @@ class HeadingLevel extends Rule {
   }
   onTagStart(event) {
     const level = extractLevel(event.target);
-    if (!level) return;
+    if (!level) {
+      return;
+    }
     const root = this.getCurrentRoot();
     if (!this.options.allowMultipleH1 && level === 1) {
       if (root.h1Count >= 1) {
@@ -6956,9 +7033,22 @@ class HiddenFocusable extends Rule {
 const defaults$j = {
   pattern: "kebabcase"
 };
+function exclude$1(set, ...values) {
+  const result = new Set(set);
+  for (const value of values) {
+    result.delete(value);
+  }
+  return result;
+}
 class IdPattern extends BasePatternRule {
   constructor(options) {
-    super("id", { ...defaults$j, ...options });
+    const allowedPatterns = exclude$1(patternNames, "tailwind");
+    super({
+      ruleId: "id-pattern",
+      attr: "id",
+      options: { ...defaults$j, ...options },
+      allowedPatterns
+    });
   }
   static schema() {
     return BasePatternRule.schema();
@@ -7262,7 +7352,9 @@ class InputMissingLabel extends Rule {
   }
 }
 function findLabelById(root, id) {
-  if (!id) return [];
+  if (!id) {
+    return [];
+  }
   return root.querySelectorAll(`label[for="${id}"]`);
 }
 function findLabelByParent(el) {
@@ -7301,7 +7393,9 @@ class LongTitle extends Rule {
   setup() {
     this.on("tag:end", (event) => {
       const node = event.previous;
-      if (node.tagName !== "title") return;
+      if (node.tagName !== "title") {
+        return;
+      }
       const text = node.textContent;
       if (text.length > this.maxlength) {
         this.report(node, `title text cannot be longer than ${String(this.maxlength)} characters`);
@@ -7503,9 +7597,22 @@ class MultipleLabeledControls extends Rule {
 const defaults$g = {
   pattern: "camelcase"
 };
+function exclude(set, ...values) {
+  const result = new Set(set);
+  for (const value of values) {
+    result.delete(value);
+  }
+  return result;
+}
 class NamePattern extends BasePatternRule {
   constructor(options) {
-    super("name", { ...defaults$g, ...options });
+    const allowedPatterns = exclude(patternNames, "tailwind");
+    super({
+      ruleId: "name-pattern",
+      attr: "name",
+      options: { ...defaults$g, ...options },
+      allowedPatterns
+    });
   }
   static schema() {
     return BasePatternRule.schema();
@@ -7866,7 +7973,7 @@ Omitted end tags can be ambigious for humans to read and many editors have troub
         return;
       }
       const parent = closed.parent;
-      const closedByParent = parent && parent.tagName === by.tagName;
+      const closedByParent = parent?.tagName === by.tagName;
       const closedByDocument = closedByParent && parent.isRootElement();
       const sameTag = closed.tagName === by.tagName;
       if (closedByDocument) {
@@ -8228,7 +8335,7 @@ class NoRedundantAriaLabel extends Rule {
           continue;
         }
         const label = document.querySelector(`label[for="${id}"]`);
-        if (!ariaLabel || !label || label.textContent.trim() !== ariaLabel.value) {
+        if (!ariaLabel || label?.textContent.trim() !== ariaLabel.value) {
           continue;
         }
         const message = "aria-label is redundant when label containing same text exists";
@@ -10047,6 +10154,46 @@ class ValidAutocomplete extends Rule {
   }
 }
 
+function isLabelable(target) {
+  const { meta } = target;
+  if (!meta) {
+    return true;
+  }
+  return Boolean(meta.labelable);
+}
+class ValidFor extends Rule {
+  documentation() {
+    return {
+      description: `The \`<label>\` \`for\` attribute must reference a labelable form control.`,
+      url: "https://html-validate.org/rules/valid-for.html"
+    };
+  }
+  setup() {
+    this.on("dom:ready", (event) => {
+      const { document } = event;
+      for (const node of document.querySelectorAll("label[for]")) {
+        const attr = node.getAttribute("for");
+        if (!isStaticAttribute(attr) || !attr.value) {
+          continue;
+        }
+        const selector = generateIdSelector(attr.value);
+        const target = document.querySelector(selector);
+        if (!target) {
+          continue;
+        }
+        if (isLabelable(target)) {
+          continue;
+        }
+        this.report({
+          node,
+          message: '<label> "for" attribute must reference a labelable form control',
+          location: attr.valueLocation
+        });
+      }
+    });
+  }
+}
+
 const defaults$4 = {
   relaxed: false
 };
@@ -10345,7 +10492,9 @@ class H36 extends Rule {
   setup() {
     this.on("tag:end", (event) => {
       const node = event.previous;
-      if (node.tagName !== "input") return;
+      if (node.tagName !== "input") {
+        return;
+      }
       if (node.getAttributeValue("type") !== "image") {
         return;
       }
@@ -10671,6 +10820,7 @@ const bundledRules = {
   "unique-landmark": UniqueLandmark,
   "unrecognized-char-ref": UnknownCharReference,
   "valid-autocomplete": ValidAutocomplete,
+  "valid-for": ValidFor,
   "valid-id": ValidID,
   "void-content": VoidContent,
   "void-style": VoidStyle,
@@ -11024,6 +11174,7 @@ const config$1 = {
     "unique-landmark": "error",
     "unrecognized-char-ref": "error",
     "valid-autocomplete": "error",
+    "valid-for": "error",
     "valid-id": ["error", { relaxed: false }],
     void: "off",
     "void-content": "error",
@@ -11071,6 +11222,7 @@ const config = {
     "script-element": "error",
     "unrecognized-char-ref": "error",
     "valid-autocomplete": "error",
+    "valid-for": "error",
     "valid-id": ["error", { relaxed: true }],
     "void-content": "error"
   }
@@ -11677,7 +11829,9 @@ class Config {
     }
     for (const plugin of plugins) {
       for (const [name, config] of Object.entries(plugin.configs ?? {})) {
-        if (!config) continue;
+        if (!config) {
+          continue;
+        }
         Config.validate(config, name);
         configs.set(`${plugin.name}:${name}`, config);
         if (plugin.name !== plugin.originalName) {
@@ -11978,7 +12132,7 @@ class EventHandler {
 }
 
 const name = "html-validate";
-const version = "10.5.0";
+const version = "10.6.0";
 const bugs = "https://gitlab.com/html-validate/html-validate/issues/new";
 
 function freeze(src) {
@@ -12029,6 +12183,7 @@ class Reporter {
       warningCount: sumWarnings(results)
     };
   }
+  /* eslint-disable-next-line @typescript-eslint/max-params -- technical debt */
   add(rule, message, severity, node, location, context) {
     if (!(location.filename in this.result)) {
       this.result[location.filename] = [];
@@ -12148,7 +12303,7 @@ class ParserError extends Error {
 }
 
 function isAttrValueToken(token) {
-  return Boolean(token && token.type === TokenType.ATTR_VALUE);
+  return token?.type === TokenType.ATTR_VALUE;
 }
 function svgShouldRetainTag(foreignTagName, tagName) {
   return foreignTagName === "svg" && ["title", "desc"].includes(tagName);
@@ -12494,7 +12649,7 @@ class Parser {
    *      ^^^          ^^^         ^^^    (null)   (null)
    */
   getAttributeValueLocation(token) {
-    if (!token || token.type !== TokenType.ATTR_VALUE || token.data[2] === "") {
+    if (token?.type !== TokenType.ATTR_VALUE || token.data[2] === "") {
       return null;
     }
     const quote = token.data[3];
@@ -12510,7 +12665,7 @@ class Parser {
    */
   getAttributeLocation(key, value) {
     const begin = key.location;
-    const end = value && value.type === TokenType.ATTR_VALUE ? value.location : void 0;
+    const end = value?.type === TokenType.ATTR_VALUE ? value.location : void 0;
     return {
       filename: begin.filename,
       line: begin.line,
@@ -12532,7 +12687,11 @@ class Parser {
       throw new Error(`Failed to parse directive "${text}"`);
     }
     if (!isValidDirective(action)) {
-      throw new ParserError(token.location, `Unknown directive "${action}"`);
+      this.trigger("parse:error", {
+        location: token.location,
+        message: `Unknown directive "${action}"`
+      });
+      return;
     }
     const [, data, separator2, comment] = match;
     const prefix = "html-validate-";
@@ -12625,7 +12784,9 @@ class Parser {
     while (!it.done) {
       const token = it.value;
       yield token;
-      if (token.type === search) return;
+      if (token.type === search) {
+        return;
+      }
       it = this.next(tokenStream);
     }
     throw new ParserError(
@@ -12788,6 +12949,9 @@ class Engine {
       parser.on("directive", (_2, event) => {
         this.processDirective(event, parser, directiveContext);
       });
+      parser.on("parse:error", (_2, event) => {
+        this.reportError("parser-error", event.message, event.location);
+      });
       try {
         parser.parseHtml(source);
       } catch (e) {
@@ -12985,7 +13149,9 @@ class Engine {
     const availableRules = {};
     for (const plugin of config.getPlugins()) {
       for (const [name, rule] of Object.entries(plugin.rules ?? {})) {
-        if (!rule) continue;
+        if (!rule) {
+          continue;
+        }
         availableRules[name] = rule;
       }
     }
@@ -13018,6 +13184,7 @@ class Engine {
   /**
    * Load and setup a rule using current config.
    */
+  /* eslint-disable-next-line @typescript-eslint/max-params -- technical debt */
   loadRule(ruleId, config, severity, options, parser, report) {
     const meta = config.getMetaTable();
     const rule = this.instantiateRule(ruleId, options);