hr-design-system-handlebars 1.95.1 → 1.96.0

package/CHANGELOG.md

@@ -1,3 +1,15 @@
+# v1.96.0 (Mon Aug 26 2024)
+
+#### 🚀 Enhancement
+
+- Feature/dpe 3322 [#1053](https://github.com/mumprod/hr-design-system-handlebars/pull/1053) ([@szuelch](https://github.com/szuelch))
+
+#### Authors: 1
+
+- [@szuelch](https://github.com/szuelch)
+
+---
+
 # v1.95.1 (Fri Aug 23 2024)
 
 #### 🐛 Bug Fix

package/dist/assets/index.css

@@ -3332,7 +3332,7 @@ article.indexTextDS .indexTextHighlighted .link {
   border-bottom-color: var(--color-secondary-ds);
 }
 .counter-reset {
-  counter-reset: cnt1724406325510;
+  counter-reset: cnt1724672641168;
 }
 .hyphens-auto {
   -webkit-hyphens: auto;
@@ -3740,7 +3740,7 @@ article.indexTextDS .indexTextHighlighted .link {
   --tw-ring-color: rgba(255, 255, 255, 0.5);
 }
 .-ordered {
-  counter-increment: cnt1724406325510 1;
+  counter-increment: cnt1724672641168 1;
 }
 .-ordered::before {
   position: absolute;
@@ -3756,7 +3756,7 @@ article.indexTextDS .indexTextHighlighted .link {
   letter-spacing: .0125em;
   --tw-text-opacity: 1;
   color: rgba(0, 0, 0, var(--tw-text-opacity));
-  content: counter(cnt1724406325510);
+  content: counter(cnt1724672641168);
 }
 /*! ****************************/
 /*! DataPolicy stuff           */

package/dist/assets/js/base/tracking/clickTracking.feature.js

@@ -1,51 +1,37 @@
-import { download, pi, uxAction, uxNavigation } from 'base/tracking/pianoHelper.subfeature'
+import { download, pi, uxAction, uxNavigation } from 'base/tracking/pianoHelper.subfeature';
 
-const ClickTracking = function (context) {
-    const { options } = context,
-        { element: elementToTrack } = context,
-        settings = options.settings || []
+const ClickTracking = (context) => {
+    const { options, element: elementToTrack } = context;
+    const settings = options.settings || [];
 
-    const init = function () {
-        configureEventHandlers()
-    }
-
-    const configureEventHandlers = function () {
-        if (window.attachEvent) {
-            elementToTrack.attachEvent('click', clickHandler)
-        } else {
-            elementToTrack.addEventListener('click', clickHandler)
-        }
-    }
-
-    const clickHandler = function (event) {
-        settings.forEach(function (trackingSetting) {
+    const clickHandler = (event) => {
+        settings.forEach(({ type, clickLabel, secondLevelId }) => {
             /* use String.prototype.replace function with a regex and the global flag
                instead of String.prototype.replaceAll function to prevent errors in older
                browsers that don't know the replaceAll function
                see: https://www.designcise.com/web/tutorial/how-to-fix-replaceall-is-not-a-function-javascript-error
             */
-            trackingSetting.clickLabel = trackingSetting.clickLabel.replace(/&/g, '-')
-            switch (trackingSetting.type) {
+            const sanitizedLabel = clickLabel.replace(/&/g, '-');
+            switch (type) {
                 case 'download':
-                    download(trackingSetting.clickLabel, trackingSetting.secondLevelId)
-                    break
+                    download(sanitizedLabel, secondLevelId);
+                    break;
                 case 'pi':
-                    pi()
-                    break
+                    pi();
+                    break;
                 case 'uxAction':
-                    uxAction(trackingSetting.clickLabel, trackingSetting.secondLevelId)
-                    break
+                    uxAction(sanitizedLabel, secondLevelId);
+                    break;
                 case 'uxNavigation':
-                    uxNavigation(trackingSetting.clickLabel, trackingSetting.secondLevelId)
-                    break
+                    uxNavigation(sanitizedLabel, secondLevelId);
+                    break;
                 default:
-                    console.log('Fehler, es wurde kein Tracking Typ angegeben.')
-                    break
+                    console.error('Fehler, es wurde kein Tracking Typ angegeben.');
             }
-        })
-    }
+        });
+    };
 
-    init()
-}
+    elementToTrack.addEventListener('click', clickHandler);
+};
 
-export default ClickTracking
+export default ClickTracking;

package/dist/assets/js/base/tracking/pianoHelper.subfeature.js

@@ -1,44 +1,36 @@
-import SettingsCookie from 'components/externalService/globalSettingsCookie.subfeature'
+import SettingsCookie from 'components/externalService/globalSettingsCookie.subfeature';
 
 const isTrackingAllowed = () => {
-    const settingsCookie = new SettingsCookie()
-    return settingsCookie.isSettingsCookieAccepted('ati')
-}
-
-const uxAction = (label, secondLevelId) => {
-    secondLevelId = undefined !== secondLevelId ? secondLevelId : typeof pageDisplayConfig !== "undefined" && pageDisplayConfig !== undefined ? pageDisplayConfig.site_level2_id:99
-    if (typeof pa !== "undefined" && pa !== undefined && isTrackingAllowed()) {
-        pa.sendEvent('click.action', {
-            click: label,
-            site_level2_id: secondLevelId,
-        })
-    }
-}
-
-const uxNavigation = (label, secondLevelId) => {
-    secondLevelId = undefined !== secondLevelId ? secondLevelId : typeof pageDisplayConfig !== "undefined" && pageDisplayConfig !== undefined ? pageDisplayConfig.site_level2_id:99
-    if (typeof pa !== "undefined" && pa !== undefined  && isTrackingAllowed()) {
-        pa.sendEvent('click.navigation', {
-            click: label,
-            site_level2_id: secondLevelId,
-        })
-    }
-}
+    const settingsCookie = new SettingsCookie();
+    return settingsCookie.isSettingsCookieAccepted('ati');
+};
 
-const pi = () => {
-    if (typeof pa !== "undefined" && pa !== undefined  && isTrackingAllowed()) {
-        pa.sendEvent('page.display', pageDisplayConfig)
+const sendEvent = (eventType, event) => {
+    if (typeof pa !== 'undefined' && pa !== undefined && isTrackingAllowed()) {
+        pa.sendEvent(eventType, event);
     }
-}
-
-const download = (label, secondLevelId) => {
-    secondLevelId = undefined !== secondLevelId ? secondLevelId : typeof pageDisplayConfig !== "undefined" && pageDisplayConfig !== undefined ? pageDisplayConfig.site_level2_id:99
-    if (typeof pa !== "undefined" && pa !== undefined  && isTrackingAllowed()) {
-        pa.sendEvent('click.download', {
-            click: label,
-            site_level2_id: secondLevelId,
-        })
+};
+
+const getDefaultEvent = (label, secondLevelId) => {
+    return {
+        click: label,
+        site_level2_id: determineSecondLevelId(secondLevelId)
     }
-}
+};
+
+const determineSecondLevelId = (secondLevelId) => {
+    return secondLevelId !== undefined
+        ? secondLevelId
+        : pageDisplayConfig.site_level2_id;
+};
+
+const uxAction = (label, secondLevelId) => sendEvent('click.action', getDefaultEvent(label, secondLevelId));
+
+const uxNavigation = (label, secondLevelId) => sendEvent('click.navigation', getDefaultEvent(label, secondLevelId));
+
+const pi = () => sendEvent('page.display', pageDisplayConfig);
+
+const download = (label, secondLevelId) => sendEvent('click.download', getDefaultEvent(label, secondLevelId));
+
 
-export { isTrackingAllowed, uxAction, uxNavigation, pi, download }
+export { isTrackingAllowed, uxAction, uxNavigation, pi, download };

package/package.json

@@ -6,7 +6,7 @@
   "license": "MIT",
   "main": "dist/index.js",
   "repository": "https://github.com/szuelch/hr-design-system-handlebars",
-  "version": "1.95.1",
+  "version": "1.96.0",
   "scripts": {
     "test": "echo \"Error: no test specified\" && exit 1",
     "storybook": "storybook dev -p 6006 public",

package/src/stories/views/base/tracking/clickTracking.feature.js

@@ -1,51 +1,37 @@
-import { download, pi, uxAction, uxNavigation } from 'base/tracking/pianoHelper.subfeature'
+import { download, pi, uxAction, uxNavigation } from 'base/tracking/pianoHelper.subfeature';
 
-const ClickTracking = function (context) {
-    const { options } = context,
-        { element: elementToTrack } = context,
-        settings = options.settings || []
+const ClickTracking = (context) => {
+    const { options, element: elementToTrack } = context;
+    const settings = options.settings || [];
 
-    const init = function () {
-        configureEventHandlers()
-    }
-
-    const configureEventHandlers = function () {
-        if (window.attachEvent) {
-            elementToTrack.attachEvent('click', clickHandler)
-        } else {
-            elementToTrack.addEventListener('click', clickHandler)
-        }
-    }
-
-    const clickHandler = function (event) {
-        settings.forEach(function (trackingSetting) {
+    const clickHandler = (event) => {
+        settings.forEach(({ type, clickLabel, secondLevelId }) => {
             /* use String.prototype.replace function with a regex and the global flag
                instead of String.prototype.replaceAll function to prevent errors in older
                browsers that don't know the replaceAll function
                see: https://www.designcise.com/web/tutorial/how-to-fix-replaceall-is-not-a-function-javascript-error
             */
-            trackingSetting.clickLabel = trackingSetting.clickLabel.replace(/&/g, '-')
-            switch (trackingSetting.type) {
+            const sanitizedLabel = clickLabel.replace(/&/g, '-');
+            switch (type) {
                 case 'download':
-                    download(trackingSetting.clickLabel, trackingSetting.secondLevelId)
-                    break
+                    download(sanitizedLabel, secondLevelId);
+                    break;
                 case 'pi':
-                    pi()
-                    break
+                    pi();
+                    break;
                 case 'uxAction':
-                    uxAction(trackingSetting.clickLabel, trackingSetting.secondLevelId)
-                    break
+                    uxAction(sanitizedLabel, secondLevelId);
+                    break;
                 case 'uxNavigation':
-                    uxNavigation(trackingSetting.clickLabel, trackingSetting.secondLevelId)
-                    break
+                    uxNavigation(sanitizedLabel, secondLevelId);
+                    break;
                 default:
-                    console.log('Fehler, es wurde kein Tracking Typ angegeben.')
-                    break
+                    console.error('Fehler, es wurde kein Tracking Typ angegeben.');
             }
-        })
-    }
+        });
+    };
 
-    init()
-}
+    elementToTrack.addEventListener('click', clickHandler);
+};
 
-export default ClickTracking
+export default ClickTracking;

package/src/stories/views/base/tracking/pianoHelper.subfeature.js

@@ -1,44 +1,36 @@
-import SettingsCookie from 'components/externalService/globalSettingsCookie.subfeature'
+import SettingsCookie from 'components/externalService/globalSettingsCookie.subfeature';
 
 const isTrackingAllowed = () => {
-    const settingsCookie = new SettingsCookie()
-    return settingsCookie.isSettingsCookieAccepted('ati')
-}
-
-const uxAction = (label, secondLevelId) => {
-    secondLevelId = undefined !== secondLevelId ? secondLevelId : typeof pageDisplayConfig !== "undefined" && pageDisplayConfig !== undefined ? pageDisplayConfig.site_level2_id:99
-    if (typeof pa !== "undefined" && pa !== undefined && isTrackingAllowed()) {
-        pa.sendEvent('click.action', {
-            click: label,
-            site_level2_id: secondLevelId,
-        })
-    }
-}
-
-const uxNavigation = (label, secondLevelId) => {
-    secondLevelId = undefined !== secondLevelId ? secondLevelId : typeof pageDisplayConfig !== "undefined" && pageDisplayConfig !== undefined ? pageDisplayConfig.site_level2_id:99
-    if (typeof pa !== "undefined" && pa !== undefined  && isTrackingAllowed()) {
-        pa.sendEvent('click.navigation', {
-            click: label,
-            site_level2_id: secondLevelId,
-        })
-    }
-}
+    const settingsCookie = new SettingsCookie();
+    return settingsCookie.isSettingsCookieAccepted('ati');
+};
 
-const pi = () => {
-    if (typeof pa !== "undefined" && pa !== undefined  && isTrackingAllowed()) {
-        pa.sendEvent('page.display', pageDisplayConfig)
+const sendEvent = (eventType, event) => {
+    if (typeof pa !== 'undefined' && pa !== undefined && isTrackingAllowed()) {
+        pa.sendEvent(eventType, event);
     }
-}
-
-const download = (label, secondLevelId) => {
-    secondLevelId = undefined !== secondLevelId ? secondLevelId : typeof pageDisplayConfig !== "undefined" && pageDisplayConfig !== undefined ? pageDisplayConfig.site_level2_id:99
-    if (typeof pa !== "undefined" && pa !== undefined  && isTrackingAllowed()) {
-        pa.sendEvent('click.download', {
-            click: label,
-            site_level2_id: secondLevelId,
-        })
+};
+
+const getDefaultEvent = (label, secondLevelId) => {
+    return {
+        click: label,
+        site_level2_id: determineSecondLevelId(secondLevelId)
     }
-}
+};
+
+const determineSecondLevelId = (secondLevelId) => {
+    return secondLevelId !== undefined
+        ? secondLevelId
+        : pageDisplayConfig.site_level2_id;
+};
+
+const uxAction = (label, secondLevelId) => sendEvent('click.action', getDefaultEvent(label, secondLevelId));
+
+const uxNavigation = (label, secondLevelId) => sendEvent('click.navigation', getDefaultEvent(label, secondLevelId));
+
+const pi = () => sendEvent('page.display', pageDisplayConfig);
+
+const download = (label, secondLevelId) => sendEvent('click.download', getDefaultEvent(label, secondLevelId));
+
 
-export { isTrackingAllowed, uxAction, uxNavigation, pi, download }
+export { isTrackingAllowed, uxAction, uxNavigation, pi, download };