howtofixcli 0.7.8 → 0.7.9

package/dist/quality/smells.js

@@ -1,67 +0,0 @@
-/**
- * Compound smells — spec §3.7.
- *
- * A smell fires only when SEVERAL metrics are over their warn line at the same
- * time; one metric over the line is just a number and is reported as such.
- * Ids, labels, and conditions come from the reference
- * (`code-multivitals/src/analyzers/smells.ts`); the `warn`/`ok` tests of the
- * reference are expressed here as severity RANKS supplied by the caller, so
- * this module depends on neither thresholds nor config and stays trivially
- * testable.
- *
- * Rank semantics (from `report.ts`): `0` = ok, `1` = warn, `2` = error; a
- * metric "at warn" means rank ≥ 1 (warn or worse), and MI < 65 is exactly
- * rank(mi) ≥ 1.
- */
-/** The report prints one concrete next step per smell that fired (spec §6). */
-export const SMELL_SUGGESTIONS = {
-    "god-function": "split it into smaller functions, one job each",
-    incomprehensible: "extract helpers and simplify the flow before touching it",
-    bloated: "long but linear; extract helpers",
-    "deeply-tangled": "nesting, not branching; flatten with early returns",
-    fragile: "many branches; add guard clauses and tests around it",
-};
-export function detectSmells(values, ranks) {
-    const smells = [];
-    // God Function: does too much — long, branchy, AND deep.
-    if (ranks.cyclomatic >= 1 && ranks.length >= 1 && ranks.nesting >= 1) {
-        smells.push({
-            id: "god-function",
-            label: "God Function",
-            reason: `high cyclomatic complexity (${values.cyclomatic}), long body (${values.length} lines), and deep nesting (${values.nesting}) — likely doing too many things`,
-        });
-    }
-    // Incomprehensible: hard to read — cognitively dense, big vocabulary, low MI.
-    if (ranks.cognitive >= 1 && ranks.halstead >= 1 && ranks.mi >= 1) {
-        smells.push({
-            id: "incomprehensible",
-            label: "Incomprehensible",
-            reason: `high cognitive complexity (${values.cognitive}) and Halstead volume (${values.halstead}) with MI ${values.mi} — very hard to understand`,
-        });
-    }
-    // Bloated: too much code, but not because of branching — extract helpers.
-    if (ranks.length >= 1 && ranks.halstead >= 1 && ranks.cyclomatic === 0) {
-        smells.push({
-            id: "bloated",
-            label: "Bloated",
-            reason: `large function (${values.length} lines) with high vocabulary (Halstead ${values.halstead}) but low branching — consider extracting helpers`,
-        });
-    }
-    // Deeply Tangled: the complexity comes from nesting, not from branches.
-    if (ranks.nesting >= 1 && ranks.cognitive >= 1 && ranks.cyclomatic === 0) {
-        smells.push({
-            id: "deeply-tangled",
-            label: "Deeply Tangled",
-            reason: `nesting depth ${values.nesting} drives cognitive complexity ${values.cognitive} — flatten with early returns or extracted helpers`,
-        });
-    }
-    // Fragile: branchy and hard to maintain, but short enough to not be bloated.
-    if (ranks.cyclomatic >= 1 && ranks.mi >= 1 && ranks.length === 0) {
-        smells.push({
-            id: "fragile",
-            label: "Fragile",
-            reason: `high cyclomatic complexity (${values.cyclomatic}) with MI ${values.mi} — many branches, hard to change safely`,
-        });
-    }
-    return smells;
-}

package/dist/quality-tool.js

@@ -1,63 +0,0 @@
-/**
- * The `quality` tool — metrics for the code the agent just wrote.
- *
- * Read-only by construction: it analyses source and reports, it never edits.
- * That is the whole point of exposing it to the agent. A run that ends with
- * "done" can be checked against numbers instead of a claim, and the agent can
- * act on the numbers before it reports: "cognitive 31, split it" is something
- * it can fix, "looks clean to me" is not.
- *
- * It defaults to the files the agent is most likely to have touched rather than
- * the whole project, because a whole-project scan on a large repo is slow and
- * buries the one function the agent just wrote under a hundred unrelated
- * warnings.
- */
-import { defineTool } from "@netrodev/hxf-coding-agent";
-import { Type } from "typebox";
-import { analyzeFiles, collectTargetPaths, formatHuman, loadQualityConfig, qualityEnabled, reportScore, summarize } from "./quality/index.js";
-/** Longest report handed back to the model, so one call cannot flood the context. */
-const MAX_REPORT_CHARS = 6000;
-export const qualityTool = defineTool({
-    name: "quality",
-    label: "quality",
-    description: "Measure code quality: cyclomatic and cognitive complexity, nesting depth, function length, Halstead volume, maintainability index, and compound smells like god-function and deeply-tangled. Read-only. Use it before reporting a task finished, especially on functions you just wrote or changed; it reports concrete numbers with line numbers and a suggested next step, so 'is this too complex' stops being a guess. Defaults to the changed files; pass a path to narrow it further.",
-    promptSnippet: "quality: complexity and maintainability metrics for changed code",
-    parameters: Type.Object({
-        path: Type.Optional(Type.String({ description: "One file or directory, relative to the project root. Omit to scan the changed set." })),
-        changes: Type.Optional(Type.Boolean({ description: "Scan only files changed against the base ref. Default true when path is omitted." })),
-        base: Type.Optional(Type.String({ description: "Git ref for `changes`. Defaults to HEAD." })),
-        top: Type.Optional(Type.Number({ description: "Only report the N worst functions." })),
-    }),
-    async execute(_toolCallId, params, _signal, _onUpdate, ctx) {
-        const cwd = ctx.cwd ?? process.cwd();
-        const state = qualityEnabled(cwd);
-        if (!state.enabled) {
-            return {
-                content: [{ type: "text", text: `quality metrics are off (source: ${state.source})` }],
-                details: { off: true },
-            };
-        }
-        const config = loadQualityConfig(cwd);
-        const useChanges = params.changes ?? params.path === undefined;
-        const paths = collectTargetPaths(cwd, { changes: useChanges, base: params.base, target: params.path }, config.ignore);
-        if (paths.length === 0) {
-            return {
-                content: [{ type: "text", text: useChanges ? "no changed files to measure" : "no source files found" }],
-                details: { files: 0 },
-            };
-        }
-        const report = await analyzeFiles(paths, config);
-        const summary = summarize(report);
-        const text = formatHuman(report, config, { top: params.top });
-        const clipped = text.length > MAX_REPORT_CHARS ? `${text.slice(0, MAX_REPORT_CHARS)}\n… (truncated; run the quality script for the full report)` : text;
-        return {
-            content: [{ type: "text", text: clipped }],
-            details: {
-                files: summary.files,
-                functions: summary.functions,
-                findings: summary.findings,
-                score: reportScore(report),
-            },
-        };
-    },
-});