houdini 0.17.8 → 0.17.9

package/.turbo/turbo-compile.log

@@ -1,5 +1,5 @@
-houdini:compile: cache hit, replaying output 46091d3751e7378b
+houdini:compile: cache hit, replaying output 0e01ddbb04113c7d
 houdini:compile: 
-houdini:compile: > houdini@0.17.8 compile /home/runner/work/houdini/houdini/packages/houdini
+houdini:compile: > houdini@0.17.9 compile /home/runner/work/houdini/houdini/packages/houdini
 houdini:compile: > scripts build
 houdini:compile: 

package/.turbo/turbo-typedefs.log

@@ -1,5 +1,5 @@
-houdini:typedefs: cache hit, replaying output 56dc71f9cf5019cc
+houdini:typedefs: cache hit, replaying output b1c668e379118489
 houdini:typedefs: 
-houdini:typedefs: > houdini@0.17.8 typedefs /home/runner/work/houdini/houdini/packages/houdini
+houdini:typedefs: > houdini@0.17.9 typedefs /home/runner/work/houdini/houdini/packages/houdini
 houdini:typedefs: > scripts typedefs
 houdini:typedefs: 

package/CHANGELOG.md

@@ -1,5 +1,15 @@
 # houdini
 
+## 0.17.9
+
+### 🐛 Fixes
+
+-   [#693](https://github.com/HoudiniGraphql/houdini/pull/693) [`6e36775`](https://github.com/HoudiniGraphql/houdini/commit/6e367755d902eca3242519b4c609c0d5bc76f4ff) Thanks [@AlecAivazis](https://github.com/AlecAivazis)! - Fix bug causing `@parentID` to be ignored when there was only one version of the list
+
+### ✨ Features
+
+-   [#693](https://github.com/HoudiniGraphql/houdini/pull/693) [`6e36775`](https://github.com/HoudiniGraphql/houdini/commit/6e367755d902eca3242519b4c609c0d5bc76f4ff) Thanks [@jycouet](https://github.com/jycouet)! - Adding a new directive @allLists to update all lists after a mutation
+
 ## 0.17.6
 
 ### 🐛 Fixes

package/build/cmd-cjs/index.js

@@ -67825,22 +67825,31 @@ var ListManager = class {
   }
   lists = /* @__PURE__ */ new Map();
   listsByField = /* @__PURE__ */ new Map();
-  get(listName, id) {
+  get(listName, id, allLists) {
     const matches = this.lists.get(listName);
     if (!matches || matches.size === 0) {
       return null;
     }
+    if (allLists) {
+      return new ListCollection(
+        Array.from(matches, ([key, value]) => [...value.lists]).flat()
+      );
+    }
     const head = [...matches.values()][0];
+    const { recordType } = head.lists[0];
+    const parentID = id ? this.cache._internal_unstable.id(recordType || "", id) : this.rootID;
     if (matches?.size === 1) {
-      return head;
+      if (!id) {
+        return head;
+      }
+      return parentID === Array.from(matches.keys())[0] ? head : null;
     }
     if (!id) {
-      throw new Error(
-        `Found multiple instances of "${listName}". Please provide a parentID that corresponds to the object containing the field marked with @list or @paginate.`
+      console.error(
+        `Found multiple instances of "${listName}". Please provide one of @parentID or @allLists directives to help identify which list you want modify. For more information, visit this guide: https://www.houdinigraphql.com/api/graphql#parentidvalue-string `
       );
+      return null;
     }
-    const { recordType } = head.lists[0];
-    const parentID = id ? this.cache._internal_unstable.id(recordType || "", id) : this.rootID;
     return this.lists.get(listName)?.get(parentID);
   }
   remove(listName, id) {
@@ -68786,8 +68795,8 @@ var Cache2 = class {
       variables
     );
   }
-  list(name2, parentID) {
-    const handler = this._internal_unstable.lists.get(name2, parentID);
+  list(name2, parentID, allLists) {
+    const handler = this._internal_unstable.lists.get(name2, parentID, allLists);
     if (!handler) {
       throw new Error(
         `Cannot find list with name: ${name2}${parentID ? " under parent " + parentID : ""}. Is it possible that the query is not mounted?`
@@ -69054,15 +69063,15 @@ var CacheInternal = class {
             parentID = id;
           }
         }
-        if (operation.list && !this.lists.get(operation.list, parentID)) {
+        if (operation.list && !this.lists.get(operation.list, parentID, operation.target === "all")) {
           continue;
         }
         const targets = Array.isArray(value) ? value : [value];
         for (const target of targets) {
           if (operation.action === "insert" && target instanceof Object && fields && operation.list) {
-            this.cache.list(operation.list, parentID).when(operation.when).addToList(fields, target, variables, operation.position || "last");
+            this.cache.list(operation.list, parentID, operation.target === "all").when(operation.when).addToList(fields, target, variables, operation.position || "last");
           } else if (operation.action === "remove" && target instanceof Object && fields && operation.list) {
-            this.cache.list(operation.list, parentID).when(operation.when).remove(target, variables);
+            this.cache.list(operation.list, parentID, operation.target === "all").when(operation.when).remove(target, variables);
           } else if (operation.action === "delete" && operation.type) {
             if (typeof target !== "string") {
               throw new Error("Cannot delete a record with a non-string ID");
@@ -69073,7 +69082,7 @@ var CacheInternal = class {
             }
             this.cache.delete(targetID);
           } else if (operation.action === "toggle" && target instanceof Object && fields && operation.list) {
-            this.cache.list(operation.list, parentID).when(operation.when).toggleElement(fields, target, variables, operation.position || "last");
+            this.cache.list(operation.list, parentID, operation.target === "all").when(operation.when).toggleElement(fields, target, variables, operation.position || "last");
           }
         }
       }
@@ -70868,6 +70877,8 @@ var Config = class {
   cacheBufferSize;
   defaultCachePolicy;
   defaultPartial;
+  internalListPosition;
+  defaultListTarget = null;
   definitionsFolder;
   newSchema = "";
   newDocuments = "";
@@ -70899,6 +70910,8 @@ var Config = class {
       definitionsPath,
       defaultCachePolicy = "CacheOrNetwork" /* CacheOrNetwork */,
       defaultPartial = false,
+      defaultListPosition = "append",
+      defaultListTarget = null,
       defaultKeys,
       types: types14 = {},
       logLevel,
@@ -70932,6 +70945,8 @@ var Config = class {
     this.cacheBufferSize = cacheBufferSize;
     this.defaultCachePolicy = defaultCachePolicy;
     this.defaultPartial = defaultPartial;
+    this.internalListPosition = defaultListPosition === "append" ? "last" : "first";
+    this.defaultListTarget == defaultListTarget;
     this.definitionsFolder = definitionsPath;
     this.logLevel = (logLevel || LogLevel.Summary).toLowerCase();
     this.disableMasking = disableMasking;
@@ -71146,6 +71161,9 @@ var Config = class {
   get listDirectiveParentIDArg() {
     return "parentID";
   }
+  get listAllListsDirective() {
+    return "allLists";
+  }
   get listNameArg() {
     return "name";
   }
@@ -71227,6 +71245,7 @@ var Config = class {
       this.listPrependDirective,
       this.listAppendDirective,
       this.listDirectiveParentIDArg,
+      this.listAllListsDirective,
       this.whenDirective,
       this.whenNotDirective,
       this.argumentsDirective,
@@ -72235,7 +72254,8 @@ function operationObject({
 }) {
   let parentID;
   let parentKind = "String";
-  let position = "last";
+  let position = config2.internalListPosition;
+  let allLists = config2.defaultListTarget ?? void 0;
   let operationWhen;
   const internalDirectives = selection2.directives?.filter(
     (directive) => config2.isInternalDirective(directive)
@@ -72247,15 +72267,21 @@ function operationObject({
     const append = internalDirectives.find(
       ({ name: name2 }) => name2.value === config2.listAppendDirective
     );
-    const when = internalDirectives.find(({ name: name2 }) => name2.value === "when");
-    const when_not = internalDirectives.find(({ name: name2 }) => name2.value === "when_not");
+    if (append) {
+      position = "last";
+    }
+    if (prepend) {
+      position = "first";
+    }
+    const allListsDirective = internalDirectives.find(
+      ({ name: name2 }) => name2.value === config2.listAllListsDirective
+    );
     let parent = internalDirectives.find(
       ({ name: name2 }) => name2.value === config2.listParentDirective
     );
-    if (append && prepend) {
-      throw new HoudiniError({ filepath, message: "you have both applied" });
-    }
-    position = prepend ? "first" : "last";
+    allLists = allListsDirective ? "all" : void 0;
+    const when = internalDirectives.find(({ name: name2 }) => name2.value === "when");
+    const when_not = internalDirectives.find(({ name: name2 }) => name2.value === "when_not");
     let parentIDArg = parent?.arguments?.find((argument) => argument.name.value === "value");
     if (!parentIDArg) {
       parentIDArg = (append || prepend)?.arguments?.find(
@@ -72317,7 +72343,10 @@ function operationObject({
     operation.type = type;
   }
   if (operationKind === "insert" || operationKind === "toggle") {
-    operation.position = position || "last";
+    operation.position = position;
+  }
+  if (operationKind === "insert" && allLists) {
+    operation.target = "all";
   }
   if (parentID) {
     operation.parentID = {
@@ -72478,12 +72507,15 @@ async function paginate(config2, documents) {
             {}
           ) || {};
           let newVariables = Object.fromEntries(
-            Object.entries(flags).filter(([, spec]) => spec.enabled).map(([fieldName, spec]) => [
+            Object.entries(flags).filter(
+              ([, spec]) => spec.enabled && spec.variableName === void 0
+            ).map(([fieldName, spec]) => [
               fieldName,
               staticVariableDefinition(
                 fieldName,
                 spec.type,
-                spec.defaultValue
+                spec.defaultValue,
+                spec.variableName
               )
             ])
           );
@@ -72735,8 +72767,11 @@ function replaceArgumentsWithVariables(args, flags) {
       const oldValue = arg.value.value;
       flags[arg.name.value].defaultValue = spec.type === "Int" ? parseInt(oldValue) : oldValue;
     }
+    if (arg.value.kind === "Variable") {
+      flags[arg.name.value].variableName = arg.value.name.value;
+    }
     seenArgs[arg.name.value] = true;
-    return variableAsArgument(arg.name.value);
+    return variableAsArgument(arg.name.value, flags[arg.name.value].variableName);
   });
   for (const name2 of Object.keys(flags)) {
     const spec = flags[name2];
@@ -72753,7 +72788,7 @@ function replaceArgumentsWithVariables(args, flags) {
   }
   return newArgs;
 }
-function variableAsArgument(name2) {
+function variableAsArgument(name2, variable) {
   return {
     kind: graphql9.Kind.ARGUMENT,
     name: {
@@ -72764,12 +72799,12 @@ function variableAsArgument(name2) {
       kind: graphql9.Kind.VARIABLE,
       name: {
         kind: graphql9.Kind.NAME,
-        value: name2
+        value: variable ?? name2
       }
     }
   };
 }
-function staticVariableDefinition(name2, type, defaultValue) {
+function staticVariableDefinition(name2, type, defaultValue, variableName) {
   return {
     kind: graphql9.Kind.VARIABLE_DEFINITION,
     type: {
@@ -72783,7 +72818,7 @@ function staticVariableDefinition(name2, type, defaultValue) {
       kind: graphql9.Kind.VARIABLE,
       name: {
         kind: graphql9.Kind.NAME,
-        value: name2
+        value: variableName ?? name2
       }
     },
     defaultValue: !defaultValue ? void 0 : {
@@ -74592,6 +74627,11 @@ directive @${config2.listPrependDirective}(
 """
 directive @${config2.listAppendDirective}(${config2.listDirectiveParentIDArg}: ID) on FRAGMENT_SPREAD
 
+"""
+	@${config2.listAllListsDirective} is used to tell the runtime to add the result to all list
+"""
+directive @${config2.listAllListsDirective} on FRAGMENT_SPREAD
+
 """
 	@${config2.listParentDirective} is used to provide a parentID without specifying position or in situations
 	where it doesn't make sense (eg when deleting a node.)
@@ -75171,6 +75211,7 @@ async function typeCheck(config2, docs) {
       listTypes,
       fragments
     }),
+    checkMutationOperation(config2),
     nodeDirectives(config2, [config2.paginateDirective]),
     knownArguments(config2),
     validateFragmentArguments(config2, filepath, fragments),
@@ -75229,24 +75270,33 @@ var validateLists = ({
       if (directive) {
         return;
       }
+      let parentIdFound = false;
       directive = node.directives?.find(({ name: name2 }) => [
         [config2.listPrependDirective, config2.listAppendDirective].includes(name2.value)
       ]);
-      if (!directive) {
-        ctx.reportError(
-          new graphql25.GraphQLError("parentID is required for this list fragment")
+      if (directive) {
+        let parentArg = directive.arguments?.find(
+          (arg) => arg.name.value === config2.listDirectiveParentIDArg
         );
+        if (parentArg) {
+          parentIdFound = true;
+        }
+      }
+      if (parentIdFound) {
         return;
       }
-      let parentArg = directive.arguments?.find(
-        (arg) => arg.name.value === config2.listDirectiveParentIDArg
+      const allLists = node.directives?.find(
+        ({ name: name2 }) => config2.listAllListsDirective === name2.value
       );
-      if (!parentArg) {
-        ctx.reportError(
-          new graphql25.GraphQLError("parentID is required for this list fragment")
-        );
+      if (allLists || config2.defaultListTarget === "all") {
         return;
       }
+      ctx.reportError(
+        new graphql25.GraphQLError(
+          `For this list fragment, you need to add or @${config2.listParentDirective} or @${config2.listAllListsDirective} directive to specify the behavior`
+        )
+      );
+      return;
     },
     Directive(node) {
       const directiveName = node.name.value;
@@ -75589,6 +75639,42 @@ function nodeDirectives(config2, directives) {
     };
   };
 }
+function checkMutationOperation(config2) {
+  return function(ctx) {
+    return {
+      FragmentSpread(node, _, __, ___, ancestors) {
+        const append = node.directives?.find(
+          (c) => c.name.value === config2.listAppendDirective
+        );
+        const prepend = node.directives?.find(
+          (c) => c.name.value === config2.listPrependDirective
+        );
+        if (append && prepend) {
+          ctx.reportError(
+            new graphql25.GraphQLError(
+              `You can't apply both @${config2.listPrependDirective} and @${config2.listAppendDirective} at the same time`
+            )
+          );
+          return;
+        }
+        const parentId = node.directives?.find(
+          (c) => c.name.value === config2.listParentDirective
+        );
+        const allLists = node.directives?.find(
+          (c) => c.name.value === config2.listAllListsDirective
+        );
+        if (parentId && allLists) {
+          ctx.reportError(
+            new graphql25.GraphQLError(
+              `You can't apply both @${config2.listParentDirective} and @${config2.listAllListsDirective} at the same time`
+            )
+          );
+          return;
+        }
+      }
+    };
+  };
+}
 function getAndVerifyNodeInterface(config2) {
   const { schema } = config2;
   const nodeInterface = schema.getType("Node");
@@ -76449,8 +76535,8 @@ async function updatePackageJSON(targetPath) {
   }
   packageJSON.devDependencies = {
     ...packageJSON.devDependencies,
-    houdini: "^0.17.8",
-    "houdini-svelte": "^0.17.8",
+    houdini: "^0.17.9",
+    "houdini-svelte": "^0.17.9",
     graphql: "^15.8.0"
   };
   await fs_exports.writeFile(packagePath, JSON.stringify(packageJSON, null, 4));