hotsheet 0.17.0-beta.16 → 0.17.0-beta.17

package/dist/channel.js

@@ -34369,7 +34369,7 @@ async function proxyRequest(settings, path, init, fetchFn) {
 var UpdateTicketInputSchema = external_exports3.object({
   id: external_exports3.number().int().describe("Ticket id (numeric, e.g. 42)"),
   status: TicketStatusSchema.optional(),
-  notes: external_exports3.string().optional().describe("Replace the ticket's notes JSON. Pass the full notes array as a JSON string."),
+  notes: external_exports3.string().optional().describe('Append a new note. Pass the markdown body as a plain string (NOT a JSON array \u2014 the server wraps the text in `{id, text, created_at}` automatically). HS-8427 \u2014 if you mistakenly pass a JSON-stringified note array like `[{"text":"..."}]`, the server unwraps it defensively so the body renders correctly, but plain text is the documented + preferred shape.'),
   priority: TicketPrioritySchema.optional(),
   category: external_exports3.string().optional().describe('Category id (e.g. "bug", "feature", "task", "issue")'),
   up_next: external_exports3.boolean().optional(),

package/dist/cli.js

@@ -575,6 +575,7 @@ __export(connection_exports, {
   getDataDir: () => getDataDir,
   getDb: () => getDb,
   getDbForDir: () => getDbForDir,
+  isRecoverableOpenError: () => isRecoverableOpenError,
   readRecoveryMarker: () => readRecoveryMarker,
   runWithDataDir: () => runWithDataDir,
   setDataDir: () => setDataDir
@@ -583,6 +584,20 @@ import { AsyncLocalStorage } from "async_hooks";
 import { PGlite } from "@electric-sql/pglite";
 import { existsSync as existsSync3, mkdirSync as mkdirSync2, readFileSync as readFileSync2, renameSync, rmSync as rmSync2, writeFileSync } from "fs";
 import { join as join3 } from "path";
+function isRecoverableOpenError(err) {
+  if (err === null || err === void 0) return false;
+  let message;
+  if (err instanceof Error) message = err.message;
+  else if (typeof err === "string") message = err;
+  else if (typeof err === "number" || typeof err === "boolean") message = String(err);
+  else return false;
+  const errName = err instanceof Error ? err.name : "";
+  if (message.includes("Aborted")) return true;
+  if (message.includes("RuntimeError")) return true;
+  if (errName === "RuntimeError") return true;
+  if (message.includes("catalog is missing")) return true;
+  return false;
+}
 function recoveryMarkerPath(dataDir) {
   return join3(dataDir, RECOVERY_MARKER_FILENAME);
 }
@@ -710,9 +725,7 @@ async function openAndCacheDb(dbPath) {
 async function recoverFromOpenFailure(dbPath, err) {
   const message = err instanceof Error ? err.message : String(err);
   const stack = err instanceof Error ? err.stack : void 0;
-  const errName = err instanceof Error ? err.name : "";
-  const isRuntimeFailure = message.includes("Aborted") || message.includes("RuntimeError") || errName === "RuntimeError";
-  if (!isRuntimeFailure) throw err;
+  if (!isRecoverableOpenError(err)) throw err;
   console.error("Failed to open database:", message);
   if (stack !== void 0) console.error(stack);
   if (tryRemoveStalePostmasterPid(dbPath)) {
@@ -824,6 +837,12 @@ async function initSchema(db) {
   `).catch((e) => {
     if (e instanceof Error && !e.message.includes("already exists")) console.error("Migration error (columns):", e.message);
   });
+  await db.exec(`
+    ALTER TABLE attachments ADD COLUMN IF NOT EXISTS draft_id TEXT;
+    CREATE INDEX IF NOT EXISTS idx_attachments_draft ON attachments(draft_id);
+  `).catch((e) => {
+    if (e instanceof Error && !e.message.includes("already exists")) console.error("Migration error (attachments.draft_id):", e.message);
+  });
   await db.exec(`
     CREATE TABLE IF NOT EXISTS ticket_sync (
       id SERIAL PRIMARY KEY,
@@ -921,7 +940,7 @@ var SCHEMA_VERSION, RECOVERY_MARKER_FILENAME, databases, defaultDbPath, requestD
 var init_connection = __esm({
   "src/db/connection.ts"() {
     "use strict";
-    SCHEMA_VERSION = 1;
+    SCHEMA_VERSION = 2;
     RECOVERY_MARKER_FILENAME = ".db-recovery-marker.json";
     databases = /* @__PURE__ */ new Map();
     defaultDbPath = null;
@@ -16022,6 +16041,18 @@ var init_backup = __esm({
 });
 
 // src/db/attachments.ts
+var attachments_exports = {};
+__export(attachments_exports, {
+  addAttachment: () => addAttachment,
+  addDraftAttachment: () => addDraftAttachment,
+  deleteAttachment: () => deleteAttachment,
+  deleteDraftAttachments: () => deleteDraftAttachments,
+  getAttachment: () => getAttachment,
+  getAttachments: () => getAttachments,
+  getDraftAttachments: () => getDraftAttachments,
+  listOrphanDraftAttachments: () => listOrphanDraftAttachments,
+  promoteDraftAttachments: () => promoteDraftAttachments
+});
 async function addAttachment(ticketId, originalFilename, storedPath) {
   const db = await getDb();
   const result = await db.query(
@@ -16030,14 +16061,30 @@ async function addAttachment(ticketId, originalFilename, storedPath) {
   );
   return result.rows[0];
 }
+async function addDraftAttachment(ticketId, draftId, originalFilename, storedPath) {
+  const db = await getDb();
+  const result = await db.query(
+    `INSERT INTO attachments (ticket_id, draft_id, original_filename, stored_path) VALUES ($1, $2, $3, $4) RETURNING *`,
+    [ticketId, draftId, originalFilename, storedPath]
+  );
+  return result.rows[0];
+}
 async function getAttachments(ticketId) {
   const db = await getDb();
   const result = await db.query(
-    `SELECT * FROM attachments WHERE ticket_id = $1 ORDER BY created_at ASC`,
+    `SELECT * FROM attachments WHERE ticket_id = $1 AND draft_id IS NULL ORDER BY created_at ASC`,
     [ticketId]
   );
   return result.rows;
 }
+async function getDraftAttachments(draftId) {
+  const db = await getDb();
+  const result = await db.query(
+    `SELECT * FROM attachments WHERE draft_id = $1 ORDER BY created_at ASC`,
+    [draftId]
+  );
+  return result.rows;
+}
 async function getAttachment(id) {
   const db = await getDb();
   const result = await db.query(
@@ -16054,6 +16101,36 @@ async function deleteAttachment(id) {
   );
   return result.rows[0] ?? null;
 }
+async function promoteDraftAttachments(draftId) {
+  const db = await getDb();
+  const result = await db.query(
+    `UPDATE attachments SET draft_id = NULL WHERE draft_id = $1 RETURNING *`,
+    [draftId]
+  );
+  return result.rows;
+}
+async function deleteDraftAttachments(draftId) {
+  const db = await getDb();
+  const result = await db.query(
+    `DELETE FROM attachments WHERE draft_id = $1 RETURNING *`,
+    [draftId]
+  );
+  return result.rows;
+}
+async function listOrphanDraftAttachments(olderThanMs) {
+  const db = await getDb();
+  const cutoff = new Date(Date.now() - olderThanMs).toISOString();
+  const result = await db.query(
+    `SELECT a.* FROM attachments a
+       LEFT JOIN feedback_drafts d ON d.id = a.draft_id
+      WHERE a.draft_id IS NOT NULL
+        AND d.id IS NULL
+        AND a.created_at < $1
+      ORDER BY a.created_at ASC`,
+    [cutoff]
+  );
+  return result.rows;
+}
 var init_attachments = __esm({
   "src/db/attachments.ts"() {
     "use strict";
@@ -16176,6 +16253,31 @@ function parseNotes(raw) {
   }
   return [{ id: generateNoteId(), text: raw, created_at: (/* @__PURE__ */ new Date()).toISOString() }];
 }
+function normalizeNotesAppend(raw) {
+  if (raw === "") return [];
+  const trimmed = raw.trimStart();
+  if (!trimmed.startsWith("[")) return [raw];
+  let parsed;
+  try {
+    parsed = JSON.parse(raw);
+  } catch {
+    return [raw];
+  }
+  if (!Array.isArray(parsed)) return [raw];
+  if (parsed.length === 0) return [raw];
+  const ALLOWED_KEYS = /* @__PURE__ */ new Set(["text", "id", "created_at"]);
+  const texts = [];
+  for (const entry of parsed) {
+    if (entry === null || typeof entry !== "object") return [raw];
+    const obj = entry;
+    if (typeof obj.text !== "string") return [raw];
+    for (const key of Object.keys(obj)) {
+      if (!ALLOWED_KEYS.has(key)) return [raw];
+    }
+    texts.push(obj.text);
+  }
+  return texts;
+}
 async function editNote(ticketId, noteId2, text) {
   const db = await getDb();
   const result = await db.query(`SELECT notes FROM tickets WHERE id = $1`, [ticketId]);
@@ -16485,12 +16587,18 @@ async function updateTicket(id, updates, options) {
     paramIdx++;
   }
   if (updates.notes !== void 0 && updates.notes !== "") {
-    const current = await db.query(`SELECT notes FROM tickets WHERE id = $1`, [id]);
-    const existing = parseNotes(current.rows[0]?.notes || "");
-    existing.push({ id: generateNoteId(), text: updates.notes, created_at: (/* @__PURE__ */ new Date()).toISOString() });
-    sets.push(`notes = $${paramIdx}`);
-    values.push(JSON.stringify(existing));
-    paramIdx++;
+    const bodies = normalizeNotesAppend(updates.notes);
+    if (bodies.length > 0) {
+      const current = await db.query(`SELECT notes FROM tickets WHERE id = $1`, [id]);
+      const existing = parseNotes(current.rows[0]?.notes || "");
+      const now = (/* @__PURE__ */ new Date()).toISOString();
+      for (const body of bodies) {
+        existing.push({ id: generateNoteId(), text: body, created_at: now });
+      }
+      sets.push(`notes = $${paramIdx}`);
+      values.push(JSON.stringify(existing));
+      paramIdx++;
+    }
   }
   if (updates.status === "completed") {
     sets.push("completed_at = NOW()");
@@ -16871,6 +16979,7 @@ var init_tickets = __esm({
 var queries_exports = {};
 __export(queries_exports, {
   addAttachment: () => addAttachment,
+  addDraftAttachment: () => addDraftAttachment,
   addLogEntry: () => addLogEntry,
   batchDeleteTickets: () => batchDeleteTickets,
   batchRestoreTickets: () => batchRestoreTickets,
@@ -16879,6 +16988,7 @@ __export(queries_exports, {
   countSearchMatchesInExcludedStatuses: () => countSearchMatchesInExcludedStatuses,
   createTicket: () => createTicket,
   deleteAttachment: () => deleteAttachment,
+  deleteDraftAttachments: () => deleteDraftAttachments,
   deleteNote: () => deleteNote,
   deleteTicket: () => deleteTicket,
   duplicateTickets: () => duplicateTickets,
@@ -16890,6 +17000,7 @@ __export(queries_exports, {
   getAttachment: () => getAttachment,
   getAttachments: () => getAttachments,
   getCategories: () => getCategories,
+  getDraftAttachments: () => getDraftAttachments,
   getLogCount: () => getLogCount,
   getLogEntries: () => getLogEntries,
   getSettings: () => getSettings,
@@ -16901,8 +17012,11 @@ __export(queries_exports, {
   hardDeleteTicket: () => hardDeleteTicket,
   isExactTicketIdSearch: () => isExactTicketIdSearch,
   listKnownTicketPrefixes: () => listKnownTicketPrefixes,
+  listOrphanDraftAttachments: () => listOrphanDraftAttachments,
   nextTicketNumber: () => nextTicketNumber,
+  normalizeNotesAppend: () => normalizeNotesAppend,
   parseNotes: () => parseNotes,
+  promoteDraftAttachments: () => promoteDraftAttachments,
   pruneLog: () => pruneLog,
   queryTickets: () => queryTickets,
   restoreTicket: () => restoreTicket,
@@ -24274,13 +24388,13 @@ import { pathToFileURL as pathToFileURL2 } from "url";
 // src/cleanup.ts
 init_queries();
 import { rmSync as rmSync4 } from "fs";
+var ORPHAN_DRAFT_ATTACHMENT_HORIZON_MS = 7 * 24 * 60 * 60 * 1e3;
 async function cleanupAttachments() {
   try {
     const settings = await getSettings();
     const verifiedDays = parseInt(settings.verified_cleanup_days, 10) || 30;
     const trashDays = parseInt(settings.trash_cleanup_days, 10) || 3;
     const tickets = await getTicketsForCleanup(verifiedDays, trashDays);
-    if (tickets.length === 0) return;
     let archived = 0;
     let deleted = 0;
     for (const ticket of tickets) {
@@ -24299,10 +24413,21 @@ async function cleanupAttachments() {
         deleted++;
       }
     }
-    if (archived > 0 || deleted > 0) {
+    let orphans = 0;
+    const orphanList = await listOrphanDraftAttachments(ORPHAN_DRAFT_ATTACHMENT_HORIZON_MS);
+    for (const att of orphanList) {
+      try {
+        rmSync4(att.stored_path, { force: true });
+      } catch {
+      }
+      await deleteAttachment(att.id);
+      orphans++;
+    }
+    if (archived > 0 || deleted > 0 || orphans > 0) {
       const parts = [];
       if (archived > 0) parts.push(`archived ${archived} verified ticket(s)`);
       if (deleted > 0) parts.push(`deleted ${deleted} trashed ticket(s)`);
+      if (orphans > 0) parts.push(`GC'd ${orphans} orphan draft attachment(s)`);
       console.log(`  Cleanup: ${parts.join(", ")}.`);
     }
   } catch (err) {
@@ -24668,6 +24793,43 @@ attachmentRoutes.post("/tickets/:id/attachments", async (c) => {
   notifyMutation(c.get("dataDir"));
   return c.json(attachment, 201);
 });
+attachmentRoutes.post("/tickets/:id/feedback-drafts/:draftId/attachments", async (c) => {
+  const id = parseIntParam(c, "id");
+  if (id === null) return c.json({ error: "Invalid attachment ticket ID" }, 400);
+  const draftId = c.req.param("draftId");
+  if (draftId === "") return c.json({ error: "Invalid draft ID" }, 400);
+  const ticket = await getTicket(id);
+  if (!ticket) return c.json({ error: "Ticket not found" }, 404);
+  const dataDir = c.get("dataDir");
+  const body = await c.req.parseBody();
+  const file2 = body["file"];
+  if (typeof file2 === "string") return c.json({ error: "No file uploaded" }, 400);
+  const originalName = file2.name;
+  const ext = extname(originalName);
+  const baseName = basename3(originalName, ext);
+  const storedName = `${ticket.ticket_number}_draft_${draftId}_${baseName}${ext}`;
+  const attachDir = join22(dataDir, "attachments");
+  mkdirSync10(attachDir, { recursive: true });
+  const storedPath = join22(attachDir, storedName);
+  const buffer = Buffer.from(await file2.arrayBuffer());
+  const { writeFileSync: writeFileSync17 } = await import("fs");
+  writeFileSync17(storedPath, buffer);
+  const attachment = await addDraftAttachment(id, draftId, originalName, storedPath);
+  notifyMutation(dataDir);
+  return c.json(attachment, 201);
+});
+attachmentRoutes.post("/tickets/:id/feedback-drafts/:draftId/promote-attachments", async (c) => {
+  const id = parseIntParam(c, "id");
+  if (id === null) return c.json({ error: "Invalid ticket ID" }, 400);
+  const draftId = c.req.param("draftId");
+  if (draftId === "") return c.json({ error: "Invalid draft ID" }, 400);
+  const ticket = await getTicket(id);
+  if (!ticket) return c.json({ error: "Ticket not found" }, 404);
+  const { promoteDraftAttachments: promoteDraftAttachments2 } = await Promise.resolve().then(() => (init_attachments(), attachments_exports));
+  const promoted = await promoteDraftAttachments2(draftId);
+  notifyMutation(c.get("dataDir"));
+  return c.json({ promoted: promoted.length, attachments: promoted });
+});
 attachmentRoutes.delete("/attachments/:id", async (c) => {
   const id = parseIntParam(c, "id");
   if (id === null) return c.json({ error: "Invalid attachment ID" }, 400);
@@ -25238,7 +25400,7 @@ function coerceFreezeEntry(raw) {
   if (raw === null || typeof raw !== "object") return null;
   const r = raw;
   const source = r.source;
-  if (source !== "client-observer" && source !== "client-heartbeat") return null;
+  if (source !== "client-observer" && source !== "client-heartbeat" && source !== "client-server-busy-banner") return null;
   const durationMs = r.durationMs;
   if (typeof durationMs !== "number" || !Number.isFinite(durationMs) || durationMs < 0) return null;
   const context = typeof r.context === "string" ? r.context : "";
@@ -25562,7 +25724,12 @@ ticketRoutes.get("/tickets/:id/feedback-drafts", async (c) => {
   if (id === null) return c.json({ error: "Invalid ticket ID" }, 400);
   const { listFeedbackDrafts: listFeedbackDrafts2 } = await Promise.resolve().then(() => (init_feedbackDrafts(), feedbackDrafts_exports));
   const drafts = await listFeedbackDrafts2(id);
-  return c.json(drafts);
+  const { getDraftAttachments: getDraftAttachments2 } = await Promise.resolve().then(() => (init_attachments(), attachments_exports));
+  const hydrated = await Promise.all(drafts.map(async (d) => ({
+    ...d,
+    attachments: await getDraftAttachments2(d.id)
+  })));
+  return c.json(hydrated);
 });
 ticketRoutes.post("/tickets/:id/feedback-drafts", async (c) => {
   const id = parseIntParam(c);
@@ -25599,10 +25766,18 @@ ticketRoutes.delete("/tickets/:id/feedback-drafts/:draftId", async (c) => {
   if (id === null) return c.json({ error: "Invalid ticket ID" }, 400);
   const draftId = c.req.param("draftId");
   const { deleteFeedbackDraft: deleteFeedbackDraft2 } = await Promise.resolve().then(() => (init_feedbackDrafts(), feedbackDrafts_exports));
+  const { deleteDraftAttachments: deleteDraftAttachments2 } = await Promise.resolve().then(() => (init_attachments(), attachments_exports));
+  const droppedAttachments = await deleteDraftAttachments2(draftId);
+  for (const att of droppedAttachments) {
+    try {
+      rmSync10(att.stored_path, { force: true });
+    } catch {
+    }
+  }
   const deleted = await deleteFeedbackDraft2(draftId);
-  if (!deleted) return c.json({ error: "Not found" }, 404);
+  if (!deleted && droppedAttachments.length === 0) return c.json({ error: "Not found" }, 404);
   notifyMutation(c.get("dataDir"));
-  return c.json({ ok: true });
+  return c.json({ ok: true, droppedAttachments: droppedAttachments.length });
 });
 ticketRoutes.delete("/tickets/:id/hard", async (c) => {
   const id = parseIntParam(c);