hop2 0.11.78 → 0.11.80

package/hay/apps/server/src/rooms.ts

@@ -1226,7 +1226,7 @@ export class Room extends EventEmitter {
    * With a client attached, the real terminal answers and we stay silent.
    */
   private answerTerminalQueriesIfHeadless(data: string) {
-    if (this.clients.size > 0 || this.ended) return;
+    if (this.ended) return;
     if (data.indexOf("\x1b") === -1) return;
     let reply = "";
     // OSC 10/11: foreground / background color queries — answered with the
@@ -1234,12 +1234,29 @@ export class Room extends EventEmitter {
     // background (Claude Code picks light vs dark this way) matches what the
     // user is really looking at. Falls back to the dark default before any
     // client has ever attached.
+    //
+    // Answered even while browsers are attached: the web terminal swallows
+    // OSC 10/11 without replying, so "a client will answer" was never true
+    // for them, and a Codex started with a tile or a viewer open got no
+    // reply — it fell back to its dark palette and an unshaded input box
+    // (alphagenome, 2026-10-15). Only a local CLI attach sits in a real
+    // terminal that answers for itself.
+    const answersColors = [...this.clients.values()].some((client) => client.source === "local-cli");
     const osc = (n: number, hex: string) => {
       const p = (i: number) => hex.slice(i, i + 2).repeat(2);
       return `\x1b]${n};rgb:${p(0)}/${p(2)}/${p(4)}\x1b\\`;
     };
-    if (/\x1b\]10;\?(?:\x07|\x1b\\)/.test(data)) reply += osc(10, this.clientFg);
-    if (/\x1b\]11;\?(?:\x07|\x1b\\)/.test(data)) reply += osc(11, this.clientBg);
+    if (!answersColors) {
+      if (/\x1b\]10;\?(?:\x07|\x1b\\)/.test(data)) reply += osc(10, this.clientFg);
+      if (/\x1b\]11;\?(?:\x07|\x1b\\)/.test(data)) reply += osc(11, this.clientBg);
+    }
+    // The rest xterm.js answers itself, so only a room nobody watches does.
+    if (this.clients.size > 0) {
+      if (reply) {
+        try { this.pty.write(reply); } catch { /* pty gone */ }
+      }
+      return;
+    }
     // DA1: identify as a VT220-class terminal (matches xterm.js's own reply).
     if (/\x1b\[0?c/.test(data)) reply += "\x1b[?62;22c";
     // DSR 5 (status): "OK".

package/hay/apps/server/test/rooms.test.ts

@@ -647,7 +647,7 @@ describe("Room", () => {
   });
 
   describe("headless terminal-identity answers", () => {
-    it("answers color/DA/truecolor probes only while no client is attached", () => {
+    it("answers DA/truecolor probes only while no client is attached; colors whenever no real terminal is", () => {
       let ptyInstance: FakePty | null = null;
       const factory: PtyFactory = () => {
         ptyInstance = new FakePty() as unknown as FakePty;
@@ -663,9 +663,19 @@ describe("Room", () => {
       expect(answered).toContain("[?62;22c");
       expect(answered).toContain("P1+r524742");
 
-      // Attached: the real terminal answers; the room stays silent.
+      // A browser attached: xterm.js answers DA itself, but swallows OSC
+      // 10/11 without replying — the room still answers the color, or a
+      // Codex started under a viewer gets no reply and goes dark.
       room.attachClient({ id: "a", name: "Alex", colorIndex: 0, cols: 80, rows: 24 }, new FakeSocket());
       ptyInstance!.writes.length = 0;
+      ptyInstance!.emit("\x1b]11;?\x07 \x1b[0c");
+      const withBrowser = ptyInstance!.writes.join("");
+      expect(withBrowser).toContain("]11;rgb:0d0d/1111/1717");
+      expect(withBrowser).not.toContain("[?62;22c");
+
+      // A local CLI attach sits in a real terminal that answers for itself.
+      room.attachClient({ id: "c", name: "cli", colorIndex: 1, cols: 80, rows: 24, source: "local-cli" }, new FakeSocket());
+      ptyInstance!.writes.length = 0;
       ptyInstance!.emit("\x1b]11;?\x07");
       expect(ptyInstance!.writes.join("")).toBe("");
     });

package/hay/apps/web/src/App.tsx

@@ -4351,6 +4351,8 @@ const App = () => {
             onOpenCheckbacks={(scope) => setCheckbacksOpen(scope)}
             userName={name}
             terminalTheme={resolveTerminalTheme(themeMode)}
+            themeMode={themeMode}
+            onThemeChange={setThemeMode}
           />
           {toast && <div className="terminal-toast" role="status" aria-live="polite">{toast}</div>}
         </main>
@@ -5016,6 +5018,8 @@ const App = () => {
             onOpenCheckbacks={(scope) => setCheckbacksOpen(scope)}
             userName={name}
             terminalTheme={resolveTerminalTheme(themeMode)}
+            themeMode={themeMode}
+            onThemeChange={setThemeMode}
             onOpenSettings={() => {
               setSwitcherOpen(false);
               setDrawerOpen(true);

package/hay/apps/web/src/components/SessionSwitcher.tsx

@@ -113,6 +113,10 @@ type Props = {
   userName?: string;
   terminalTheme?: object;
   onOpenSettings?: () => void;
+  // The page theme, switchable straight from the wall: the settings drawer
+  // lives in the full-screen view, and the hub (no session open) has none.
+  themeMode?: "system" | "light" | "dark";
+  onThemeChange?: (mode: "system" | "light" | "dark") => void;
   onToggleKeyboard?: () => void;
   onFind?: () => void;
   // Open the Views panel. No argument = the whole fleet (header button); an
@@ -1299,6 +1303,8 @@ export const SessionSwitcher = ({
   userName,
   terminalTheme,
   onOpenSettings,
+  themeMode,
+  onThemeChange,
   onToggleKeyboard,
   onFind,
   onOpenViews,
@@ -3344,6 +3350,18 @@ export const SessionSwitcher = ({
                 : (() => { const n = visibleSessions.reduce((k, s) => k + (s.views?.count || 0), 0); return n > 0 ? <span className="views-entry-count">{n}</span> : null; })()}
             </button>
           )}
+          {onThemeChange && themeMode && (() => {
+            const next = themeMode === "system" ? "light" : themeMode === "light" ? "dark" : "system";
+            const label = (m: string) => (m === "system" ? "Auto" : m === "light" ? "Light" : "Dark");
+            return (
+              <button type="button" className="switcher-action theme-entry" onClick={() => onThemeChange(next)}
+                      aria-label={`Theme: ${label(themeMode)} — switch to ${label(next)}`}
+                      title={`Theme: ${label(themeMode)} — click for ${label(next)}`}>
+                <span aria-hidden="true">{themeMode === "light" ? "☀" : themeMode === "dark" ? "☾" : "◐"}</span>
+                {label(themeMode)}
+              </button>
+            );
+          })()}
           {onOpenSettings && (
             <button type="button" className="switcher-action" aria-label="Settings" title="Settings" onClick={onOpenSettings}>
               <svg width="16" height="16" viewBox="0 0 24 24" fill="none" stroke="currentColor" strokeWidth="2" strokeLinecap="round" strokeLinejoin="round">

package/hay/apps/web/src/styles.css

@@ -4889,6 +4889,9 @@ body.pane-dragging { user-select: none; }
 }
 .views-entry-count.fresh { background: var(--accent, #7c5cff); color: #fff; }
 .switcher-action.views-entry { width: auto; padding: 0 10px; gap: 6px; font-size: 12.5px; font-weight: 600; }
+/* The theme button carries a word too ("Light"), so it sizes like Views
+   rather than the 32px icon square. */
+.switcher-action.theme-entry { width: auto; padding: 0 10px; gap: 6px; font-size: 12.5px; font-weight: 600; white-space: nowrap; }
 
 /* The switcher's header action is a fixed 32px square with a centred glyph —
    an inline dot would shove the icon off-centre, so it rides the corner. */

package/hop

@@ -11917,6 +11917,7 @@ happens until someone clicks it.
                 }
                 res.writeHead(206, {
                     'Content-Type': viewType,
+                    'Content-Disposition': `inline; filename*=UTF-8''${encodeURIComponent(path.basename(target))}`,
                     'Content-Length': end - start + 1,
                     'Content-Range': `bytes ${start}-${end}/${viewSize}`,
                     'Accept-Ranges': 'bytes'
@@ -11929,9 +11930,10 @@ happens until someone clicks it.
             // anything else in them.
             const downloadName = path.basename(target);
             const asciiName = downloadName.replace(/[^\x20-\x7e]/g, '_').replace(/["\\]/g, '_');
-            const disposition = wantDownload
-                ? { 'Content-Disposition': `attachment; filename="${asciiName}"; filename*=UTF-8''${encodeURIComponent(downloadName)}` }
-                : {};
+            // Inline still names the file: a type the browser can't show
+            // (pptx, zip, octet-stream) is saved anyway, and without a name it
+            // took the URL's last segment — every such download read "inline".
+            const disposition = { 'Content-Disposition': `${wantDownload ? 'attachment' : 'inline'}; filename="${asciiName}"; filename*=UTF-8''${encodeURIComponent(downloadName)}` };
             res.writeHead(200, {
                 ...disposition,
                 'Content-Type': viewType,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "hop2",
-  "version": "0.11.78",
+  "version": "0.11.80",
   "description": "🐰 Hop into your terminal from anywhere. Secure remote shell access with 2FA via Cloudflare Tunnel. Next-gen rewrite with native terminal sharing.",
   "main": "hop",
   "bin": {

package/tests/terminal-api.integration.test.cjs

@@ -870,6 +870,33 @@ test('fork falls past a poisoned record cwd to the durable one', async () => {
 });
 
 
+// A view the browser cannot display (pptx, zip) is saved instead of shown.
+// Opening it must still name the file — without a Content-Disposition name
+// the browser took the URL's last segment and every download read "inline".
+test('a view keeps its file name when opened, downloaded or range-read', async () => {
+  const dir = path.join(hopHome, 'views', 'nameprobe');
+  await fs.mkdir(dir, { recursive: true });
+  await fs.writeFile(path.join(dir, 'deck v2.pptx'), Buffer.alloc(64, 1));
+  const head = (reqPath, extra = {}) => new Promise((resolve, reject) => {
+    const req = http.request({ hostname: '127.0.0.1', port: state.port, path: reqPath, method: 'GET',
+      headers: { Authorization: `Bearer ${state.sessionSecret}`, ...extra } }, (res) => {
+      res.resume(); res.on('end', () => resolve({ status: res.statusCode, headers: res.headers }));
+    });
+    req.on('error', reject); req.end();
+  });
+  const base = '/view/nameprobe/' + encodeURIComponent('deck v2.pptx');
+  const opened = await head(base + '/inline');
+  assert.equal(opened.status, 200);
+  assert.match(opened.headers['content-disposition'] || '', /^inline;.*filename\*=UTF-8''deck%20v2\.pptx/);
+  const saved = await head(base + '/download');
+  assert.match(saved.headers['content-disposition'] || '', /^attachment;.*filename="deck v2\.pptx"/);
+  const ranged = await head(base + '/inline', { Range: 'bytes=0-9' });
+  assert.equal(ranged.status, 206);
+  assert.match(ranged.headers['content-disposition'] || '', /deck%20v2\.pptx/);
+  await fs.rm(dir, { recursive: true, force: true });
+});
+
+
 // "Continue in fresh Claude": the same agent, started over from the
 // condensed trajectory instead of resuming the full history. The new session
 // runs the SOURCE's claude launch (a fake one here, so no real agent starts)