hone-ai 0.5.0 → 0.10.0

package/src/agent.ts

@@ -1,21 +1,21 @@
-import { spawn, type ChildProcess } from 'child_process';
-import type { AgentType } from './config';
-import { exitWithError, ErrorMessages } from './errors';
-import { logVerbose, logVerboseError } from './logger';
+import { spawn, type ChildProcess } from 'child_process'
+import type { AgentType } from './config'
+import { exitWithError, ErrorMessages } from './errors'
+import { logVerbose, logVerboseError } from './logger'
 
 export interface SpawnAgentOptions {
-  agent: AgentType;
-  prompt: string;
-  workingDir?: string;
-  model?: string;
-  silent?: boolean;
-  timeout?: number; // Timeout in milliseconds
+  agent: AgentType
+  prompt: string
+  workingDir?: string
+  model?: string
+  silent?: boolean
+  timeout?: number // Timeout in milliseconds
 }
 
 export interface SpawnAgentResult {
-  exitCode: number;
-  stdout: string;
-  stderr: string;
+  exitCode: number
+  stdout: string
+  stderr: string
 }
 
 /**
@@ -24,155 +24,155 @@ export interface SpawnAgentResult {
  * @returns Promise resolving to exit code and captured output
  */
 export async function spawnAgent(options: SpawnAgentOptions): Promise<SpawnAgentResult> {
-  const { agent, prompt, workingDir = process.cwd(), model, silent = false, timeout } = options;
-  
+  const { agent, prompt, workingDir = process.cwd(), model, silent = false, timeout } = options
+
   // Log agent spawn initiation
-  logVerbose(`[Agent] Spawning ${agent} agent${model ? ` with model ${model}` : ''}`);
-  logVerbose(`[Agent] Working directory: ${workingDir}`);
-  
+  logVerbose(`[Agent] Spawning ${agent} agent${model ? ` with model ${model}` : ''}`)
+  logVerbose(`[Agent] Working directory: ${workingDir}`)
+
   // Build command and args based on agent type
   // opencode: opencode run [--model anthropic/<model>] "prompt text"
   // claude: claude -p "prompt text" [--model <model>]
-  const command = agent === 'opencode' ? 'opencode' : 'claude';
-  const args: string[] = [];
-  
+  const command = agent === 'opencode' ? 'opencode' : 'claude'
+  const args: string[] = []
+
   if (agent === 'opencode') {
-    args.push('run');
+    args.push('run')
     if (model) {
-      args.push('--model', `anthropic/${model}`);
+      args.push('--model', `anthropic/${model}`)
     }
-    args.push(prompt);
+    args.push(prompt)
   } else {
-    args.push('-p', prompt);
+    args.push('-p', prompt)
     if (model) {
-      args.push('--model', model);
+      args.push('--model', model)
     }
   }
-  
+
   // Log command being executed
-  const cmdString = `${command} ${args.slice(0, -1).join(' ')} "<prompt>"`;
-  logVerbose(`[Agent] Command: ${cmdString}`);
-  
+  const cmdString = `${command} ${args.slice(0, -1).join(' ')} "<prompt>"`
+  logVerbose(`[Agent] Command: ${cmdString}`)
+
   return new Promise((resolve, reject) => {
     const child: ChildProcess = spawn(command, args, {
       cwd: workingDir,
-      stdio: ['inherit', 'pipe', 'pipe']
-    });
-    
-    let stdout = '';
-    let stderr = '';
-    let isKilled = false;
-    let timeoutId: NodeJS.Timeout | undefined;
-    
+      stdio: ['inherit', 'pipe', 'pipe'],
+    })
+
+    let stdout = ''
+    let stderr = ''
+    let isKilled = false
+    let timeoutId: NodeJS.Timeout | undefined
+
     // Stream stdout to console and capture
     if (child.stdout) {
       child.stdout.on('data', (data: Buffer) => {
-        const text = data.toString();
+        const text = data.toString()
         if (!silent) {
-          process.stdout.write(text);
+          process.stdout.write(text)
         }
-        stdout += text;
-      });
+        stdout += text
+      })
     }
-    
+
     // Stream stderr to console and capture
     if (child.stderr) {
       child.stderr.on('data', (data: Buffer) => {
-        const text = data.toString();
+        const text = data.toString()
         if (!silent) {
-          process.stderr.write(text);
+          process.stderr.write(text)
         }
-        stderr += text;
-      });
+        stderr += text
+      })
     }
-    
+
     // Set up timeout if specified
     if (timeout && timeout > 0) {
       timeoutId = setTimeout(() => {
         if (!isKilled && child.pid) {
-          logVerboseError(`[Agent] Process timed out after ${timeout}ms, killing...`);
-          isKilled = true;
+          logVerboseError(`[Agent] Process timed out after ${timeout}ms, killing...`)
+          isKilled = true
           try {
-            process.kill(-child.pid, 'SIGTERM');
+            process.kill(-child.pid, 'SIGTERM')
           } catch (err) {
-            child.kill('SIGTERM');
+            child.kill('SIGTERM')
           }
         }
-      }, timeout);
+      }, timeout)
     }
 
     // Handle SIGINT (ctrl+c) and SIGTERM to kill child process
     const handleSignal = (signal: NodeJS.Signals) => {
       if (!isKilled && child.pid) {
-        isKilled = true;
+        isKilled = true
         if (timeoutId) {
-          clearTimeout(timeoutId);
-          timeoutId = undefined;
+          clearTimeout(timeoutId)
+          timeoutId = undefined
         }
         // Kill the child process group
         try {
-          process.kill(-child.pid, signal);
+          process.kill(-child.pid, signal)
         } catch (err) {
           // Fallback to killing just the child
-          child.kill(signal);
+          child.kill(signal)
         }
       }
-    };
-    
-    process.on('SIGINT', handleSignal);
-    process.on('SIGTERM', handleSignal);
-    
+    }
+
+    process.on('SIGINT', handleSignal)
+    process.on('SIGTERM', handleSignal)
+
     // Handle process exit
     child.on('close', (code: number | null) => {
       // Clean up signal handlers and timeout
-      process.off('SIGINT', handleSignal);
-      process.off('SIGTERM', handleSignal);
+      process.off('SIGINT', handleSignal)
+      process.off('SIGTERM', handleSignal)
       if (timeoutId) {
-        clearTimeout(timeoutId);
-        timeoutId = undefined;
+        clearTimeout(timeoutId)
+        timeoutId = undefined
       }
-      
-      const exitCode = code ?? 1;
-      
+
+      const exitCode = code ?? 1
+
       // Check if process was killed due to timeout
       if (isKilled && timeout) {
-        logVerboseError(`[Agent] Process was terminated due to timeout (${timeout}ms)`);
+        logVerboseError(`[Agent] Process was terminated due to timeout (${timeout}ms)`)
         resolve({
           exitCode: 124, // Standard timeout exit code
           stdout,
-          stderr: stderr + '\nProcess timed out'
-        });
-        return;
+          stderr: stderr + '\nProcess timed out',
+        })
+        return
       }
-      
+
       // Log completion status
       if (exitCode === 0) {
-        logVerbose(`[Agent] Process completed successfully (exit code 0)`);
+        logVerbose(`[Agent] Process completed successfully (exit code 0)`)
       } else {
-        logVerboseError(`[Agent] Process exited with code ${exitCode}`);
+        logVerboseError(`[Agent] Process exited with code ${exitCode}`)
       }
-      
+
       resolve({
         exitCode,
         stdout,
-        stderr
-      });
-    });
-    
+        stderr,
+      })
+    })
+
     // Handle spawn errors (e.g., command not found)
     child.on('error', (error: Error) => {
       // Clean up signal handlers and timeout
-      process.off('SIGINT', handleSignal);
-      process.off('SIGTERM', handleSignal);
+      process.off('SIGINT', handleSignal)
+      process.off('SIGTERM', handleSignal)
       if (timeoutId) {
-        clearTimeout(timeoutId);
-        timeoutId = undefined;
+        clearTimeout(timeoutId)
+        timeoutId = undefined
       }
-      
-      logVerboseError(`[Agent] Spawn error: ${error.message}`);
-      reject(new Error(`Failed to spawn ${agent}: ${error.message}`));
-    });
-  });
+
+      logVerboseError(`[Agent] Spawn error: ${error.message}`)
+      reject(new Error(`Failed to spawn ${agent}: ${error.message}`))
+    })
+  })
 }
 
 /**
@@ -181,19 +181,19 @@ export async function spawnAgent(options: SpawnAgentOptions): Promise<SpawnAgent
  * @returns Promise resolving to true if agent is available
  */
 export async function isAgentAvailable(agent: AgentType): Promise<boolean> {
-  const command = agent === 'opencode' ? 'opencode' : 'claude';
-  
-  return new Promise((resolve) => {
+  const command = agent === 'opencode' ? 'opencode' : 'claude'
+
+  return new Promise(resolve => {
     const child = spawn(command === 'opencode' ? 'which' : 'which', [command], {
-      stdio: 'ignore'
-    });
-    
+      stdio: 'ignore',
+    })
+
     child.on('close', (code: number | null) => {
-      resolve(code === 0);
-    });
-    
+      resolve(code === 0)
+    })
+
     child.on('error', () => {
-      resolve(false);
-    });
-  });
+      resolve(false)
+    })
+  })
 }

package/src/agents-md-generator.test.ts

@@ -0,0 +1,360 @@
+import { describe, expect, test, beforeEach, afterEach, mock } from 'bun:test'
+import { generateAgentsMd, AGENTS_DOCS_DIR } from './agents-md-generator'
+import type { AgentsMdGeneratorOptions, GenerationResult } from './agents-md-generator'
+import { existsSync, mkdirSync, rmSync } from 'fs'
+import { join } from 'path'
+import * as fs from 'fs/promises'
+
+// Mock AgentClient
+import { AgentClient } from './agent-client'
+
+const mockAgentResponse = {
+  content: [
+    {
+      type: 'text' as const,
+      text: 'PRIMARY LANGUAGES: JavaScript, TypeScript\nUSAGE CONTEXT: TypeScript for main application code, JavaScript for configuration files',
+    },
+  ],
+}
+
+const mockAgentClient = {
+  messages: {
+    create: mock(async () => mockAgentResponse),
+  },
+}
+
+// Mock the AgentClient constructor
+mock.module('./agent-client', () => ({
+  AgentClient: mock(() => mockAgentClient),
+}))
+
+// Test workspace setup
+const TEST_WORKSPACE = join(process.cwd(), '.test-agents-md-workspace')
+const originalCwd = process.cwd()
+
+// Mock console and logger functions
+const originalLog = console.log
+const originalError = console.error
+let logCalls: string[] = []
+let errorCalls: string[] = []
+
+beforeEach(() => {
+  // Reset call tracking
+  logCalls = []
+  errorCalls = []
+
+  // Create isolated test workspace
+  if (existsSync(TEST_WORKSPACE)) {
+    rmSync(TEST_WORKSPACE, { recursive: true, force: true })
+  }
+  mkdirSync(TEST_WORKSPACE, { recursive: true })
+
+  // Change to test workspace
+  process.chdir(TEST_WORKSPACE)
+
+  // Mock console functions
+  console.log = mock((message: string) => {
+    logCalls.push(message)
+  })
+
+  console.error = mock((message: string) => {
+    errorCalls.push(message)
+  })
+})
+
+afterEach(() => {
+  // Restore console functions
+  console.log = originalLog
+  console.error = originalError
+
+  // Return to original directory and clean up
+  process.chdir(originalCwd)
+  if (existsSync(TEST_WORKSPACE)) {
+    rmSync(TEST_WORKSPACE, { recursive: true, force: true })
+  }
+})
+
+describe('agents-md-generator', () => {
+  test('generateAgentsMd returns proper result structure', async () => {
+    const result: GenerationResult = await generateAgentsMd()
+
+    expect(result).toHaveProperty('success')
+    expect(result).toHaveProperty('filesCreated')
+    expect(typeof result.success).toBe('boolean')
+    expect(Array.isArray(result.filesCreated)).toBe(true)
+  })
+
+  test('generateAgentsMd generates content with basic project analysis', async () => {
+    const result: GenerationResult = await generateAgentsMd()
+
+    if (result.success && result.mainFilePath) {
+      expect(existsSync(result.mainFilePath)).toBe(true)
+      const content = await fs.readFile(result.mainFilePath, 'utf-8')
+      expect(content).toContain('# AGENTS.md')
+      expect(content).toContain('## Project Overview')
+      expect(content).toContain('## Build System')
+    }
+  })
+
+  test('generateAgentsMd accepts custom project path', async () => {
+    const options: AgentsMdGeneratorOptions = {
+      projectPath: process.cwd(),
+    }
+
+    const result = await generateAgentsMd(options)
+    expect(typeof result.success).toBe('boolean')
+  })
+
+  test('generateAgentsMd respects overwrite option when file exists', async () => {
+    // First generation should succeed
+    const firstResult = await generateAgentsMd()
+    expect(firstResult.success).toBe(true)
+
+    // Second generation without overwrite should fail
+    const secondResult = await generateAgentsMd()
+    expect(secondResult.success).toBe(false)
+    expect(secondResult.error?.message).toContain('already exists')
+
+    // Third generation with overwrite should succeed
+    const thirdResult = await generateAgentsMd({ overwrite: true })
+    expect(thirdResult.success).toBe(true)
+  })
+
+  test('generateAgentsMd handles errors gracefully', async () => {
+    // Test with invalid project path
+    const result = await generateAgentsMd({ projectPath: '/nonexistent/path' })
+
+    // Should handle errors gracefully and return error result
+    if (!result.success) {
+      expect(result.error).toBeInstanceOf(Error)
+    }
+  })
+
+  test('generateAgentsMd outputs expected log messages', async () => {
+    await generateAgentsMd()
+
+    expect(logCalls.some(msg => msg.includes('Phase 1: Project Analysis'))).toBe(true)
+    expect(logCalls.some(msg => msg.includes('✓ Generated AGENTS.md'))).toBe(true)
+  })
+
+  test(`generateAgentsMd creates ${AGENTS_DOCS_DIR}/ directory when content exceeds 100 lines`, async () => {
+    // Mock a response that will generate a very long output
+    const longMockResponse = {
+      content: [
+        {
+          type: 'text' as const,
+          text:
+            'PRIMARY LANGUAGES: JavaScript, TypeScript, Python, Java, Go, Rust, PHP, Ruby, C++, C#, Swift, Kotlin, Scala, Clojure, Elixir, Erlang, Haskell, OCaml, F#, R, MATLAB, Lua, Perl, Shell\n'.repeat(
+              20
+            ) +
+            'This is a very detailed analysis that will definitely exceed the 100-line limit when combined with other sections. ' +
+            'It includes extensive information about the project structure, dependencies, build systems, testing frameworks, and deployment strategies. ' +
+            `The content is intentionally verbose to trigger the ${AGENTS_DOCS_DIR}/ subdirectory creation logic.`,
+        },
+      ],
+    }
+
+    // Mock agent client to return long content
+    const longMockAgentClient = {
+      messages: {
+        create: mock(async () => longMockResponse),
+      },
+    }
+
+    // Replace the mock temporarily
+    const originalMock = mockAgentClient.messages.create
+    mockAgentClient.messages.create = longMockAgentClient.messages.create
+
+    const result = await generateAgentsMd()
+
+    // Restore original mock
+    mockAgentClient.messages.create = originalMock
+
+    expect(result.success).toBe(true)
+
+    // Check if ${AGENTS_DOCS_DIR}/ directory was created
+    if (result.agentsDirPath) {
+      expect(existsSync(result.agentsDirPath)).toBe(true)
+      expect(result.filesCreated.length).toBeGreaterThan(1) // Main file + detail files
+      expect(logCalls.some(msg => msg.includes('exceeds 100-line limit'))).toBe(true)
+      expect(logCalls.some(msg => msg.includes('✓ Created') && msg.includes('detail files'))).toBe(
+        true
+      )
+    }
+  })
+
+  test(`generateAgentsMd creates compact content with references when using ${AGENTS_DOCS_DIR}/ directory`, async () => {
+    // Create a package.json with many dependencies to ensure we have content
+    await fs.writeFile(
+      'package.json',
+      JSON.stringify({
+        name: 'test-project',
+        scripts: { build: 'tsc', test: 'jest' },
+        dependencies: {
+          react: '^18.0.0',
+          typescript: '^5.0.0',
+          jest: '^29.0.0',
+          express: '^4.18.0',
+        },
+      }),
+      'utf-8'
+    )
+
+    const result = await generateAgentsMd()
+    expect(result.success).toBe(true)
+
+    if (result.mainFilePath) {
+      const content = await fs.readFile(result.mainFilePath, 'utf-8')
+
+      // Should contain section headers
+      expect(content).toContain('## Project Overview')
+      expect(content).toContain('## Build System')
+
+      // If ${AGENTS_DOCS_DIR}/ directory was used, should contain references
+      if (result.agentsDirPath && existsSync(result.agentsDirPath)) {
+        expect(content).toContain(AGENTS_DOCS_DIR)
+        expect(content).toContain('for detailed information')
+
+        // Check that detail files were created
+        const detailFiles = ['languages.md', 'build.md']
+        for (const file of detailFiles) {
+          const detailPath = join(result.agentsDirPath, file)
+          if (existsSync(detailPath)) {
+            const detailContent = await fs.readFile(detailPath, 'utf-8')
+            expect(detailContent).toContain('# ')
+            expect(detailContent).toContain('part of the AGENTS.md documentation system')
+          }
+        }
+      }
+    }
+  })
+
+  test('generateAgentsMd handles project with TypeScript configuration', async () => {
+    // Create TypeScript project files
+    await fs.writeFile(
+      'tsconfig.json',
+      JSON.stringify({
+        compilerOptions: {
+          target: 'ES2020',
+          module: 'commonjs',
+          strict: true,
+        },
+      }),
+      'utf-8'
+    )
+
+    await fs.writeFile(
+      'package.json',
+      JSON.stringify({
+        name: 'typescript-project',
+        scripts: { build: 'tsc' },
+        devDependencies: {
+          typescript: '^5.0.0',
+        },
+      }),
+      'utf-8'
+    )
+
+    const result = await generateAgentsMd()
+    expect(result.success).toBe(true)
+
+    if (result.mainFilePath) {
+      const content = await fs.readFile(result.mainFilePath, 'utf-8')
+      expect(content).toContain('## Project Overview')
+      expect(content).toContain('## Build System')
+    }
+  })
+
+  test(`generateAgentsMd handles existing ${AGENTS_DOCS_DIR}/ directory properly`, async () => {
+    // Create existing ${AGENTS_DOCS_DIR}/ directory with a file
+    const agentsDir = join(process.cwd(), AGENTS_DOCS_DIR)
+    if (!existsSync(agentsDir)) {
+      mkdirSync(agentsDir, { recursive: true })
+    }
+    await fs.writeFile(join(agentsDir, 'existing.md'), 'Existing content', 'utf-8')
+
+    // First generation without overwrite
+    const result1 = await generateAgentsMd()
+    expect(result1.success).toBe(true)
+
+    // Second generation with overwrite
+    const result2 = await generateAgentsMd({ overwrite: true })
+    expect(result2.success).toBe(true)
+
+    // Verify existing file is still there (we don't delete unrelated files)
+    expect(existsSync(join(agentsDir, 'existing.md'))).toBe(true)
+  })
+
+  test(`generateAgentsMd creates ${AGENTS_DOCS_DIR}/ directory for complex projects`, async () => {
+    // Create a project with many sections to trigger ${AGENTS_DOCS_DIR}/ creation
+    await fs.writeFile(
+      'package.json',
+      JSON.stringify({
+        name: 'complex-project',
+        scripts: {
+          build: 'tsc',
+          test: 'jest',
+          deploy: 'docker build',
+          lint: 'eslint',
+        },
+        dependencies: {
+          react: '^18.0.0',
+          express: '^4.18.0',
+          typescript: '^5.0.0',
+          jest: '^29.0.0',
+          eslint: '^8.0.0',
+          docker: '^1.0.0',
+        },
+      }),
+      'utf-8'
+    )
+
+    // Create multiple config files
+    await fs.writeFile('Dockerfile', 'FROM node:18', 'utf-8')
+    await fs.writeFile('docker-compose.yml', 'version: "3"', 'utf-8')
+
+    const result = await generateAgentsMd()
+    expect(result.success).toBe(true)
+
+    // Should trigger ${AGENTS_DOCS_DIR}/ directory creation due to complexity
+    if (result.agentsDirPath) {
+      expect(existsSync(result.agentsDirPath)).toBe(true)
+      expect(result.filesCreated.length).toBeGreaterThan(1)
+    }
+  })
+
+  test('should generate AGENTS.md without unhelpful agent preambles', async () => {
+    // Test that generated AGENTS.md files don't contain "Based on my..." text
+    // This validates the fix for task-011/012 where agent preambles were cluttering the output
+
+    // Create minimal test project
+    await fs.writeFile('package.json', JSON.stringify({ name: 'test-project' }), 'utf-8')
+
+    const result = await generateAgentsMd({ overwrite: true })
+    expect(result.success).toBe(true)
+
+    if (result.success && result.mainFilePath) {
+      const content = await fs.readFile(result.mainFilePath, 'utf-8')
+
+      // Verify that unhelpful agent preambles are NOT in the AGENTS.md summary
+      // Comprehensive check for all common preamble patterns
+      expect(content).not.toMatch(/Based on my analysis.*?here's.*?/i)
+      expect(content).not.toMatch(/Based on my architectural analysis.*?/i)
+      expect(content).not.toMatch(/Based on my exploration.*?/i)
+      expect(content).not.toMatch(/Based on my comprehensive analysis.*?/i)
+      expect(content).not.toMatch(/Based on the.*?analysis.*?/i)
+      expect(content).not.toMatch(/Here's.*?analysis.*?:/i)
+      expect(content).not.toMatch(/Here's what I found.*?:/i)
+      expect(content).not.toMatch(/I've analyzed.*?:/i)
+      expect(content).not.toMatch(/I'll analyze.*?:/i)
+      expect(content).not.toMatch(/Looking at the project.*?:/i)
+      expect(content).not.toMatch(/After analyzing.*?:/i)
+      expect(content).not.toMatch(/Upon examination.*?:/i)
+      expect(content).not.toMatch(/Let me analyze.*?:/i)
+
+      // The content should have meaningful section headers
+      expect(content).toMatch(/## Project Overview/)
+      expect(content).toMatch(/## Build System/)
+    }
+  })
+})