homey-api 3.16.0 → 3.16.1

package/lib/HomeyAPI/HomeyAPI.js

@@ -90,6 +90,7 @@ class HomeyAPI extends EventEmitter {
       value: properties.softwareVersion ?? null,
       enumerable: true,
       writable: true,
+      configurable: true,
     });
 
     // Set Name

package/lib/HomeyAPI/HomeyAPIV3.js

@@ -228,20 +228,6 @@ class HomeyAPIV3 extends HomeyAPI {
       throw new Error('No Discovery Strategies Available');
     }
 
-    // TODO
-    // maybe we should always ping
-
-    // Don't discover, just set the only strategy
-    if (Object.keys(urls).length === 1) {
-      this.__baseUrl = Object.values(urls)[0];
-      this.__strategyId = Object.keys(urls)[0];
-
-      return {
-        baseUrl: this.__baseUrl,
-        strategyId: this.__strategyId,
-      };
-    }
-
     this.__debug(`Discovery Strategies: ${Object.keys(urls).join(',')}`);
 
     // Create the returned Promise
@@ -448,7 +434,7 @@ class HomeyAPIV3 extends HomeyAPI {
     } else if (pings[HomeyAPI.DISCOVERY_STRATEGIES.LOCAL]) {
       pings[HomeyAPI.DISCOVERY_STRATEGIES.LOCAL]
         .then((result) => resolve(result))
-        .catch(() => {
+        .catch((err) => {
           if (pings[HomeyAPI.DISCOVERY_STRATEGIES.CLOUD]) {
             pings[HomeyAPI.DISCOVERY_STRATEGIES.CLOUD]
               .then((result) => resolve(result))
@@ -463,12 +449,14 @@ class HomeyAPIV3 extends HomeyAPI {
 
                 reject(new APIErrorHomeyOffline(err));
               });
+          } else {
+            reject(new APIErrorHomeyOffline(err));
           }
         });
     } else if (pings[HomeyAPI.DISCOVERY_STRATEGIES.MDNS]) {
       pings[HomeyAPI.DISCOVERY_STRATEGIES.MDNS]
         .then((result) => resolve(result))
-        .catch(() => {
+        .catch((err) => {
           if (pings[HomeyAPI.DISCOVERY_STRATEGIES.CLOUD]) {
             pings[HomeyAPI.DISCOVERY_STRATEGIES.CLOUD]
               .then((result) => resolve(result))
@@ -483,12 +471,14 @@ class HomeyAPIV3 extends HomeyAPI {
 
                 reject(new APIErrorHomeyOffline(err));
               });
+          } else {
+            reject(new APIErrorHomeyOffline(err));
           }
         });
     } else if (pings[HomeyAPI.DISCOVERY_STRATEGIES.REMOTE_FORWARDED]) {
       pings[HomeyAPI.DISCOVERY_STRATEGIES.REMOTE_FORWARDED]
         .then((result) => resolve(result))
-        .catch(() => {
+        .catch((err) => {
           if (pings[HomeyAPI.DISCOVERY_STRATEGIES.CLOUD]) {
             pings[HomeyAPI.DISCOVERY_STRATEGIES.CLOUD]
               .then((result) => resolve(result))
@@ -503,6 +493,8 @@ class HomeyAPIV3 extends HomeyAPI {
 
                 reject(new APIErrorHomeyOffline(err));
               });
+          } else {
+            reject(new APIErrorHomeyOffline(err));
           }
         });
     } else if (pings[HomeyAPI.DISCOVERY_STRATEGIES.CLOUD]) {
@@ -660,6 +652,7 @@ class HomeyAPIV3 extends HomeyAPI {
           this.__token = store.token;
           this.__session = store.session;
 
+          await this.baseUrl; // Ensure discovery has completed
           return;
         }
 

package/lib/HomeyAPI/HomeyAPIV3Cloud.js

@@ -32,6 +32,11 @@ class HomeyAPIV3Cloud extends HomeyAPIV3 {
       strategy,
       ...props,
     });
+
+    // Seed the version cache with the initial value from the Cloud API,
+    // then remove the own data property so the prototype getter is used.
+    this.__versionCache[this.id] ??= this.version;
+    delete this.version;
   }
 
   get tier() {
@@ -42,6 +47,10 @@ class HomeyAPIV3Cloud extends HomeyAPIV3 {
     return this.__versionCache[this.id];
   }
 
+  set version(value) {
+    this.__versionCache[this.id] = value;
+  }
+
   get platform() {
     return 'cloud';
   }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "homey-api",
-  "version": "3.16.0",
+  "version": "3.16.1",
   "description": "Homey API",
   "main": "index.js",
   "license": "SEE LICENSE",
@@ -73,7 +73,7 @@
     "homey-api": "^3.0.8",
     "http-server": "^0.12.3",
     "jest": "^30.0.0-alpha.2",
-    "jsdoc": "^4.0.2",
+    "jsdoc": "4.0.5",
     "jsdoc-to-markdown": "^8.0.0",
     "jsdoc-ts-utils": "^4.0.0",
     "jsdoc-tsimport-plugin": "^1.0.5",