homebridge-yoto 0.0.38 → 0.0.39

package/lib/accessory.js

@@ -950,14 +950,11 @@ export class YotoPlayerAccessory {
 
     const normalizedPercent = Math.max(0, Math.min(Math.round(requestedPercent), 100))
     const requestedSteps = Math.round((normalizedPercent / 100) * 16)
-    const maxVolumeSteps = Number.isFinite(deviceModel.status.maxVolume)
-      ? deviceModel.status.maxVolume
-      : 16
-    const steps = Math.max(0, Math.min(Math.round(requestedSteps), maxVolumeSteps))
+    const steps = Math.max(0, Math.min(Math.round(requestedSteps), 16))
     const resultPercent = Math.round((steps / 16) * 100)
     this.#log.debug(
       LOG_PREFIX.ACCESSORY,
-      `[${this.#device.name}] Set volume raw=${value} normalizedPercent=${normalizedPercent} requestedSteps=${requestedSteps} -> steps=${steps} percent=${resultPercent} (maxSteps=${maxVolumeSteps})`
+      `[${this.#device.name}] Set volume raw=${value} normalizedPercent=${normalizedPercent} requestedSteps=${requestedSteps} -> steps=${steps} percent=${resultPercent}`
     )
 
     // Track last non-zero volume for unmute
@@ -1035,8 +1032,8 @@ export class YotoPlayerAccessory {
   async getOnlineStatus () {
     const { Characteristic } = this.#platform
     return this.#deviceModel.status.isOnline
-      ? Characteristic.ContactSensorState.CONTACT_DETECTED
-      : Characteristic.ContactSensorState.CONTACT_NOT_DETECTED
+      ? Characteristic.ContactSensorState.CONTACT_NOT_DETECTED
+      : Characteristic.ContactSensorState.CONTACT_DETECTED
   }
 
   // ==================== Battery Characteristic Handlers ====================
@@ -1450,7 +1447,7 @@ export class YotoPlayerAccessory {
     const { Characteristic } = this.#platform
     const status = this.#deviceModel.status
     const isActive = status.nightlightMode !== 'off'
-    return isActive ? Characteristic.ContactSensorState.CONTACT_DETECTED : Characteristic.ContactSensorState.CONTACT_NOT_DETECTED
+    return isActive ? Characteristic.ContactSensorState.CONTACT_NOT_DETECTED : Characteristic.ContactSensorState.CONTACT_DETECTED
   }
 
   /**
@@ -1463,7 +1460,7 @@ export class YotoPlayerAccessory {
     const isDay = status.dayMode === 'day'
     const isActive = status.nightlightMode !== 'off'
     const isShowing = isDay && isActive
-    return isShowing ? Characteristic.ContactSensorState.CONTACT_DETECTED : Characteristic.ContactSensorState.CONTACT_NOT_DETECTED
+    return isShowing ? Characteristic.ContactSensorState.CONTACT_NOT_DETECTED : Characteristic.ContactSensorState.CONTACT_DETECTED
   }
 
   /**
@@ -1476,7 +1473,7 @@ export class YotoPlayerAccessory {
     const isNight = status.dayMode === 'night'
     const isActive = status.nightlightMode !== 'off'
     const isShowing = isNight && isActive
-    return isShowing ? Characteristic.ContactSensorState.CONTACT_DETECTED : Characteristic.ContactSensorState.CONTACT_NOT_DETECTED
+    return isShowing ? Characteristic.ContactSensorState.CONTACT_NOT_DETECTED : Characteristic.ContactSensorState.CONTACT_DETECTED
   }
 
   // ==================== Card Slot ContactSensor Getter ====================
@@ -1489,7 +1486,7 @@ export class YotoPlayerAccessory {
     const { Characteristic } = this.#platform
     const status = this.#deviceModel.status
     const hasCard = status.cardInsertionState !== 'none'
-    return hasCard ? Characteristic.ContactSensorState.CONTACT_DETECTED : Characteristic.ContactSensorState.CONTACT_NOT_DETECTED
+    return hasCard ? Characteristic.ContactSensorState.CONTACT_NOT_DETECTED : Characteristic.ContactSensorState.CONTACT_DETECTED
   }
 
   // ==================== Night Mode ContactSensor Getter ====================
@@ -1503,8 +1500,8 @@ export class YotoPlayerAccessory {
     const status = this.#deviceModel.status
     const isNightMode = status.dayMode === 'night'
     return isNightMode
-      ? Characteristic.ContactSensorState.CONTACT_DETECTED
-      : Characteristic.ContactSensorState.CONTACT_NOT_DETECTED
+      ? Characteristic.ContactSensorState.CONTACT_NOT_DETECTED
+      : Characteristic.ContactSensorState.CONTACT_DETECTED
   }
 
   // ==================== Sleep Timer Switch Getter/Setter ====================
@@ -1765,8 +1762,8 @@ export class YotoPlayerAccessory {
       this.onlineStatusService
         .getCharacteristic(Characteristic.ContactSensorState)
         .updateValue(isOnline
-          ? Characteristic.ContactSensorState.CONTACT_DETECTED
-          : Characteristic.ContactSensorState.CONTACT_NOT_DETECTED)
+          ? Characteristic.ContactSensorState.CONTACT_NOT_DETECTED
+          : Characteristic.ContactSensorState.CONTACT_DETECTED)
     }
 
     // Update TemperatureSensor (temperature reading)
@@ -1846,7 +1843,7 @@ export class YotoPlayerAccessory {
       const isActive = status.nightlightMode !== 'off'
       this.nightlightActiveService
         .getCharacteristic(Characteristic.ContactSensorState)
-        .updateValue(isActive ? Characteristic.ContactSensorState.CONTACT_DETECTED : Characteristic.ContactSensorState.CONTACT_NOT_DETECTED)
+        .updateValue(isActive ? Characteristic.ContactSensorState.CONTACT_NOT_DETECTED : Characteristic.ContactSensorState.CONTACT_DETECTED)
     }
 
     if (this.dayNightlightActiveService) {
@@ -1855,7 +1852,7 @@ export class YotoPlayerAccessory {
       const isShowing = isDay && isActive
       this.dayNightlightActiveService
         .getCharacteristic(Characteristic.ContactSensorState)
-        .updateValue(isShowing ? Characteristic.ContactSensorState.CONTACT_DETECTED : Characteristic.ContactSensorState.CONTACT_NOT_DETECTED)
+        .updateValue(isShowing ? Characteristic.ContactSensorState.CONTACT_NOT_DETECTED : Characteristic.ContactSensorState.CONTACT_DETECTED)
     }
 
     if (this.nightNightlightActiveService) {
@@ -1864,7 +1861,7 @@ export class YotoPlayerAccessory {
       const isShowing = isNight && isActive
       this.nightNightlightActiveService
         .getCharacteristic(Characteristic.ContactSensorState)
-        .updateValue(isShowing ? Characteristic.ContactSensorState.CONTACT_DETECTED : Characteristic.ContactSensorState.CONTACT_NOT_DETECTED)
+        .updateValue(isShowing ? Characteristic.ContactSensorState.CONTACT_NOT_DETECTED : Characteristic.ContactSensorState.CONTACT_DETECTED)
     }
   }
 
@@ -1882,7 +1879,7 @@ export class YotoPlayerAccessory {
 
     this.cardSlotService
       .getCharacteristic(Characteristic.ContactSensorState)
-      .updateValue(hasCard ? Characteristic.ContactSensorState.CONTACT_DETECTED : Characteristic.ContactSensorState.CONTACT_NOT_DETECTED)
+      .updateValue(hasCard ? Characteristic.ContactSensorState.CONTACT_NOT_DETECTED : Characteristic.ContactSensorState.CONTACT_DETECTED)
   }
 
   /**
@@ -1899,7 +1896,7 @@ export class YotoPlayerAccessory {
 
     this.nightModeService
       .getCharacteristic(Characteristic.ContactSensorState)
-      .updateValue(isNightMode ? Characteristic.ContactSensorState.CONTACT_DETECTED : Characteristic.ContactSensorState.CONTACT_NOT_DETECTED)
+      .updateValue(isNightMode ? Characteristic.ContactSensorState.CONTACT_NOT_DETECTED : Characteristic.ContactSensorState.CONTACT_DETECTED)
   }
 
   /**

package/lib/platform.js

@@ -188,11 +188,19 @@ export class YotoPlatform {
         this.log.info(`Device offline: ${deviceId}${reason}`)
       })
 
+      /**
+       * @param {string} deviceId
+       * @returns {string}
+       */
       const getDeviceLabel = (deviceId) => {
         const deviceName = this.yotoAccount?.getDevice(deviceId)?.device?.name
         return deviceName || deviceId
       }
 
+      /**
+       * @param {{ status?: Record<string, unknown> } | null | undefined} message
+       * @returns {string}
+       */
       const formatLegacyStatusFields = (message) => {
         const status = message?.status
         if (!status || typeof status !== 'object') return ''

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "homebridge-yoto",
   "description": "Control your Yoto players through Apple HomeKit with real-time MQTT updates",
-  "version": "0.0.38",
+  "version": "0.0.39",
   "author": "Bret Comnes <bcomnes@gmail.com> (https://bret.io)",
   "bugs": {
     "url": "https://github.com/bcomnes/homebridge-yoto/issues"